Skip to contentSkip to conversation

drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

PATCH Superseded Stefan Riedmueller 3 participants 8 messages Apr 15, 2021 – Jun 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format.

---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 4e2dad314c79..44583d0ed902 100644
@@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
 		.width = 211,
 		.height = 158,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g121ean01_mode = {
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/3 drm/panel: Add connector_type for some EDT displays

The connector_type for following two EDT displays is missing:
- EDT ETM0430G0DH6
- EDT ETM0700G0BDH6

Both are parallel displays thus add the corresponding connector_type.

---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 44583d0ed902..723c09a82c4c 100644
@@ -1900,6 +1900,7 @@ static const struct panel_desc edt_etm0430g0dh6 = {
 		.width = 95,
 		.height = 54,
 	},
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
 static const struct drm_display_mode edt_et057090dhu_mode = {
@@ -1964,6 +1965,7 @@ static const struct panel_desc edt_etm0700g0bdh6 = {
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
 static const struct display_timing evervision_vgg804821_timing = {
Signature · 1 line
2.25.1
#2 lore raw

PATCH 3/3 drm/panel: Add bus_format and bus_flags for EDT ETM0430G0DH6

In reply to Stefan Riedmueller

Add corresponding bus_format and bus_flags for the EDT ETM0430G0DH6 display.

---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 723c09a82c4c..1bbb205a3b81 100644
@@ -1900,6 +1900,8 @@ static const struct panel_desc edt_etm0430g0dh6 = {
 		.width = 95,
 		.height = 54,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
 	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
Signature · 1 line
2.25.1
#3 lore raw
In reply to Stefan Riedmueller

Hi,

gentle ping for this small series.

Regards,
Stefan

Quoted 22 lines · Stefan Riedmueller

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format.

---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 4e2dad314c79..44583d0ed902 100644
@@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
 		.width = 211,
 		.height = 158,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g121ean01_mode = {
#4 lore raw

Hi,

another gentle ping.

Also adding Laurent Pinchart to CC.

Regards,
Stefan

Quoted 30 lines · Stefan Riedmüller

Hi,

gentle ping for this small series.

Regards,
Stefan

Quoted 22 lines · Stefan Riedmueller

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format.

---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 4e2dad314c79..44583d0ed902 100644
@@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
 		.width = 211,
 		.height = 158,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g121ean01_mode = {
#5 lore raw

Hi Stefan,

Quoted 5 lines · Stefan Riedmüller

Hi,

another gentle ping.

Also adding Laurent Pinchart to CC.

Can I ask you to resend the whole lot. I have resurfaced after an off-line period and deleted all pending mails.

I could probarly hunt down the mails somewhere but resend is easier on my end.

Sam

#6 lore raw

Hi Sam,

Quoted 7 lines · Sam Ravnborg

Hi Stefan,

Quoted 4 lines · Stefan Riedmüller

Hi,

another gentle ping.

Quoted 7 lines
Quoted 1 line

Also adding Laurent Pinchart to CC.

Can I ask you to resend the whole lot. I have resurfaced after an off-line period and deleted all pending mails.

I could probarly hunt down the mails somewhere but resend is easier on my end.

Sure, no problem, I'll send it out ASAP.

Stefan

Quoted 2 lines

Sam

Reviewed-by
#7 lore raw
In reply to Stefan Riedmüller

Hi Stefan,

Thank you for the patch.

Quoted 3 lines · Stefan Riedmüller

Hi,

another gentle ping.

Sorry for the delay, I have way too little bandwidth these days :-S

Quoted 8 lines

Also adding Laurent Pinchart to CC.

Quoted 5 lines · Stefan Riedmüller
Quoted 4 lines · Stefan Riedmueller

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format.

It will be interesting to add support for the 6bpp mode at some point (I assume through a custom DT property that reports the state of the panel's SEL68 pin, as it should be strapped in most cases).

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 4e2dad314c79..44583d0ed902 100644
@@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
 		.width = 211,
 		.height = 158,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g121ean01_mode = {
Signature · 3 lines
Regards,

Laurent Pinchart