Skip to contentSkip to conversation

thermal: mediatek: add sensors-support

PATCH Superseded Frank Wunderlich 3 participants 3 messages Apr 20, 2021 – Jun 8, 2021

Subsystems (2)
Arm MediaTek Thermal

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Frank Wunderlich

author
#0 lore raw

PATCH v3 1/1 thermal: mediatek: add sensors-support

From: Frank Wunderlich <[email protected]>

add HWMON-support to mediateks thermal driver to allow lm-sensors userspace tools read soc temperature

Signed-off-by Frank Wunderlich <[email protected]>

---
v3: drop no_hwmon - now really, sorry
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs

---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/thermal/mtk_thermal.c +6 -0
index 149c6d7fd5a0..85964988684b 100644
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c

@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:
Signature · 1 line
2.25.1
#1 lore raw

Hi,

just a gentle ping ;)

regards Frank

Quoted 47 lines

Gesendet: Dienstag, 20. April 2021 um 19:23 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Daniel Lezcano" <[email protected]>, "Amit Kucheria" <[email protected]>, "Matthias Brugger" <[email protected]>, [email protected], [email protected], [email protected]
Betreff: [PATCH v3] thermal: mediatek: add sensors-support

From: Frank Wunderlich <[email protected]>

add HWMON-support to mediateks thermal driver to allow lm-sensors userspace tools read soc temperature

Signed-off-by Frank Wunderlich <[email protected]>

---
v3: drop no_hwmon - now really, sorry
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs

---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/thermal/mtk_thermal.c +6 -1
index 149c6d7fd5a0..85964988684b 100644
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c

@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:
--

2.25.1

maintainer
#2 lore raw
In reply to Frank Wunderlich
Quoted 27 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

add HWMON-support to mediateks thermal driver to allow lm-sensors userspace tools read soc temperature

Signed-off-by Frank Wunderlich <[email protected]>

---
v3: drop no_hwmon - now really, sorry
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs

---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/thermal/mtk_thermal.c +2 -0
index 149c6d7fd5a0..85964988684b 100644
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c

drivers/thermal/mtk_thermal.c static int mtk_thermal_probe(struct platform_device *pdev) · line 1094

Quoted 6 lines
drivers/thermal/mtk_thermal.c +3 -0
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");

I think dev_warn() is more appropriate here.

Regards,
Matthias

Quoted 5 lines
drivers/thermal/mtk_thermal.c +1 -0
+
 	return 0;
 
 err_disable_clk_peri_therm: