Skip to contentSkip to conversation

ARM: dts: aspeed: Rainier remove PSU gpio-keys

PATCH New Brandon Wyman 2 participants 3 messages Jun 23, 2021 – Jun 24, 2021

Subsystems (2)
Device tree bindings Arm/Aspeed machine support
lore
Share & tools
lore

Brandon Wyman

author
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: Rainier remove PSU gpio-keys

From: "B. J. Wyman" <[email protected]>

Remove the gpio-keys entries for the power supply presence lines from the Rainier device tree. The user space applications are going to change from using libevdev to libgpiod.

Signed-off-by B. J. Wyman <[email protected]>
---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 28 --------------------
 1 file changed, 28 deletions(-)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +0 -28
index 941c0489479a..d6ed583cfb1b 100644
@@ -116,34 +116,6 @@ vga_memory: region at bf000000 {
 		};
 	};
 
-	gpio-keys {
-		compatible = "gpio-keys";
-
-		ps0-presence {
-			label = "ps0-presence";
-			gpios = <&gpio0 ASPEED_GPIO(S, 0) GPIO_ACTIVE_LOW>;
-			linux,code = <ASPEED_GPIO(S, 0)>;
-		};
-
-		ps1-presence {
-			label = "ps1-presence";
-			gpios = <&gpio0 ASPEED_GPIO(S, 1) GPIO_ACTIVE_LOW>;
-			linux,code = <ASPEED_GPIO(S, 1)>;
-		};
-
-		ps2-presence {
-			label = "ps2-presence";
-			gpios = <&gpio0 ASPEED_GPIO(S, 2) GPIO_ACTIVE_LOW>;
-			linux,code = <ASPEED_GPIO(S, 2)>;
-		};
-
-		ps3-presence {
-			label = "ps3-presence";
-			gpios = <&gpio0 ASPEED_GPIO(S, 3) GPIO_ACTIVE_LOW>;
-			linux,code = <ASPEED_GPIO(S, 3)>;
-		};
-	};
-
 	i2c2mux: i2cmux {
 		compatible = "i2c-mux-gpio";
 		#address-cells = <1>;
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 ARM: dts: aspeed: Rainier remove PSU gpio-keys

Quoted 6 lines · Brandon Wyman

From: "B. J. Wyman" <[email protected]>

Remove the gpio-keys entries for the power supply presence lines from the Rainier device tree. The user space applications are going to change from using libevdev to libgpiod.

Have they already added support for libgpiod? We should support both at least while we're switching over.

Andrew

author
#2 lore raw

PATCH 1/1 ARM: dts: aspeed: Rainier remove PSU gpio-keys

Quoted 10 lines · Andrew Jeffery
Quoted 6 lines · Brandon Wyman

From: "B. J. Wyman" <[email protected]>

Remove the gpio-keys entries for the power supply presence lines from the Rainier device tree. The user space applications are going to change from using libevdev to libgpiod.

Have they already added support for libgpiod? We should support both at least while we're switching over.

There is a change, hopefully nearing the end of review, that will support both.

Quoted 2 lines

Andrew