Skip to contentSkip to conversation

imx8mm-evk: Generate a single bootable flash.bin again

PATCH Superseded Fabio Estevam 4 participants 15 messages Aug 19, 2021 – Aug 23, 2021

Subsystems (3)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 imx8mm-evk: Generate a single bootable flash.bin again

After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed.

Such new requirement breaks existing distro mechanisms to generate the final binary because the extra u-boot.itb is now required.

Generate a final flash.bin that can be used again as a single bootable binary to keep the original behavior.

After this change the SPL binary is called spl.bin, which is a more descriptive name for its purpose, and can still be used standalone (for example, for secure boot purposes).

Also update imx8mm_evk.rst to remove the u-boot.itb copy step.

---
Changes since v2:
- Change the LOADER to mkimage.spl.mkimage (Frieder)

 arch/arm/dts/imx8mm-evk-u-boot.dtsi             | 17 ++++++++++++++++-
 .../imx8mm_evk/imximage-8mm-lpddr4.cfg          |  2 +-
 doc/board/freescale/imx8mm_evk.rst              |  1 -
 3 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/dts/imx8mm-evk-u-boot.dtsi +16 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
 	};
 
 
-       flash {
+	spl {
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
 			};
 		};
 	};
+
+	imx-boot {
+		filename = "flash.bin";
+		pad-byte = <0x00>;
+
+		spl: blob-ext@1 {
+			offset = <0x0>;
+			filename = "spl.bin";
+		};
+
+		uboot: blob-ext@2 {
+			offset = <0x57c00>;
+			filename = "u-boot.itb";
+		};
+	};
 };
board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +1 -1
index b89092a559..2c15dbc413 100644
@@ -6,4 +6,4 @@
 #define __ASSEMBLY__
 
 BOOT_FROM	sd
-LOADER		mkimage.flash.mkimage	0x7E1000
+LOADER		mkimage.spl.mkimage	0x7E1000
doc/board/freescale/imx8mm_evk.rst +0 -1
index 7fd3d72564..b377c4de27 100644
@@ -50,7 +50,6 @@ Burn the flash.bin to MicroSD card offset 33KB:
 .. code-block:: bash
 
    $sudo dd if=flash.bin of=/dev/sd[x] bs=1024 seek=33 conv=notrunc
-   $sudo dd if=u-boot.itb of=/dev/sdc bs=1024 seek=384 conv=sync
 
 Boot
 ----
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 2/2 Makefile: Clean the i.MX8MM artifacts

Clean the binaries generated by binman on imx8mm-evk:
spl.* mkimage*.mkimage imx-boot.*

---
Changes since v2:
- None. Newly introducedin this series.

 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Makefile +2 -1
index 3c8437d21a..7096fdf895 100644
@@ -2095,7 +2095,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \
 	       boot* u-boot* MLO* SPL System.map fit-dtb.blob* \
 	       u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \
 	       lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
-	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c
+	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
+	       spl.* mkimage*.mkimage imx-boot.*
 
 # Directories & files removed with 'make mrproper'
 MRPROPER_DIRS  += include/config include/generated spl tpl \
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v3 2/2] Makefile: Clean the i.MX8MM artifacts

Hi Fabio,

Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 18 lines

Clean the binaries generated by binman on imx8mm-evk:
spl.* mkimage*.mkimage imx-boot.*

---
Changes since v2:
- None. Newly introducedin this series.

 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Makefile +0 -0
index 3c8437d21a..7096fdf895 100644

Makefile CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \ · line 2099

Quoted 6 lines
Makefile +2 -1
@@ -2095,7 +2095,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \
               boot* u-boot* MLO* SPL System.map fit-dtb.blob* \
               u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \
               lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
-              idbloader.img flash.bin flash.log defconfig keep-syms-lto.c
+              idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
+              spl.* mkimage*.mkimage imx-boot.*

it might be useful to use one variable for all BINMAN clean files. Otherwise it is difficult to understand by whom the files were created.

Something like that:

Makefile +4 -1
@@ -2091,12 +2091,14 @@ CLEAN_DIRS  += $(MODVERDIR) \
               $(foreach d, spl tpl, $(patsubst %,$d/%, \
                        $(filter-out include, $(shell ls -1 $d 2>/dev/null))))
 
+BINMAN_CLEAN_FILES = spl.* mkimage*.mkimage
+
 CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \
               boot* u-boot* MLO* SPL System.map fit-dtb.blob* \
               u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \
               lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
               idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
-              spl.* mkimage*.mkimage imx-boot.*
+              imx-boot.* $(BINMAN_CLEAN_FILES)
+
 
 

I had the idea, if binman could create a list with the created files. This could then be used to set the files to be deleted. I think of other users where the output files have a different name. Then the files could be deleted "automatically" with clean.

Signature · 1 line
Heiko
#3 lore raw

Re: [PATCH v3 2/2] Makefile: Clean the i.MX8MM artifacts

Hi,

Am Fr., 20. Aug. 2021 um 07:34 Uhr schrieb Heiko Thiery <[email protected]>:

Quoted 38 lines

Hi Fabio,

Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 18 lines

Clean the binaries generated by binman on imx8mm-evk:
spl.* mkimage*.mkimage imx-boot.*

---
Changes since v2:
- None. Newly introducedin this series.

 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Makefile +0 -0
index 3c8437d21a..7096fdf895 100644

Makefile CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \ · line 2099

Quoted 6 lines
Makefile +2 -1
@@ -2095,7 +2095,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \
               boot* u-boot* MLO* SPL System.map fit-dtb.blob* \
               u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \
               lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
-              idbloader.img flash.bin flash.log defconfig keep-syms-lto.c
+              idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
+              spl.* mkimage*.mkimage imx-boot.*

it might be useful to use one variable for all BINMAN clean files. Otherwise it is difficult to understand by whom the files were created.

Something like that:

Makefile CLEAN_DIRS += $(MODVERDIR) \ · line 2094

Quoted 4 lines
Makefile +1 -0
@@ -2091,12 +2091,14 @@ CLEAN_DIRS  += $(MODVERDIR) \
               $(foreach d, spl tpl, $(patsubst %,$d/%, \
                        $(filter-out include, $(shell ls -1 $d 2>/dev/null))))
 
+BINMAN_CLEAN_FILES = spl.* mkimage*.mkimage

While looking at it a second time, I noticed that itb.fit.fit and itb.fit.itb were also created by binman.

Signature · 1 line
Heiko
#4 lore raw
In reply to Fabio Estevam

Hi Fabio,

Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 88 lines

After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed.

Such new requirement breaks existing distro mechanisms to generate the final binary because the extra u-boot.itb is now required.

Generate a final flash.bin that can be used again as a single bootable binary to keep the original behavior.

After this change the SPL binary is called spl.bin, which is a more descriptive name for its purpose, and can still be used standalone (for example, for secure boot purposes).

Also update imx8mm_evk.rst to remove the u-boot.itb copy step.

---
Changes since v2:
- Change the LOADER to mkimage.spl.mkimage (Frieder)

 arch/arm/dts/imx8mm-evk-u-boot.dtsi             | 17 ++++++++++++++++-
 .../imx8mm_evk/imximage-8mm-lpddr4.cfg          |  2 +-
 doc/board/freescale/imx8mm_evk.rst              |  1 -
 3 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/dts/imx8mm-evk-u-boot.dtsi +16 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
        };
 
 
-       flash {
+       spl {
                mkimage {
                        args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
                        };
                };
        };
+
+       imx-boot {
+               filename = "flash.bin";
+               pad-byte = <0x00>;
+
+               spl: blob-ext@1 {
+                       offset = <0x0>;
+                       filename = "spl.bin";
+               };
+
+               uboot: blob-ext@2 {
+                       offset = <0x57c00>;
+                       filename = "u-boot.itb";
+               };
+       };
 };
board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +1 -1
index b89092a559..2c15dbc413 100644
@@ -6,4 +6,4 @@
 #define __ASSEMBLY__
 
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x7E1000
+LOADER         mkimage.spl.mkimage     0x7E1000
doc/board/freescale/imx8mm_evk.rst +0 -2
index 7fd3d72564..b377c4de27 100644
@@ -50,7 +50,6 @@ Burn the flash.bin to MicroSD card offset 33KB:
 .. code-block:: bash
 
    $sudo dd if=flash.bin of=/dev/sd[x] bs=1024 seek=33 conv=notrunc
-   $sudo dd if=u-boot.itb of=/dev/sdc bs=1024 seek=384 conv=sync
 
 Boot
 ----
--
Quoted 2 lines

2.25.1

When building from a clean checkout I see the following warnings. It seems that there are some dependency checks that are looking for the files in mkimage config file.

  AR      arch/arm/lib/lib.a
  AS      arch/arm/lib/crt0_aarch64_efi.o
  CC      arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional
  AS      arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      arch/arm/mach-imx/imx8m/clock_slice.o
  CC      arch/arm/mach-imx/imx8m/soc.o
    :
    :
  AS      spl/arch/arm/lib/crt0_aarch64_efi.o
  CC      spl/arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional
  AS      spl/arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      spl/arch/arm/mach-imx/imx8m/clock_slice.o
  CC      spl/arch/arm/mach-imx/imx8m/soc.o
    :
    :

COPY spl/u-boot-spl.bin
SYM spl/u-boot-spl.sym
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional make[1]: Nothing to be done for 'SPL'.
OBJCOPY u-boot.srec
OBJCOPY u-boot-nodtb.bin

Signature · 1 line
Heiko
#5 lore raw
Quoted 22 lines · Heiko Thiery

...

When building from a clean checkout I see the following warnings. It seems that there are some dependency checks that are looking for the files in mkimage config file.

  AR      arch/arm/lib/lib.a
  AS      arch/arm/lib/crt0_aarch64_efi.o
  CC      arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional AS      arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      arch/arm/mach-imx/imx8m/clock_slice.o
  CC      arch/arm/mach-imx/imx8m/soc.o
    :
    :
  AS      spl/arch/arm/lib/crt0_aarch64_efi.o
  CC      spl/arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional AS      spl/arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      spl/arch/arm/mach-imx/imx8m/clock_slice.o
  CC      spl/arch/arm/mach-imx/imx8m/soc.o

Quoted 8 lines

    :
    :
  COPY    spl/u-boot-spl.bin
  SYM     spl/u-boot-spl.sym
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional make[1]: Nothing to be done for 'SPL'.
  OBJCOPY u-boot.srec
  OBJCOPY u-boot-nodtb.bin

Yes, I believe it really requires explicitly setting the filename as I previously suggested.

https://marc.info/?l=u-boot&m=162940109314578

reviewer
#6 lore raw

Hi Heiko and Marcel,

Quoted 33 lines · Marcel Ziswiler
Quoted 24 lines · Heiko Thiery

...

When building from a clean checkout I see the following warnings. It seems that there are some dependency checks that are looking for the files in mkimage config file.

  AR      arch/arm/lib/lib.a
  AS      arch/arm/lib/crt0_aarch64_efi.o
  CC      arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional
  AS      arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      arch/arm/mach-imx/imx8m/clock_slice.o
  CC      arch/arm/mach-imx/imx8m/soc.o
    :
    :
  AS      spl/arch/arm/lib/crt0_aarch64_efi.o
  CC      spl/arch/arm/lib/reloc_aarch64_efi.o
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional
  AS      spl/arch/arm/mach-imx/imx8m/lowlevel_init.o
  CC      spl/arch/arm/mach-imx/imx8m/clock_slice.o
  CC      spl/arch/arm/mach-imx/imx8m/soc.o
    :
    :
Quoted 6 lines

COPY spl/u-boot-spl.bin
SYM spl/u-boot-spl.sym
WARNING 'mkimage.spl.mkimage' not found, resulting binary is not-functional make[1]: Nothing to be done for 'SPL'.
OBJCOPY u-boot.srec
OBJCOPY u-boot-nodtb.bin

Quoted 4 lines

Yes, I believe it really requires explicitly setting the filename as I previously suggested.

https://marc.info/?l=u-boot&m=162940109314578

Peng Fan has sent a patch fixing this:
https://www.mail-archive.com/[email protected]/msg414966.html

Thanks

#8 lore raw
Quoted 11 lines · Heiko Thiery

Hi Fabio,

Quoted 7 lines
Quoted 4 lines

Yes, I believe it really requires explicitly setting the filename as I previously suggested.

https://marc.info/?l=u-boot&m=162940109314578

Peng Fan has sent a patch fixing this:
https://www.mail-archive.com/[email protected]/msg414966.html

Ah ok. Thanks

Yes, I can confirm that Peng's patch fixes this. I guess, me explicitly adding the filename did not really change anything but due to me running make again it subsequently picked up the previously generated artifact. Sorry for the noise.

#9 lore raw
In reply to Fabio Estevam

Hi Heiko Thiery and Marcel,

Quoted 24 lines · Fabio Estevam
arch/arm/dts/imx8mm-evk-u-boot.dtsi +7 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
 	};
 
 
-       flash {
+	spl {
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
 			};
 		};
 	};
+
+	imx-boot {
+		filename = "flash.bin";
+		pad-byte = <0x00>;
+
+		spl: blob-ext@1 {

arch/arm/dts/imx8mm-evk-u-boot.dtsi line 235

Quoted 10 lines
arch/arm/dts/imx8mm-evk-u-boot.dtsi +9 -0
+			offset = <0x0>;
+			filename = "spl.bin";
+		};
+
+		uboot: blob-ext@2 {
+			offset = <0x57c00>;
+			filename = "u-boot.itb";
+		};
+	};
 };

Do we have a consensus on the binman format to generate a monolithic flash.bin?

I understand that patch 2/2 still needs to be improved, but what about this one?

Thanks,

Fabio Estevam

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: [email protected]
Reviewed-by
#10 lore raw

Hi Fabio

Quoted 33 lines · Fabio Estevam

Hi Heiko Thiery and Marcel,

Quoted 29 lines · Fabio Estevam
arch/arm/dts/imx8mm-evk-u-boot.dtsi +12 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
         };
 
 
-       flash {
+       spl {
                 mkimage {
                         args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
                         };
                 };
         };
+
+       imx-boot {
+               filename = "flash.bin";
+               pad-byte = <0x00>;
+
+               spl: blob-ext@1 {
+                       offset = <0x0>;
+                       filename = "spl.bin";
+               };
+
+               uboot: blob-ext@2 {
Quoted 8 lines

arch/arm/dts/imx8mm-evk-u-boot.dtsi line 235

Quoted 5 lines
arch/arm/dts/imx8mm-evk-u-boot.dtsi +4 -0
+                       offset = <0x57c00>;
+                       filename = "u-boot.itb";
+               };
+       };
  };

Do we have a consensus on the binman format to generate a monolithic flash.bin?

Yes, I would say so. Remember, I did include this already in our latest verdin-imx8mm specific patch set together with its migration to using binman [1].

Quoted 2 lines

I understand that patch 2/2 still needs to be improved, but what about this one?

Yes, I agree.

[1] https://marc.info/?l=u-boot&m=162949278629882

Quoted 3 lines

Thanks,

Fabio Estevam

Cheers

Marcel

#11 lore raw
In reply to Fabio Estevam

Hi Fabio,

Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 70 lines

After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed.
and if it is not
Such new requirement breaks existing distro mechanisms to generate the final binary because the extra u-boot.itb is now required.

Generate a final flash.bin that can be used again as a single bootable binary to keep the original behavior.

After this change the SPL binary is called spl.bin, which is a more descriptive name for its purpose, and can still be used standalone (for example, for secure boot purposes).

Also update imx8mm_evk.rst to remove the u-boot.itb copy step.

---
Changes since v2:
- Change the LOADER to mkimage.spl.mkimage (Frieder)

 arch/arm/dts/imx8mm-evk-u-boot.dtsi             | 17 ++++++++++++++++-
 .../imx8mm_evk/imximage-8mm-lpddr4.cfg          |  2 +-
 doc/board/freescale/imx8mm_evk.rst              |  1 -
 3 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/dts/imx8mm-evk-u-boot.dtsi +16 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
        };
 
 
-       flash {
+       spl {
                mkimage {
                        args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
                        };
                };
        };
+
+       imx-boot {
+               filename = "flash.bin";
+               pad-byte = <0x00>;
+
+               spl: blob-ext@1 {
+                       offset = <0x0>;
+                       filename = "spl.bin";
+               };
+
+               uboot: blob-ext@2 {
+                       offset = <0x57c00>;
+                       filename = "u-boot.itb";
+               };
+       };
 };
board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +0 -0
index b89092a559..2c15dbc413 100644

board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg line 9

Quoted 5 lines
board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +1 -1
@@ -6,4 +6,4 @@
 #define __ASSEMBLY__
 
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x7E1000
+LOADER         mkimage.spl.mkimage     0x7E1000

I think the "mkimage.spl.mkimage" is a temporarily created file from binman. Isn't it correct to use the output file of the binman image u-boot-spl-ddr ("u-boot-spl-ddr.bin") here?

Signature · 1 line
Heiko
#12 lore raw
Quoted 76 lines · Heiko Thiery

Hi Fabio,

Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 73 lines

After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed.
and if it is not
Such new requirement breaks existing distro mechanisms to generate the final binary because the extra u-boot.itb is now required.

Generate a final flash.bin that can be used again as a single bootable binary to keep the original behavior.

After this change the SPL binary is called spl.bin, which is a more descriptive name for its purpose, and can still be used standalone (for example, for secure boot purposes).

Also update imx8mm_evk.rst to remove the u-boot.itb copy step.

---
Changes since v2:
- Change the LOADER to mkimage.spl.mkimage (Frieder)

 arch/arm/dts/imx8mm-evk-u-boot.dtsi             | 17 ++++++++++++++++- .../imx8mm_evk/imximage-8mm-lpddr4.cfg          |  2 +- doc/board/freescale/imx8mm_evk.rst              |  1 -

 3 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/dts/imx8mm-evk-u-boot.dtsi +16 -1
index f200afac9f..75cd59e545 100644
@@ -150,7 +150,7 @@
         };
 
 
-       flash {
+       spl {
                 mkimage {
                         args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
 
@@ -217,4 +217,19 @@
                         };
                 };
         };
+
+       imx-boot {
+               filename = "flash.bin";
+               pad-byte = <0x00>;
+
+               spl: blob-ext@1 {
+                       offset = <0x0>;
+                       filename = "spl.bin";
+               };
+
+               uboot: blob-ext@2 {
+                       offset = <0x57c00>;
+                       filename = "u-boot.itb";
+               };
+       };
  };
board/freescale/imx8mm_evk/imximage-8mm- renamed from board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +0 -0

lpddr4.cfg
index b89092a559..2c15dbc413 100644

board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +0 -0
@@ -6,4 +6,4 @@
  #define __ASSEMBLY__
 
Quoted 7 lines

board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg line 9

Quoted 3 lines

 BOOT_FROM      sd

board/freescale/imx8mm_evk/imximage-8mm-lpddr4.cfg +1 -1
-LOADER         mkimage.flash.mkimage   0x7E1000
+LOADER         mkimage.spl.mkimage     0x7E1000

I think the "mkimage.spl.mkimage" is a temporarily created file from binman. Isn't it correct to use the output file of the binman image u-boot-spl-ddr ("u-boot-spl-ddr.bin") here?

Yes, looking at it again, that really seems the proper one and I can confirm that this works fine.

reviewer
#13 lore raw
In reply to Heiko Thiery

Hi Heiko,

Quoted 3 lines · Heiko Thiery

I think the "mkimage.spl.mkimage" is a temporarily created file from binman. Isn't it correct to use the output file of the binman image u-boot-spl-ddr ("u-boot-spl-ddr.bin") here?

I did as you suggested in v4. Please reply with your Reviewed-by if it looks good to you.

Also, I dropped the 2/2 patch (cleaning of the binman files) as it needs improvement.

Could you please take care of the binman files cleanup mechanism?

Thanks,

Fabio Estevam

Quoted 3 lines

--
Heiko

#14 lore raw

Hi Fabio,

Am Mo., 23. Aug. 2021 um 14:16 Uhr schrieb Fabio Estevam <[email protected]>:

Quoted 9 lines

Hi Heiko,

Quoted 3 lines · Heiko Thiery

I think the "mkimage.spl.mkimage" is a temporarily created file from binman. Isn't it correct to use the output file of the binman image u-boot-spl-ddr ("u-boot-spl-ddr.bin") here?

Quoted 7 lines

I did as you suggested in v4. Please reply with your Reviewed-by if it looks good to you.

Also, I dropped the 2/2 patch (cleaning of the binman files) as it needs improvement.

Could you please take care of the binman files cleanup mechanism?

Yes, I will see what I can do.

--
Heiko