fs/pipe: local vars has to match types of proper pipe_inode_info fields
PATCH 1/1 fs/pipe: local vars has to match types of proper pipe_inode_info fields
head, tail, ring_size are declared as unsigned int, so all local variables that operate with these fields have to be unsigned to avoid signed integer overflow.
Right now, it isn't an issue because the maximum pipe size is limited by 1U<<31.
Cc Dmitry Safonov <[email protected]>
Suggested-by Dmitry Safonov <[email protected]>
Signed-off-by Andrei Vagin <[email protected]>
--- fs/pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/pipe.c +2 -2
@@ -605,7 +605,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)static long pipe_ioctl (struct file *filp,unsigned int cmd,unsigned long arg) {struct pipe_inode_info *pipe = filp->private_data; -int count, head, tail, mask; +unsigned int count, head, tail, mask;switch (cmd) {case FIONREAD :
@@ -827,7 +827,7 @@ struct pipe_inode_info *alloc_pipe_info(void)void free_pipe_info (struct pipe_inode_info *pipe) { -int i; +unsigned int i;#ifdef CONFIG_WATCH_QUEUE if (pipe->watch_queue) {
Signature · 1 line
2.33.1
Quoted 11 lines · Andrei Vagin
head, tail,
ring_sizeare declared as unsigned int, so all local variables that operate with these fields have to be unsigned to avoid signed integer overflow.Right now, it isn't an issue because the maximum pipe size is limited by 1U<<31.
Cc Dmitry Safonov <[email protected]>Suggested-by Dmitry Safonov <[email protected]>Signed-off-by Andrei Vagin <[email protected]>---
Looks good,