Skip to contentSkip to conversation

dt-bindings: Drop unnecessary pinctrl properties

PATCH Applied Rob Herring 4 participants 5 messages Jan 19, 2022 – Jan 20, 2022

Subsystems (13)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: Drop unnecessary pinctrl properties

For a single pinctrl mode, it is not necessary to define pinctrl properties as the tools always allow pinctrl properties.

---
 .../display/rockchip/rockchip,rk3066-hdmi.yaml         |  8 --------
 Documentation/devicetree/bindings/input/gpio-keys.yaml |  6 ------
 .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml  |  9 ---------
 .../devicetree/bindings/pinctrl/cirrus,madera.yaml     | 10 ----------
 .../devicetree/bindings/sound/samsung-i2s.yaml         |  6 ------
 5 files changed, 39 deletions(-)
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml +0 -8
index 008c144257cb..1a68a940d165 100644
@@ -26,14 +26,6 @@ properties:
   clock-names:
     const: hclk
 
-  pinctrl-0:
-    maxItems: 2
-
-  pinctrl-names:
-    const: default
-    description:
-      Switch the iomux for the HPD/I2C pins to HDMI function.
-
   power-domains:
     maxItems: 1
 
Documentation/devicetree/bindings/input/gpio-keys.yaml +0 -6
index dbe7ecc19ccb..7fe1966ea28a 100644
@@ -88,12 +88,6 @@ patternProperties:
             which can be disabled to suppress events from the button.
           type: boolean
 
-        pinctrl-0:
-          maxItems: 1
-
-        pinctrl-names:
-          maxItems: 1
-
       required:
         - linux,code
 
Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml +0 -9
index 80020539c3bb..5cd512b7d5ba 100644
@@ -51,15 +51,6 @@ properties:
       appropriate of the LOCHNAGARx_PIN_NUM_GPIOS define, see [3].
     maxItems: 1
 
-  pinctrl-0:
-    description:
-      A phandle to the default pinctrl state.
-
-  pinctrl-names:
-    description:
-      A pinctrl state named "default" must be defined.
-    const: default
-
   pin-settings:
     type: object
     patternProperties:
Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml +0 -10
index e50d7ad5c229..c85f759ae5a3 100644
@@ -30,16 +30,6 @@ description: |
     Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
 
 properties:
-  pinctrl-0:
-    description:
-      A phandle to the node containing the subnodes containing default
-      configurations.
-
-  pinctrl-names:
-    description:
-      A pinctrl state named "default" must be defined.
-    const: default
-
   pin-settings:
     description:
       One subnode is required to contain the default settings. It
Documentation/devicetree/bindings/sound/samsung-i2s.yaml +0 -6
index 2e3628ef48df..84c4d6cba521 100644
@@ -110,12 +110,6 @@ properties:
       Internal DMA register base address of the audio
       subsystem (used in secondary sound source).
 
-  pinctrl-0:
-    description: Should specify pin control groups used for this controller.
-
-  pinctrl-names:
-    const: default
-
   power-domains:
     maxItems: 1
 
Signature · 1 line
2.32.0
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Rob Herring

For a single pinctrl mode, it is not necessary to define pinctrl properties as the tools always allow pinctrl properties.

---
 .../display/rockchip/rockchip,rk3066-hdmi.yaml         |  8 --------
 Documentation/devicetree/bindings/input/gpio-keys.yaml |  6 ------
 .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml  |  9 ---------
 .../devicetree/bindings/pinctrl/cirrus,madera.yaml     | 10 ----------
 .../devicetree/bindings/sound/samsung-i2s.yaml         |  6 ------
 5 files changed, 39 deletions(-)

Best regards,
Krzysztof

author maintainer Applied
#4 lore raw
In reply to Rob Herring
Quoted 12 lines · Rob Herring

For a single pinctrl mode, it is not necessary to define pinctrl properties as the tools always allow pinctrl properties.

---
 .../display/rockchip/rockchip,rk3066-hdmi.yaml         |  8 --------
 Documentation/devicetree/bindings/input/gpio-keys.yaml |  6 ------
 .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml  |  9 ---------
 .../devicetree/bindings/pinctrl/cirrus,madera.yaml     | 10 ----------
 .../devicetree/bindings/sound/samsung-i2s.yaml         |  6 ------
 5 files changed, 39 deletions(-)

Applied, thanks!