DRM kmap() fixes and kmap_local_page() conversions
Subsystems (7)
v2 cover DRM kmap() fixes and kmap_local_page() conversions
From: Ira Weiny <[email protected]>
Changes from V1:
Use memcpy_to_page() where appropriate
Rebased to latest
The kmap() call may cause issues with work being done with persistent memory. For this and other reasons it is being deprecated.
This series starts by converting the last easy kmap() uses in the drm tree to kmap_local_page().
The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() conversion. They are valid fixes but were found via code inspection not because of any actual bug so don't require a stable tag.[1]
There is one more call to kmap() used in ttm_bo_kmap_ttm(). Unfortunately, fixing this is not straight forward so it is left to future work.[2]
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
Ira Weiny (7):
drm/i915: Replace kmap() with kmap_local_page()
drm/amd: Replace kmap() with kmap_local_page()
drm/gma: Remove calls to kmap()
drm/radeon: Replace kmap() with kmap_local_page()
drm/msm: Alter comment to use kmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++---- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 ++----- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- drivers/gpu/drm/radeon/radeon_uvd.c | 1 +
13 files changed, 32 insertions(+), 37 deletions(-)
--
2.31.1
PATCH v2 2/7 drm/amd: Replace kmap() with kmap_local_page()
From: Ira Weiny <[email protected]>
kmap() is being deprecated. These maps are thread local and can be replaced with kmap_local_page().
Replace kmap() with kmap_local_page()
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +4 -4
@@ -2272,9 +2272,9 @@ static ssize_t amdgpu_iomem_read(struct file *f, char __user *buf,if (p->mapping != adev->mman.bdev.dev_mapping)return -EPERM ; - ptr =kmap (p); + ptr =kmap_local_page (p); r =copy_to_user (buf, ptr + off, bytes); -kunmap (p); +kunmap_local (ptr);if (r)return -EFAULT ;
@@ -2323,9 +2323,9 @@ static ssize_t amdgpu_iomem_write(struct file *f, const char __user *buf,if (p->mapping != adev->mman.bdev.dev_mapping)return -EPERM ; - ptr =kmap (p); + ptr =kmap_local_page (p); r =copy_from_user (ptr + off, buf, bytes); -kunmap (p); +kunmap_local (ptr);if (r)return -EFAULT ;
Signature · 1 line
2.31.1
PATCH v2 1/7 drm/i915: Replace kmap() with kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used.
Replace kmap() calls with kmap_local_page().
---
Changes for V2:
From Christoph Helwig
Prefer the use of memcpy_*_page() where appropriate.
--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++---- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 ++----- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 6 files changed, 16 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2 -4
@@ -619,7 +619,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv, do { unsigned int len = min_t(typeof(size), size, PAGE_SIZE); struct page *page; - void *pgdata, *vaddr; + void *pgdata; err = pagecache_write_begin(file, file->f_mapping, offset, len, 0,
@@ -627,9 +627,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,if (err <0 ) goto fail; - vaddr =kmap (page); -memcpy (vaddr, data, len); -kunmap (page); +memcpy_to_page (page,0 , data, len); err = pagecache_write_end(file, file->f_mapping, offset, len, len,
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +4 -4
@@ -145,7 +145,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (to_gt (i915)); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -163,7 +163,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu); out:__i915_vma_put (vma);
@@ -239,7 +239,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (to_gt (i915)); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -257,7 +257,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu);if (err)return err;
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +2 -2
@@ -743,7 +743,7 @@ static void swizzle_page(struct page *page)char *vaddr;int i; - vaddr =kmap (page); + vaddr =kmap_local_page (page);for (i =0 ; i <PAGE_SIZE ; i +=128 ) {memcpy (temp, &vaddr[i],64 );
@@ -751,7 +751,7 @@ static void swizzle_page(struct page *page)memcpy (&vaddr[i +64 ], temp,64 ); } -kunmap (page); +kunmap_local (vaddr); }/**
drivers/gpu/drm/i915/gt/shmem_utils.c +2 -5
@@ -97,22 +97,19 @@ static int __shmem_rw(struct file *file, loff_t off,unsigned int this =min_t (size_t,PAGE_SIZE -offset_in_page (off), len);struct page *page; -void *vaddr; page =shmem_read_mapping_page_gfp (file->f_mapping, pfn,GFP_KERNEL );if (IS_ERR (page))return PTR_ERR (page); - vaddr =kmap (page);if (write) { -memcpy (vaddr +offset_in_page (off), ptr, this); +memcpy_to_page (page,offset_in_page (off), ptr, this);set_page_dirty (page); }else { -memcpy (ptr, vaddr +offset_in_page (off), this); +memcpy_from_page (ptr, page,offset_in_page (off), this); }mark_page_accessed (page); -kunmap (page);put_page (page); len -= this;
drivers/gpu/drm/i915/i915_gem.c +4 -4
@@ -196,14 +196,14 @@ shmem_pread(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush)drm_clflush_virt_range (vaddr + offset, len); ret =__copy_to_user (user_data, vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
@@ -618,7 +618,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush_before)drm_clflush_virt_range (vaddr + offset, len);
@@ -627,7 +627,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,if (!ret && needs_clflush_after)drm_clflush_virt_range (vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
drivers/gpu/drm/i915/i915_gpu_error.c +2 -2
@@ -1093,9 +1093,9 @@ i915_vma_coredump_create(const struct intel_gt *gt,drm_clflush_pages (&page,1 ); - s =kmap (page); + s =kmap_local_page (page); ret =compress_page (compress, s, dst, false); -kunmap (page); +kunmap_local (s);drm_clflush_pages (&page,1 );
Signature · 1 line
2.31.1
PATCH v2 3/7 drm/gma: Remove calls to kmap()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and these instances are easy to convert to kmap_local_page().
Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper instead of an open coded use of kmap_local_page().
--- drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- 2 files changed, 6 insertions(+), 8 deletions(-)
drivers/gpu/drm/gma500/gma_display.c +2 -4
@@ -335,7 +335,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,struct psb_gem_object *pobj;struct psb_gem_object *cursor_pobj = gma_crtc->cursor_pobj;struct drm_gem_object *obj; -void *tmp_dst, *tmp_src; +void *tmp_dst;int ret =0 , i, cursor_pages;/* If we didn't get a handle then turn the cursor off */
@@ -400,9 +400,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,/* Copy the cursor to cursor mem */ tmp_dst = dev_priv->vram_addr + cursor_pobj->offset;for (i =0 ; i < cursor_pages; i++) { - tmp_src =kmap (pobj->pages[i]); -memcpy (tmp_dst, tmp_src,PAGE_SIZE ); -kunmap (pobj->pages[i]); +memcpy_from_page (tmp_dst, pobj->pages[i],0 ,PAGE_SIZE ); tmp_dst +=PAGE_SIZE ; }
drivers/gpu/drm/gma500/mmu.c +4 -4
@@ -184,17 +184,17 @@ struct psb_mmu_pd *psb_mmu_alloc_pd(struct psb_mmu_driver *driver, pd->invalid_pte =0 ; } - v =kmap (pd->dummy_pt); + v =kmap_local_page (pd->dummy_pt);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pte; -kunmap (pd->dummy_pt); +kunmap_local (v); - v =kmap (pd->p); + v =kmap_local_page (pd->p);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pde; -kunmap (pd->p); +kunmap_local (v);clear_page (kmap (pd->dummy_page));kunmap (pd->dummy_page);
Signature · 1 line
2.31.1
PATCH v2 6/7 drm/amdgpu: Ensure kunmap is called on error
In reply to [email protected]From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up.
---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1 -0
@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Signature · 1 line
2.31.1
PATCH v2 5/7 drm/msm: Alter comment to use kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated. So this comment could be misleading in the future.
Change this comment to point to using kmap_local_page(). While here remove 'we' from the comment.
--- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem_submit.c +2 -2
@@ -438,8 +438,8 @@ static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obreturn -EINVAL ; } -/* For now, just map the entire thing. Eventually we probably -* to do it page-by-page, w/ kmap() if not vmap()d.. +/* For now, just map the entire thing. Eventually it should probably +* be done page-by-page, w/ kmap_local_page() if not vmap()d.. */ ptr =msm_gem_get_vaddr_locked (&obj->base);
Signature · 1 line
2.31.1
PATCH v2 4/7 drm/radeon: Replace kmap() with kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and this usage is local to the thread. Use kmap_local_page() instead.
--- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_ttm.c +2 -2
@@ -907,11 +907,11 @@ static ssize_t radeon_ttm_gtt_read(struct file *f, char __user *buf, page = rdev->gart.pages[p];if (page) { - ptr =kmap (page); + ptr =kmap_local_page (page); ptr += off; r =copy_to_user (buf, ptr, cur_size); -kunmap (rdev->gart.pages[p]); +kunmap_local (ptr); }else r =clear_user (buf, cur_size);
Signature · 1 line
2.31.1
PATCH v2 7/7 drm/radeon: Ensure kunmap is called on error
In reply to [email protected]From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up.
---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.
--- drivers/gpu/drm/radeon/radeon_uvd.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/radeon/radeon_uvd.c +1 -0
@@ -560,6 +560,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,default : +radeon_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type);return -EINVAL ; }
Signature · 1 line
2.31.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DRM kmap() fixes and kmap_local_page() conversions (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions (rev4)
URL : https://patchwork.freedesktop.org/series/97889/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for DRM kmap() fixes and kmap_local_page() conversions (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions (rev4)
URL : https://patchwork.freedesktop.org/series/97889/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22074
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/index.html
Participating hosts (49 -> 41)
------------------------------
Additional (1): fi-pnv-d510
Missing (9): fi-ilk-m540 shard-tglu fi-hsw-4200u fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 shard-rkl shard-dg1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_22074 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [SKIP][2] ([fdo#109271]) +57 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-pnv-d510/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([fdo#109271]) +21 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#533])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
* igt@runner@aborted:
- fi-tgl-1115g4: NOTRUN -> [FAIL][7] ([i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-tgl-1115g4/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [INCOMPLETE][8] ([i915#4547]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/fi-skl-6600u/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-skl-6600u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][10] ([i915#4269]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/fi-cml-u2/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/fi-cml-u2/igt@[email protected]
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][12] ([i915#4494]) -> [DMESG-FAIL][13] ([i915#4494] / [i915#4957])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/bat-dg1-6/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/bat-dg1-6/igt@i915_selftest@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11120 -> Patchwork_22074
CI-20190529: 20190529
CI_DRM_11120: d8e524ded1a6cb24bbd2da0785b04f199c03f1b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6330: f73008bac9a8db0779264b170f630483e9165764 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22074: 2b9596236b139baf2d34adb9f374a66b6a185740 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2b9596236b13 drm/radeon: Ensure kunmap is called on error 26ed6e026d00 drm/amdgpu: Ensure kunmap is called on error 90ed4e064dc9 drm/msm: Alter comment to use kmap_local_page() f6c388027cc0 drm/radeon: Replace kmap() with kmap_local_page() 399bc3fab1df drm/gma: Remove calls to kmap() 3e2a8bf136f6 drm/amd: Replace kmap() with kmap_local_page() 2ea7d2a090d2 drm/i915: Replace kmap() with kmap_local_page()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for DRM kmap() fixes and kmap_local_page() conversions (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions (rev4)
URL : https://patchwork.freedesktop.org/series/97889/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22074_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22074_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22074_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22074_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_softpin@softpin:
- shard-snb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-snb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-snb6/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_schedule@u-submit-early-slice@bcs0:
- {shard-tglu}: NOTRUN -> [INCOMPLETE][3] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglu-7/igt@gem_exec_schedule@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22074_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-tglb2/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk5/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl6/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl4/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb5/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@[email protected]
* igt@gem_mmap_wc@write-read:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl2/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3323])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][20] ([i915#3002])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#3297])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#3297])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +7 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl3/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [PASS][25] -> [INCOMPLETE][26] ([i915#151])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl6/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl4/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][28] ([i915#3763])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3886]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3886]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_color_chamelium@pipe-a-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109284] / [fdo#111827])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109284] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +7 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl8/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl2/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][36] ([i915#2105])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +7 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#3319]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#109279] / [i915#3359])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109278] / [fdo#109279])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-128x128-random:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278]) +4 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][43] -> [FAIL][44] ([i915#79])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk4/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#79])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl1/igt@kms_flip@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][47] -> [DMESG-WARN][48] ([i915#180] / [i915#1982])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl3/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271]) +105 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271]) +14 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109280] / [fdo#111825]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109280]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271]) +98 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl4/igt@[email protected]
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#1187])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#1187])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl4/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][60] -> [FAIL][61] ([fdo#108145] / [i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl7/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl2/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][62] -> [SKIP][63] ([fdo#109642] / [fdo#111068] / [i915#658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb2/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb5/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl2/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl8/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][66] -> [FAIL][67] ([i915#31])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl1/igt@[email protected]
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#31])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk8/igt@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][70] ([IGT#2])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@kms_sysfs_edid_timing.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2437])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [PASS][72] -> [FAIL][73] ([i915#1542])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl8/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl8/igt@[email protected]
* igt@perf@short-reads:
- shard-skl: [PASS][74] -> [FAIL][75] ([i915#51])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl9/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl1/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2994])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl6/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2994]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [DMESG-WARN][78] ([i915#180]) -> [PASS][79] +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl3/igt@gem_ctx_isolation@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl4/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][80] ([i915#2410]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-tglb2/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-tglb1/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][82] ([i915#4525]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb1/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][84] ([i915#2846]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk7/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk2/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk1/igt@gem_exec_fair@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk7/igt@gem_exec_fair@[email protected]
- shard-apl: [FAIL][88] ([i915#2842]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl8/igt@gem_exec_fair@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][90] ([i915#2842]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl4/igt@gem_exec_fair@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][92] ([i915#4171]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk3/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk1/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][94] ([i915#118]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-glk2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-glk5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [FAIL][96] ([i915#2346]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][98] ([i915#180]) -> [PASS][99] +6 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@kms_flip@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1:
- shard-apl: [FAIL][100] ([i915#2122]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-apl1/igt@kms_flip@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-apl6/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][102] ([fdo#108145] / [i915#265]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl4/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][104] ([fdo#109441]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb6/igt@kms_psr@psr2_primary_render.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@kms_psr@psr2_primary_render.html
* igt@prime_vgem@wait@vecs0:
- shard-skl: [DMESG-WARN][106] ([i915#1982]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl3/igt@prime_vgem@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl10/igt@prime_vgem@[email protected]
* igt@sysfs_heartbeat_interval@mixed@bcs0:
- shard-skl: [WARN][108] ([i915#4055]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl3/igt@sysfs_heartbeat_interval@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl10/igt@sysfs_heartbeat_interval@[email protected]
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [FAIL][110] ([i915#1731]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl3/igt@sysfs_heartbeat_interval@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl10/igt@sysfs_heartbeat_interval@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][112] ([i915#4916]) -> [SKIP][113] ([i915#4525])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb4/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb3/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][114] ([i915#1804] / [i915#2684]) -> [WARN][115] ([i915#2684]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][116] ([fdo#111068] / [i915#658]) -> [SKIP][117] ([i915#2920]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb1/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb2/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [FAIL][118] ([i915#4148]) -> [SKIP][119] ([fdo#109642] / [fdo#111068] / [i915#658])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-iclb5/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#602] / [i915#92]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#4312] / [i915#602] / [i915#92])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl7/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl1/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl4/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl1/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl6/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-kbl4/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl6/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl6/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl6/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl1/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl6/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-kbl7/igt@[email protected]
- shard-snb: ([FAIL][144], [FAIL][145]) ([i915#3002] / [i915#4312]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#2426] / [i915#3002] / [i915#4312])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-snb4/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-snb5/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-snb7/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-snb6/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-snb5/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-snb4/igt@[email protected]
- shard-skl: ([FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#4312]) -> ([FAIL][155], [FAIL][156]) ([i915#3002] / [i915#4312])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl5/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl10/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl2/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl5/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11120/shard-skl9/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl9/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/shard-skl1/igt@[email protected]
{name}: This element is suppressed
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22074/index.html
Am 24.01.22 um 02:54 schrieb [email protected]:
Quoted 8 lines
From: Ira Weiny <[email protected]>
Changes from V1:
Usememcpy_to_page()where appropriate
Rebased to latestThe
kmap()call may cause issues with work being done with persistent memory. For this and other reasons it is being deprecated.
I'm really wondering how we should be able to implement the kernel mapping without kmap in TTM.
Quoted 9 lines
This series starts by converting the last easy
kmap()uses in the drm tree tokmap_local_page().The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion. They are valid fixes but were found via code inspection not because of any actual bug so don't require a stable tag.[1]There is one more call to
kmap()used inttm_bo_kmap_ttm(). Unfortunately, fixing this is not straight forward so it is left to future work.[2]
Patches #2, #4, #6 and #7 are Reviewed-by: Christian König <[email protected]>
How to you now want to push those upstream? I can pick them up for the AMD tree like Daniel suggested or you can push them through something else.
Regards,
Christian.
Quoted 32 lines
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 6 ++----drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 7 ++-----drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 37 deletions(-)--
2.31.1
Daniel Vetter
AppliedRe: [PATCH V2 3/7] drm/gma: Remove calls to kmap()
In reply to [email protected]Quoted 9 lines · On Sun, Jan 23, 2022 at 05:54:05PM -0800, [email protected] wrote:
From: Ira Weiny <[email protected]>
kmap()is being deprecated and these instances are easy to convert tokmap_local_page().Furthermore, in
gma_crtc_cursor_set()use thememcpy_from_page()helper instead of an open coded use ofkmap_local_page().Signed-off-by Ira Weiny <[email protected]>
Applied to drm-misc-next, the others should all have full time maintainers to make sure the patches land. Pls holler if not.
Thanks, Daniel
Quoted 58 lines
--- drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- 2 files changed, 6 insertions(+), 8 deletions(-)drivers/gpu/drm/gma500/gma_display.c +2
-4@@ -335,7 +335,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,struct psb_gem_object *pobj;struct psb_gem_object *cursor_pobj = gma_crtc->cursor_pobj;struct drm_gem_object *obj; -void *tmp_dst, *tmp_src; +void *tmp_dst;int ret =0 , i, cursor_pages;/* If we didn't get a handle then turn the cursor off */ @@ -400,9 +400,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,/* Copy the cursor to cursor mem */ tmp_dst = dev_priv->vram_addr + cursor_pobj->offset;for (i =0 ; i < cursor_pages; i++) { - tmp_src =kmap (pobj->pages[i]); -memcpy (tmp_dst, tmp_src,PAGE_SIZE ); -kunmap (pobj->pages[i]); +memcpy_from_page (tmp_dst, pobj->pages[i],0 ,PAGE_SIZE ); tmp_dst +=PAGE_SIZE ; }drivers/gpu/drm/gma500/mmu.c +4
-4@@ -184,17 +184,17 @@ struct psb_mmu_pd *psb_mmu_alloc_pd(struct psb_mmu_driver *driver, pd->invalid_pte =0 ; } - v =kmap (pd->dummy_pt); + v =kmap_local_page (pd->dummy_pt);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pte; -kunmap (pd->dummy_pt); +kunmap_local (v); - v =kmap (pd->p); + v =kmap_local_page (pd->p);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pde; -kunmap (pd->p); +kunmap_local (v);clear_page (kmap (pd->dummy_page));kunmap (pd->dummy_page);Signature · 1 line
2.31.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 20 lines · Christian König
Am 24.01.22 um 02:54 schrieb [email protected]:
Quoted 8 lines
From: Ira Weiny <[email protected]>
Changes from V1:
Usememcpy_to_page()where appropriate
Rebased to latestThe
kmap()call may cause issues with work being done with persistent memory. For this and other reasons it is being deprecated.I'm really wondering how we should be able to implement the kernel mapping without kmap in TTM.
Quoted 7 lines
This series starts by converting the last easy
kmap()uses in the drm tree tokmap_local_page().The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion. They are valid fixes but were found via code inspection not because of any actual bug so don't require a stable tag.[1]
Quoted 5 lines
Quoted 2 lines
There is one more call to
kmap()used inttm_bo_kmap_ttm(). Unfortunately, fixing this is not straight forward so it is left to future work.[2]Patches #2, #4, #6 and #7 are Reviewed-by: Christian König <[email protected]>
Christian,
Would you prefer I send those 4 to you as a separate series?
Quoted 3 lines
How to you now want to push those upstream? I can pick them up for the AMD tree like Daniel suggested or you can push them through something else.
You picking them up from this series is ok as well.
Daniel will you take #1, #3, and #5?
Thanks,
Ira
Quoted 37 lines
Regards,
Christian.Quoted 32 lines
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 6 ++----drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 7 ++-----drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 37 deletions(-)--
2.31.1