leds: remove ide-disk trigger
Subsystems (2)
PATCH v2 1/1 leds: remove ide-disk trigger
No user of ide-disk remains, so remove this deprecated trigger.
Signed-off-by Corentin Labbe <[email protected]>
---
Changes since v1:
- remove also DEFINE_LED_TRIGGER(ledtrig_ide)
Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +0 -3
@@ -91,9 +91,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software
drivers/leds/trigger/ledtrig-disk.c +0 -4
@@ -16,7 +16,6 @@DEFINE_LED_TRIGGER (ledtrig_disk);DEFINE_LED_TRIGGER (ledtrig_disk_read);DEFINE_LED_TRIGGER (ledtrig_disk_write); -DEFINE_LED_TRIGGER (ledtrig_ide);void ledtrig_disk_activity (bool write) {
@@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write)led_trigger_blink_oneshot (ledtrig_disk, &blink_delay, &blink_delay,0 ); -led_trigger_blink_oneshot (ledtrig_ide, - &blink_delay, &blink_delay,0 );if (write)led_trigger_blink_oneshot (ledtrig_disk_write, &blink_delay, &blink_delay,0 );
@@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void)led_trigger_register_simple ("disk-activity" , &ledtrig_disk);led_trigger_register_simple ("disk-read" , &ledtrig_disk_read);led_trigger_register_simple ("disk-write" , &ledtrig_disk_write); -led_trigger_register_simple ("ide-disk" , &ledtrig_ide);return 0 ; }
Signature · 1 line
2.34.1
Quoted 1 line · Corentin Labbe
No user of ide-disk remains, so remove this deprecated trigger.
Strictly speaking, this would break someone if they didn't update their DT. But it only looks like only a few platforms used this and they were fixed in 2016. The commit message should say all this so I don't have to go research it.
With that,
Acked-by Rob Herring <[email protected]>
Quoted 9 lines
Signed-off-by Corentin Labbe <[email protected]>---
Changes since v1:
- remove alsoDEFINE_LED_TRIGGER(ledtrig_ide)Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-)