ACPI: device_sysfs: Add sysfs support for _PLD
PATCH 1/1 ACPI: device_sysfs: Add sysfs support for _PLD
When ACPI table includes _PLD fields for a device, create a new file (pld) in sysfs to share _PLD fields.
Signed-off-by Won Chung <[email protected]>
--- drivers/acpi/device_sysfs.c | 42 +++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)
drivers/acpi/device_sysfs.c +42 -0
@@ -509,6 +509,40 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr, }static DEVICE_ATTR_RO (status); +static ssize_t pld_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct acpi_device *acpi_dev =to_acpi_device (dev); +acpi_status status; +struct acpi_pld_info *pld; + + status =acpi_get_physical_device_location (acpi_dev->handle, &pld); +if (ACPI_FAILURE (status)) +return -ENODEV ; + +return sprintf (buf,"GROUP_TOKEN=%u\n" +"GROUP_POSITION=%u\n" +"USER_VISIBLE=%u\n" +"DOCK=%u\n" +"BAY=%u\n" +"LID=%u\n" +"PANEL=%u\n" +"HORIZONTAL_POSITION=%u\n" +"VERTICAL_POSITION=%u\n" +"SHAPE=%u\n" , + pld->group_token, + pld->group_position, + pld->user_visible, + pld->dock, + pld->bay, + pld->lid, + pld->panel, + pld->horizontal_position, + pld->vertical_position, + pld->shape); +} +static DEVICE_ATTR_RO (pld); +/** * acpi_device_setup_files - Create sysfs attributes of an ACPI device. * @dev: ACPI device object.
@@ -595,6 +629,12 @@ int acpi_device_setup_files(struct acpi_device *dev) &dev_attr_real_power_state); } +if (acpi_has_method (dev->handle,"_PLD" )) { + result =device_create_file (&dev->dev, &dev_attr_pld); +if (result) + goto end; + } +acpi_expose_nondev_subnodes (&dev->dev.kobj, &dev->data); end:
@@ -645,4 +685,6 @@ void acpi_device_remove_files(struct acpi_device *dev)device_remove_file (&dev->dev, &dev_attr_status);if (dev->handle)device_remove_file (&dev->dev, &dev_attr_path); +if (acpi_has_method (dev->handle,"_PLD" )) +device_remove_file (&dev->dev, &dev_attr_pld); }
Signature · 1 line
2.35.0.rc0.227.g00780c9af4-goog
Hi Won,
Quoted 2 lines · Won Chung
When ACPI table includes
_PLDfields for a device, create a new file (pld) in sysfs to share_PLDfields.
If you're adding a new attribute, you should also update the Documentation file here: Documentation/ABI/testing/sysfs-bus-acpi
Thanks,
Benson
Quoted 74 lines
Signed-off-by Won Chung <[email protected]>--- drivers/acpi/device_sysfs.c | 42 +++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)drivers/acpi/device_sysfs.c +42
-0@@ -509,6 +509,40 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr, }static DEVICE_ATTR_RO (status); +static ssize_t pld_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct acpi_device *acpi_dev =to_acpi_device (dev); +acpi_status status; +struct acpi_pld_info *pld; + + status =acpi_get_physical_device_location (acpi_dev->handle, &pld); +if (ACPI_FAILURE (status)) +return -ENODEV ; + +return sprintf (buf,"GROUP_TOKEN=%u\n" +"GROUP_POSITION=%u\n" +"USER_VISIBLE=%u\n" +"DOCK=%u\n" +"BAY=%u\n" +"LID=%u\n" +"PANEL=%u\n" +"HORIZONTAL_POSITION=%u\n" +"VERTICAL_POSITION=%u\n" +"SHAPE=%u\n" , + pld->group_token, + pld->group_position, + pld->user_visible, + pld->dock, + pld->bay, + pld->lid, + pld->panel, + pld->horizontal_position, + pld->vertical_position, + pld->shape); +} +static DEVICE_ATTR_RO (pld); +/** * acpi_device_setup_files - Create sysfs attributes of an ACPI device. * @dev: ACPI device object. @@ -595,6 +629,12 @@ int acpi_device_setup_files(struct acpi_device *dev) &dev_attr_real_power_state); } +if (acpi_has_method (dev->handle,"_PLD" )) { + result =device_create_file (&dev->dev, &dev_attr_pld); +if (result) + goto end; + } +acpi_expose_nondev_subnodes (&dev->dev.kobj, &dev->data); end:@@ -645,4 +685,6 @@ void acpi_device_remove_files(struct acpi_device *dev)device_remove_file (&dev->dev, &dev_attr_status);if (dev->handle)device_remove_file (&dev->dev, &dev_attr_path); +if (acpi_has_method (dev->handle,"_PLD" )) +device_remove_file (&dev->dev, &dev_attr_pld); }Signature · 1 line
2.35.0.rc0.227.g00780c9af4-goog
Signature · 7 lines
Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]