Skip to contentSkip to conversation

i2c: designware: remove unneeded semicolon

PATCH Superseded Yang Li 2 participants 2 messages Feb 14, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 i2c: designware: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon

---

--Changes in v2:
According to Jan's suggestion
Fix the same problem in check_i2c_req_sts() function.

 drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-designware-amdpsp.c +2 -2
index 752e0024db03..9d37becbd846 100644
@@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)
 	case PSP_I2C_REQ_STS_INV_PARAM:
 	default:
 		return -EIO;
-	};
+	}
 }
 
 static int psp_send_check_i2c_req(struct psp_i2c_req *req)
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
 	if (psp_i2c_access_count) {
 		psp_i2c_access_count++;
 		goto cleanup;
-	};
+	}
 
 	status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
 	if (status) {
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v2 1/1
#1 lore raw

pon., 14 lut 2022 o 10:00 Yang Li <[email protected]> napisał(a):

Quoted 2 lines

Eliminate the following coccicheck warning:

nit: warnings

Quoted 5 lines

./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon

Beside a nit above:

Best Regards,
Jan

Quoted 34 lines

---

--Changes in v2:
According to Jan's suggestion
Fix the same problem in check_i2c_req_sts() function.

 drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-designware-amdpsp.c +2 -3
index 752e0024db03..9d37becbd846 100644
@@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)
        case PSP_I2C_REQ_STS_INV_PARAM:
        default:
                return -EIO;
-       };
+       }
 }
 
 static int psp_send_check_i2c_req(struct psp_i2c_req *req)
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
        if (psp_i2c_access_count) {
                psp_i2c_access_count++;
                goto cleanup;
-       };
+       }
 
        status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
        if (status) {
--

2.20.1.7.g153144c