i2c: designware: remove unneeded semicolon
Subsystems (3)
PATCH RESEND v2 1/1 i2c: designware: remove unneeded semicolon
Eliminate the following coccicheck warnings:
./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
---
--Changes in v2:
According to Jan's suggestion
Fix the same problem in check_i2c_req_sts() function.
drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-designware-amdpsp.c +2 -2
@@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)case PSP_I2C_REQ_STS_INV_PARAM :default :return -EIO ; - }; + } }static int psp_send_check_i2c_req (struct psp_i2c_req *req)
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)if (psp_i2c_access_count) { psp_i2c_access_count++; goto cleanup; - }; + } status =psp_send_i2c_req (PSP_I2C_REQ_ACQUIRE );if (status) {
Signature · 1 line
2.20.1.7.g153144c
Hi
Quoted 6 lines · Yang Li
Eliminate the following coccicheck warnings:
./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolonReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Quoted 9 lines
---
--Changes in v2:
According to Jan's suggestion
Fix the same problem incheck_i2c_req_sts()function.drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
For future contributions: Technically this would be v3 rather than v2 RESEND since you fixed the typo in commit log noted by Jan for v2.
Please use RESEND only if you'll send exactly the same version for instance if you didn't receive any comments for several weeks or some recipient was missing from Cc field.
I believe Jan will give Reviewed-by tag to this version too.
Jan Dąbroś
Reviewed-bypon., 14 lut 2022 o 14:03 Jarkko Nikula
<[email protected]> napisał(a):
Quoted 22 lines
Hi
Quoted 6 lines · Yang Li
Eliminate the following coccicheck warnings:
./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolonReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>Quoted 9 lines
---
--Changes in v2:
According to Jan's suggestion
Fix the same problem incheck_i2c_req_sts()function.drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)For future contributions: Technically this would be v3 rather than v2 RESEND since you fixed the typo in commit log noted by Jan for v2.
Quoted 7 lines
Please use RESEND only if you'll send exactly the same version for instance if you didn't receive any comments for several weeks or some recipient was missing from Cc field.
I believe Jan will give Reviewed-by tag to this version too.
Acked-by Jarkko Nikula <[email protected]>
Correct.
Best Regards,
Jan