arm64: dts: qcom: Drop bogus interrupt flags cell on MDSS nodes
Rob Herring
maintainerPATCH 1/1 arm64: dts: qcom: Drop bogus interrupt flags cell on MDSS nodes
The MDSS interrupt provider is a single cell, so specifying interrupt flags on the consumers is incorrect.
--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
@@ -4281,7 +4281,7 @@ mdss_mdp: mdp@ae01000 { power-domains = <&rpmhpd SDM845_CX>; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; ports { #address-cells = <1>;
arch/arm64/boot/dts/qcom/sm8250.dtsi +1 -1
@@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { power-domains = <&rpmhpd SM8250_MMCX>; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; ports { #address-cells = <1>;
Signature · 1 line
2.32.0
Hi Rob,
Quoted 2 lines · Rob Herring
The MDSS interrupt provider is a single cell, so specifying interrupt flags on the consumers is incorrect.
There seem to be many more violators of #interrupt-cells = <1>;, at least on -next e6ada6df471f. It seems those are not intentionally omitted in this patch? Searching for interrupt-parent = <&mdss>; globally and evaluating interrupts = right next to it yields:
- Two more hits in both sdm845.dtsi and sm8250.dtsi;
- qcom-msm8974.dtsi;
- msm8996.dtsi;
- sdm630.dtsi;
- sdm660.dtsi.
And for the docs patch:
- mdp5.txt;
- And the recently added dpu-qcm2290.yaml, whose CI failure might have exactly lead to this patch?
Would you mind cleaning these up in a v2, or otherwise explain and forgive my ignorance for not seeing why these were not changed?
Thanks!
- Marijn
Quoted 35 lines
Signed-off-by Rob Herring <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/qcom/sdm845.dtsi +1
-1@@ -4281,7 +4281,7 @@ mdss_mdp: mdp@ae01000 { power-domains = <&rpmhpd SDM845_CX>; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; ports { #address-cells = <1>;arch/arm64/boot/dts/qcom/sm8250.dtsi +1
-1@@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { power-domains = <&rpmhpd SM8250_MMCX>; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; ports { #address-cells = <1>;Signature · 1 line
2.32.0
Rob Herring
maintainerQuoted 12 lines · Marijn Suijten
Hi Rob,
Quoted 2 lines · Rob Herring
The MDSS interrupt provider is a single cell, so specifying interrupt flags on the consumers is incorrect.
There seem to be many more violators of
#interrupt-cells = <1>;, at least on -nexte6ada6df471f. It seems those are not intentionally omitted in this patch? Searching forinterrupt-parent = <&mdss>;globally and evaluatinginterrupts =right next to it yields:
Quoted 8 lines
- Two more hits in both
sdm845.dtsiandsm8250.dtsi;
-qcom-msm8974.dtsi;
-msm8996.dtsi;
-sdm630.dtsi;
-sdm660.dtsi.And for the docs patch:
- mdp5.txt;
Don't care, it's a .txt file.
Quoted 5 lines
- And the recently added
dpu-qcm2290.yaml, whose CI failure might have exactly lead to this patch?Would you mind cleaning these up in a v2, or otherwise explain and forgive my ignorance for not seeing why these were not changed?
For the rest, just inadequate searching on my part. v2 coming soon.
Rob