Resolve some redundant property accessors
Subsystems (2)
cover Resolve some redundant property accessors
No changes. Just also CC'ed to qemu-trivial.
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 570 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
hw/riscv/sifive_u.c | 24 ++++-------------------- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 2 files changed, 13 insertions(+), 45 deletions(-)
Signature · 1 line
2.35.1
PATCH RESEND 1/2 hw/vfio/pci-quirks: Resolve redundant property getters
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
--- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-)
hw/vfio/pci-quirks.c +9 -25
@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;
@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size); free_exit:
@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed); free_exit:
Signature · 1 line
2.35.1
Re: [PATCH RESEND 1/2] hw/vfio/pci-quirks: Resolve redundant property getters
Am 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 5 lines
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>Reviewed-by Alistair Francis <[email protected]>
Meh, I accidently swapped Alistair's Reviewed-by into this patch while dropping it from the other. Please ignore and sorry for that.
Best regards,
Bernhard
Quoted 67 lines
Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
hw/vfio/pci-quirks.c| 34 +++++++++-------------------------1 file changed, 9 insertions(+), 25 deletions(-)hw/vfio/pci-quirks.c +3
-19@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size);
free_exit:hw/vfio/pci-quirks.c +6
-6@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed);
free_exit:
Re: [PATCH RESEND 1/2] hw/vfio/pci-quirks: Resolve redundant property getters
In reply to Bernhard BeschowAm 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 70 lines
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
hw/vfio/pci-quirks.c| 34 +++++++++-------------------------1 file changed, 9 insertions(+), 25 deletions(-)hw/vfio/pci-quirks.c +3
-19@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size);
free_exit:hw/vfio/pci-quirks.c +6
-6@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed);
Quoted 1 line
free_exit:
Ping
@Alistair: When resending, I accidently added a Reviewed-by with your name here which I asked to be ignored *after* you re-acked patch 2/2. In case you intended to ack this patch as well your voice would be needed again.
Thanks,
Bernhard
Re: [PATCH RESEND 1/2] hw/vfio/pci-quirks: Resolve redundant property getters
Quoted 75 lines · Bernhard Beschow
Am 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 70 lines
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
hw/vfio/pci-quirks.c| 34 +++++++++-------------------------1 file changed, 9 insertions(+), 25 deletions(-)hw/vfio/pci-quirks.c +3
-19@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size);
free_exit:hw/vfio/pci-quirks.c +6
-6@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed);Quoted 1 line
free_exit:Ping
Quoted 1 line
@Alistair: When resending, I accidently added a Reviewed-by with your name here which I asked to be ignored *after* you re-acked patch 2/2. In case you intended to ack this patch as well your voice would be needed again.
FWIW I expect these patches to get merged via the qemu-trivial@ tree once the 7.1 development window opens.
Re: [PATCH RESEND 1/2] hw/vfio/pci-quirks: Resolve redundant property getters
Am 21. März 2022 13:06:29 UTC schrieb "Philippe Mathieu-Daudé" <[email protected]>:
Quoted 76 lines · Bernhard Beschow
Quoted 75 lines
Am 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 70 lines
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
hw/vfio/pci-quirks.c| 34 +++++++++-------------------------1 file changed, 9 insertions(+), 25 deletions(-)hw/vfio/pci-quirks.c +3
-19@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size);
free_exit:hw/vfio/pci-quirks.c +6
-6@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed);Quoted 1 line
free_exit:Ping
Quoted 4 lines
Quoted 1 line
@Alistair: When resending, I accidently added a Reviewed-by with your name here which I asked to be ignored *after* you re-acked patch 2/2. In case you intended to ack this patch as well your voice would be needed again.
FWIW I expect these patches to get merged via the qemu-trivial@ tree once the 7.1 development window opens.
Excellent!
Best regards,
Bernhard
PATCH RESEND 2/2 hw/riscv/sifive_u: Resolve redundant property accessors
In reply to Bernhard BeschowThe QOM API already provides accessors for uint32 values, so reuse them.
--- hw/riscv/sifive_u.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)
hw/riscv/sifive_u.c +4 -20
@@ -713,36 +713,20 @@ static void sifive_u_machine_set_start_in_flash(Object *obj, bool value, Error * s->start_in_flash = value; } -static void sifive_u_machine_get_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} - -static void sifive_u_machine_set_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} -static void sifive_u_machine_instance_init (Object *obj) {SiFiveUState *s =RISCV_U_MACHINE (obj); s->start_in_flash = false; s->msel =0 ; -object_property_add (obj,"msel" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->msel); +object_property_add_uint32_ptr (obj,"msel" , &s->msel, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"msel" ,"Mode Select (MSEL[3:0]) pin state" ); s->serial =OTP_SERIAL ; -object_property_add (obj,"serial" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->serial); +object_property_add_uint32_ptr (obj,"serial" , &s->serial, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"serial" ,"Board serial number" ); }
Signature · 1 line
2.35.1
Re: [PATCH RESEND 2/2] hw/riscv/sifive_u: Resolve redundant property accessors
Quoted 5 lines · Bernhard Beschow
The QOM API already provides accessors for uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Alistair
Quoted 53 lines
--- hw/riscv/sifive_u.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)hw/riscv/sifive_u.c +4
-21@@ -713,36 +713,20 @@ static void sifive_u_machine_set_start_in_flash(Object *obj, bool value, Error * s->start_in_flash = value; } -static void sifive_u_machine_get_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} - -static void sifive_u_machine_set_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} -static void sifive_u_machine_instance_init (Object *obj) {SiFiveUState *s =RISCV_U_MACHINE (obj); s->start_in_flash = false; s->msel =0 ; -object_property_add (obj,"msel" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->msel); +object_property_add_uint32_ptr (obj,"msel" , &s->msel, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"msel" ,"Mode Select (MSEL[3:0]) pin state" ); s->serial =OTP_SERIAL ; -object_property_add (obj,"serial" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->serial); +object_property_add_uint32_ptr (obj,"serial" , &s->serial, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"serial" ,"Board serial number" ); } --2.35.1
Am 1. März 2022 22:52:18 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 15 lines
No changes. Just also CC'ed to qemu-trivial.
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 570 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 8 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
hw/riscv/sifive_u.c| 24 ++++--------------------hw/vfio/pci-quirks.c| 34 +++++++++-------------------------2 files changed, 13 insertions(+), 45 deletions(-)
Ping
First round of trivial patches went already in for 7.1, hence a reminder.
Best regards,
Bernhard
Am 5. Mai 2022 16:52:13 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 25 lines
Am 1. März 2022 22:52:18 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 15 lines
No changes. Just also CC'ed to qemu-trivial.
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 570 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0Quoted 8 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
hw/riscv/sifive_u.c| 24 ++++--------------------hw/vfio/pci-quirks.c| 34 +++++++++-------------------------2 files changed, 13 insertions(+), 45 deletions(-)
Quoted 6 lines
Ping
First round of trivial patches went already in for 7.1, hence a reminder.
Best regards,
Bernhard
Ping 2
Alistair Francis
AppliedQuoted 16 lines · Bernhard Beschow
No changes. Just also CC'ed to qemu-trivial.
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 570 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 3 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
Thanks!
Applied to riscv-to-apply.next
Alistair
Quoted 9 lines
hw/riscv/sifive_u.c | 24 ++++-------------------- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 2 files changed, 13 insertions(+), 45 deletions(-)--
2.35.1
Am 17. Mai 2022 03:41:51 UTC schrieb Alistair Francis <[email protected]>:
Quoted 17 lines · Bernhard Beschow
Quoted 16 lines
No changes. Just also CC'ed to qemu-trivial.
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 570 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 7 lines
Quoted 3 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessorsThanks!
Applied to riscv-to-apply.next
Finally :)
Thanks,
Bernhard
Quoted 12 lines
Alistair
Quoted 9 lines
hw/riscv/sifive_u.c | 24 ++++-------------------- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 2 files changed, 13 insertions(+), 45 deletions(-)--
2.35.1