Skip to contentSkip to conversation

sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true'

PATCH Superseded kernel test robot 4 participants 5 messages Mar 9, 2022 – Mar 14, 2022

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://github.com/ammarfaizi2/linux-block broonie/sound/for-next
head:   0b7daa6bd0a4cab3b0c6f266a8cb1344ce14ef19
commit: 50291652af5269813baa6024eb0e81b5f0bbb451 [13916/13921] ASoC: atmel: mchp-pdmc: add PDMC driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20220309/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/50291652af5269813baa6024eb0e81b5f0bbb451
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block broonie/sound/for-next
git checkout 50291652af5269813baa6024eb0e81b5f0bbb451
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/atmel/

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>):

>> sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true' [-Wpointer-bool-conversion]
           bool af = uvalue->value.integer.value ? true : false;
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~ ~

1 warning generated.

vim +186 sound/soc/atmel/mchp-pdmc.c

180
181 static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
182 struct snd_ctl_elem_value *uvalue)
183 {
184 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
185 struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);

 > 186		bool af = uvalue->value.integer.value ? true : false;

187
188 if (dd->audio_filter_en == af)
189 return 0;
190
191 dd->audio_filter_en = af;
192
193 return 1;
194 }
195

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

#1 lore raw

PATCH 1/1 ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

In function mchp_pdmc_af_put(), Intel's kernel test robot reports the following warning:

  sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
  'uvalue->value.integer.value' will always evaluate to 'true' \
  [-Wpointer-bool-conversion]

This is because we are using uvalue->value.integer.value which its type is long value[128]; for conditional expression and that array will always decay to a non-NULL pointer. Using a non-NULL pointer for conditional expression will always evaluate to true.

Fix this by changing it to uvalue->value.integer.value[0] as that's what the mchp_pdmc_af_get() function sets.

To: Mark Brown <[email protected]>

Cc Codrin Ciubotariu <[email protected]>
Cc Nugraha <[email protected]>
Cc llvm(a)lists.linux.dev
Cc kbuild-all(a)lists.01.org
Cc gwml(a)vger.gnuweeb.org
Cc linux-kernel(a)vger.kernel.org
Fixes 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
---
 sound/soc/atmel/mchp-pdmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/atmel/mchp-pdmc.c +1 -1
index c44636f6207d..7b87f75c284c 100644
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
 	struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
-	bool af = uvalue->value.integer.value ? true : false;
+	bool af = uvalue->value.integer.value[0] ? true : false;
 
 	if (dd->audio_filter_en == af)
 		return 0;

base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451

Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

Quoted 16 lines · Alviro Iskandar Setiawan

In function mchp_pdmc_af_put(), Intel's kernel test robot reports the following warning:

   sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
   'uvalue->value.integer.value' will always evaluate to 'true' \
   [-Wpointer-bool-conversion]

This is because we are using uvalue->value.integer.value which its type is long value[128]; for conditional expression and that array will always decay to a non-NULL pointer. Using a non-NULL pointer for conditional expression will always evaluate to true.

Fix this by changing it to uvalue->value.integer.value[0] as that's what the mchp_pdmc_af_get() function sets.

To: Mark Brown <[email protected]>

Quoted 10 lines
Cc Codrin Ciubotariu <[email protected]>
Cc Nugraha <[email protected]>
Cc llvm(a)lists.linux.dev
Cc kbuild-all(a)lists.01.org
Cc gwml(a)vger.gnuweeb.org
Cc linux-kernel(a)vger.kernel.org
Fixes 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")

Thank you!

Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

In reply to Alviro Iskandar Setiawan

Hi Alviro,

Quoted 15 lines · Alviro Iskandar Setiawan

In function mchp_pdmc_af_put(), Intel's kernel test robot reports the following warning:

  sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
  'uvalue->value.integer.value' will always evaluate to 'true' \
  [-Wpointer-bool-conversion]

This is because we are using uvalue->value.integer.value which its type is long value[128]; for conditional expression and that array will always decay to a non-NULL pointer. Using a non-NULL pointer for conditional expression will always evaluate to true.

Fix this by changing it to uvalue->value.integer.value[0] as that's what the mchp_pdmc_af_get() function sets.

Quoted 7 lines

To: Mark Brown <[email protected]>
Cc: Codrin Ciubotariu <[email protected]>
Cc: Nugraha <[email protected]>
Cc: llvm(a)lists.linux.dev
Cc: kbuild-all(a)lists.01.org
Cc: gwml(a)vger.gnuweeb.org
Cc: linux-kernel(a)vger.kernel.org

I would recommend removing these and just setting those values via git send-email flags. In other words:

git send-email --to "..." --cc "..." --cc "..." <path to .patch>

and so on. It can cause a lot of spam if this patch is ever backported or needed in other trees.

Quoted 3 lines
Fixes 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")

This should be simplified to:

Fixes 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")

I don't think the automated checkers will complain about that but the short form is preferred.

Quoted 1 line

Thanks a lot for the patch!

I don't know if those nits are worth resending but I do not see this applied to Mark's tree yet. It might have gotten lost because this was sent as a reply to the build report, rather than its own thread, which has caused issues for me in the past:

https://lore.kernel.org/r/20210903162639.GM4932(a)sirena.org.uk/

If there is no action on this patch in the next couple of days, please consider resending with the above nits addressed with Codrin's tag and my tag.

Quoted 23 lines
---
 sound/soc/atmel/mchp-pdmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/atmel/mchp-pdmc.c +1 -1
index c44636f6207d..7b87f75c284c 100644
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
 	struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
-	bool af = uvalue->value.integer.value ? true : false;
+	bool af = uvalue->value.integer.value[0] ? true : false;
 
 	if (dd->audio_filter_en == af)
 		return 0;

base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451

Signature · 1 line
2.27.0
#4 lore raw

Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

Quoted 1 line · Nathan Chancellor

Hi Alviro,

[...]

Quoted 8 lines

I would recommend removing these and just setting those values via git send-email flags. In other words:

git send-email --to "..." --cc "..." --cc "..." <path to .patch>

and so on. It can cause a lot of spam if this patch is ever backported or needed in other trees.

Fixed.

Quoted 10 lines
Quoted 3 lines
Fixes 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")

This should be simplified to:

Fixes 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")

I don't think the automated checkers will complain about that but the short form is preferred.

Fixed.

Quoted 11 lines
Quoted 1 line

Thanks a lot for the patch!

I don't know if those nits are worth resending but I do not see this applied to Mark's tree yet. It might have gotten lost because this was sent as a reply to the build report, rather than its own thread, which has caused issues for me in the past:

Quoted 5 lines

https://lore.kernel.org/r/20210903162639.GM4932(a)sirena.org.uk/

If there is no action on this patch in the next couple of days, please consider resending with the above nits addressed with Codrin's tag and my tag.

Will address those. Thanks for the review.

-- Viro