pci: imx: remove weak overrides no longer used
Subsystems (3)
PATCH 1/1 pci: imx: remove weak overrides no longer used
There are no users of the imx6_pcie_toggle_power and imx6_pcie_toggle_reset weak overrides and as these functions are able to be handled now via dt properties lets remove these.
Cc Marek Vasut <[email protected]>
Signed-off-by Tim Harvey <[email protected]>
--- arch/arm/include/asm/arch-mx6/sys_proto.h | 3 --- drivers/pci/pcie_imx.c | 10 ++-------- 2 files changed, 2 insertions(+), 11 deletions(-)
arch/arm/include/asm/arch-mx6/sys_proto.h +0 -3
@@ -18,9 +18,6 @@#define is_usbotg_phy_active (void) (!(readl(USB_PHY0_BASE_ADDR + USBPHY_PWD) & \ USBPHY_PWD_RXPWDRX)) -int imx6_pcie_toggle_power (struct udevice *vpcie); -int imx6_pcie_toggle_reset (struct gpio_desc *gpio,bool active_high); -enum ldo_reg {LDO_ARM ,LDO_SOC ,
drivers/pci/pcie_imx.c +2 -8
@@ -532,7 +532,7 @@ static int imx6_pcie_init_phy(void)return 0 ; } -__weak int imx6_pcie_toggle_power (struct udevice *vpcie) +int imx6_pcie_toggle_power (struct udevice *vpcie) {#ifdef CONFIG_PCIE_IMX_POWER_GPIO gpio_request (CONFIG_PCIE_IMX_POWER_GPIO ,"pcie_power" );
@@ -554,7 +554,7 @@ __weak int imx6_pcie_toggle_power(struct udevice *vpcie)return 0 ; } -__weak int imx6_pcie_toggle_reset (struct gpio_desc *gpio,bool active_high) +int imx6_pcie_toggle_reset (struct gpio_desc *gpio,bool active_high) {/* * See 'PCI EXPRESS BASE SPECIFICATION, REV 3.0, SECTION 6.6.1'
@@ -570,12 +570,6 @@ __weak int imx6_pcie_toggle_reset(struct gpio_desc *gpio, bool active_high)* configuration file and the condition below will handle the rest * of the reset toggling. * -* In case your #PERST toggling logic is more complex, for example -* connected via CPLD or somesuch, you can override this function -* in your board file and implement reset logic as needed. You must -* not forget to wait at least 20 ms after de-asserting #PERST in -* this case either though. -* * In case your #PERST line of the PCIe EP device is not connected * at all, your design is broken and you should fix your design, * otherwise you will observe problems like for example the link
Signature · 1 line
2.17.1
PATCH 1/1 pci: imx: remove weak overrides no longer used
Quoted 5 lines
There are no users of the
imx6_pcie_toggle_powerandimx6_pcie_toggle_resetweak overrides and as these functions are able to be handled now via dt properties lets remove these.Cc Marek Vasut <[email protected]>Signed-off-by Tim Harvey <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================