Skip to contentSkip to conversation

imx8mn_evk: Enable cache in SPL

PATCH In review Fabio Estevam 3 participants 6 messages Apr 18, 2022 – Apr 28, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 imx8mn_evk: Enable cache in SPL

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

---
 configs/imx8mn_evk_defconfig | 2 --
 1 file changed, 2 deletions(-)
configs/imx8mn_evk_defconfig +0 -2
index b2981d1e3692..e661b3ba7e55 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
Signature · 1 line
2.25.1
author reviewer
#1 lore raw

PATCH 2/2 doc: imx8mn_evk: Do not export ATF_LOAD_ADDR

From: Fabio Estevam <[email protected]>

The imx8mn_evk target have been converted to use binman.

With the binman approach the ATF load address is described via devicetree, so remove the now unneeded instruction of exporting ATF_LOAD_ADDR.

---
 doc/board/nxp/imx8mn_evk.rst | 1 -
 1 file changed, 1 deletion(-)
doc/board/nxp/imx8mn_evk.rst +0 -1
index 711545af896a..c45bb7bac7a1 100644
@@ -42,7 +42,6 @@ Build U-Boot
 
    $ export CROSS_COMPILE=aarch64-poky-linux-
    $ make imx8mn_ddr4_evk_defconfig
-   $ export ATF_LOAD_ADDR=0x960000
    $ make
 
 Burn the flash.bin to MicroSD card offset 32KB:
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/2 doc: imx8mn_evk: Do not export ATF_LOAD_ADDR

Quoted 6 lines

From: Fabio Estevam <[email protected]>
The imx8mn_evk target have been converted to use binman. With the binman approach the ATF load address is described via devicetree, so remove the now unneeded instruction of exporting ATF_LOAD_ADDR.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Reviewed-by Peng Fan on v1 2/2
#3 lore raw

Re: [PATCH 2/2] doc: imx8mn_evk: Do not export ATF_LOAD_ADDR

In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The imx8mn_evk target have been converted to use binman.

With the binman approach the ATF load address is described via devicetree, so remove the now unneeded instruction of exporting ATF_LOAD_ADDR.

Quoted 17 lines
---
  doc/board/nxp/imx8mn_evk.rst | 1 -
  1 file changed, 1 deletion(-)
doc/board/nxp/imx8mn_evk.rst +0 -1
index 711545af896a..c45bb7bac7a1 100644
@@ -42,7 +42,6 @@ Build U-Boot
 
     $ export CROSS_COMPILE=aarch64-poky-linux-
     $ make imx8mn_ddr4_evk_defconfig
-   $ export ATF_LOAD_ADDR=0x960000
     $ make
 
  Burn the flash.bin to MicroSD card offset 32KB:
#4 lore raw

PATCH 1/2 imx8mn_evk: Enable cache in SPL

In reply to Fabio Estevam
Quoted 6 lines

From: Fabio Estevam <[email protected]>
There is no reason for disabling I-cache and D-cache in SPL.
Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and CONFIG_SPL_SYS_DCACHE_OFF options.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Reviewed-by Peng Fan on v1 1/2
#5 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

Quoted 16 lines
---
  configs/imx8mn_evk_defconfig | 2 --
  1 file changed, 2 deletions(-)
configs/imx8mn_evk_defconfig +0 -2
index b2981d1e3692..e661b3ba7e55 100644
@@ -1,6 +1,4 @@
  CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
  CONFIG_ARCH_IMX8M=y
  CONFIG_SYS_TEXT_BASE=0x40200000
  CONFIG_SYS_MALLOC_LEN=0x2000000