Skip to contentSkip to conversation

imx8mn_ddr4_evk: Add USB Mass Storage support

PATCH Superseded Fabio Estevam 2 participants 3 messages Apr 21, 2022

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/2 imx8mn_ddr4_evk: Add USB Mass Storage support

From: Fabio Estevam <[email protected]>

Add USB Mass Storage support, which is a convenient way to flash the eMMC card, for example.

---
Changes since v1:
- None

 configs/imx8mn_ddr4_evk_defconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configs/imx8mn_ddr4_evk_defconfig +12 -0
index 917cdb5aa9d9..065f7392b706 100644
@@ -42,6 +42,8 @@ CONFIG_CMD_FUSE=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_REGULATOR=y
 CONFIG_CMD_EXT4_WRITE=y
@@ -82,4 +84,14 @@ CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_PSCI=y
 CONFIG_SYSRESET_WATCHDOG=y
 CONFIG_DM_THERMAL=y
+CONFIG_USB=y
+# CONFIG_SPL_DM_USB is not set
+CONFIG_USB_EHCI_HCD=y
+CONFIG_MXC_USB_OTG_HACTIVE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_USB_GADGET_VENDOR_NUM=0x0525
+CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
+CONFIG_CI_UDC=y
+CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_IMX_WATCHDOG=y
Signature · 1 line
2.25.1
author reviewer
#1 lore raw

PATCH v2 2/2 imx8mn/8mp: Allow booting via USB

From: Fabio Estevam <[email protected]>

When trying to boot via USB on i.MX8MN it is necessary to specify the U-Boot environment location, otherwise the boot process simply hangs.

Specify the environment location when booting from USB.

Tested on a imx8mn-evk.

---
Changes since v1:
- Handle the env selection for the USB_BOOT case (Michael).

 arch/arm/mach-imx/imx8m/soc.c | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/mach-imx/imx8m/soc.c +8 -0
index 7059d87e336b..34f8475bca46 100644
@@ -1536,6 +1536,14 @@ enum env_location arch_env_get_location(enum env_operation op, int prio)
 		return ENVL_UNKNOWN;
 
 	switch (dev) {
+	case USB_BOOT:
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_SPI_FLASH))
+			return ENVL_SPI_FLASH;
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_NAND))
+			return ENVL_NAND;
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_MMC))
+			return ENVL_MMC;
+		return ENVL_NOWHERE;
 	case QSPI_BOOT:
 	case SPI_NOR_BOOT:
 		if (IS_ENABLED(CONFIG_ENV_IS_IN_SPI_FLASH))
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v2 2/2] imx8mn/8mp: Allow booting via USB

Quoted 25 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When trying to boot via USB on i.MX8MN it is necessary to specify the U-Boot environment location, otherwise the boot process simply hangs.

Specify the environment location when booting from USB.

Tested on a imx8mn-evk.

---
Changes since v1:
- Handle the env selection for the USB_BOOT case (Michael).

  arch/arm/mach-imx/imx8m/soc.c | 8 ++++++++
  1 file changed, 8 insertions(+)
arch/arm/mach-imx/imx8m/soc.c +0 -0
index 7059d87e336b..34f8475bca46 100644
@@ -1536,6 +1536,14 @@ enum env_location arch_env_get_location(enum env_operation op, int prio)
  		return ENVL_UNKNOWN;

arch/arm/mach-imx/imx8m/soc.c enum env_location arch_env_get_location(enum env_operation op, int prio) · line 1546

Quoted 10 lines
arch/arm/mach-imx/imx8m/soc.c +8 -0
 
  	switch (dev) {
+	case USB_BOOT:
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_SPI_FLASH))
+			return ENVL_SPI_FLASH;
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_NAND))
+			return ENVL_NAND;
+		if (IS_ENABLED(CONFIG_ENV_IS_IN_MMC))
+			return ENVL_MMC;
+		return ENVL_NOWHERE;

Shouldn't this last entry also be

if (IS_ENABLED(CONFIG_ENV_IS_NOWHERE))

	return ENVL_NOWHERE;

?