Skip to contentSkip to conversation

arm64: dts: mt8192: Follow binding order for SCP registers

PATCH In review Nícolas F. R. A. Prado 4 participants 4 messages May 4, 2022 – May 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: mt8192: Follow binding order for SCP registers

The dt-binding for SCP documents the reg-names order as sram, cfg, l1tcm. Update the SCP node on the mt8192 devicetree to follow that order, which gets rid of a dtbs_check warning. This doesn't change any behavior since the SCP driver accesses the memory regions through the names anyway.

Fixes c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")

---

Changes in v2:
- Added missing Fixes tag

 arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/mediatek/mt8192.dtsi +3 -3
index 26dbe9ecc528..733aec2e7f77 100644
@@ -699,9 +699,9 @@ spi7: spi@1101e000 {
 		scp: scp@10500000 {
 			compatible = "mediatek,mt8192-scp";
 			reg = <0 0x10500000 0 0x100000>,
-			      <0 0x10700000 0 0x8000>,
-			      <0 0x10720000 0 0xe0000>;
-			reg-names = "sram", "l1tcm", "cfg";
+			      <0 0x10720000 0 0xe0000>,
+			      <0 0x10700000 0 0x8000>;
+			reg-names = "sram", "cfg", "l1tcm";
 			interrupts = <GIC_SPI 435 IRQ_TYPE_LEVEL_HIGH 0>;
 			clocks = <&infracfg CLK_INFRA_SCPSYS>;
 			clock-names = "main";
Signature · 1 line
2.36.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Nícolas F. R. A. Prado

The dt-binding for SCP documents the reg-names order as sram, cfg, l1tcm. Update the SCP node on the mt8192 devicetree to follow that order, which gets rid of a dtbs_check warning. This doesn't change any behavior since the SCP driver accesses the memory regions through the names anyway.

Fixes c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")
maintainer Reviewed-by on v2 1/1
#2 lore raw
In reply to Nícolas F. R. A. Prado

Il 04/05/22 23:45, Nícolas F. R. A. Prado ha scritto:

Quoted 8 lines

The dt-binding for SCP documents the reg-names order as sram, cfg, l1tcm. Update the SCP node on the mt8192 devicetree to follow that order, which gets rid of a dtbs_check warning. This doesn't change any behavior since the SCP driver accesses the memory regions through the names anyway.

Fixes c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")

Now, that's perfect! Thanks!

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer
#3 lore raw
In reply to Nícolas F. R. A. Prado
Quoted 9 lines · Nícolas F. R. A. Prado

The dt-binding for SCP documents the reg-names order as sram, cfg, l1tcm. Update the SCP node on the mt8192 devicetree to follow that order, which gets rid of a dtbs_check warning. This doesn't change any behavior since the SCP driver accesses the memory regions through the names anyway.

Fixes c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")

Applied thanks!

Quoted 15 lines

---

Changes in v2:
- Added missing Fixes tag

  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/mediatek/mt8192.dtsi +0 -0
index 26dbe9ecc528..733aec2e7f77 100644
@@ -699,9 +699,9 @@ spi7: spi@1101e000 {
  		scp: scp@10500000 {
  			compatible = "mediatek,mt8192-scp";

arch/arm64/boot/dts/mediatek/mt8192.dtsi spi7: spi@1101e000 { · line 707

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8192.dtsi +3 -3
  			reg = <0 0x10500000 0 0x100000>,
-			      <0 0x10700000 0 0x8000>,
-			      <0 0x10720000 0 0xe0000>;
-			reg-names = "sram", "l1tcm", "cfg";
+			      <0 0x10720000 0 0xe0000>,
+			      <0 0x10700000 0 0x8000>;
+			reg-names = "sram", "cfg", "l1tcm";
  			interrupts = <GIC_SPI 435 IRQ_TYPE_LEVEL_HIGH 0>;
  			clocks = <&infracfg CLK_INFRA_SCPSYS>;
  			clock-names = "main";

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek