ASoC: SOF: Introduce generic (in)firmware tracing infrastructure
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 2/8 ASoC: SOF: Rename dtrace_is_supported flag to fw_trace_is_supported
In reply to Peter UjfalusiRename the internal flag to not limit it's use for dma-trace, but to be used for generic firmware tracing functionality.
--- sound/soc/sof/core.c | 2 +- sound/soc/sof/intel/hda-dsp.c | 2 +- sound/soc/sof/sof-priv.h | 4 +++- sound/soc/sof/trace.c | 14 +++++++------- 4 files changed, 12 insertions(+), 10 deletions(-)
sound/soc/sof/core.c +1 -1
@@ -250,7 +250,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev) }if (sof_debug_check_flag (SOF_DBG_ENABLE_TRACE )) { - sdev->dtrace_is_supported = true; + sdev->fw_trace_is_supported = true;/* init DMA trace */ ret =snd_sof_init_trace (sdev);
sound/soc/sof/intel/hda-dsp.c +1 -1
@@ -432,7 +432,7 @@ static int hda_dsp_set_D0_state(struct snd_sof_dev *sdev,* when the DSP enters D0I3 while the system is in S0 * for debug purpose. */ -if (!sdev->dtrace_is_supported || +if (!sdev->fw_trace_is_supported || !hda_enable_trace_D0I3_S0 || sdev->system_suspend_target !=SOF_SUSPEND_NONE ) flags =HDA_PM_NO_DMA_TRACE ;
sound/soc/sof/sof-priv.h +3 -1
@@ -546,13 +546,15 @@ struct snd_sof_dev {int ipc_timeout;int boot_timeout; +/* firmwre tracing */ +bool fw_trace_is_supported;/* set with Kconfig or module parameter */ +/* DMA for Trace */ struct snd_dma_buffer dmatb;struct snd_dma_buffer dmatp;int dma_trace_pages;wait_queue_head_t trace_sleep;u32 host_offset; -bool dtrace_is_supported;/* set with Kconfig or module parameter */ bool dtrace_error;bool dtrace_draining;enum sof_dtrace_state dtrace_state;
sound/soc/sof/trace.c +7 -7
@@ -392,7 +392,7 @@ static int snd_sof_enable_trace(struct snd_sof_dev *sdev)struct sof_ipc_reply ipc_reply;int ret; -if (!sdev->dtrace_is_supported) +if (!sdev->fw_trace_is_supported)return 0 ;if (sdev->dtrace_state ==SOF_DTRACE_ENABLED || !sdev->dma_trace_pages)
@@ -459,9 +459,9 @@ int snd_sof_init_trace(struct snd_sof_dev *sdev)/* dtrace is only supported with SOF_IPC */ if (sdev->pdata->ipc_type !=SOF_IPC ) - sdev->dtrace_is_supported = false; + sdev->fw_trace_is_supported = false; -if (!sdev->dtrace_is_supported) +if (!sdev->fw_trace_is_supported)return 0 ;/* set false before start initialization */
@@ -521,7 +521,7 @@ EXPORT_SYMBOL(snd_sof_init_trace);int snd_sof_trace_update_pos (struct snd_sof_dev *sdev,struct sof_ipc_dma_trace_posn *posn) { -if (!sdev->dtrace_is_supported) +if (!sdev->fw_trace_is_supported)return 0 ; if (sdev->dtrace_state == SOF_DTRACE_ENABLED &&
@@ -541,7 +541,7 @@ int snd_sof_trace_update_pos(struct snd_sof_dev *sdev,/* an error has occurred within the DSP that prevents further trace */ void snd_sof_trace_notify_for_error (struct snd_sof_dev *sdev) { -if (!sdev->dtrace_is_supported) +if (!sdev->fw_trace_is_supported)return ;if (sdev->dtrace_state ==SOF_DTRACE_ENABLED ) {
@@ -559,7 +559,7 @@ static void snd_sof_release_trace(struct snd_sof_dev *sdev, bool only_stop)struct sof_ipc_reply ipc_reply;int ret; -if (!sdev->dtrace_is_supported || sdev->dtrace_state ==SOF_DTRACE_DISABLED ) +if (!sdev->fw_trace_is_supported || sdev->dtrace_state ==SOF_DTRACE_DISABLED )return ; ret =snd_sof_dma_trace_trigger (sdev,SNDRV_PCM_TRIGGER_STOP );
@@ -611,7 +611,7 @@ EXPORT_SYMBOL(snd_sof_trace_resume);void snd_sof_free_trace (struct snd_sof_dev *sdev) { -if (!sdev->dtrace_is_supported) +if (!sdev->fw_trace_is_supported)return ;/* release trace */
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 1/8 ASoC: SOF: Introduce IPC independent ops for firmware tracing support
In reply to Peter UjfalusiThe current (dma-)trace is only supported with IPC3, it is not available when IPC4 is used.
--- sound/soc/sof/sof-priv.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
sound/soc/sof/sof-priv.h +18 -0
@@ -357,6 +357,22 @@ struct snd_sof_ipc_msg {bool ipc_complete; }; +/** +* struct sof_ipc_fw_tracing_ops - IPC-specific firmware tracing ops +* @init: Function pointer for initialization of the tracing +* @free: Optional function pointer for freeing of the tracing +* @fw_crashed: Optional function pointer to notify the tracing of a firmware crash +* @suspend: Function pointer for system/runtime suspend +* @resume: Function pointer for system/runtime resume +*/ +struct sof_ipc_fw_tracing_ops { +int (*init)(struct snd_sof_dev *sdev); +void (*free)(struct snd_sof_dev *sdev); +void (*fw_crashed)(struct snd_sof_dev *sdev); +void (*suspend)(struct snd_sof_dev *sdev,pm_message_t pm_state); +int (*resume)(struct snd_sof_dev *sdev); +}; +/** * struct sof_ipc_pm_ops - IPC-specific PM ops * @ctx_save: Function pointer for context save
@@ -395,6 +411,7 @@ struct sof_ipc_pcm_ops;* @pm: Pointer to PM ops * @pcm: Pointer to PCM ops * @fw_loader: Pointer to Firmware Loader ops +* @fw_tracing: Pointer to Firmware tracing ops * * @tx_msg: Function pointer for sending a 'short' IPC message * @set_get_data: Function pointer for set/get data ('large' IPC message). This
@@ -415,6 +432,7 @@ struct sof_ipc_ops {const struct sof_ipc_pm_ops *pm;const struct sof_ipc_pcm_ops *pcm;const struct sof_ipc_fw_loader_ops *fw_loader; +const struct sof_ipc_fw_tracing_ops *fw_tracing;int (*tx_msg)(struct snd_sof_dev *sdev,void *msg_data,size_t msg_bytes,void *reply_data,size_t reply_bytes,bool no_pm);
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainercover ASoC: SOF: Introduce generic (in)firmware tracing infrastructure
Hi,
SOF is using dma-trace (or dtrace) as a firmware tracing method, which is only supported with IPC3 and it is not applicable for IPC4.
Currently the dtrace is 'open managed' regardless of IPC version (we do force disable it for IPC4, but the dtrace calls remain in place).
From the kernel point of view there are only few ops that needs to be exposed by the firmware tracing support and everything else is IPC private, should not be known by the core.
This series converts the current dma-trace as ipc3 specific firmware tracing sub-component and moves all private data out from generic code.
Regards,
Peter
---
Peter Ujfalusi (8):
ASoC: SOF: Introduce IPC independent ops for firmware tracing support
ASoC: SOF: Rename dtrace_is_supported flag to fw_trace_is_supported
ASoC: SOF: Clone the trace code to ipc3-dtrace as fw_tracing
implementation
ASoC: SOF: Switch to IPC generic firmware tracing
ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to
private
ASoC: SOF: Modify the host trace_init parameter list to include dmab
ASoC: SOF: Introduce opaque storage of private data for firmware
tracing
ASoC: SOF: ipc3-dtrace: Move dtrace related variables local from
sof_dev
sound/soc/sof/Makefile | 1 + sound/soc/sof/amd/acp-trace.c | 4 +- sound/soc/sof/amd/acp.h | 2 +- sound/soc/sof/core.c | 13 +- sound/soc/sof/debug.c | 2 +- sound/soc/sof/intel/hda-dsp.c | 2 +- sound/soc/sof/intel/hda-trace.c | 4 +- sound/soc/sof/intel/hda.h | 2 +- sound/soc/sof/ipc.c | 6 + sound/soc/sof/ipc3-dtrace.c | 649 ++++++++++++++++++++++++++++++++ sound/soc/sof/ipc3-priv.h | 38 ++ sound/soc/sof/ipc3.c | 3 +- sound/soc/sof/ops.c | 2 +- sound/soc/sof/ops.h | 26 -- sound/soc/sof/pm.c | 8 +- sound/soc/sof/sof-priv.h | 53 +-- sound/soc/sof/trace.c | 621 ++---------------------------- 17 files changed, 767 insertions(+), 669 deletions(-) create mode 100644 sound/soc/sof/ipc3-dtrace.c
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 4/8 ASoC: SOF: Switch to IPC generic firmware tracing
Introduce new, generic API for firmware tracing with sof_fw_trace_ prefix and switch to use it.
At the same time the old IPC3 code can be dropped from trace.c, which is now a generic wrapper for the firmware tracing ops.
--- sound/soc/sof/core.c | 11 +- sound/soc/sof/debug.c | 2 +- sound/soc/sof/ipc.c | 6 + sound/soc/sof/ipc3.c | 2 +- sound/soc/sof/ops.c | 2 +- sound/soc/sof/pm.c | 8 +- sound/soc/sof/sof-priv.h | 13 +- sound/soc/sof/trace.c | 615 ++------------------------------------- 8 files changed, 44 insertions(+), 615 deletions(-)
sound/soc/sof/core.c +5 -6
@@ -252,12 +252,11 @@ static int sof_probe_continue(struct snd_sof_dev *sdev)if (sof_debug_check_flag (SOF_DBG_ENABLE_TRACE )) { sdev->fw_trace_is_supported = true; -/* init DMA trace */ - ret =snd_sof_init_trace (sdev); +/* init firmware tracing */ + ret =sof_fw_trace_init (sdev);if (ret <0 ) {/* non fatal */ -dev_warn (sdev->dev, -"warning: failed to initialize trace %d\n" , +dev_warn (sdev->dev,"failed to initialize firmware tracing %d\n" , ret); } }else {
@@ -308,7 +307,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev) sof_machine_err:snd_sof_machine_unregister (sdev, plat_data); fw_trace_err: -snd_sof_free_trace (sdev); +sof_fw_trace_free (sdev); fw_run_err:snd_sof_fw_unload (sdev); fw_load_err:
@@ -447,7 +446,7 @@ int snd_sof_device_remove(struct device *dev)snd_sof_machine_unregister (sdev, pdata);if (sdev->fw_state >SOF_FW_BOOT_NOT_STARTED ) { -snd_sof_free_trace (sdev); +sof_fw_trace_free (sdev); ret =snd_sof_dsp_power_down_notify (sdev);if (ret <0 ) dev_warn(dev, "error: %d failed to prepare DSP for device removal",
sound/soc/sof/debug.c +1 -1
@@ -443,6 +443,6 @@ void snd_sof_handle_fw_exception(struct snd_sof_dev *sdev)snd_sof_ipc_dump (sdev);snd_sof_dsp_dbg_dump (sdev,"Firmware exception" ,SOF_DBG_DUMP_REGS |SOF_DBG_DUMP_MBOX ); -snd_sof_trace_notify_for_error (sdev); +sof_fw_trace_fw_crashed (sdev); }EXPORT_SYMBOL (snd_sof_handle_fw_exception);
sound/soc/sof/ipc.c +6 -0
@@ -184,6 +184,12 @@ struct snd_sof_ipc *snd_sof_ipc_init(struct snd_sof_dev *sdev)return NULL ; } +if (ops->fw_tracing && (!ops->fw_tracing->init || !ops->fw_tracing->suspend || + !ops->fw_tracing->resume)) { +dev_err (sdev->dev,"Missing firmware tracing ops\n" ); +return NULL ; + } +return ipc; }EXPORT_SYMBOL (snd_sof_ipc_init);
sound/soc/sof/ipc3.c +1 -1
@@ -946,7 +946,7 @@ static void ipc3_trace_message(struct snd_sof_dev *sdev, void *msg_buf)switch (msg_type) {case SOF_IPC_TRACE_DMA_POSITION : -snd_sof_trace_update_pos (sdev, msg_buf); +ipc3_dtrace_posn_update (sdev, msg_buf);break ;default :dev_err (sdev->dev,"unhandled trace message %#x\n" , msg_type);
sound/soc/sof/ops.c +1 -1
@@ -177,7 +177,7 @@ void snd_sof_dsp_panic(struct snd_sof_dev *sdev, u32 offset, bool non_recoverablsnd_sof_dsp_dbg_dump (sdev,"DSP panic!" ,SOF_DBG_DUMP_REGS |SOF_DBG_DUMP_MBOX );sof_set_fw_state (sdev,SOF_FW_CRASHED ); -snd_sof_trace_notify_for_error (sdev); +sof_fw_trace_fw_crashed (sdev); }else { snd_sof_dsp_dbg_dump(sdev, "DSP panic (recovery will be attempted)",
sound/soc/sof/pm.c +4 -4
@@ -107,7 +107,7 @@ static int sof_resume(struct device *dev, bool runtime_resume)*/ if (!runtime_resume &&sof_ops (sdev)->set_power_state && old_state ==SOF_DSP_PM_D0 ) { - ret =snd_sof_trace_resume (sdev); + ret =sof_fw_trace_resume (sdev);if (ret <0 )/* non fatal */ dev_warn(sdev->dev,
@@ -143,7 +143,7 @@ static int sof_resume(struct device *dev, bool runtime_resume) }/* resume DMA trace */ - ret =snd_sof_trace_resume (sdev); + ret =sof_fw_trace_resume (sdev);if (ret <0 ) {/* non fatal */ dev_warn(sdev->dev,
@@ -208,7 +208,7 @@ static int sof_suspend(struct device *dev, bool runtime_suspend)/* Skip to platform-specific suspend if DSP is entering D0 */ if (target_state ==SOF_DSP_PM_D0 ) { -snd_sof_trace_suspend (sdev, pm_state); +sof_fw_trace_suspend (sdev, pm_state);/* Notify clients not managed by pm framework about core suspend */ sof_suspend_clients (sdev, pm_state); goto suspend;
@@ -218,7 +218,7 @@ static int sof_suspend(struct device *dev, bool runtime_suspend) tplg_ops->tear_down_all_pipelines (sdev, false);/* suspend DMA trace */ -snd_sof_trace_suspend (sdev, pm_state); +sof_fw_trace_suspend (sdev, pm_state);/* Notify clients not managed by pm framework about core suspend */ sof_suspend_clients (sdev, pm_state);
sound/soc/sof/sof-priv.h +6 -7
@@ -660,27 +660,26 @@ static inline void snd_sof_ipc_process_reply(struct snd_sof_dev *sdev, u32 msg_i/* * Trace/debug */ -int snd_sof_init_trace (struct snd_sof_dev *sdev); -void snd_sof_free_trace (struct snd_sof_dev *sdev);int snd_sof_dbg_init (struct snd_sof_dev *sdev);void snd_sof_free_debug (struct snd_sof_dev *sdev);int snd_sof_debugfs_buf_item (struct snd_sof_dev *sdev,void *base,size_t size,const char *name,mode_t mode); -int snd_sof_trace_update_pos (struct snd_sof_dev *sdev, -struct sof_ipc_dma_trace_posn *posn); -void snd_sof_trace_notify_for_error (struct snd_sof_dev *sdev);void sof_print_oops_and_stack (struct snd_sof_dev *sdev,const char *level,u32 panic_code,u32 tracep_code,void *oops,struct sof_ipc_panic_info *panic_info,void *stack,size_t stack_words); -void snd_sof_trace_suspend (struct snd_sof_dev *sdev,pm_message_t pm_state); -int snd_sof_trace_resume (struct snd_sof_dev *sdev);void snd_sof_handle_fw_exception (struct snd_sof_dev *sdev);int snd_sof_dbg_memory_info_init (struct snd_sof_dev *sdev);int snd_sof_debugfs_add_region_item_iomem (struct snd_sof_dev *sdev,enum snd_sof_fw_blk_type blk_type,u32 offset,size_t size,const char *name,enum sof_debugfs_access_type access_type); +/* Firmware tracing */ +int sof_fw_trace_init (struct snd_sof_dev *sdev); +void sof_fw_trace_free (struct snd_sof_dev *sdev); +void sof_fw_trace_fw_crashed (struct snd_sof_dev *sdev); +void sof_fw_trace_suspend (struct snd_sof_dev *sdev,pm_message_t pm_state); +int sof_fw_trace_resume (struct snd_sof_dev *sdev);/* * DSP Architectures.
sound/soc/sof/trace.c +20 -595
646 lines not on this page · raw message
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 5/8 ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to private
In reply to Peter UjfalusiMove the snd_sof_dma_trace_* ops wrappers from ops.h to ipc3-priv.h since they are not used outside of IPC3 code.
While moving, rename them to sof_dtrace_host_*
--- sound/soc/sof/ipc3-dtrace.c | 10 +++++----- sound/soc/sof/ipc3-priv.h | 32 ++++++++++++++++++++++++++++++++ sound/soc/sof/ops.h | 26 -------------------------- 3 files changed, 37 insertions(+), 31 deletions(-)
sound/soc/sof/ipc3-dtrace.c +5 -5
@@ -412,7 +412,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev) sdev->host_offset =0 ; sdev->dtrace_draining = false; - ret =snd_sof_dma_trace_init (sdev, ¶ms); + ret =sof_dtrace_host_init (sdev, ¶ms);if (ret <0 ) {dev_err (sdev->dev,"Host dtrace init failed: %d\n" , ret);return ret;
@@ -427,7 +427,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev) } start: - ret =snd_sof_dma_trace_trigger (sdev,SNDRV_PCM_TRIGGER_START ); + ret =sof_dtrace_host_trigger (sdev,SNDRV_PCM_TRIGGER_START );if (ret <0 ) {dev_err (sdev->dev,"Host dtrace trigger start failed: %d\n" , ret); goto trace_release;
@@ -438,7 +438,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)return 0 ; trace_release: -snd_sof_dma_trace_release (sdev); +sof_dtrace_host_release (sdev);return ret; }
@@ -541,7 +541,7 @@ static void ipc3_dtrace_release(struct snd_sof_dev *sdev, bool only_stop)if (!sdev->fw_trace_is_supported || sdev->dtrace_state ==SOF_DTRACE_DISABLED )return ; - ret =snd_sof_dma_trace_trigger (sdev,SNDRV_PCM_TRIGGER_STOP ); + ret =sof_dtrace_host_trigger (sdev,SNDRV_PCM_TRIGGER_STOP );if (ret <0 )dev_err (sdev->dev,"Host dtrace trigger stop failed: %d\n" , ret); sdev->dtrace_state =SOF_DTRACE_STOPPED ;
@@ -563,7 +563,7 @@ static void ipc3_dtrace_release(struct snd_sof_dev *sdev, bool only_stop)if (only_stop) goto out; - ret =snd_sof_dma_trace_release (sdev); + ret =sof_dtrace_host_release (sdev);if (ret <0 )dev_err (sdev->dev,"Host dtrace release failed %d\n" , ret);
sound/soc/sof/ipc3-priv.h +32 -0
@@ -29,4 +29,36 @@ int sof_ipc3_validate_fw_version(struct snd_sof_dev *sdev);int ipc3_dtrace_posn_update (struct snd_sof_dev *sdev,struct sof_ipc_dma_trace_posn *posn); +/* dtrace platform callback wrappers */ +static inline int sof_dtrace_host_init (struct snd_sof_dev *sdev, +struct sof_ipc_dma_trace_params_ext *dtrace_params) +{ +struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops; + +if (dsp_ops->trace_init) +return dsp_ops->trace_init (sdev, dtrace_params); + +return 0 ; +} + +static inline int sof_dtrace_host_release (struct snd_sof_dev *sdev) +{ +struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops; + +if (dsp_ops->trace_release) +return dsp_ops->trace_release (sdev); + +return 0 ; +} + +static inline int sof_dtrace_host_trigger (struct snd_sof_dev *sdev,int cmd) +{ +struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops; + +if (dsp_ops->trace_trigger) +return dsp_ops->trace_trigger (sdev, cmd); + +return 0 ; +} +#endif
sound/soc/sof/ops.h +0 -26
@@ -375,32 +375,6 @@ static inline int snd_sof_dsp_send_msg(struct snd_sof_dev *sdev,return sof_ops (sdev)->send_msg (sdev, msg); } -/* host DMA trace */ -static inline int snd_sof_dma_trace_init (struct snd_sof_dev *sdev, -struct sof_ipc_dma_trace_params_ext *dtrace_params) -{ -if (sof_ops (sdev)->trace_init) -return sof_ops (sdev)->trace_init (sdev, dtrace_params); - -return 0 ; -} - -static inline int snd_sof_dma_trace_release (struct snd_sof_dev *sdev) -{ -if (sof_ops (sdev)->trace_release) -return sof_ops (sdev)->trace_release (sdev); - -return 0 ; -} - -static inline int snd_sof_dma_trace_trigger (struct snd_sof_dev *sdev,int cmd) -{ -if (sof_ops (sdev)->trace_trigger) -return sof_ops (sdev)->trace_trigger (sdev, cmd); - -return 0 ; -} -/* host PCM ops */ static inline int snd_sof_pcm_platform_open(struct snd_sof_dev *sdev,
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 3/8 ASoC: SOF: Clone the trace code to ipc3-dtrace as fw_tracing implementation
In reply to Peter UjfalusiThe existing trace.c file is implementing the IPC3 dma-trace support.
Clone the existing code with prefix fixes as ipc3 fw_tracing implementation to be used when the core is converted to use generic ops for firmware tracing.
Drop the dual licensing of the content as the implementation is based on debugfs.
--- sound/soc/sof/Makefile | 1 + sound/soc/sof/ipc3-dtrace.c | 605 ++++++++++++++++++++++++++++++++++++ sound/soc/sof/ipc3-priv.h | 5 + sound/soc/sof/ipc3.c | 1 + 4 files changed, 612 insertions(+) create mode 100644 sound/soc/sof/ipc3-dtrace.c
sound/soc/sof/Makefile +1 -0
@@ -3,6 +3,7 @@ snd-sof-objs := core.o ops.o loader.o ipc.o pcm.o pm.o debug.o topology.o\ control.o trace.o iomem-utils.o sof-audio.o stream-ipc.o\ ipc3-topology.o ipc3-control.o ipc3.o ipc3-pcm.o ipc3-loader.o\ + ipc3-dtrace.o\ ipc4.o ipc4-loader.o ifneq ($(CONFIG_SND_SOC_SOF_CLIENT),) snd-sof-objs += sof-client.o
sound/soc/sof/ipc3-dtrace.c new file +605 -0
605 lines not on this page · raw message
sound/soc/sof/ipc3-priv.h +5 -0
@@ -16,6 +16,7 @@ extern const struct sof_ipc_pcm_ops ipc3_pcm_ops;extern const struct sof_ipc_tplg_ops ipc3_tplg_ops;extern const struct sof_ipc_tplg_control_ops tplg_ipc3_control_ops;extern const struct sof_ipc_fw_loader_ops ipc3_loader_ops; +extern const struct sof_ipc_fw_tracing_ops ipc3_dtrace_ops;/* helpers for fw_ready and ext_manifest parsing */ int sof_ipc3_get_ext_windows(struct snd_sof_dev *sdev,
@@ -24,4 +25,8 @@ int sof_ipc3_get_cc_info(struct snd_sof_dev *sdev, const struct sof_ipc_ext_data_hdr *ext_hdr);int sof_ipc3_validate_fw_version (struct snd_sof_dev *sdev); +/* dtrace position update */ +int ipc3_dtrace_posn_update (struct snd_sof_dev *sdev, +struct sof_ipc_dma_trace_posn *posn); +#endif
sound/soc/sof/ipc3.c +1 -0
@@ -1070,6 +1070,7 @@ const struct sof_ipc_ops ipc3_ops = { .pm = &ipc3_pm_ops, .pcm = &ipc3_pcm_ops, .fw_loader = &ipc3_loader_ops, + .fw_tracing = &ipc3_dtrace_ops, .tx_msg = sof_ipc3_tx_msg, .rx_msg = sof_ipc3_rx_msg,
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 6/8 ASoC: SOF: Modify the host trace_init parameter list to include dmab
In reply to Peter UjfalusiStop host code (AMD, Intel) to access sdev->dmatb directly. Modify the trace_init prototype to include the pointer to a struct snd_dma_buffer. The ipc3-dtrace passes for now the pointer to sdev->dmatb, but the aim is to move all tracing related runtime information local to a trace implementation.
--- sound/soc/sof/amd/acp-trace.c | 4 ++-- sound/soc/sof/amd/acp.h | 2 +- sound/soc/sof/intel/hda-trace.c | 4 ++-- sound/soc/sof/intel/hda.h | 2 +- sound/soc/sof/ipc3-dtrace.c | 2 +- sound/soc/sof/ipc3-priv.h | 3 ++- sound/soc/sof/sof-priv.h | 3 ++- 7 files changed, 11 insertions(+), 9 deletions(-)
sound/soc/sof/amd/acp-trace.c +2 -2
@@ -34,7 +34,7 @@ int acp_sof_trace_release(struct snd_sof_dev *sdev) }EXPORT_SYMBOL_NS (acp_sof_trace_release,SND_SOC_SOF_AMD_COMMON ); -int acp_sof_trace_init (struct snd_sof_dev *sdev, +int acp_sof_trace_init (struct snd_sof_dev *sdev,struct snd_dma_buffer *dmab,struct sof_ipc_dma_trace_params_ext *dtrace_params) {struct acp_dsp_stream *stream;
@@ -46,7 +46,7 @@ int acp_sof_trace_init(struct snd_sof_dev *sdev,if (!stream)return -ENODEV ; - stream->dmab = &sdev->dmatb; + stream->dmab = dmab; stream->num_pages =NUM_PAGES ; ret =acp_dsp_stream_config (sdev, stream);
sound/soc/sof/amd/acp.h +1 -1
@@ -212,7 +212,7 @@ extern struct snd_sof_dsp_ops sof_renoir_ops;int snd_amd_acp_find_config (struct pci_dev *pci);/* Trace */ -int acp_sof_trace_init (struct snd_sof_dev *sdev, +int acp_sof_trace_init (struct snd_sof_dev *sdev,struct snd_dma_buffer *dmab,struct sof_ipc_dma_trace_params_ext *dtrace_params);int acp_sof_trace_release (struct snd_sof_dev *sdev);
sound/soc/sof/intel/hda-trace.c +2 -2
@@ -36,7 +36,7 @@ static int hda_dsp_trace_prepare(struct snd_sof_dev *sdev, struct snd_dma_bufferreturn ret; } -int hda_dsp_trace_init (struct snd_sof_dev *sdev, +int hda_dsp_trace_init (struct snd_sof_dev *sdev,struct snd_dma_buffer *dmab,struct sof_ipc_dma_trace_params_ext *dtrace_params) {struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata;
@@ -57,7 +57,7 @@ int hda_dsp_trace_init(struct snd_sof_dev *sdev,* initialize capture stream, set BDL address and return corresponding * stream tag which will be sent to the firmware by IPC message. */ - ret =hda_dsp_trace_prepare (sdev, &sdev->dmatb); + ret =hda_dsp_trace_prepare (sdev, dmab);if (ret <0 ) {dev_err (sdev->dev,"error: hdac trace init failed: %d\n" , ret); hda_dsp_stream_put(sdev, SNDRV_PCM_STREAM_CAPTURE,
sound/soc/sof/intel/hda.h +1 -1
@@ -658,7 +658,7 @@ static inline int hda_codec_i915_exit(struct snd_sof_dev *sdev) { return 0; }/* * Trace Control. */ -int hda_dsp_trace_init (struct snd_sof_dev *sdev, +int hda_dsp_trace_init (struct snd_sof_dev *sdev,struct snd_dma_buffer *dmab,struct sof_ipc_dma_trace_params_ext *dtrace_params);int hda_dsp_trace_release (struct snd_sof_dev *sdev);int hda_dsp_trace_trigger (struct snd_sof_dev *sdev,int cmd);
sound/soc/sof/ipc3-dtrace.c +1 -1
@@ -412,7 +412,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev) sdev->host_offset =0 ; sdev->dtrace_draining = false; - ret =sof_dtrace_host_init (sdev, ¶ms); + ret =sof_dtrace_host_init (sdev, &sdev->dmatb, ¶ms);if (ret <0 ) {dev_err (sdev->dev,"Host dtrace init failed: %d\n" , ret);return ret;
sound/soc/sof/ipc3-priv.h +2 -1
@@ -31,12 +31,13 @@ int ipc3_dtrace_posn_update(struct snd_sof_dev *sdev,/* dtrace platform callback wrappers */ static inline int sof_dtrace_host_init (struct snd_sof_dev *sdev, +struct snd_dma_buffer *dmatb,struct sof_ipc_dma_trace_params_ext *dtrace_params) {struct snd_sof_dsp_ops *dsp_ops = sdev->pdata->desc->ops;if (dsp_ops->trace_init) -return dsp_ops->trace_init (sdev, dtrace_params); +return dsp_ops->trace_init (sdev, dmatb, dtrace_params);return 0 ; }
sound/soc/sof/sof-priv.h +2 -1
@@ -254,8 +254,9 @@ struct snd_sof_dsp_ops { size_t size, const char *name, enum sof_debugfs_access_type access_type); /* optional */ -/* host DMA trace initialization */ +/* host DMA trace (IPC3) */ int (*trace_init)(struct snd_sof_dev *sdev, +struct snd_dma_buffer *dmatb,struct sof_ipc_dma_trace_params_ext *dtrace_params);/* optional */ int (*trace_release)(struct snd_sof_dev *sdev);/* optional */ int (*trace_trigger)(struct snd_sof_dev *sdev,
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 7/8 ASoC: SOF: Introduce opaque storage of private data for firmware tracing
In reply to Peter UjfalusiFirmware tracing implementations can allocate and store their privately used data behind the fw_trace_pdata pointer instead of adding more members to struct snd_sof_dev.
--- sound/soc/sof/sof-priv.h | 1 + 1 file changed, 1 insertion(+)
sound/soc/sof/sof-priv.h +1 -0
@@ -549,6 +549,7 @@ struct snd_sof_dev {/* firmwre tracing */ bool fw_trace_is_supported;/* set with Kconfig or module parameter */ +void *fw_trace_data;/* private data used by firmware tracing implementation */ /* DMA for Trace */ struct snd_dma_buffer dmatb;
Signature · 1 line
2.36.1
Peter Ujfalusi
maintainerPATCH 8/8 ASoC: SOF: ipc3-dtrace: Move dtrace related variables local from sof_dev
In reply to Peter UjfalusiThe variables and structs for DMA trace can be moved local to ipc3-dtrace.c and the storage can be allocated dynamically, stored behind the fw_trace_data pointer.
--- sound/soc/sof/ipc3-dtrace.c | 142 +++++++++++++++++++++++------------- sound/soc/sof/sof-priv.h | 16 ---- 2 files changed, 93 insertions(+), 65 deletions(-)
sound/soc/sof/ipc3-dtrace.c +93 -49
@@ -15,6 +15,23 @@#define TRACE_FILTER_ELEMENTS_PER_ENTRY 4#define TRACE_FILTER_MAX_CONFIG_STRING_LENGTH 1024 +enum sof_dtrace_state { +SOF_DTRACE_DISABLED , +SOF_DTRACE_STOPPED , +SOF_DTRACE_ENABLED , +}; + +struct sof_dtrace_priv { +struct snd_dma_buffer dmatb; +struct snd_dma_buffer dmatp; +int dma_trace_pages; +wait_queue_head_t trace_sleep; +u32 host_offset; +bool dtrace_error; +bool dtrace_draining; +enum sof_dtrace_state dtrace_state; +}; +static int trace_filter_append_elem (struct snd_sof_dev *sdev,u32 key,u32 value,struct sof_ipc_trace_filter_elem *elem_list,int capacity,int *counter)
@@ -228,7 +245,8 @@ static int debugfs_create_trace_filter(struct snd_sof_dev *sdev)static size_t sof_dtrace_avail (struct snd_sof_dev *sdev,loff_t pos,size_t buffer_size) { -loff_t host_offset =READ_ONCE (sdev->host_offset); +struct sof_dtrace_priv *priv = sdev->fw_trace_data; +loff_t host_offset =READ_ONCE (priv->host_offset);/* * If host offset is less than local pos, it means write pointer of
@@ -248,32 +266,33 @@ static size_t sof_dtrace_avail(struct snd_sof_dev *sdev,static size_t sof_wait_dtrace_avail (struct snd_sof_dev *sdev,loff_t pos,size_t buffer_size) { -wait_queue_entry_t wait;size_t ret =sof_dtrace_avail (sdev, pos, buffer_size); +struct sof_dtrace_priv *priv = sdev->fw_trace_data; +wait_queue_entry_t wait;/* data immediately available */ if (ret)return ret; -if (sdev->dtrace_state !=SOF_DTRACE_ENABLED && sdev->dtrace_draining) { +if (priv->dtrace_state !=SOF_DTRACE_ENABLED && priv->dtrace_draining) {/* * tracing has ended and all traces have been * read by client, return EOF */ - sdev->dtrace_draining = false; + priv->dtrace_draining = false;return 0 ; }/* wait for available trace data from FW */ init_waitqueue_entry (&wait, current);set_current_state (TASK_INTERRUPTIBLE ); -add_wait_queue (&sdev->trace_sleep, &wait); +add_wait_queue (&priv->trace_sleep, &wait);if (!signal_pending (current)) {/* set timeout to max value, no error code */ schedule_timeout (MAX_SCHEDULE_TIMEOUT ); } -remove_wait_queue (&sdev->trace_sleep, &wait); +remove_wait_queue (&priv->trace_sleep, &wait);return sof_dtrace_avail (sdev, pos, buffer_size); }
@@ -283,13 +302,14 @@ static ssize_t dfsentry_dtrace_read(struct file *file, char __user *buffer, {struct snd_sof_dfsentry *dfse = file->private_data;struct snd_sof_dev *sdev = dfse->sdev; +struct sof_dtrace_priv *priv = sdev->fw_trace_data;unsigned long rem;loff_t lpos = *ppos;size_t avail, buffer_size = dfse->size;u64 lpos_64;/* make sure we know about any failures on the DSP side */ - sdev->dtrace_error = false; + priv->dtrace_error = false;/* check pos and count */ if (lpos <0 )
@@ -303,7 +323,7 @@ static ssize_t dfsentry_dtrace_read(struct file *file, char __user *buffer,/* get available count based on current host offset */ avail =sof_wait_dtrace_avail (sdev, lpos, buffer_size); -if (sdev->dtrace_error) { +if (priv->dtrace_error) {dev_err (sdev->dev,"trace IO error\n" );return -EIO ; }
@@ -318,7 +338,7 @@ static ssize_t dfsentry_dtrace_read(struct file *file, char __user *buffer,* Note: snd_dma_buffer_sync() is called for normal audio playback and * capture streams also. */ -snd_dma_buffer_sync (&sdev->dmatb,SNDRV_DMA_SYNC_CPU ); +snd_dma_buffer_sync (&priv->dmatb,SNDRV_DMA_SYNC_CPU );/* copy available trace data to debugfs */ rem =copy_to_user (buffer, ((u8 *)(dfse->buf) + lpos), count);if (rem)
@@ -334,10 +354,11 @@ static int dfsentry_dtrace_release(struct inode *inode, struct file *file) {struct snd_sof_dfsentry *dfse = inode->i_private;struct snd_sof_dev *sdev = dfse->sdev; +struct sof_dtrace_priv *priv = sdev->fw_trace_data;/* avoid duplicate traces at next open */ -if (sdev->dtrace_state !=SOF_DTRACE_ENABLED ) - sdev->host_offset =0 ; +if (priv->dtrace_state !=SOF_DTRACE_ENABLED ) + priv->host_offset =0 ;return 0 ; }
@@ -351,12 +372,15 @@ static const struct file_operations sof_dfs_dtrace_fops = {static int debugfs_create_dtrace (struct snd_sof_dev *sdev) { +struct sof_dtrace_priv *priv;struct snd_sof_dfsentry *dfse;int ret;if (!sdev)return -EINVAL ; + priv = sdev->fw_trace_data; + ret =debugfs_create_trace_filter (sdev);if (ret <0 )dev_warn (sdev->dev,"failed to create filter debugfs file: %d" , ret);
@@ -366,8 +390,8 @@ static int debugfs_create_dtrace(struct snd_sof_dev *sdev)return -ENOMEM ; dfse->type =SOF_DFSENTRY_TYPE_BUF ; - dfse->buf = sdev->dmatb.area; - dfse->size = sdev->dmatb.bytes; + dfse->buf = priv->dmatb.area; + dfse->size = priv->dmatb.bytes; dfse->sdev = sdev; debugfs_create_file("trace", 0444, sdev->debugfs_root, dfse,
@@ -378,6 +402,7 @@ static int debugfs_create_dtrace(struct snd_sof_dev *sdev)static int ipc3_dtrace_enable (struct snd_sof_dev *sdev) { +struct sof_dtrace_priv *priv = sdev->fw_trace_data;struct sof_ipc_fw_ready *ready = &sdev->fw_ready;struct sof_ipc_fw_version *v = &ready->version;struct sof_ipc_dma_trace_params_ext params;
@@ -387,10 +412,10 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)if (!sdev->fw_trace_is_supported)return 0 ; -if (sdev->dtrace_state ==SOF_DTRACE_ENABLED || !sdev->dma_trace_pages) +if (priv->dtrace_state ==SOF_DTRACE_ENABLED || !priv->dma_trace_pages)return -EINVAL ; -if (sdev->dtrace_state ==SOF_DTRACE_STOPPED ) +if (priv->dtrace_state ==SOF_DTRACE_STOPPED ) goto start;/* set IPC parameters */
@@ -404,15 +429,15 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev) params.hdr.size =sizeof (struct sof_ipc_dma_trace_params ); params.hdr.cmd |=SOF_IPC_TRACE_DMA_PARAMS ; } - params.buffer.phy_addr = sdev->dmatp.addr; - params.buffer.size = sdev->dmatb.bytes; - params.buffer.pages = sdev->dma_trace_pages; + params.buffer.phy_addr = priv->dmatp.addr; + params.buffer.size = priv->dmatb.bytes; + params.buffer.pages = priv->dma_trace_pages; params.stream_tag =0 ; - sdev->host_offset =0 ; - sdev->dtrace_draining = false; + priv->host_offset =0 ; + priv->dtrace_draining = false; - ret =sof_dtrace_host_init (sdev, &sdev->dmatb, ¶ms); + ret =sof_dtrace_host_init (sdev, &priv->dmatb, ¶ms);if (ret <0 ) {dev_err (sdev->dev,"Host dtrace init failed: %d\n" , ret);return ret;
@@ -433,7 +458,7 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev) goto trace_release; } - sdev->dtrace_state =SOF_DTRACE_ENABLED ; + priv->dtrace_state =SOF_DTRACE_ENABLED ;return 0 ;
@@ -444,18 +469,30 @@ static int ipc3_dtrace_enable(struct snd_sof_dev *sdev)static int ipc3_dtrace_init (struct snd_sof_dev *sdev) { +struct sof_dtrace_priv *priv;int ret;/* dtrace is only supported with SOF_IPC */ if (sdev->pdata->ipc_type !=SOF_IPC )return -EOPNOTSUPP ; +if (sdev->fw_trace_data) { +dev_err (sdev->dev,"fw_trace_data has been already allocated\n" ); +return -EBUSY ; + } + + priv =devm_kzalloc (sdev->dev,sizeof (*priv),GFP_KERNEL ); +if (!priv) +return -ENOMEM ; + + sdev->fw_trace_data = priv; +/* set false before start initialization */ - sdev->dtrace_state =SOF_DTRACE_DISABLED ; + priv->dtrace_state =SOF_DTRACE_DISABLED ;/* allocate trace page table buffer */ ret =snd_dma_alloc_pages (SNDRV_DMA_TYPE_DEV , sdev->dev, -PAGE_SIZE , &sdev->dmatp); +PAGE_SIZE , &priv->dmatp);if (ret <0 ) {dev_err (sdev->dev,"can't alloc page table for trace %d\n" , ret);return ret;
@@ -464,21 +501,21 @@ static int ipc3_dtrace_init(struct snd_sof_dev *sdev)/* allocate trace data buffer */ ret =snd_dma_alloc_dir_pages (SNDRV_DMA_TYPE_DEV_SG , sdev->dev,DMA_FROM_DEVICE ,DMA_BUF_SIZE_FOR_TRACE , - &sdev->dmatb); + &priv->dmatb);if (ret <0 ) {dev_err (sdev->dev,"can't alloc buffer for trace %d\n" , ret); goto page_err; }/* create compressed page table for audio firmware */ - ret =snd_sof_create_page_table (sdev->dev, &sdev->dmatb, - sdev->dmatp.area, sdev->dmatb.bytes); + ret =snd_sof_create_page_table (sdev->dev, &priv->dmatb, + priv->dmatp.area, priv->dmatb.bytes);if (ret <0 ) goto table_err; - sdev->dma_trace_pages = ret; + priv->dma_trace_pages = ret;dev_dbg (sdev->dev,"%s: dma_trace_pages: %d\n" , __func__, - sdev->dma_trace_pages); + priv->dma_trace_pages);if (sdev->first_boot) { ret =debugfs_create_dtrace (sdev);
@@ -486,7 +523,7 @@ static int ipc3_dtrace_init(struct snd_sof_dev *sdev) goto table_err; } -init_waitqueue_head (&sdev->trace_sleep); +init_waitqueue_head (&priv->trace_sleep); ret =ipc3_dtrace_enable (sdev);if (ret <0 )
@@ -494,23 +531,25 @@ static int ipc3_dtrace_init(struct snd_sof_dev *sdev)return 0 ; table_err: - sdev->dma_trace_pages =0 ; -snd_dma_free_pages (&sdev->dmatb); + priv->dma_trace_pages =0 ; +snd_dma_free_pages (&priv->dmatb); page_err: -snd_dma_free_pages (&sdev->dmatp); +snd_dma_free_pages (&priv->dmatp);return ret; }int ipc3_dtrace_posn_update (struct snd_sof_dev *sdev,struct sof_ipc_dma_trace_posn *posn) { +struct sof_dtrace_priv *priv = sdev->fw_trace_data; +if (!sdev->fw_trace_is_supported)return 0 ; -if (sdev->dtrace_state ==SOF_DTRACE_ENABLED && - sdev->host_offset != posn->host_offset) { - sdev->host_offset = posn->host_offset; -wake_up (&sdev->trace_sleep); +if (priv->dtrace_state ==SOF_DTRACE_ENABLED && + priv->host_offset != posn->host_offset) { + priv->host_offset = posn->host_offset; +wake_up (&priv->trace_sleep); }if (posn->overflow !=0 )
@@ -524,27 +563,30 @@ int ipc3_dtrace_posn_update(struct snd_sof_dev *sdev,/* an error has occurred within the DSP that prevents further trace */ static void ipc3_dtrace_fw_crashed (struct snd_sof_dev *sdev) { -if (sdev->dtrace_state ==SOF_DTRACE_ENABLED ) { - sdev->dtrace_error = true; -wake_up (&sdev->trace_sleep); +struct sof_dtrace_priv *priv = sdev->fw_trace_data; + +if (priv->dtrace_state ==SOF_DTRACE_ENABLED ) { + priv->dtrace_error = true; +wake_up (&priv->trace_sleep); } }static void ipc3_dtrace_release (struct snd_sof_dev *sdev,bool only_stop) { +struct sof_dtrace_priv *priv = sdev->fw_trace_data;struct sof_ipc_fw_ready *ready = &sdev->fw_ready;struct sof_ipc_fw_version *v = &ready->version;struct sof_ipc_cmd_hdr hdr;struct sof_ipc_reply ipc_reply;int ret; -if (!sdev->fw_trace_is_supported || sdev->dtrace_state ==SOF_DTRACE_DISABLED ) +if (!sdev->fw_trace_is_supported || priv->dtrace_state ==SOF_DTRACE_DISABLED )return ; ret =sof_dtrace_host_trigger (sdev,SNDRV_PCM_TRIGGER_STOP );if (ret <0 )dev_err (sdev->dev,"Host dtrace trigger stop failed: %d\n" , ret); - sdev->dtrace_state =SOF_DTRACE_STOPPED ; + priv->dtrace_state =SOF_DTRACE_STOPPED ;/* * stop and free trace DMA in the DSP. TRACE_DMA_FREE is only supported from
@@ -567,11 +609,11 @@ static void ipc3_dtrace_release(struct snd_sof_dev *sdev, bool only_stop)if (ret <0 )dev_err (sdev->dev,"Host dtrace release failed %d\n" , ret); - sdev->dtrace_state =SOF_DTRACE_DISABLED ; + priv->dtrace_state =SOF_DTRACE_DISABLED ; out: - sdev->dtrace_draining = true; -wake_up (&sdev->trace_sleep); + priv->dtrace_draining = true; +wake_up (&priv->trace_sleep); }static void ipc3_dtrace_suspend (struct snd_sof_dev *sdev,pm_message_t pm_state)
@@ -586,13 +628,15 @@ static int ipc3_dtrace_resume(struct snd_sof_dev *sdev)static void ipc3_dtrace_free (struct snd_sof_dev *sdev) { +struct sof_dtrace_priv *priv = sdev->fw_trace_data; +/* release trace */ ipc3_dtrace_release (sdev, false); -if (sdev->dma_trace_pages) { -snd_dma_free_pages (&sdev->dmatb); -snd_dma_free_pages (&sdev->dmatp); - sdev->dma_trace_pages =0 ; +if (priv->dma_trace_pages) { +snd_dma_free_pages (&priv->dmatb); +snd_dma_free_pages (&priv->dmatp); + priv->dma_trace_pages =0 ; } }
sound/soc/sof/sof-priv.h +0 -16
@@ -461,12 +461,6 @@ struct snd_sof_ipc {const struct sof_ipc_ops *ops; }; -enum sof_dtrace_state { -SOF_DTRACE_DISABLED , -SOF_DTRACE_STOPPED , -SOF_DTRACE_ENABLED , -}; -/* * SOF Device Level. */
@@ -551,16 +545,6 @@ struct snd_sof_dev {bool fw_trace_is_supported;/* set with Kconfig or module parameter */ void *fw_trace_data;/* private data used by firmware tracing implementation */ -/* DMA for Trace */ -struct snd_dma_buffer dmatb; -struct snd_dma_buffer dmatp; -int dma_trace_pages; -wait_queue_head_t trace_sleep; -u32 host_offset; -bool dtrace_error; -bool dtrace_draining; -enum sof_dtrace_state dtrace_state; -bool msi_enabled;/* DSP core context */
Signature · 1 line
2.36.1
Mark Brown
maintainerQuoted 11 lines · Peter Ujfalusi
SOF is using dma-trace (or dtrace) as a firmware tracing method, which is only supported with IPC3 and it is not applicable for IPC4.
Currently the dtrace is 'open managed' regardless of IPC version (we do force disable it for IPC4, but the dtrace calls remain in place).
From the kernel point of view there are only few ops that needs to be exposed by the firmware tracing support and everything else is IPC private, should not be known by the core.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/8] ASoC: SOF: Introduce IPC independent ops for firmware tracing support
commit: 0cfbaee21fcbf131f02c475dbc15f8a18ee621bc
[2/8] ASoC: SOF: Rename dtrace_is_supported flag to fw_trace_is_supported
commit: 25b17da691f3c1a7cc433f864fd4845998a5a37a
[3/8] ASoC: SOF: Clone the trace code to ipc3-dtrace as fw_tracing implementation
commit: 671e0b90051ec19e83c12501905734fb808b944e
[4/8] ASoC: SOF: Switch to IPC generic firmware tracing
commit: 1dedbe4f223cac603e871d91133b9aa3136fbc21
[5/8] ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to private
commit: b69979a1ec2d9347a43bf0ebdad2c1eb23447ca6
[6/8] ASoC: SOF: Modify the host trace_init parameter list to include dmab
commit: 4b49cbd1e7ebe4b000a7eedc4f910488da62c055
[7/8] ASoC: SOF: Introduce opaque storage of private data for firmware tracing
commit: 08341b27bd2ee3c79265ef7925b3bc68a1790ab9
[8/8] ASoC: SOF: ipc3-dtrace: Move dtrace related variables local from sof_dev
commit: 0683532999ab3890f44f832cd47feee9e2374c22All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark