ARM: dts: at91: replace microchip, 24aa02e48 with atmel, at24c02
PATCH 1/3 ARM: dts: at91: replace microchip, 24aa02e48 with atmel, at24c02
microchip,24aa025e48 does not exist in the bindings of this driver. It can be replaced with atmel,at24c02 which is a standard compatible and the memory is compatible with this one, depending on the page size. microchip 24aa02e48 has a page size of 8, while 24aa025e48 has a page size of 16 bytes.
--- arch/arm/dts/at91-sama5d2_icp.dts | 6 +++--- arch/arm/dts/at91-sama7g5ek.dts | 4 ++-- arch/arm/dts/sama5d27_som1.dtsi | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/dts/at91-sama5d2_icp.dts +3 -3
@@ -68,19 +68,19 @@ status = "okay"; eeprom@50 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x50>; pagesize = <16>; }; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x53>; pagesize = <16>; };
arch/arm/dts/at91-sama7g5ek.dts +2 -2
@@ -405,13 +405,13 @@ status = "okay"; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x53>; pagesize = <16>; };
arch/arm/dts/sama5d27_som1.dtsi +1 -1
@@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa02e48 */ reg = <0x50>; }; };
Signature · 1 line
2.25.1
PATCH 2/3 misc: i2c_eeprom: remove 24aa02e48
This compatible does not exist in the bindings.
All occurences in DT have been replaced by at24c02 which is equivalent.
--- drivers/misc/i2c_eeprom.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/misc/i2c_eeprom.c +0 -8
@@ -169,13 +169,6 @@ static const struct i2c_eeprom_drv_data eeprom_data = { .offset_len = 1, }; -static const struct i2c_eeprom_drv_data mc24aa02e48_data = { - .size =256 , - .pagesize =8 , - .addr_offset_mask =0 , - .offset_len =1 , -}; -static const struct i2c_eeprom_drv_data atmel24c01a_data = { .size =128 , .pagesize =8 ,
@@ -263,7 +256,6 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, - { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, { .compatible ="atmel,24c01" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c01a" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c02" , (ulong)&atmel24c02_data },
Signature · 1 line
2.25.1
PATCH 3/3 ARM: dts: at91: sam9x60ek: fix eeprom compatible
In reply to Eugen HristevThe memory on this board is microchip 24aa025e48 which is compatible with at24c02 with a page size of 16.
Fix the compatible accordingly.
---
Hi,
I will also send a patch to Linux to fix this
Eugen
arch/arm/dts/sam9x60ek.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/sam9x60ek.dts +1 -1
@@ -72,7 +72,7 @@ status = "okay"; eeprom@53 { - compatible = "atmel,24c32"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x53>; pagesize = <16>; };
Signature · 1 line
2.25.1
Re: [PATCH 1/3] ARM: dts: at91: replace microchip,24aa02e48 with atmel,at24c02
In reply to Eugen HristevAm 2022-05-26 16:04, schrieb Eugen Hristev:
Quoted 5 lines
microchip,24aa025e48 does not exist in the bindings of this driver. It can be replaced with atmel,at24c02 which is a standard compatible and the memory is compatible with this one, depending on the page size. microchip
24aa02e48has a page size of 8, while24aa025e48has a page size of 16 bytes.
Nice. Thanks for taking care! One minor nit below.
Quoted 1 line
Signed-off-by Eugen Hristev <[email protected]>
Quoted 64 lines
--- arch/arm/dts/at91-sama5d2_icp.dts | 6 +++--- arch/arm/dts/at91-sama7g5ek.dts | 4 ++-- arch/arm/dts/sama5d27_som1.dtsi | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)arch/arm/dts/at91-sama5d2_icp.dts +1
-1@@ -68,19 +68,19 @@ status = "okay"; eeprom@50 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa025e48, an at24c02 with page size of 16 */arch/arm/dts/at91-sama5d2_icp.dts +1
-1reg = <0x50>; pagesize = <16>; }; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa025e48, an at24c02 with page size of 16 */arch/arm/dts/at91-sama5d2_icp.dts +1
-1reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa025e48, an at24c02 with page size of 16 */arch/arm/dts/at91-sama5d2_icp.dts +0
-0reg = <0x53>; pagesize = <16>; };arch/arm/dts/at91-sama7g5ek.dts +1
-1@@ -405,13 +405,13 @@ status = "okay"; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa025e48, an at24c02 with page size of 16 */arch/arm/dts/at91-sama7g5ek.dts +1
-1reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa025e48, an at24c02 with page size of 16 */arch/arm/dts/at91-sama7g5ek.dts +0
-0reg = <0x53>; pagesize = <16>; };arch/arm/dts/sama5d27_som1.dtsi +0
-0
arch/arm/dts/sama5d27_som1.dtsi line 94
Quoted 3 lines
arch/arm/dts/sama5d27_som1.dtsi +0
-0@@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 {
Nit: that one should actually be just "eeprom@50".
-michael
Quoted 6 lines
arch/arm/dts/sama5d27_som1.dtsi +1
-1- compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip
24aa02e48*/arch/arm/dts/sama5d27_som1.dtsi +0
-0reg = <0x50>; }; };
Re: [PATCH 2/3] misc: i2c_eeprom: remove 24aa02e48
In reply to Eugen HristevAm 2022-05-26 16:04, schrieb Eugen Hristev:
Quoted 5 lines
This compatible does not exist in the bindings.
All occurences in DT have been replaced by at24c02 which is equivalent.Fixes 7264066707 ("misc: i2c_eeprom: Add compatible for 24AA02E48")Signed-off-by Eugen Hristev <[email protected]>
-michael
Re: [PATCH 1/3] ARM: dts: at91: replace microchip,24aa02e48 with atmel,at24c02
In reply to Michael WalleOn 5/26/22 5:11 PM, Michael Walle wrote:
[snip]
Quoted 6 lines
arch/arm/dts/sama5d27_som1.dtsi line 94
Quoted 4 lines
arch/arm/dts/sama5d27_som1.dtsi +0
-0@@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 {Nit: that one should actually be just "eeprom@50".
Hi Michael,
That's true, but my patch just changes the compatible .
With time, I want to completely sync the DT with Linux. It will take some effort, but I am gathering the pieces of the puzzle slowly.
Thanks !
Eugen
Quoted 10 lines
-michael
Quoted 7 lines
(quoted diff) +1
-1- compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /*EEPROM is 2Kbits microchip
24aa02e48*/
reg = <0x50>; };
};
Heiko Schocher
Reviewed-byRe: [PATCH 1/3] ARM: dts: at91: replace microchip,24aa02e48 with atmel,at24c02
Hello Eugen,
Quoted 11 lines · On 26.05.22 16:18, [email protected] wrote:
On 5/26/22 5:11 PM, Michael Walle wrote:
[snip]
Quoted 6 lines
arch/arm/dts/sama5d27_som1.dtsi line 94
Quoted 4 lines
arch/arm/dts/sama5d27_som1.dtsi +0
-0@@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 {Nit: that one should actually be just "eeprom@50".
Quoted 8 lines
Hi Michael,
That's true, but my patch just changes the compatible .
With time, I want to completely sync the DT with Linux. It will take some effort, but I am gathering the pieces of the puzzle slowly.
Thanks !
Fine with me.
bye,
Heiko
Quoted 15 lines
Eugen
Quoted 10 lines
-michael
Quoted 7 lines
(quoted diff) +1
-1- compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /*EEPROM is 2Kbits microchip
24aa02e48*/
reg = <0x50>; };
};
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Re: [PATCH 2/3] misc: i2c_eeprom: remove 24aa02e48
In reply to Eugen HristevHello Eugen,
Quoted 8 lines · Eugen Hristev
This compatible does not exist in the bindings.
All occurences in DT have been replaced by at24c02 which is equivalent.Fixes 7264066707 ("misc: i2c_eeprom: Add compatible for 24AA02E48")Signed-off-by Eugen Hristev <[email protected]>--- drivers/misc/i2c_eeprom.c | 8 -------- 1 file changed, 8 deletions(-)
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Re: [PATCH 3/3] ARM: dts: at91: sam9x60ek: fix eeprom compatible
In reply to Eugen HristevHello Eugen,
Quoted 11 lines · Eugen Hristev
The memory on this board is microchip
24aa025e48which is compatible with at24c02 with a page size of 16.
Fix the compatible accordingly.Reported-by Sergiu Moga <[email protected]>Signed-off-by Eugen Hristev <[email protected]>Tested-by Sergiu Moga <[email protected]>---
Hi,I will also send a patch to Linux to fix this
Thanks!
Quoted 5 lines
Eugen
arch/arm/dts/sam9x60ek.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Re: [PATCH 1/3] ARM: dts: at91: replace microchip,24aa02e48 with atmel,at24c02
In reply to Heiko SchocherQuoted 18 lines · Heiko Schocher
Hello Eugen,
Quoted 15 lines · On 26.05.22 16:18, [email protected] wrote:
On 5/26/22 5:11 PM, Michael Walle wrote:
[snip]
Quoted 6 lines
arch/arm/dts/sama5d27_som1.dtsi line 94
Quoted 4 lines
arch/arm/dts/sama5d27_som1.dtsi +0
-0@@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 {Nit: that one should actually be just "eeprom@50".
Hi Michael,
That's true, but my patch just changes the compatible .
Quoted 8 lines
Quoted 4 lines
With time, I want to completely sync the DT with Linux. It will take some effort, but I am gathering the pieces of the puzzle slowly.
Thanks !
Fine with me.
Reviewed-by Heiko Schocher <[email protected]>
Applied the series to u-boot-at91/next
Thanks for reviewing.
Eugen
Quoted 24 lines
bye,
HeikoQuoted 15 lines
Eugen
Quoted 10 lines
-michael
Quoted 7 lines
(quoted diff) +1
-1- compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /*EEPROM is 2Kbits microchip
24aa02e48*/reg = <0x50>; }; };--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]