iavf: Fix missing state logs
Subsystems (2)
PATCH 1/1 iavf: Fix missing state logs
Fix debug prints, by adding missing state prints.
Extend iavf_state_str by strings for __IAVF_INIT_EXTENDED_CAPS and __IAVF_INIT_CONFIG_ADAPTER.
Without this patch, when enabling debug prints for iavf.h, user will
see:
iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE
--- drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/iavf/iavf.h +4 -0
@@ -464,6 +464,10 @@ static inline const char *iavf_state_str(enum iavf_state_t state)return "__IAVF_INIT_VERSION_CHECK" ;case __IAVF_INIT_GET_RESOURCES:return "__IAVF_INIT_GET_RESOURCES" ; +case __IAVF_INIT_EXTENDED_CAPS: +return "__IAVF_INIT_EXTENDED_CAPS" ; +case __IAVF_INIT_CONFIG_ADAPTER: +return "__IAVF_INIT_CONFIG_ADAPTER" ;case __IAVF_INIT_SW:return "__IAVF_INIT_SW" ;case __IAVF_INIT_FAILED:
Signature · 6 lines
2.35.3 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Dear Jun, dear Przemyslaw,
Am 08.06.22 um 01:53 schrieb Jun Zhang:
Quoted 1 line
Fix debug prints, by adding missing state prints.
… to string conversion function.
Quoted 4 lines
Extend
iavf_state_strby strings for__IAVF_INIT_EXTENDED_CAPSand__IAVF_INIT_CONFIG_ADAPTER.
Without this patch, when enabling debug prints foriavf.h, user will see:
Please do not break lines, just because a sentence ends, or add a blank line between paragraphs.
Quoted 2 lines
iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE
Add a Fixes: tag?
Quoted 11 lines
Signed-off-by Przemyslaw Patynowski <[email protected]>Signed-off-by Jun Zhang <[email protected]>--- drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/ethernet/intel/iavf/iavf.h +0
-0
drivers/net/ethernet/intel/iavf/iavf.h static inline const char *iavf_state_str(enum iavf_state_t state) · line 473
Quoted 10 lines
drivers/net/ethernet/intel/iavf/iavf.h +4
-0@@ -464,6 +464,10 @@ static inline const char *iavf_state_str(enum iavf_state_t state)return "__IAVF_INIT_VERSION_CHECK" ;case __IAVF_INIT_GET_RESOURCES:return "__IAVF_INIT_GET_RESOURCES" ; +case __IAVF_INIT_EXTENDED_CAPS: +return "__IAVF_INIT_EXTENDED_CAPS" ; +case __IAVF_INIT_CONFIG_ADAPTER: +return "__IAVF_INIT_CONFIG_ADAPTER" ;case __IAVF_INIT_SW:return "__IAVF_INIT_SW" ;case __IAVF_INIT_FAILED:
Kind regards,
Paul
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan