Skip to contentSkip to conversation

iavf: Fix missing state logs

PATCH In review Jun Zhang 2 participants 2 messages Jun 15, 2022 – Jul 5, 2022

Subsystems (2)
lore
Share & tools
lore

Jun Zhang

author
#0 lore raw

PATCH v3 1/1 iavf: Fix missing state logs

From: Przemyslaw Patynowski <[email protected]>

Fix debug prints, by adding missing state prints.

Extend iavf_state_str by strings for __IAVF_INIT_EXTENDED_CAPS and __IAVF_INIT_CONFIG_ADAPTER.

Without this patch, when enabling debug prints for iavf.h, user will
see:
iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE

Fixes 605ca7c5c670 ("iavf: Fix kernel BUG in free_msi_irqs")

---
v2: add Fixes Tag and Blank lines @ commit message
v3: change code author

---
 drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/iavf/iavf.h +4 -0
index fda1198d2c00..cbcf0c710072 100644
@@ -464,6 +464,10 @@ static inline const char *iavf_state_str(enum iavf_state_t state)
 		return "__IAVF_INIT_VERSION_CHECK";
 	case __IAVF_INIT_GET_RESOURCES:
 		return "__IAVF_INIT_GET_RESOURCES";
+	case __IAVF_INIT_EXTENDED_CAPS:
+		return "__IAVF_INIT_EXTENDED_CAPS";
+	case __IAVF_INIT_CONFIG_ADAPTER:
+		return "__IAVF_INIT_CONFIG_ADAPTER";
 	case __IAVF_INIT_SW:
 		return "__IAVF_INIT_SW";
 	case __IAVF_INIT_FAILED:
Signature · 6 lines
2.35.3

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by on v3 1/1
#1 lore raw

drivers/net/ethernet/intel/iavf/iavf.h

Quoted 39 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jun Zhang
Sent: Wednesday, June 15, 2022 7:57 PM
To: [email protected]
Cc: Patynowski, PrzemyslawX <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v3] iavf: Fix missing state logs

From: Przemyslaw Patynowski <[email protected]>

Fix debug prints, by adding missing state prints.

Extend iavf_state_str by strings for __IAVF_INIT_EXTENDED_CAPS and __IAVF_INIT_CONFIG_ADAPTER.

Without this patch, when enabling debug prints for iavf.h, user will see:
iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE

Fixes 605ca7c5c670 ("iavf: Fix kernel BUG in free_msi_irqs")
Signed-off-by Przemyslaw Patynowski

<[email protected]>

---
v2: add Fixes Tag and Blank lines @ commit message
v3: change code author

---
 drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/iavf/iavf.h +0 -0
index fda1198d2c00..cbcf0c710072 100644

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan