Skip to contentSkip to conversation

adc-joystick: Add polled support

PATCH Superseded Chris Morgan 5 participants 15 messages Jun 13, 2022 – Jun 25, 2022

Subsystems (5)

v3 of 13 Superseded Latest is v13 →

lore
Share & tools
lore
#5 lore raw

PATCH v3 2/3 Input: adc-joystick - Add polled input device support

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +41 -11
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev, "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
 	}
 
 	return 0;
Signature · 1 line
2.25.1
#0 lore raw

v3 cover adc-joystick: Add polled support

From: Chris Morgan <[email protected]>

Add support to the existing adc-joystick driver to support polling rather than relying on triggered buffers. This is useful for devices that do not offer triggered buffers in hardware. Code adapted from changes made by Maya Matuszczyk <[email protected]>.

Changes from V2:
- Changed parameter from "adc-joystick,polled" to "adc-joystick,no-hardware-trigger" as it is more representative of what the driver and hardware are doing.

Changes from V1:
- Removed driver compatible string of "adc-joystick-polled".
- Added new optional boolean value of "adc-joystick,polled".
- Cleaned up if statements regarding polling behavior.

Chris Morgan (3):
dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger
Input: adc-joystick - Add polled input device support
arm64: dts: rockchip: Update joystick to polled for Odroid-Go2

 .../bindings/input/adc-joystick.yaml          |  9 +++-
 .../boot/dts/rockchip/rk3326-odroid-go2.dts   |  1 +
 drivers/input/joystick/adc-joystick.c         | 52 +++++++++++++++----
 3 files changed, 50 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.1
#14 lore raw

PATCH v3 3/3 arm64: dts: rockchip: Update joystick to polled for Odroid-Go2

From: Chris Morgan <[email protected]>

Update the Odroid Go Advance to use "adc-joystick,no-hardware-trigger" from the adc-joystick driver.

---
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1 -0
index ea0695b51ecd..ffa49b8dee15 100644
@@ -24,6 +24,7 @@ chosen {
 
 	adc-joystick {
 		compatible = "adc-joystick";
+		adc-joystick,no-hardware-trigger;
 		io-channels = <&saradc 1>,
 			      <&saradc 2>;
 		#address-cells = <1>;
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/3 dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for adc-joystick,no-hardware-trigger. New device-tree properties have been added.

- adc-joystick,no-hardware-trigger: A boolean value noting the joystick device should be polled rather than use a triggered buffer.

---
 .../devicetree/bindings/input/adc-joystick.yaml          | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/input/adc-joystick.yaml +8 -1
index 2ee04e03bc22..627cc6c40191 100644
@@ -12,12 +12,19 @@ maintainers:
 
 description: >
   Bindings for joystick devices connected to ADC controllers supporting
-  the Industrial I/O subsystem.
+  the Industrial I/O subsystem. Supports both polled devices where no
+  iio trigger is available and non-polled devices which are triggered
+  by iio.
 
 properties:
   compatible:
     const: adc-joystick
 
+  adc-joystick,no-hardware-trigger:
+    type: boolean
+    description:
+      If the device does not support triggered buffers and needs to be polled.
+
   io-channels:
     minItems: 1
     maxItems: 1024
Signature · 1 line
2.25.1
#6 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

In reply to Chris Morgan
Quoted 9 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

Quoted 43 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +17 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev, 
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;

As mentioned in v2, I don't think a DT property is required here. Assuming the polled mode is a fallback for devices with no buffers, just do:

```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```
Quoted 15 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 262

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +2 -5
 		return error;
 	}
 
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);

Please maintain line discipline of 80 chars to stay consistent with the rest of this driver.

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev)

Quoted 12 lines
drivers/input/joystick/adc-joystick.c +5 -4
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup, 
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup, 
 joy->buffer);

Same here.

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;
#2 lore raw

Re: [PATCH v3 1/3] dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger

In reply to Chris Morgan
Quoted 25 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for adc-joystick,no-hardware-trigger. New device-tree properties have been added.

- adc-joystick,no-hardware-trigger: A boolean value noting the joystick device should be polled rather than use a triggered buffer.

---
 .../devicetree/bindings/input/adc-joystick.yaml          | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/input/adc-joystick.yaml +0 -0
index 2ee04e03bc22..627cc6c40191 100644
@@ -12,12 +12,19 @@ maintainers:
 
 description: >
   Bindings for joystick devices connected to ADC controllers 

supporting

Documentation/devicetree/bindings/input/adc-joystick.yaml maintainers: · line 23

Quoted 10 lines
Documentation/devicetree/bindings/input/adc-joystick.yaml +4 -1
-  the Industrial I/O subsystem.
+  the Industrial I/O subsystem. Supports both polled devices where no
+  iio trigger is available and non-polled devices which are triggered
+  by iio.
 
 properties:
   compatible:
     const: adc-joystick
 
+  adc-joystick,no-hardware-trigger:

I'm against using Device Tree for this functionality. See my reply to patch 2/3 for details.
But in case we do end up going DT way, I would much prefer going with Rob's suggestion of using the existing poll-interval input property.

Cheers,
Artur

Quoted 8 lines
Documentation/devicetree/bindings/input/adc-joystick.yaml +3 -0
+    type: boolean
+    description:
+      If the device does not support triggered buffers and needs to be 

polled.
+
io-channels:

     minItems: 1
     maxItems: 1024
#7 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

In reply to Artur Rojek
Quoted 70 lines · Artur Rojek
Quoted 9 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

Quoted 43 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +17 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;

As mentioned in v2, I don't think a DT property is required here. Assuming the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 9 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 261

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);

Please maintain line discipline of 80 chars to stay consistent with the rest of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;
#3 lore raw

Re: [PATCH v3 1/3] dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger

In reply to Artur Rojek
Quoted 31 lines · Artur Rojek
Quoted 30 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for adc-joystick,no-hardware-trigger. New device-tree properties have been added.

- adc-joystick,no-hardware-trigger: A boolean value noting the joystick device should be polled rather than use a triggered buffer.

---
 .../devicetree/bindings/input/adc-joystick.yaml          | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/input/adc-joystick.yaml +0 -0
index 2ee04e03bc22..627cc6c40191 100644
@@ -12,12 +12,19 @@ maintainers:
 
 description: >
   Bindings for joystick devices connected to ADC controllers 

supporting

Documentation/devicetree/bindings/input/adc-joystick.yaml +3 -1
-  the Industrial I/O subsystem.
+  the Industrial I/O subsystem. Supports both polled devices where no
+  iio trigger is available and non-polled devices which are triggered
+  by iio.
Quoted 7 lines
Quoted 5 lines

properties:
compatible:
const: adc-joystick

+ adc-joystick,no-hardware-trigger:

I'm against using Device Tree for this functionality. See my reply to patch 2/3 for details.

I am surprised to see v3 after that comment...

Quoted 2 lines

But in case we do end up going DT way, I would much prefer going with Rob's suggestion of using the existing poll-interval input property.

+1 here as well, if above does not work.

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v3 1/3] dt-bindings: adc-joystick: add adc-joystick,no-hardware-trigger

Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Artur Rojek
Quoted 34 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for adc-joystick,no-hardware-trigger. New device-tree properties have been added.

- adc-joystick,no-hardware-trigger: A boolean value noting the joystick device should be polled rather than use a triggered buffer.

---
 .../devicetree/bindings/input/adc-joystick.yaml          | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/input/adc-joystick.yaml +0 -0
index 2ee04e03bc22..627cc6c40191 100644
@@ -12,12 +12,19 @@ maintainers:
 
 description: >
   Bindings for joystick devices connected to ADC controllers 

supporting

Documentation/devicetree/bindings/input/adc-joystick.yaml +3 -1
-  the Industrial I/O subsystem.
+  the Industrial I/O subsystem. Supports both polled devices where no
+  iio trigger is available and non-polled devices which are triggered
+  by iio.
 
 properties:
   compatible:
     const: adc-joystick
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

+ adc-joystick,no-hardware-trigger:

I'm against using Device Tree for this functionality. See my reply to patch 2/3 for details.

I am surprised to see v3 after that comment...

No, I'm sorry I must have missed this comment or glossed over it when updating a v3. I've tested checking for INDIO_ALL_BUFFER_MODES and that doesn't seem to trigger the desired behavior (since I think maybe something in my kernel config is adding INDIO_BUFFER_TRIGGERED, and I'd hate for behavior to be dependent on what's in the config versus what's in the hardware). Would it be sufficient to check for "(INDIO_BUFFER_HARDWARE | INDIO_BUFFER_SOFTWARE)"?

Thank you.

Quoted 9 lines
Quoted 3 lines

But in case we do end up going DT way, I would much prefer going with Rob's suggestion of using the existing poll-interval input property.

+1 here as well, if above does not work.

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

In reply to Chris Morgan
Quoted 76 lines · Chris Morgan
Quoted 70 lines · Artur Rojek
Quoted 9 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

Quoted 43 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +17 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;

As mentioned in v2, I don't think a DT property is required here. Assuming the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```
Quoted 7 lines

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Having INDIO_BUFFER_TRIGGERED means that your saradc is capable of using the existing flow. You should be able to register a software trigger and use the adc-joystick driver without further issues.
That said, this is where it gets problematic - there is no way to create an IIO trigger via Device Tree, since triggers don't describe any piece of hardware, and you shouldn't need to register it at runtime (configfs/sysfs) for communication between two kernel drivers either. At the same time, it's not adc-joystick's job to register an external trigger.

Jonathan,
I don't know what the proper approach to this should be, perhaps you could assist?

Cheers,
Artur

Quoted 59 lines

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 9 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 261

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);

Please maintain line discipline of 80 chars to stay consistent with the rest of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;
maintainer
#13 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

In reply to Artur Rojek
Quoted 8 lines · On Wed, 15 Jun 2022 03:43:07 +0200 Artur Rojek <[email protected]> wrote:
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Quoted 6 lines
Quoted 2 lines

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

Please cc [email protected] on future versions.

Quoted 111 lines
Quoted 44 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +17 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev, 
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;  

As mentioned in v2, I don't think a DT property is required here. Assuming the polled mode is a fallback for devices with no buffers, just do:

```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```
Quoted 15 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 262

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +2 -5
 		return error;
 	}
 
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);  

Please maintain line discipline of 80 chars to stay consistent with the rest of this driver.

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev)

Quoted 12 lines
drivers/input/joystick/adc-joystick.c +5 -4
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup, 
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup, 
 joy->buffer);  

Same here.

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;  
maintainer
#9 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

In reply to Artur Rojek
Quoted 10 lines · On Sat, 18 Jun 2022 15:08:29 +0200 Artur Rojek <[email protected]> wrote:
Quoted 9 lines · Chris Morgan
Quoted 8 lines · Artur Rojek
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

+CC linux-iio

Quoted 79 lines
Quoted 62 lines
Quoted 57 lines
Quoted 44 lines
  
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +17 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;  

As mentioned in v2, I don't think a DT property is required here. Assuming
the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```  
Quoted 7 lines

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Having INDIO_BUFFER_TRIGGERED means that your saradc is capable of using the existing flow. You should be able to register a software trigger and use the adc-joystick driver without further issues.
That said, this is where it gets problematic - there is no way to create an IIO trigger via Device Tree, since triggers don't describe any piece of hardware, and you shouldn't need to register it at runtime (configfs/sysfs) for communication between two kernel drivers either. At the same time, it's not adc-joystick's job to register an external trigger.

Quoted 3 lines

Jonathan,
I don't know what the proper approach to this should be, perhaps you could assist?

You are correct in your description above. Device tree folk take the view that sysfs / hrtimer etc triggers are a policy decision so don't belong in device tree. In general you need some userspace code to stitch up the trigger anyway (even ADCs that provide triggers of their own often have several).

An alternative that may make sense here would be for the adc-joystick driver to provide a trigger of it's own. That's easy enough to do, but as things stand we don't provide a way to control the attached trigger from other kernel drivers (i.e. you can't do the equivalent of writing current_trigger for another device).

It's probably not implausible to add that though. Is it worth it for a joystick (vs doing what is done here), maybe not.

It would be worth doing if we cared about high performance (for some ADCs anyway) but here we don't really so the polled read functions are fine.

Note many ADC drivers only support running in either polled or buffered mode in IIO because polling random channels when doing highly optimised accesses tends to make the drivers complex. Hence you might find this doesn't work for all setups...

Thanks,

Jonathan

Quoted 63 lines

Cheers,
Artur

Quoted 60 lines

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 10 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 261

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);  

Please maintain line discipline of 80 chars to stay consistent with the rest
of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);  

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;  
#10 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

Quoted 50 lines · Jonathan Cameron
Quoted 10 lines · On Sat, 18 Jun 2022 15:08:29 +0200 Artur Rojek <[email protected]> wrote:
Quoted 9 lines · Chris Morgan
Quoted 8 lines · Artur Rojek
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

+CC linux-iio

Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +5 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/input/joystick/adc-joystick.c struct adc_joystick { · line 42

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +7 -0
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);

Perhaps check the return value and leave early on error.

Quoted 66 lines
Quoted 44 lines
Quoted 27 lines
Quoted 22 lines
Quoted 9 lines
drivers/input/joystick/adc-joystick.c +5 -0
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;

As mentioned in v2, I don't think a DT property is required here. Assuming
the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```
Quoted 7 lines

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Having INDIO_BUFFER_TRIGGERED means that your saradc is capable of using the existing flow. You should be able to register a software trigger and use the adc-joystick driver without further issues.
That said, this is where it gets problematic - there is no way to create an IIO trigger via Device Tree, since triggers don't describe any piece of hardware, and you shouldn't need to register it at runtime (configfs/sysfs) for communication between two kernel drivers either. At the same time, it's not adc-joystick's job to register an external trigger.

Quoted 3 lines

Jonathan,
I don't know what the proper approach to this should be, perhaps you could assist?

You are correct in your description above. Device tree folk take the view that sysfs / hrtimer etc triggers are a policy decision so don't belong in device tree. In general you need some userspace code to stitch up the trigger anyway (even ADCs that provide triggers of their own often have several).

An alternative that may make sense here would be for the adc-joystick driver to provide a trigger of it's own. That's easy enough to do, but as things stand we don't provide a way to control the attached trigger from other kernel drivers (i.e. you can't do the equivalent of writing current_trigger for another device).

It's probably not implausible to add that though. Is it worth it for a joystick (vs doing what is done here), maybe not.

It would be worth doing if we cared about high performance (for some ADCs anyway) but here we don't really so the polled read functions are fine.

Quoted 8 lines

Note many ADC drivers only support running in either polled or buffered mode in IIO because polling random channels when doing highly optimised accesses tends to make the drivers complex. Hence you might find this doesn't work for all setups...

Thanks,

Jonathan

Jonathan,
thanks for the detailed answer.

Chris,
In light of the above, I think the best course of action should be to keep your polling code. It looks like your saradc has introduced [1] INDIO_BUFFER_TRIGGERED support exclusively for this very (adc-joystick) case. This means we can't use indio_dev->modes to determine whether the joystick can be polled, otherwise we might break behavior of existing hardware. I suggest that we get back to passing this intention via optional poll-interval DT property, that enables the polling path if present (indiscriminately of the IIO mode). Let's see what the Device Tree folk say about that :)

Cheers,
Artur

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4e130dc7b41348b13684f0758c26cc6cf72a3449

Quoted 66 lines
Quoted 66 lines

Cheers,
Artur

Quoted 60 lines

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 10 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 261

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);

Please maintain line discipline of 80 chars to stay consistent with the rest
of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;
#11 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

Quoted 51 lines · Artur Rojek
Quoted 50 lines · Jonathan Cameron
Quoted 10 lines · On Sat, 18 Jun 2022 15:08:29 +0200 Artur Rojek <[email protected]> wrote:
Quoted 9 lines · Chris Morgan
Quoted 8 lines · Artur Rojek
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

+CC linux-iio

Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +5 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/input/joystick/adc-joystick.c struct adc_joystick { · line 42

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +7 -0
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);

Perhaps check the return value and leave early on error.

Okay, I'll do that.

Quoted 85 lines
Quoted 73 lines
Quoted 49 lines
Quoted 27 lines
Quoted 22 lines
Quoted 9 lines
drivers/input/joystick/adc-joystick.c +5 -0
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;

As mentioned in v2, I don't think a DT property is required here. Assuming
the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```
Quoted 7 lines

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Having INDIO_BUFFER_TRIGGERED means that your saradc is capable of using
the existing flow. You should be able to register a software trigger and
use the adc-joystick driver without further issues.
That said, this is where it gets problematic - there is no way to create
an IIO trigger via Device Tree, since triggers don't describe any piece
of hardware, and you shouldn't need to register it at runtime (configfs/sysfs) for communication between two kernel drivers either. At
the same time, it's not adc-joystick's job to register an external trigger.

Quoted 3 lines

Jonathan,
I don't know what the proper approach to this should be, perhaps you could assist?

You are correct in your description above. Device tree folk take the view
that sysfs / hrtimer etc triggers are a policy decision so don't belong in device tree. In general you need some userspace code to stitch up the trigger anyway (even ADCs that provide triggers of their own often have several).

An alternative that may make sense here would be for the adc-joystick driver to provide a trigger of it's own. That's easy enough to do, but as things stand we don't provide a way to control the attached trigger from other kernel drivers (i.e. you can't do the equivalent of writing current_trigger for another device).

It's probably not implausible to add that though. Is it worth it for a joystick (vs doing what is done here), maybe not.

It would be worth doing if we cared about high performance (for some ADCs
anyway) but here we don't really so the polled read functions are fine.

Quoted 8 lines

Note many ADC drivers only support running in either polled or buffered mode in IIO because polling random channels when doing highly optimised accesses tends to make the drivers complex. Hence you might find this doesn't work for all setups...

Thanks,

Jonathan

Jonathan,
thanks for the detailed answer.

Quoted 11 lines

Chris,
In light of the above, I think the best course of action should be to keep your polling code. It looks like your saradc has introduced [1] INDIO_BUFFER_TRIGGERED support exclusively for this very (adc-joystick) case. This means we can't use indio_dev->modes to determine whether the joystick can be polled, otherwise we might break behavior of existing hardware. I suggest that we get back to passing this intention via optional poll-interval DT property, that enables the polling path if present (indiscriminately of the IIO mode). Let's see what the Device Tree folk say about that :)

Thanks. While I know there is a very strict policy of "don't break userspace" I'm not aware of any consumers of the rockchip sardac using the adc-joystick in production. I mean, it's in the tree for this one device but to this day no one is shipping a distro with it to my knowledge, especially since the driver has a major known issue I'm not able to fix at current time (has to do with channels 1 and 2 being used instead of 0 and 1 for this specific SARADC). What I'm getting at is if the current situation is wrong by adding the INDIO_BUFFER_TRIGGERED I don't think it's too late to change it right now.

Would the current poll code be best given the circumstances then? If you think so, I'll go ahead and make all requested changes and resubmit it. I think I'm understanding that what you want is for us to check for the existence of the property of "poll-interval" which is the polling time in milliseconds. If this value is present, use the polling code and if this value is not present, use the existing code (regardless of what the hardware supports or doesn't).

Thank you once again for all your help and guidance. -Chris

Quoted 70 lines

Cheers,
Artur

[1] https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2F%3Fid%3D4e130dc7b41348b13684f0758c26cc6cf72a3449&amp;data=05%7C01%7C%7C43ade3c4216a47079d5208da52112487%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637912530824693621%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Gorf7r9PJr1CDBbRKVNXnRyBJBw2cy%2FLv9tPP24Q5B0%3D&amp;reserved=0

Quoted 66 lines
Quoted 66 lines

Cheers,
Artur

Quoted 60 lines

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 10 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 261

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);

Please maintain line discipline of 80 chars to stay consistent with the rest
of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;
maintainer
#12 lore raw

Re: [PATCH v3 2/3] Input: adc-joystick - Add polled input device support

Quoted 160 lines · On Tue, 21 Jun 2022 16:41:01 -0500 Chris Morgan <[email protected]> wrote:
Quoted 51 lines · Artur Rojek
Quoted 50 lines · Jonathan Cameron
Quoted 10 lines · On Sat, 18 Jun 2022 15:08:29 +0200 Artur Rojek <[email protected]> wrote:
Quoted 9 lines · Chris Morgan
Quoted 8 lines · Artur Rojek
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Hi Chris,

Comments inline. I also Cc'd Paul and Jonathan, who were attached in v2.

+CC linux-iio

Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
 
---
 drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
 1 file changed, 41 insertions(+), 11 deletions(-)
drivers/input/joystick/adc-joystick.c +5 -0
index 78ebca7d400a..dc01cd0214d2 100644
@@ -13,6 +13,10 @@
 
 #include <asm/unaligned.h>
 
+#define ADC_JSK_POLL_INTERVAL	16
+#define ADC_JSK_POLL_MIN	8
+#define ADC_JSK_POLL_MAX	32
+
 struct adc_joystick_axis {
 	u32 code;
 	s32 range[2];
@@ -26,8 +30,21 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/input/joystick/adc-joystick.c struct adc_joystick { · line 42

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +7 -0
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		iio_read_channel_raw(&joy->chans[i], &val);  

Perhaps check the return value and leave early on error.

Okay, I'll do that.

Quoted 85 lines
Quoted 73 lines
Quoted 49 lines
Quoted 27 lines
Quoted 22 lines
Quoted 9 lines
drivers/input/joystick/adc-joystick.c +5 -0
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 239

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +3 -2
@@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (device_property_read_bool(dev,
 "adc-joystick,no-hardware-trigger"))
+		joy->polled = 1;  

As mentioned in v2, I don't think a DT property is required here. Assuming
the polled mode is a fallback for devices with no buffers, just do:

Quoted 4 lines
```
	joy->polled = !(joy->chans[0].indio_dev->modes &
			INDIO_ALL_BUFFER_MODES);
```  
Quoted 7 lines

Understood. I attempted this and noticed that it was showing I have INDIO_BUFFER_TRIGGERED in addition to INDIO_DIRECT_MODE (the INDIO_DIRECT_MODE is the only one specified at the hardware level though). Should I just check for INDIO_BUFFER_SOFTWARE & INDIO_BUFFER_HARDWARE instead? I think it's possible that the inclusion of the industrialio_triggered_buffer module in my kernel is adding this to the channel somehow?

Having INDIO_BUFFER_TRIGGERED means that your saradc is capable of using
the existing flow. You should be able to register a software trigger and
use the adc-joystick driver without further issues.
That said, this is where it gets problematic - there is no way to create
an IIO trigger via Device Tree, since triggers don't describe any piece
of hardware, and you shouldn't need to register it at runtime (configfs/sysfs) for communication between two kernel drivers either. At
the same time, it's not adc-joystick's job to register an external trigger.

Quoted 3 lines

Jonathan,
I don't know what the proper approach to this should be, perhaps you could assist?

You are correct in your description above. Device tree folk take the view
that sysfs / hrtimer etc triggers are a policy decision so don't belong in device tree. In general you need some userspace code to stitch up the trigger anyway (even ADCs that provide triggers of their own often have several).

An alternative that may make sense here would be for the adc-joystick driver to provide a trigger of it's own. That's easy enough to do, but as things stand we don't provide a way to control the attached trigger from other kernel drivers (i.e. you can't do the equivalent of writing current_trigger for another device).

It's probably not implausible to add that though. Is it worth it for a joystick (vs doing what is done here), maybe not.

It would be worth doing if we cared about high performance (for some ADCs
anyway) but here we don't really so the polled read functions are fine.

Quoted 8 lines

Note many ADC drivers only support running in either polled or buffered mode in IIO because polling random channels when doing highly optimised accesses tends to make the drivers complex. Hence you might find this doesn't work for all setups...

Thanks,

Jonathan

Jonathan,
thanks for the detailed answer.

Quoted 11 lines

Chris,
In light of the above, I think the best course of action should be to keep your polling code. It looks like your saradc has introduced [1] INDIO_BUFFER_TRIGGERED support exclusively for this very (adc-joystick) case. This means we can't use indio_dev->modes to determine whether the joystick can be polled, otherwise we might break behavior of existing hardware. I suggest that we get back to passing this intention via optional poll-interval DT property, that enables the polling path if present (indiscriminately of the IIO mode). Let's see what the Device Tree folk say about that :)

Quoted 8 lines

Thanks. While I know there is a very strict policy of "don't break userspace" I'm not aware of any consumers of the rockchip sardac using the adc-joystick in production. I mean, it's in the tree for this one device but to this day no one is shipping a distro with it to my knowledge, especially since the driver has a major known issue I'm not able to fix at current time (has to do with channels 1 and 2 being used instead of 0 and 1 for this specific SARADC). What I'm getting at is if the current situation is wrong by adding the INDIO_BUFFER_TRIGGERED I don't think it's too late to change it right now.

No, better to leave that alone as it's correct, just not helpful to what you want to do here.

Quoted 7 lines

Would the current poll code be best given the circumstances then? If you think so, I'll go ahead and make all requested changes and resubmit it. I think I'm understanding that what you want is for us to check for the existence of the property of "poll-interval" which is the polling time in milliseconds. If this value is present, use the polling code and if this value is not present, use the existing code (regardless of what the hardware supports or doesn't).

Sounds good to me. We might get push back on dt binding though as that doesn't sound very much like something that is about hardware rather than policy. It could be argued that a joystick works best at a particular rate though so maybe we'll be fine. We'll see when you send out the binding docs.

Jonathan

Quoted 74 lines

Thank you once again for all your help and guidance. -Chris

Quoted 70 lines

Cheers,
Artur

[1] https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2F%3Fid%3D4e130dc7b41348b13684f0758c26cc6cf72a3449&amp;data=05%7C01%7C%7C43ade3c4216a47079d5208da52112487%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637912530824693621%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Gorf7r9PJr1CDBbRKVNXnRyBJBw2cy%2FLv9tPP24Q5B0%3D&amp;reserved=0

Quoted 66 lines
Quoted 66 lines

Cheers,
Artur

Quoted 60 lines

Thank you.

Quoted 18 lines
Quoted 18 lines
drivers/input/joystick/adc-joystick.c +10 -0
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
+		input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
+		input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
drivers/input/joystick/adc-joystick.c +0 -0
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 10 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 262

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +2 -5
-	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
-	if (IS_ERR(joy->buffer)) {
-		dev_err(dev, "Unable to allocate callback buffer\n");
-		return PTR_ERR(joy->buffer);
-	}
+	if (!joy->polled) {
+		joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);  

Please maintain line discipline of 80 chars to stay consistent with the rest
of this driver.

Understood, sorry about that.

Quoted 5 lines
Quoted 5 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (IS_ERR(joy->buffer)) {
+			dev_err(dev, "Unable to allocate callback buffer\n");
+			return PTR_ERR(joy->buffer);
+		}
 
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 270

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +1 -4
-	error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);
-	if (error)  {
-		dev_err(dev, "Unable to add action\n");
-		return error;
+		error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
 joy->buffer);  

Same here.

Ditto.

Quoted 10 lines

Cheers,
Artur

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +4 -0
+		if (error)  {
+			dev_err(dev, "Unable to add action\n");
+			return error;
+		}
drivers/input/joystick/adc-joystick.c +0 -0
 	}
 
 	return 0;