QEMU RISC-V nested virtualization fixes
v7 cover QEMU RISC-V nested virtualization fixes
This series does fixes and improvements to have nested virtualization on QEMU RISC-V.
These patches can also be found in riscv_nested_fixes_v7 branch at:
https://github.com/avpatel/qemu.git
The RISC-V nested virtualization was tested on QEMU RISC-V using Xvisor RISC-V which has required hypervisor support to run another hypervisor as Guest/VM.
Changes since v6:
- Droppred original PATCH1 and PATCH2 since these are already merged
- Added PATCH1 to revert dummy mcountinhibit CSR
- Added PATCH2 to fix minimum priv spec version for mcountinhibit CSR
- Fixed checkpatch error in PATCH3
- Fixed compile error in PATCH4
Changes since v5:
- Correctly set "Addr. Offset" for misaligned load/store traps in PATCH3
- Use offsetof() instead of pointer in PATCH4
Changes since v4:
- Updated commit description in PATCH1, PATCH2, and PATCH4
- Use "const" for local array in PATCH5
Changes since v3:
- Updated PATCH3 to set special pseudoinstructions in htinst for guest page faults which result due to VS-stage page table walks
- Updated warning message in PATCH4
Changes since v2:
- Dropped the patch which are already in Alistair's next branch
- Set "Addr. Offset" in the transformed instruction for PATCH3
- Print warning in riscv_cpu_realize() if we are disabling an extension due to privilege spec verions mismatch for PATCH4
Changes since v1:
- Set write_gva to env->two_stage_lookup which ensures that for HS-mode to HS-mode trap write_gva is true only for HLV/HSV instructions
- Included "[PATCH 0/3] QEMU RISC-V priv spec version fixes" patches in this series for easy review
- Re-worked PATCH7 to force disable extensions if required priv spec version is not staisfied
- Added new PATCH8 to fix "aia=aplic-imsic" mode of virt machine
Anup Patel (4):
Revert "target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11
or higher"
target/riscv: Set minumum priv spec version for mcountinhibit target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt() target/riscv: Force disable extensions if priv spec version does not
match
target/riscv/cpu.c | 150 ++++++++++++++++---------- target/riscv/cpu.h | 5 + target/riscv/cpu_bits.h | 3 - target/riscv/cpu_helper.c | 214 ++++++++++++++++++++++++++++++++++++-- target/riscv/csr.c | 4 +- target/riscv/instmap.h | 45 ++++++++ 6 files changed, 353 insertions(+), 68 deletions(-)
Signature · 1 line
2.34.1
PATCH v7 1/4 Revert "target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or higher"
This reverts commit 33cc1c0b69e457f5c526f64297353cba6f7bfdb4 because commit eab4776b2badd4088a4f807c9bb3dc453c53dc23 already implements proper mcountinhibit CSR emulation.
--- target/riscv/cpu_bits.h | 3 --- target/riscv/csr.c | 2 -- 2 files changed, 5 deletions(-)
target/riscv/cpu_bits.h +0 -3
@@ -159,9 +159,6 @@#define CSR_MTVEC 0x305#define CSR_MCOUNTEREN 0x306 -/* Machine Counter Setup */ -#define CSR_MCOUNTINHIBIT 0x320 -/* 32-bit only */ #define CSR_MSTATUSH 0x310
target/riscv/csr.c +0 -2
@@ -3642,8 +3642,6 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = { [CSR_MIE] = { "mie", any, NULL, NULL, rmw_mie }, [CSR_MTVEC] = { "mtvec", any, read_mtvec, write_mtvec }, [CSR_MCOUNTEREN] = { "mcounteren", any, read_mcounteren, write_mcounteren }, - [CSR_MCOUNTINHIBIT] = { "mcountinhibit", any, read_zero, write_ignore, - .min_priv_ver = PRIV_VERSION_1_11_0 }, [CSR_MSTATUSH] = { "mstatush", any32, read_mstatush, write_mstatush },
Signature · 1 line
2.34.1
PATCH v7 2/4 target/riscv: Set minumum priv spec version for mcountinhibit
In reply to Anup PatelThe minimum priv spec versino for mcountinhibit to v1.11 so that it is not available for v1.10 (or lower).
--- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/riscv/csr.c +1 -1
@@ -3944,7 +3944,7 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = { write_mhpmcounter }, [CSR_MCOUNTINHIBIT] = { "mcountinhibit", any, read_mcountinhibit, - write_mcountinhibit }, + write_mcountinhibit, .min_priv_ver = PRIV_VERSION_1_11_0 }, [CSR_MHPMEVENT3] = { "mhpmevent3", any, read_mhpmevent, write_mhpmevent },
Signature · 1 line
2.34.1
PATCH v7 3/4 target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt()
In reply to Anup PatelWe should write transformed instruction encoding of the trapped instruction in [m|h]tinst CSR at time of taking trap as defined by the RISC-V privileged specification v1.12.
--- target/riscv/cpu.h | 5 + target/riscv/cpu_helper.c | 214 ++++++++++++++++++++++++++++++++++++-- target/riscv/instmap.h | 45 ++++++++ 3 files changed, 258 insertions(+), 6 deletions(-)
target/riscv/cpu.h +5 -0
@@ -285,6 +285,11 @@ struct CPUArchState {/* Signals whether the current exception occurred with two-stage address translation active. */ bool two_stage_lookup; +/* +* Signals whether the current exception occurred while doing two-stage +* address translation for the VS-stage page table walk. +*/ +bool two_stage_indirect_lookup;target_ulong scounteren;target_ulong mcounteren;
target/riscv/cpu_helper.c +208 -6
305 lines not on this page · raw message
target/riscv/instmap.h +45 -0
73 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v7 4/4 target/riscv: Force disable extensions if priv spec version does not match
In reply to Anup PatelWe should disable extensions in riscv_cpu_realize() if minimum required priv spec version is not satisfied. This also ensures that machines with priv spec v1.11 (or lower) cannot enable H, V, and various multi-letter extensions.
--- target/riscv/cpu.c | 150 ++++++++++++++++++++++++++++----------------- 1 file changed, 94 insertions(+), 56 deletions(-)
target/riscv/cpu.c +94 -56
@@ -43,9 +43,82 @@ static const char riscv_single_letter_exts[] = "IEMAFDQCPVH";struct isa_ext_data {const char *name; -bool enabled; +bool multi_letter; +int min_version; +int ext_enable_offset; }; +#define ISA_EXT_DATA_ENTRY (_name, _m_letter, _min_ver, _prop) \ +{#_name, _m_letter, _min_ver, offsetof(struct RISCVCPUConfig, _prop)} + +/** +* Here are the ordering rules of extension naming defined by RISC-V +* specification : +* 1. All extensions should be separated from other multi-letter extensions +* by an underscore. +* 2. The first letter following the 'Z' conventionally indicates the most +* closely related alphabetical extension category, IMAFDQLCBKJTPVH. +* If multiple 'Z' extensions are named, they should be ordered first +* by category, then alphabetically within a category. +* 3. Standard supervisor-level extensions (starts with 'S') should be +* listed after standard unprivileged extensions. If multiple +* supervisor-level extensions are listed, they should be ordered +* alphabetically. +* 4. Non-standard extensions (starts with 'X') must be listed after all +* standard extensions. They must be separated from other multi-letter +* extensions by an underscore. +*/ +static const struct isa_ext_data isa_edata_arr[] = { +ISA_EXT_DATA_ENTRY (h, false,PRIV_VERSION_1_12_0 , ext_h), +ISA_EXT_DATA_ENTRY (v, false,PRIV_VERSION_1_12_0 , ext_v), +ISA_EXT_DATA_ENTRY (zicsr, true,PRIV_VERSION_1_10_0 , ext_icsr), +ISA_EXT_DATA_ENTRY (zifencei, true,PRIV_VERSION_1_10_0 , ext_ifencei), +ISA_EXT_DATA_ENTRY (zfh, true,PRIV_VERSION_1_12_0 , ext_zfh), +ISA_EXT_DATA_ENTRY (zfhmin, true,PRIV_VERSION_1_12_0 , ext_zfhmin), +ISA_EXT_DATA_ENTRY (zfinx, true,PRIV_VERSION_1_12_0 , ext_zfinx), +ISA_EXT_DATA_ENTRY (zdinx, true,PRIV_VERSION_1_12_0 , ext_zdinx), +ISA_EXT_DATA_ENTRY (zba, true,PRIV_VERSION_1_12_0 , ext_zba), +ISA_EXT_DATA_ENTRY (zbb, true,PRIV_VERSION_1_12_0 , ext_zbb), +ISA_EXT_DATA_ENTRY (zbc, true,PRIV_VERSION_1_12_0 , ext_zbc), +ISA_EXT_DATA_ENTRY (zbkb, true,PRIV_VERSION_1_12_0 , ext_zbkb), +ISA_EXT_DATA_ENTRY (zbkc, true,PRIV_VERSION_1_12_0 , ext_zbkc), +ISA_EXT_DATA_ENTRY (zbkx, true,PRIV_VERSION_1_12_0 , ext_zbkx), +ISA_EXT_DATA_ENTRY (zbs, true,PRIV_VERSION_1_12_0 , ext_zbs), +ISA_EXT_DATA_ENTRY (zk, true,PRIV_VERSION_1_12_0 , ext_zk), +ISA_EXT_DATA_ENTRY (zkn, true,PRIV_VERSION_1_12_0 , ext_zkn), +ISA_EXT_DATA_ENTRY (zknd, true,PRIV_VERSION_1_12_0 , ext_zknd), +ISA_EXT_DATA_ENTRY (zkne, true,PRIV_VERSION_1_12_0 , ext_zkne), +ISA_EXT_DATA_ENTRY (zknh, true,PRIV_VERSION_1_12_0 , ext_zknh), +ISA_EXT_DATA_ENTRY (zkr, true,PRIV_VERSION_1_12_0 , ext_zkr), +ISA_EXT_DATA_ENTRY (zks, true,PRIV_VERSION_1_12_0 , ext_zks), +ISA_EXT_DATA_ENTRY (zksed, true,PRIV_VERSION_1_12_0 , ext_zksed), +ISA_EXT_DATA_ENTRY (zksh, true,PRIV_VERSION_1_12_0 , ext_zksh), +ISA_EXT_DATA_ENTRY (zkt, true,PRIV_VERSION_1_12_0 , ext_zkt), +ISA_EXT_DATA_ENTRY (zve32f, true,PRIV_VERSION_1_12_0 , ext_zve32f), +ISA_EXT_DATA_ENTRY (zve64f, true,PRIV_VERSION_1_12_0 , ext_zve64f), +ISA_EXT_DATA_ENTRY (zhinx, true,PRIV_VERSION_1_12_0 , ext_zhinx), +ISA_EXT_DATA_ENTRY (zhinxmin, true,PRIV_VERSION_1_12_0 , ext_zhinxmin), +ISA_EXT_DATA_ENTRY (svinval, true,PRIV_VERSION_1_12_0 , ext_svinval), +ISA_EXT_DATA_ENTRY (svnapot, true,PRIV_VERSION_1_12_0 , ext_svnapot), +ISA_EXT_DATA_ENTRY (svpbmt, true,PRIV_VERSION_1_12_0 , ext_svpbmt), +}; + +static bool isa_ext_is_enabled (RISCVCPU *cpu, +const struct isa_ext_data *edata) +{ +bool *ext_enabled = (void *)&cpu->cfg + edata->ext_enable_offset; + +return *ext_enabled; +} + +static void isa_ext_update_enabled (RISCVCPU *cpu, +const struct isa_ext_data *edata,bool en) +{ +bool *ext_enabled = (void *)&cpu->cfg + edata->ext_enable_offset; + + *ext_enabled = en; +} +const char *const riscv_int_regnames[] = {"x0/zero" ,"x1/ra" ,"x2/sp" ,"x3/gp" ,"x4/tp" ,"x5/t0" ,"x6/t1" ,"x7/t2" ,"x8/s0" ,"x9/s1" ,"x10/a0" ,"x11/a1" ,"x12/a2" ,"x13/a3" ,
@@ -530,7 +603,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)CPURISCVState *env = &cpu->env;RISCVCPUClass *mcc =RISCV_CPU_GET_CLASS (dev);CPUClass *cc =CPU_CLASS (mcc); -int priv_version =-1 ; +int i, priv_version =-1 ;Error *local_err =NULL ;cpu_exec_realizefn (cs, &local_err);
@@ -558,6 +631,23 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)set_priv_version (env, priv_version); } +/* Force disable extensions if priv spec version does not match */ +for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { +if (isa_ext_is_enabled (cpu, &isa_edata_arr[i]) && + (env->priv_ver < isa_edata_arr[i].min_version)) { +isa_ext_update_enabled (cpu, &isa_edata_arr[i], false); +#ifndef CONFIG_USER_ONLY +warn_report ("disabling %s extension for hart 0x%lx because " +"privilege spec version does not match" , + isa_edata_arr[i].name, (unsigned long )env->mhartid); +#else +warn_report ("disabling %s extension because " +"privilege spec version does not match" , + isa_edata_arr[i].name); +#endif + } + } +if (cpu->cfg.mmu) {riscv_set_feature (env,RISCV_FEATURE_MMU ); }
@@ -1049,67 +1139,15 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)device_class_set_props (dc, riscv_cpu_properties); } -#define ISA_EDATA_ENTRY (name, prop) {#name, cpu->cfg.prop} -static void riscv_isa_string_ext (RISCVCPU *cpu,char **isa_str,int max_str_len) {char *old = *isa_str;char *new = *isa_str;int i; -/** -* Here are the ordering rules of extension naming defined by RISC-V -* specification : -* 1. All extensions should be separated from other multi-letter extensions -* by an underscore. -* 2. The first letter following the 'Z' conventionally indicates the most -* closely related alphabetical extension category, IMAFDQLCBKJTPVH. -* If multiple 'Z' extensions are named, they should be ordered first -* by category, then alphabetically within a category. -* 3. Standard supervisor-level extensions (starts with 'S') should be -* listed after standard unprivileged extensions. If multiple -* supervisor-level extensions are listed, they should be ordered -* alphabetically. -* 4. Non-standard extensions (starts with 'X') must be listed after all -* standard extensions. They must be separated from other multi-letter -* extensions by an underscore. -*/ -struct isa_ext_data isa_edata_arr[] = { -ISA_EDATA_ENTRY (zicsr, ext_icsr), -ISA_EDATA_ENTRY (zifencei, ext_ifencei), -ISA_EDATA_ENTRY (zmmul, ext_zmmul), -ISA_EDATA_ENTRY (zfh, ext_zfh), -ISA_EDATA_ENTRY (zfhmin, ext_zfhmin), -ISA_EDATA_ENTRY (zfinx, ext_zfinx), -ISA_EDATA_ENTRY (zdinx, ext_zdinx), -ISA_EDATA_ENTRY (zba, ext_zba), -ISA_EDATA_ENTRY (zbb, ext_zbb), -ISA_EDATA_ENTRY (zbc, ext_zbc), -ISA_EDATA_ENTRY (zbkb, ext_zbkb), -ISA_EDATA_ENTRY (zbkc, ext_zbkc), -ISA_EDATA_ENTRY (zbkx, ext_zbkx), -ISA_EDATA_ENTRY (zbs, ext_zbs), -ISA_EDATA_ENTRY (zk, ext_zk), -ISA_EDATA_ENTRY (zkn, ext_zkn), -ISA_EDATA_ENTRY (zknd, ext_zknd), -ISA_EDATA_ENTRY (zkne, ext_zkne), -ISA_EDATA_ENTRY (zknh, ext_zknh), -ISA_EDATA_ENTRY (zkr, ext_zkr), -ISA_EDATA_ENTRY (zks, ext_zks), -ISA_EDATA_ENTRY (zksed, ext_zksed), -ISA_EDATA_ENTRY (zksh, ext_zksh), -ISA_EDATA_ENTRY (zkt, ext_zkt), -ISA_EDATA_ENTRY (zve32f, ext_zve32f), -ISA_EDATA_ENTRY (zve64f, ext_zve64f), -ISA_EDATA_ENTRY (zhinx, ext_zhinx), -ISA_EDATA_ENTRY (zhinxmin, ext_zhinxmin), -ISA_EDATA_ENTRY (svinval, ext_svinval), -ISA_EDATA_ENTRY (svnapot, ext_svnapot), -ISA_EDATA_ENTRY (svpbmt, ext_svpbmt), - }; -for (i =0 ; i <ARRAY_SIZE (isa_edata_arr); i++) { -if (isa_edata_arr[i].enabled) { +if (isa_edata_arr[i].multi_letter && +isa_ext_is_enabled (cpu, &isa_edata_arr[i])) { new =g_strconcat (old,"_" , isa_edata_arr[i].name,NULL );g_free (old); old = new;
Signature · 1 line
2.34.1