Skip to contentSkip to conversation

video: dw_mipi_dsi: fix vsync active vs back porch

PATCH Superseded John Keeping 1 participant 1 message Jul 22, 2022 Framebuffer layer

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: dw_mipi_dsi: fix vsync active vs back porch

The wrong fields are pulled out of the timings here so the values programmed into the DSI_VID_VSA_LINES and DSI_VID_VBP_LINES registers are swapped.

Use the right fields so that the correct values are programmed.

Fixes d4f7ea83fc ("video: add MIPI DSI host controller bridge")
---
 drivers/video/dw_mipi_dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/dw_mipi_dsi.c +2 -2
index a5b38acabd..c68dd66fdc 100644
@@ -644,9 +644,9 @@ static void dw_mipi_dsi_vertical_timing_config(struct dw_mipi_dsi *dsi,
 	u32 vactive, vsa, vfp, vbp;
 
 	vactive = timings->vactive.typ;
-	vsa =  timings->vback_porch.typ;
+	vsa =  timings->vsync_len.typ;
 	vfp =  timings->vfront_porch.typ;
-	vbp = timings->vsync_len.typ;
+	vbp = timings->vback_porch.typ;
 
 	dsi_write(dsi, DSI_VID_VACTIVE_LINES, vactive);
 	dsi_write(dsi, DSI_VID_VSA_LINES, vsa);
Signature · 1 line
2.37.1