Skip to contentSkip to conversation

dt-bindings: adc-joystick: add poll-interval

PATCH Superseded Chris Morgan 5 participants 8 messages Aug 5, 2022 – Aug 12, 2022

Subsystems (5)

v12 of 13 Superseded Latest is v13 →

lore
Share & tools
lore
#0 lore raw

v12 cover dt-bindings: adc-joystick: add poll-interval

From: Chris Morgan <[email protected]>

Add support to the existing adc-joystick driver to support polling rather than relying on triggered buffers. This is useful for devices that do not offer triggered buffers in hardware. Code adapted from changes made by Maya Matuszczyk <[email protected]>.

Changes from V10:
- Removed two unnecessary line breaks.

Changes from V9:
- Simplified skipping of channel checking logic.
- Simplified return logic for driver probe.

Changes from V8:
- Changed logic for checking channels to skip checking of storagebits.
- Changed comment format to comply with Linux style rules.

Changes from V7:
- Dropped acks from adc-joystick.c changes, as it has been altered somewhat since v7.
- Improved checking value of poll-interval to ensure explicit error handling in the event of malformed values.
- Adjusted logic to not check for storagebits if polling is in use, which allows adc-joystick to work in polling mode for devices that utilize a mux (such as the Odroid Go Super and the Anbernic RG353).
- Changed error message and channel size comparison logic slightly to ensure code can fit within 80 character column width.

Changes from V6:
- Reverted back to "poll-interval" after mailing list discussion.
- Referenced input.yaml for definition of poll-interval in adc-joystick documentation.

Changes from V5:
- Corrected an error found by yamllint in the documentation.

Changes from V4:
- Added unit property to devicetree attribute making it now "poll-interval-ms".
- Simplified logic for setting polled value and made variable names more clear.

Changes from V3:
- After lengthy discussion decided to support with existing attribute of "poll-interval". If present, the driver will use polling and if not present, it will use triggered buffers (as the driver does today).
- Corrected some lines to honor the 80 character line-limit.
- Check return value from polling method and return early if there is an error reading the data.

Changes from V2:
- Changed parameter from "adc-joystick,polled" to "adc-joystick,no-hardware-trigger" as it is more representative of what the driver and hardware are doing.

Changes from V1:
- Removed driver compatible string of "adc-joystick-polled".
- Added new optional boolean value of "adc-joystick,polled".
- Cleaned up if statements regarding polling behavior.

Chris Morgan (3):
dt-bindings: adc-joystick: add poll-interval
Input: adc-joystick - Add polled input device support
arm64: dts: rockchip: Update joystick to polled for OG2

 .../bindings/input/adc-joystick.yaml          |  5 +++
 .../boot/dts/rockchip/rk3326-odroid-go2.dts   |  1 +
 drivers/input/joystick/adc-joystick.c         | 44 +++++++++++++++++--
 3 files changed, 47 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH v12 1/3 dt-bindings: adc-joystick: add poll-interval

From: Chris Morgan <[email protected]>

Add poll-interval support for the adc-joystick documentation. This is an optional value and if not provided the adc-joystick works as it does today (with buffers). If this value is provided, the adc-joystick driver is polled at the specified interval. The existing attribute of "poll-interval" was used instead of complying with property-units.yaml after discussion of the issue on the mailing list.

---
 Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/input/adc-joystick.yaml +5 -0
index 2ee04e03bc22..ab5caad055ea 100644
@@ -14,6 +14,9 @@ description: >
   Bindings for joystick devices connected to ADC controllers supporting
   the Industrial I/O subsystem.
 
+allOf:
+  - $ref: input.yaml#
+
 properties:
   compatible:
     const: adc-joystick
@@ -28,6 +31,8 @@ properties:
       https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml
       for details.
 
+  poll-interval: true
+
   '#address-cells':
     const: 1
 
Signature · 1 line
2.25.1
#2 lore raw

PATCH v12 2/3 Input: adc-joystick - Add polled input device support

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

---
 drivers/input/joystick/adc-joystick.c | 44 +++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 3 deletions(-)
drivers/input/joystick/adc-joystick.c +41 -3
index 78ebca7d400a..77dfb7dd96eb 100644
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	unsigned int poll_interval;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
 	if (!joy)
@@ -192,8 +208,21 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
-	/* Count how many channels we got. NULL terminated. */
+	if (device_property_present(dev, "poll-interval")) {
+		error = device_property_read_u32(dev, "poll-interval",
+						 &poll_interval);
+		if (error)
+			return error;
+		joy->polled = true;
+	}
+
+	/*
+	 * Count how many channels we got. NULL terminated.
+	 * Do not check the storage size if using polling.
+	 */
 	for (i = 0; joy->chans[i].indio_dev; i++) {
+		if (joy->polled)
+			continue;
 		bits = joy->chans[i].channel->scan_type.storagebits;
 		if (!bits || bits > 16) {
 			dev_err(dev, "Unsupported channel storage size\n");
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, poll_interval);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,6 +264,9 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
+	if (joy->polled)
+		return 0;
+
 	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
 	if (IS_ERR(joy->buffer)) {
 		dev_err(dev, "Unable to allocate callback buffer\n");
Signature · 1 line
2.25.1
#7 lore raw

PATCH v12 3/3 arm64: dts: rockchip: Update joystick to polled for OG2

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Update the Odroid Go Advance to use "poll-interval" from the adc-joystick driver.

---
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1 -0
index 415aa9ff8bd4..3389755dbdc8 100644
@@ -26,6 +26,7 @@ adc-joystick {
 		compatible = "adc-joystick";
 		io-channels = <&saradc 1>,
 			      <&saradc 2>;
+		poll-interval = <60>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v12 2/3
#3 lore raw

Re: [PATCH v12 2/3] Input: adc-joystick - Add polled input device support

In reply to Chris Morgan
Quoted 9 lines · On Fri, 5 Aug 2022 12:10:15 -0500 Chris Morgan <[email protected]> wrote:

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Trying to avoid too much indentation has lead to an odd code structure. Still minor thing, so either way this looks fine to me.

Quoted 50 lines
---
 drivers/input/joystick/adc-joystick.c | 44 +++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 3 deletions(-)
drivers/input/joystick/adc-joystick.c +21 -1
index 78ebca7d400a..77dfb7dd96eb 100644
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	unsigned int poll_interval;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
 	if (!joy)
@@ -192,8 +208,21 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
-	/* Count how many channels we got. NULL terminated. */
+	if (device_property_present(dev, "poll-interval")) {
+		error = device_property_read_u32(dev, "poll-interval",
+						 &poll_interval);
+		if (error)
+			return error;

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 225

Quoted 10 lines
drivers/input/joystick/adc-joystick.c +9 -0
+		joy->polled = true;
+	}
+
+	/*
+	 * Count how many channels we got. NULL terminated.
+	 * Do not check the storage size if using polling.
+	 */
 	for (i = 0; joy->chans[i].indio_dev; i++) {
+		if (joy->polled)
+			continue;

Whilst I can see why did this, it is a rather 'unusual' code structure and that makes me a tiny bit uncomfortable. However if everyone else is happy with this then fair enough (I see it was Artur's suggestion to handle it like this).

Quoted 30 lines
drivers/input/joystick/adc-joystick.c +11 -2
 		bits = joy->chans[i].channel->scan_type.storagebits;
 		if (!bits || bits > 16) {
 			dev_err(dev, "Unsupported channel storage size\n");
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, poll_interval);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
 	if (error)
@@ -229,6 +264,9 @@ static int adc_joystick_probe(struct platform_device *pdev)
 		return error;
 	}
 
+	if (joy->polled)
+		return 0;
+
 	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
 	if (IS_ERR(joy->buffer)) {
 		dev_err(dev, "Unable to allocate callback buffer\n");
Acked-by
#4 lore raw

Re: [PATCH v12 2/3] Input: adc-joystick - Add polled input device support

Quoted 79 lines · Jonathan Cameron
Quoted 9 lines · On Fri, 5 Aug 2022 12:10:15 -0500 Chris Morgan <[email protected]> wrote:

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Trying to avoid too much indentation has lead to an odd code structure. Still minor thing, so either way this looks fine to me.

Quoted 60 lines
---
 drivers/input/joystick/adc-joystick.c | 44 
+++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 3 deletions(-)
drivers/input/joystick/adc-joystick.c +16 -0
index 78ebca7d400a..77dfb7dd96eb 100644
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	unsigned int poll_interval;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
drivers/input/joystick/adc-joystick.c +12 -1
 	if (!joy)
@@ -192,8 +208,21 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 		return error;
 	}
 
-	/* Count how many channels we got. NULL terminated. */
+	if (device_property_present(dev, "poll-interval")) {
+		error = device_property_read_u32(dev, "poll-interval",
+						 &poll_interval);
+		if (error)
+			return error;
+		joy->polled = true;
+	}
+
+	/*
+	 * Count how many channels we got. NULL terminated.
+	 * Do not check the storage size if using polling.
+	 */
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 225

Quoted 3 lines
drivers/input/joystick/adc-joystick.c +2 -0
 	for (i = 0; joy->chans[i].indio_dev; i++) {
+		if (joy->polled)
+			continue;

Whilst I can see why did this, it is a rather 'unusual' code structure and that makes me a tiny bit uncomfortable. However if everyone else is happy with this then fair enough (I see it was Artur's suggestion to handle it like this).

Yep, I'm fine with the way it is right now :)

Quoted 33 lines
Quoted 33 lines
drivers/input/joystick/adc-joystick.c +0 -0
 		bits = joy->chans[i].channel->scan_type.storagebits;
 		if (!bits || bits > 16) {
drivers/input/joystick/adc-joystick.c +8 -2
 			dev_err(dev, "Unsupported channel storage size\n");
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, poll_interval);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
drivers/input/joystick/adc-joystick.c +3 -0
 	if (error)
@@ -229,6 +264,9 @@ static int adc_joystick_probe(struct 
 platform_device *pdev)
 		return error;
 	}
 
+	if (joy->polled)
+		return 0;
+
 	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
 	if (IS_ERR(joy->buffer)) {

dev_err(dev, "Unable to allocate callback buffer\n");

maintainer
#5 lore raw

Re: [PATCH v12 2/3] Input: adc-joystick - Add polled input device support

Quoted 68 lines · Artur Rojek
Quoted 67 lines · Jonathan Cameron
Quoted 9 lines · On Fri, 5 Aug 2022 12:10:15 -0500 Chris Morgan <[email protected]> wrote:

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Trying to avoid too much indentation has lead to an odd code structure. Still minor thing, so either way this looks fine to me.

Quoted 48 lines
---
 drivers/input/joystick/adc-joystick.c | 44
+++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 3 deletions(-)
drivers/input/joystick/adc-joystick.c +16 -0
index 78ebca7d400a..77dfb7dd96eb 100644
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	unsigned int poll_interval;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
drivers/input/joystick/adc-joystick.c +0 -0
 	if (!joy)
@@ -192,8 +208,21 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 7 lines
Quoted 7 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 216

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +6 -1
-	/* Count how many channels we got. NULL terminated. */
+	if (device_property_present(dev, "poll-interval")) {
+		error = device_property_read_u32(dev, "poll-interval",
+						 &poll_interval);
+		if (error)
+			return error;
+		joy->polled = true;

device_property_read_u32() return -EINVAL if property is not present, so we can write:

	error = device_property_read_u32(dev, "poll-interval", &poll_interval);
	if (error) {
		/* -EINVAL means the property is absent. */
		if (error != -EINVAL)
			return error;
	} else if (poll_interval == 0) {
		dev_err(...);
		return -EINVAL;
	} else {
		joy->polled = true;
	}
Quoted 45 lines
Quoted 6 lines
Quoted 6 lines
drivers/input/joystick/adc-joystick.c +6 -0
+	}
+
+	/*
+	 * Count how many channels we got. NULL terminated.
+	 * Do not check the storage size if using polling.
+	 */
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 225

Quoted 3 lines
drivers/input/joystick/adc-joystick.c +2 -0
 	for (i = 0; joy->chans[i].indio_dev; i++) {
+		if (joy->polled)
+			continue;

Whilst I can see why did this, it is a rather 'unusual' code structure and that makes me a tiny bit uncomfortable. However if everyone else is happy with this then fair enough (I see it was Artur's suggestion to handle it like this).

Yep, I'm fine with the way it is right now :)

Quoted 27 lines
Quoted 27 lines
drivers/input/joystick/adc-joystick.c +0 -0
 		bits = joy->chans[i].channel->scan_type.storagebits;
 		if (!bits || bits > 16) {
drivers/input/joystick/adc-joystick.c +8 -2
 			dev_err(dev, "Unsupported channel storage size\n");
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, poll_interval);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
drivers/input/joystick/adc-joystick.c +0 -0
 	if (error)
@@ -229,6 +264,9 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 3 lines
Quoted 3 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 269

Quoted 3 lines
drivers/input/joystick/adc-joystick.c +3 -0
+	if (joy->polled)
+		return 0;
+

This is no longer compatible with the latest driver code as input device registration has been moved to the very end, so you actually need to move getting bugger and setting up cleanup action into the "else" clause of "if (joy->polled)", even though it adds indentation level.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/input/joystick/adc-joystick.c +0 -0
 	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
 	if (IS_ERR(joy->buffer)) {

dev_err(dev, "Unable to allocate callback buffer\n");

Thanks.

Signature · 1 line
Dmitry
#6 lore raw

Re: [PATCH v12 2/3] Input: adc-joystick - Add polled input device support

Quoted 69 lines · Dmitry Torokhov
Quoted 68 lines · Artur Rojek
Quoted 67 lines · Jonathan Cameron
Quoted 9 lines · On Fri, 5 Aug 2022 12:10:15 -0500 Chris Morgan <[email protected]> wrote:

From: Chris Morgan <[email protected]>

Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.

Hi Chris,

Trying to avoid too much indentation has lead to an odd code structure. Still minor thing, so either way this looks fine to me.

Quoted 48 lines
---
 drivers/input/joystick/adc-joystick.c | 44
+++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 3 deletions(-)
drivers/input/joystick/adc-joystick.c +16 -0
index 78ebca7d400a..77dfb7dd96eb 100644
@@ -26,8 +26,23 @@ struct adc_joystick {
 	struct adc_joystick_axis *axes;
 	struct iio_channel *chans;
 	int num_chans;
+	bool polled;
 };
 
+static void adc_joystick_poll(struct input_dev *input)
+{
+	struct adc_joystick *joy = input_get_drvdata(input);
+	int i, val, ret;
+
+	for (i = 0; i < joy->num_chans; i++) {
+		ret = iio_read_channel_raw(&joy->chans[i], &val);
+		if (ret < 0)
+			return;
+		input_report_abs(input, joy->axes[i].code, val);
+	}
+	input_sync(input);
+}
+
 static int adc_joystick_handle(const void *data, void *private)
 {
 	struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	int error;
 	int bits;
 	int i;
+	unsigned int poll_interval;
 
 	joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
drivers/input/joystick/adc-joystick.c +0 -0
 	if (!joy)
@@ -192,8 +208,21 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 216

Quoted 7 lines
drivers/input/joystick/adc-joystick.c +6 -1
-	/* Count how many channels we got. NULL terminated. */
+	if (device_property_present(dev, "poll-interval")) {
+		error = device_property_read_u32(dev, "poll-interval",
+						 &poll_interval);
+		if (error)
+			return error;
+		joy->polled = true;

device_property_read_u32() return -EINVAL if property is not present, so we can write:

Understood. Both ways can work but when I do the next revision I'll change it to this.

Quoted 58 lines
	error = device_property_read_u32(dev, "poll-interval", &poll_interval);
	if (error) {
		/* -EINVAL means the property is absent. */
		if (error != -EINVAL)
			return error;
	} else if (poll_interval == 0) {
		dev_err(...);
		return -EINVAL;
	} else {
		joy->polled = true;
	}
Quoted 45 lines
Quoted 6 lines
Quoted 6 lines
drivers/input/joystick/adc-joystick.c +6 -0
+	}
+
+	/*
+	 * Count how many channels we got. NULL terminated.
+	 * Do not check the storage size if using polling.
+	 */
Quoted 8 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 225

Quoted 3 lines
drivers/input/joystick/adc-joystick.c +2 -0
 	for (i = 0; joy->chans[i].indio_dev; i++) {
+		if (joy->polled)
+			continue;

Whilst I can see why did this, it is a rather 'unusual' code structure and that makes me a tiny bit uncomfortable. However if everyone else is happy with this then fair enough (I see it was Artur's suggestion to handle it like this).

Yep, I'm fine with the way it is right now :)

Quoted 27 lines
Quoted 27 lines
drivers/input/joystick/adc-joystick.c +0 -0
 		bits = joy->chans[i].channel->scan_type.storagebits;
 		if (!bits || bits > 16) {
drivers/input/joystick/adc-joystick.c +8 -2
 			dev_err(dev, "Unsupported channel storage size\n");
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 	joy->input = input;
 	input->name = pdev->name;
 	input->id.bustype = BUS_HOST;
-	input->open = adc_joystick_open;
-	input->close = adc_joystick_close;
+
+	if (joy->polled) {
+		input_setup_polling(input, adc_joystick_poll);
+		input_set_poll_interval(input, poll_interval);
+	} else {
+		input->open = adc_joystick_open;
+		input->close = adc_joystick_close;
+	}
 
 	error = adc_joystick_set_axes(dev, joy);
drivers/input/joystick/adc-joystick.c +0 -0
 	if (error)
@@ -229,6 +264,9 @@ static int adc_joystick_probe(struct
 platform_device *pdev)
 		return error;
 	}
 
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 269

Quoted 3 lines
drivers/input/joystick/adc-joystick.c +3 -0
+	if (joy->polled)
+		return 0;
+

This is no longer compatible with the latest driver code as input device registration has been moved to the very end, so you actually need to move getting bugger and setting up cleanup action into the "else" clause of "if (joy->polled)", even though it adds indentation level.

I'm afraid I don't understand the issue you are describing. input_register_device is called before this section, and since it's allocated with devm we shouldn't need to clean it up in the event of an error, right? The two functions below this line (including the one establishing the joystick cleanup) are only required for non-polled devices.

Thank you.

Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/input/joystick/adc-joystick.c +0 -0
 	joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
 	if (IS_ERR(joy->buffer)) {

dev_err(dev, "Unable to allocate callback buffer\n");

Thanks.

Signature · 1 line
Dmitry