Skip to contentSkip to conversation

board: gateworks: venice: update GW74xx PMIC config

PATCH Superseded Tim Harvey 2 participants 3 messages Sep 8, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 board: gateworks: venice: update GW74xx PMIC config

Update the GW74xx PMIC configuration.

---
 board/gateworks/venice/spl.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)
board/gateworks/venice/spl.c +9 -11
index 56a985ed668f..eadb58f9ac75 100644
@@ -153,20 +153,18 @@ static int power_init_board(void)
 		/* BUCKxOUT_DVS0/1 control BUCK123 output */
 		dm_i2c_reg_write(dev, PCA9450_BUCK123_DVS, 0x29);
 
-		/* Buck 1 DVS control through PMIC_STBY_REQ */
-		dm_i2c_reg_write(dev, PCA9450_BUCK1CTRL, 0x59);
-
-		/* Set DVS1 to 0.8v for suspend */
-		dm_i2c_reg_write(dev, PCA9450_BUCK1OUT_DVS1, 0x10);
+		/* increase VDD_SOC to 0.95V before first DRAM access */
+		dm_i2c_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x1C);
 
-		/* increase VDD_DRAM to 0.95v for 3Ghz DDR */
-		dm_i2c_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x1C);
+		/* Set DVS1 to 0.85v for suspend */
+		dm_i2c_reg_write(dev, PCA9450_BUCK1OUT_DVS1, 0x14);
 
-		/* VDD_DRAM off in suspend: B1_ENMODE=10 */
-		dm_i2c_reg_write(dev, PCA9450_BUCK3CTRL, 0x4a);
+		/* Enable DVS control through PMIC_STBY_REQ */
+		dm_i2c_reg_write(dev, PCA9450_BUCK1CTRL, 0x59);
 
-		/* set VDD_SNVS_0V8 from default 0.85V */
-		dm_i2c_reg_write(dev, PCA9450_LDO2CTRL, 0xC0);
+		/* Kernel uses OD/OD freq for SOC */
+		/* To avoid timing risk from SOC to ARM, increase VDD_ARM to OD voltage 0.95v */
+		dm_i2c_reg_write(dev, PCA9450_BUCK2OUT_DVS0, 0x1C);
 
 		/* set WDOG_B_CFG to cold reset */
 		dm_i2c_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
Signature · 1 line
2.25.1
#1 lore raw

Hi Tim,

Quoted 2 lines · Tim Harvey

Update the GW74xx PMIC configuration.

Please explain why you are doing this change.

author
#2 lore raw
Quoted 8 lines · Fabio Estevam

Hi Tim,

Quoted 2 lines · Tim Harvey

Update the GW74xx PMIC configuration.

Please explain why you are doing this change.

Fabio,

Thanks for the quick review - I've sent a v2.

Best Regards,

Tim