Skip to contentSkip to conversation

cmd: nand: Extend nand info to print ecc information

PATCH In review Michael Trimarchi 3 participants 4 messages Sep 22, 2022 – Oct 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: nand: Extend nand info to print ecc information

Extract the information about ecc strength and ecc step size from mtd controller. This information is usefull to check if what we think as ecc is what we really configured.

---
 cmd/nand.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
cmd/nand.c +8 -6
index e730484d0b..9a9794684b 100644
@@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
 		printf("%dx ", chip->numchips);
 	printf("%s, sector size %u KiB\n",
 	       mtd->name, mtd->erasesize >> 10);
-	printf("  Page size   %8d b\n", mtd->writesize);
-	printf("  OOB size    %8d b\n", mtd->oobsize);
-	printf("  Erase size  %8d b\n", mtd->erasesize);
-	printf("  subpagesize %8d b\n", chip->subpagesize);
-	printf("  options     0x%08x\n", chip->options);
-	printf("  bbt options 0x%08x\n", chip->bbt_options);
+	printf("  Page size     %8d b\n", mtd->writesize);
+	printf("  OOB size      %8d b\n", mtd->oobsize);
+	printf("  Erase size    %8d b\n", mtd->erasesize);
+	printf("  ecc strength  %8d bits\n", mtd->ecc_strength);
+	printf("  ecc step size %8d b\n", mtd->ecc_step_size);
+	printf("  subpagesize   %8d b\n", chip->subpagesize);
+	printf("  options       0x%08x\n", chip->options);
+	printf("  bbt options   0x%08x\n", chip->bbt_options);
 
 	/* Set geometry info */
 	env_set_hex("nand_writesize", mtd->writesize);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Michael,

Quoted 36 lines · Michael Trimarchi

Extract the information about ecc strength and ecc step size from mtd controller. This information is usefull to check if what we think as ecc is what we really configured.

---
 cmd/nand.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
cmd/nand.c +8 -7
index e730484d0b..9a9794684b 100644
@@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
                printf("%dx ", chip->numchips);
        printf("%s, sector size %u KiB\n",
               mtd->name, mtd->erasesize >> 10);
-       printf("  Page size   %8d b\n", mtd->writesize);
-       printf("  OOB size    %8d b\n", mtd->oobsize);
-       printf("  Erase size  %8d b\n", mtd->erasesize);
-       printf("  subpagesize %8d b\n", chip->subpagesize);
-       printf("  options     0x%08x\n", chip->options);
-       printf("  bbt options 0x%08x\n", chip->bbt_options);
+       printf("  Page size     %8d b\n", mtd->writesize);
+       printf("  OOB size      %8d b\n", mtd->oobsize);
+       printf("  Erase size    %8d b\n", mtd->erasesize);
+       printf("  ecc strength  %8d bits\n", mtd->ecc_strength);
+       printf("  ecc step size %8d b\n", mtd->ecc_step_size);
+       printf("  subpagesize   %8d b\n", chip->subpagesize);
+       printf("  options       0x%08x\n", chip->options);
+       printf("  bbt options   0x%08x\n", chip->bbt_options);
 
        /* Set geometry info */
        env_set_hex("nand_writesize", mtd->writesize);
--
Quoted 2 lines

2.34.1

Thanks and regards,
Dario

Signature · 17 lines
Dario Binacchi

Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com
#2 lore raw

HI Tom

Quoted 38 lines · Dario Binacchi

Hi Michael,

Quoted 33 lines · Michael Trimarchi

Extract the information about ecc strength and ecc step size from mtd controller. This information is usefull to check if what we think as ecc is what we really configured.

---
 cmd/nand.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
cmd/nand.c +8 -6
index e730484d0b..9a9794684b 100644
@@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
                printf("%dx ", chip->numchips);
        printf("%s, sector size %u KiB\n",
               mtd->name, mtd->erasesize >> 10);
-       printf("  Page size   %8d b\n", mtd->writesize);
-       printf("  OOB size    %8d b\n", mtd->oobsize);
-       printf("  Erase size  %8d b\n", mtd->erasesize);
-       printf("  subpagesize %8d b\n", chip->subpagesize);
-       printf("  options     0x%08x\n", chip->options);
-       printf("  bbt options 0x%08x\n", chip->bbt_options);
+       printf("  Page size     %8d b\n", mtd->writesize);
+       printf("  OOB size      %8d b\n", mtd->oobsize);
+       printf("  Erase size    %8d b\n", mtd->erasesize);
+       printf("  ecc strength  %8d bits\n", mtd->ecc_strength);
+       printf("  ecc step size %8d b\n", mtd->ecc_step_size);
+       printf("  subpagesize   %8d b\n", chip->subpagesize);
+       printf("  options       0x%08x\n", chip->options);
+       printf("  bbt options   0x%08x\n", chip->bbt_options);
 
Quoted 8 lines
Quoted 5 lines
cmd/nand.c +0 -1
        /* Set geometry info */
        env_set_hex("nand_writesize", mtd->writesize);
--

2.34.1

Can I pick it up?

Michael

Quoted 21 lines

Thanks and regards,
Dario
--

Dario Binacchi

Embedded Linux Developer

[email protected]

__________________________________

Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com

Signature · 11 lines
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
#3 lore raw
Quoted 51 lines · Michael Nazzareno Trimarchi

HI Tom

Quoted 38 lines · Dario Binacchi

Hi Michael,

Quoted 33 lines · Michael Trimarchi

Extract the information about ecc strength and ecc step size from mtd controller. This information is usefull to check if what we think as ecc is what we really configured.

---
 cmd/nand.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
cmd/nand.c +8 -6
index e730484d0b..9a9794684b 100644
@@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
                printf("%dx ", chip->numchips);
        printf("%s, sector size %u KiB\n",
               mtd->name, mtd->erasesize >> 10);
-       printf("  Page size   %8d b\n", mtd->writesize);
-       printf("  OOB size    %8d b\n", mtd->oobsize);
-       printf("  Erase size  %8d b\n", mtd->erasesize);
-       printf("  subpagesize %8d b\n", chip->subpagesize);
-       printf("  options     0x%08x\n", chip->options);
-       printf("  bbt options 0x%08x\n", chip->bbt_options);
+       printf("  Page size     %8d b\n", mtd->writesize);
+       printf("  OOB size      %8d b\n", mtd->oobsize);
+       printf("  Erase size    %8d b\n", mtd->erasesize);
+       printf("  ecc strength  %8d bits\n", mtd->ecc_strength);
+       printf("  ecc step size %8d b\n", mtd->ecc_step_size);
+       printf("  subpagesize   %8d b\n", chip->subpagesize);
+       printf("  options       0x%08x\n", chip->options);
+       printf("  bbt options   0x%08x\n", chip->bbt_options);
 
Quoted 8 lines
Quoted 5 lines
cmd/nand.c +0 -1
        /* Set geometry info */
        env_set_hex("nand_writesize", mtd->writesize);
--

2.34.1

Quoted 1 line

Can I pick it up?

Yes.

Signature · 1 line
Tom