imx8mn-ddr4-evk-u-boot: Fix broken boot
Subsystems (2)
PATCH v2 1/1 imx8mn-ddr4-evk-u-boot: Fix broken boot
When the imx8mn.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.
Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.
---
Changes since v1:
- Fix typo in commit log: imx8mm.dtsi--> imx8mn.dtsi
Hi Tom and Stefano,
I know today is release day. Could this one be applied directly?
It fixes a boot regression.
Thanks
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi +4 -0
@@ -26,6 +26,10 @@ u-boot,dm-spl; }; +&spba1 { + u-boot,dm-spl; +}; + &clk { u-boot,dm-spl; u-boot,dm-pre-reloc;
Signature · 1 line
2.25.1
Hi Fabio
Quoted 33 lines · Fabio Estevam
When the
imx8mn.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.
Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Fix typo in commit log: imx8mm.dtsi-->imx8mn.dtsiHi Tom and Stefano,
I know today is release day. Could this one be applied directly?
It fixes a boot regression.
Thanks
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi +0
-0
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi line 35
Quoted 10 lines
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi +4
-0@@ -26,6 +26,10 @@ u-boot,dm-spl; }; +&spba1 { + u-boot,dm-spl; +}; + &clk { u-boot,dm-spl; u-boot,dm-pre-reloc;
If this is valid for all the board could you just move in imx8mn-uboot.dtsi?
Michael
Quoted 3 lines
--
2.25.1
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Hi Michael,
Quoted 1 line · Michael Nazzareno Trimarchi
If this is valid for all the board could you just move in
imx8mn-uboot.dtsi?
I plan to do this, but imx8mn-u-boot.dtsi does not exist today.
To fix the regression, let's go with this patch for 2022.10, then for 2023.01 the imx8mn-u-boot.dtsi can be introduced.
Regards,
Fabio Estevam
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: [email protected]
Hi
Quoted 5 lines · Fabio Estevam
Hi Michael,
On 03/10/2022 11:12, Michael Nazzareno Trimarchi wrote:
Quoted 8 lines
Quoted 2 lines
If this is valid for all the board could you just move in
imx8mn-uboot.dtsi?I plan to do this, but
imx8mn-u-boot.dtsidoes not exist today.To fix the regression, let's go with this patch for 2022.10, then for 2023.01 the
imx8mn-u-boot.dtsican be introduced.
You can create only and populate with one. The inclusion should be automatic
Michael
Quoted 8 lines
Regards,
Fabio Estevam
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
[email protected]
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Hi
to be more clear
imx8mn-u-boot.dtsi
&{/soc@0} {
u-boot,dm-pre-reloc;
u-boot,dm-spl;
};&spba1 {
u-boot,dm-spl;
};Michael
Quoted 45 lines · Michael Nazzareno Trimarchi
Hi
Quoted 5 lines · Fabio Estevam
Hi Michael,
On 03/10/2022 11:12, Michael Nazzareno Trimarchi wrote:
Quoted 8 lines
Quoted 2 lines
If this is valid for all the board could you just move in
imx8mn-uboot.dtsi?I plan to do this, but
imx8mn-u-boot.dtsidoes not exist today.To fix the regression, let's go with this patch for 2022.10, then for 2023.01 the
imx8mn-u-boot.dtsican be introduced.You can create only and populate with one. The inclusion should be automatic
Michael
Quoted 8 lines
Regards,
Fabio Estevam
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
[email protected]--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Hi Michael,
Quoted 6 lines · Michael Nazzareno Trimarchi
Hi
to be more clear
imx8mn-u-boot.dtsi
Quoted 8 lines
&{/soc@0} { u-boot,dm-pre-reloc; u-boot,dm-spl; };&spba1 { u-boot,dm-spl; };
Just to be clear: it makes sense to introduce imx8mn-u-boot.dtsi.
However, we are in the release day for 2022.10.
My goal is to avoid the boot regressions with the minimum changes, so that's why I have sent these patches.
After 2022.10 is out, then imx8mn-u-boot.dtsi can be properly introduced.
Regards,
Fabio Estevam
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: [email protected]
Hi Fabio
Quoted 21 lines · Fabio Estevam
Hi Michael,
Quoted 6 lines · Michael Nazzareno Trimarchi
Hi
to be more clear
imx8mn-u-boot.dtsiQuoted 8 lines
&{/soc@0} { u-boot,dm-pre-reloc; u-boot,dm-spl; };&spba1 { u-boot,dm-spl; };Just to be clear: it makes sense to introduce
imx8mn-u-boot.dtsi.
Quoted 7 lines
However, we are in the release day for 2022.10.
My goal is to avoid the boot regressions with the minimum changes, so that's why I have sent these patches.
After 2022.10 is out, then
imx8mn-u-boot.dtsican be properly introduced.
It's clear.
Michael
Quoted 9 lines
Regards,
Fabio Estevam
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
[email protected]
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Quoted 7 lines · Fabio Estevam
When the
imx8mn.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.
Quoted 5 lines
Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.
Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom
Quoted 13 lines · Fabio Estevam
When the
imx8mn.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.
Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Fabio Estevam <[email protected]>
Quoted 7 lines
---
Changes since v1:
- Fix typo in commit log: imx8mm.dtsi-->imx8mn.dtsiHi Tom and Stefano,
I know today is release day. Could this one be applied directly?
I have a series to push this fix into a common imx8mn-u-boot.dtsi file [1]. Theoretically, pulling in that series should fix all the 8mn's.
[1] - https://patchwork.ozlabs.org/project/uboot/list/?series=312016
adam
Quoted 26 lines
It fixes a boot regression.
Thanks
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi +4
-1@@ -26,6 +26,10 @@ u-boot,dm-spl; }; +&spba1 { + u-boot,dm-spl; +}; + &clk { u-boot,dm-spl; u-boot,dm-pre-reloc; --2.25.1