Skip to contentSkip to conversation

imx8mn-venice-u-boot: Fix broken boot

PATCH Superseded Fabio Estevam 4 participants 4 messages Oct 3, 2022 – Oct 22, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx8mn-venice-u-boot: Fix broken boot

When the imx8mm.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.

Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.

Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")

---
Hi Tim,

Could you please test this patch?

It fixes boot regression on imx8mn-evk and imx8mn-beacon.

 arch/arm/dts/imx8mn-venice-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/imx8mn-venice-u-boot.dtsi +4 -0
index 9fb3871452..9debf9675d 100644
@@ -20,6 +20,10 @@
 	u-boot,dm-spl;
 };
 
+&spba1 {
+	u-boot,dm-spl;
+};
+
 &clk {
 	u-boot,dm-spl;
 	u-boot,dm-pre-reloc;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

Hi

Quoted 28 lines · Fabio Estevam

When the imx8mm.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.

Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.

Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")

---
Hi Tim,

Could you please test this patch?

It fixes boot regression on imx8mn-evk and imx8mn-beacon.

 arch/arm/dts/imx8mn-venice-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/imx8mn-venice-u-boot.dtsi +0 -0
index 9fb3871452..9debf9675d 100644

arch/arm/dts/imx8mn-venice-u-boot.dtsi line 29

Quoted 10 lines
arch/arm/dts/imx8mn-venice-u-boot.dtsi +4 -0
@@ -20,6 +20,10 @@
        u-boot,dm-spl;
 };
 
+&spba1 {
+       u-boot,dm-spl;
+};
+
 &clk {
        u-boot,dm-spl;
        u-boot,dm-pre-reloc;

I have seen a series already here I think

Quoted 3 lines

--
2.25.1

Signature · 11 lines
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
#2 lore raw

PATCH 1/1 imx8mn-venice-u-boot: Fix broken boot

In reply to Fabio Estevam
Quoted 11 lines

When the imx8mm.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.
Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.

Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
reviewer
#3 lore raw

Hi Stefano,

Quoted 12 lines · On Fri, Oct 21, 2022 at 8:50 AM <[email protected]> wrote:
Quoted 9 lines

When the imx8mm.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.
Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board.

Quoted 3 lines
Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Thanks, but this one is already present in U-Boot 2022.10 final.

Tom applied it directly to avoid the boot regression.

It seems that the u-boot-imx base is not up to date.