net: dsa: mv88e6xxx: Add RGMII delay to 88E6320
Subsystems (4)
PATCH v3 1/1 net: dsa: mv88e6xxx: Add RGMII delay to 88E6320
From: Steffen Bätz <[email protected]>
Currently, the .port_set_rgmii_delay hook is missing for the 88E6320 family, which causes failure to retrieve an IP address via DHCP.
Add mv88e6320_port_set_rgmii_delay() that allows applying the RGMII delay for ports 2, 5, and 6, which are the only ports that can be used in RGMII mode.
Tested on a custom i.MX8MN board connected to an 88E6320 switch.
This change also applies safely to the 88E6321 variant.
The only difference between 88E6320 versus 88E6321 is the temperature grade and pinout.
They share exactly the same MDIO register map for ports 2, 5, and 6, which are the only ports that can be used in RGMII mode.
---
Changes since v2:
- Add .port_set_rgmii_delay to mv88e6321_ops as well (Andrew). Changes since v1:
- Improve the commit log by saying that change is also valid for the 88E631 chip. (Andrew).
drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ drivers/net/dsa/mv88e6xxx/port.c | 9 +++++++++ drivers/net/dsa/mv88e6xxx/port.h | 2 ++ 3 files changed, 13 insertions(+)
drivers/net/dsa/mv88e6xxx/chip.c +2 -0
@@ -5029,6 +5029,7 @@ static const struct mv88e6xxx_ops mv88e6320_ops = { .phy_write = mv88e6xxx_g2_smi_phy_write, .port_set_link = mv88e6xxx_port_set_link, .port_sync_link = mv88e6xxx_port_sync_link, + .port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay, .port_set_speed_duplex = mv88e6185_port_set_speed_duplex, .port_tag_remap = mv88e6095_port_tag_remap, .port_set_frame_mode = mv88e6351_port_set_frame_mode,
@@ -5073,6 +5074,7 @@ static const struct mv88e6xxx_ops mv88e6321_ops = { .phy_write = mv88e6xxx_g2_smi_phy_write, .port_set_link = mv88e6xxx_port_set_link, .port_sync_link = mv88e6xxx_port_sync_link, + .port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay, .port_set_speed_duplex = mv88e6185_port_set_speed_duplex, .port_tag_remap = mv88e6095_port_tag_remap, .port_set_frame_mode = mv88e6351_port_set_frame_mode,
drivers/net/dsa/mv88e6xxx/port.c +9 -0
@@ -133,6 +133,15 @@ int mv88e6390_port_set_rgmii_delay(struct mv88e6xxx_chip *chip, int port,return mv88e6xxx_port_set_rgmii_delay (chip, port, mode); } +int mv88e6320_port_set_rgmii_delay (struct mv88e6xxx_chip *chip,int port, +phy_interface_t mode) +{ +if (port !=2 && port !=5 && port !=6 ) +return -EOPNOTSUPP ; + +return mv88e6xxx_port_set_rgmii_delay (chip, port, mode); +} +int mv88e6xxx_port_set_link (struct mv88e6xxx_chip *chip,int port,int link) {u16 reg;
drivers/net/dsa/mv88e6xxx/port.h +2 -0
@@ -332,6 +332,8 @@ int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg,int mv88e6185_port_set_pause (struct mv88e6xxx_chip *chip,int port,int pause); +int mv88e6320_port_set_rgmii_delay (struct mv88e6xxx_chip *chip,int port, +phy_interface_t mode);int mv88e6352_port_set_rgmii_delay (struct mv88e6xxx_chip *chip,int port,phy_interface_t mode); int mv88e6390_port_set_rgmii_delay(struct mv88e6xxx_chip *chip, int port,
Signature · 1 line
2.25.1
Quoted 16 lines · Fabio Estevam
From: Steffen Bätz <[email protected]>
Currently, the .port_set_rgmii_delay hook is missing for the 88E6320 family, which causes failure to retrieve an IP address via DHCP.
Add
mv88e6320_port_set_rgmii_delay()that allows applying the RGMII delay for ports 2, 5, and 6, which are the only ports that can be used in RGMII mode.Tested on a custom i.MX8MN board connected to an 88E6320 switch.
This change also applies safely to the 88E6321 variant.
The only difference between 88E6320 versus 88E6321 is the temperature grade and pinout.
Quoted 6 lines
They share exactly the same MDIO register map for ports 2, 5, and 6, which are the only ports that can be used in RGMII mode.
Signed-off-by Steffen Bätz <[email protected]>[fabio: Improved commit log and extended it to mv88e6321_ops]Signed-off-by Fabio Estevam <[email protected]>
Andrew
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Fri, 28 Oct 2022 13:31:58 -0300 you wrote:
From: Steffen Bätz <[email protected]>
Currently, the .port_set_rgmii_delay hook is missing for the 88E6320 family, which causes failure to retrieve an IP address via DHCP.
Add
mv88e6320_port_set_rgmii_delay()that allows applying the RGMII delay for ports 2, 5, and 6, which are the only ports that can be used in RGMII mode.[...]
Here is the summary with links:
- [v3,net-next] net: dsa: mv88e6xxx: Add RGMII delay to 88E6320
https://git.kernel.org/netdev/net-next/c/91e87045a5ef
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html