Skip to contentSkip to conversation

baseband/acc100: changes for 22.11

PATCH Applied Hernan Vargas 3 participants 4 messages Nov 3, 2022 – Nov 7, 2022

lore
Share & tools
lore
#0 lore raw

v8 cover baseband/acc100: changes for 22.11

v8: Remove unused parameter per community recommendation.
v7: Not including dependency on SDK introduced in previous v3 for now due to lack of consensus yet.
Still detecting the known corner case and flagging it.
v6: Fix commit message typo.
v5: Fix compilation error and squash documentation changes.
v4: Rebased code to use the latest ACC common API and implemented review comment changes.
v3: Code refactor based on comments and grouping fixes at beginning of series.
v2: Rebased code to use ACC common API.
v1: Upstreaming ACC100 changes for 22.11.
This patch series is dependant on series:
https://patches.dpdk.org/project/dpdk/list/?series=25191

Hernan Vargas (1):
baseband/acc100: add detection for deRM corner cases

 drivers/baseband/acc/acc_common.h     |  8 +++++
 drivers/baseband/acc/rte_acc100_pmd.c | 48 ++++++++++++++++++++++++++-
 2 files changed, 55 insertions(+), 1 deletion(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH v8 1/1 baseband/acc100: add detection for deRM corner cases

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
 drivers/baseband/acc/acc_common.h     |  8 +++++
 drivers/baseband/acc/rte_acc100_pmd.c | 48 ++++++++++++++++++++++++++-
 2 files changed, 55 insertions(+), 1 deletion(-)
drivers/baseband/acc/acc_common.h +8 -0
index 5cfa2b64ba..c076dc72cc 100644
@@ -123,6 +123,14 @@
 #define ACC_HARQ_ALIGN_64B          64
 #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */
+#define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */
+#define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */
+#define ACC_MAX_E (128 * 1024 - 2)
+
 /* Helper macro for logging */
 #define rte_acc_log(level, fmt, ...) \
 	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
drivers/baseband/acc/rte_acc100_pmd.c +47 -1

84 lines not on this page · raw message

Signature · 1 line
2.37.1
Reviewed-by on v8 1/1
#2 lore raw

Re: [PATCH v8 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 7 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

Quoted 6 lines
---
  drivers/baseband/acc/acc_common.h     |  8 +++++
  drivers/baseband/acc/rte_acc100_pmd.c | 48 ++++++++++++++++++++++++++-
  2 files changed, 55 insertions(+), 1 deletion(-)

Thanks,
Maxime

Applied
#3 lore raw

RE: [EXT] Re: [PATCH v8 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 12 lines · Hernan Vargas
Quoted 11 lines

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
  drivers/baseband/acc/acc_common.h     |  8 +++++
  drivers/baseband/acc/rte_acc100_pmd.c | 48
Quoted 5 lines

++++++++++++++++++++++++++-

Quoted 2 lines
  2 files changed, 55 insertions(+), 1 deletion(-)

Applied to dpdk-next-crypto

Subject changed to
baseband/acc100: detect deRM corner cases

Use only one verb in patch titles.