Skip to contentSkip to conversation

net: ethernet: Simplify bool conversion

PATCH In review Yang Li 2 participants 2 messages Nov 4, 2022

Subsystems (4)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v3 1/1 net: ethernet: Simplify bool conversion

The result of 'scaled_ppm < 0' is Boolean, and the question mark expression is redundant, remove it to clear the below warning:

./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here

---

change in v3:
--According to Richard's suggestion, to preserve reverse Christmas tree order.

 drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/renesas/rcar_gen4_ptp.c +1 -1
index c007e33c47e1..0dc80f6bbf94 100644
@@ -29,8 +29,8 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
 static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
 {
 	struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
-	bool neg_adj = scaled_ppm < 0 ? true : false;
 	s64 addend = ptp_priv->default_addend;
+	bool neg_adj = scaled_ppm < 0;
 	s64 diff;
 
 	if (neg_adj)
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 5 lines · Yang Li

The result of 'scaled_ppm < 0' is Boolean, and the question mark expression is redundant, remove it to clear the below warning:

./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here

Quoted 7 lines

---

change in v3:
--According to Richard's suggestion, to preserve reverse Christmas tree order.

Don't send a new version of a patch for at least 24 hours.

https://docs.kernel.org/process/maintainer-netdev.html#tl-dr

People need time to review your patch and suggest how to make it better.

Andrew