Skip to contentSkip to conversation

ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC

PATCH Superseded Quan Nguyen 2 participants 4 messages Nov 7, 2022 – Dec 7, 2022 Arm (32-bit)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
 arch/arm/dts/Makefile               |   1 +
 arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)
 create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts
arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2600-dcscm.dtb \
 	ast2600-fpga.dtb \
 	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
 	ast2600-ncsi.dtb \
 	ast2600-p10bmc.dtb \
 	ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0

114 lines not on this page · raw message

Signature · 1 line
2.35.1
#1 lore raw

Just a gentle ping on the patch.
Thanks
- Quan

Quoted 142 lines · Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
  arch/arm/dts/Makefile               |   1 +
  arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
  2 files changed, 115 insertions(+)

create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
  	ast2600-dcscm.dtb \
  	ast2600-fpga.dtb \
  	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
  	ast2600-ncsi.dtb \
  	ast2600-p10bmc.dtb \
  	ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0
new file mode 100644
index 0000000000..69ed0c5fbc
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "Ampere Mt.Mitchell BMC";
+	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+	};
+
+	aliases {
+		spi0 = &fmc;
+		ethernet0 = &mac0;
+	};
+
+	cpus {
+		cpu@0 {
+			clock-frequency = <800000000>;
+		};
+		cpu@1 {
+			clock-frequency = <800000000>;
+		};
+	};
+};
+
+&uart5 {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&sdrammc {
+	clock-frequency = <400000000>;
+};
+
+&wdt1 {
+	status = "okay";
+};
+
+&wdt2 {
+	status = "okay";
+};
+
+&wdt3 {
+	status = "okay";
+};
+
+&mdio {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <	&pinctrl_mdio1_default &pinctrl_mdio2_default
+			&pinctrl_mdio3_default &pinctrl_mdio4_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+	flash@0 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+
+	flash@1 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+};
+
+&scu {
+	mac0-clk-delay = <0x10 0x0a
+			  0x10 0x10
+			  0x10 0x10>;
+};
+
+&hace {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&acry {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
#2 lore raw

Dear maintainers,

Just for a another gentle ping on the patch.

Thanks
- Quan

Quoted 147 lines · Quan Nguyen

Just a gentle ping on the patch.
Thanks
- Quan

Quoted 142 lines · Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
  arch/arm/dts/Makefile               |   1 + arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++

  2 files changed, 115 insertions(+)

  create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
       ast2600-dcscm.dtb \
       ast2600-fpga.dtb \
       ast2600-intel.dtb \
+    ast2600-mtmitchell.dtb \
       ast2600-ncsi.dtb \
       ast2600-p10bmc.dtb \
       ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0
new file mode 100644
index 0000000000..69ed0c5fbc
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+    model = "Ampere Mt.Mitchell BMC";
+    compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+    memory {
+        device_type = "memory";
+        reg = <0x80000000 0x40000000>;
+    };
+
+    chosen {
+        stdout-path = &uart5;
+    };
+
+    aliases {
+        spi0 = &fmc;
+        ethernet0 = &mac0;
+    };
+
+    cpus {
+        cpu@0 {
+            clock-frequency = <800000000>;
+        };
+        cpu@1 {
+            clock-frequency = <800000000>;
+        };
+    };
+};
+
+&uart5 {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};
+
+&sdrammc {
+    clock-frequency = <400000000>;
+};
+
+&wdt1 {
+    status = "okay";
+};
+
+&wdt2 {
+    status = "okay";
+};
+
+&wdt3 {
+    status = "okay";
+};
+
+&mdio {
+    status = "okay";
+    pinctrl-names = "default";
+    pinctrl-0 = <    &pinctrl_mdio1_default &pinctrl_mdio2_default
+            &pinctrl_mdio3_default &pinctrl_mdio4_default>;
+    #address-cells = <1>;
+    #size-cells = <0>;
+    ethphy0: ethernet-phy@0 {
+        reg = <0>;
+    };
+};
+
+&mac0 {
+    status = "okay";
+    phy-mode = "rgmii-rxid";
+    phy-handle = <&ethphy0>;
+    pinctrl-names = "default";
+    pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+    status = "okay";
+
+    pinctrl-names = "default";
+    pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+    flash@0 {
+        compatible = "spi-flash", "sst,w25q256";
+        status = "okay";
+        spi-max-frequency = <50000000>;
+        spi-tx-bus-width = <4>;
+        spi-rx-bus-width = <4>;
+    };
+
+    flash@1 {
+        compatible = "spi-flash", "sst,w25q256";
+        status = "okay";
+        spi-max-frequency = <50000000>;
+        spi-tx-bus-width = <4>;
+        spi-rx-bus-width = <4>;
+    };
+};
+
+&scu {
+    mac0-clk-delay = <0x10 0x0a
+              0x10 0x10
+              0x10 0x10>;
+};
+
+&hace {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};
+
+&acry {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};
Reviewed-by on v1 1/1
#3 lore raw
In reply to Quan Nguyen
Quoted 78 lines · Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++

2 files changed, 115 insertions(+)

create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2600-dcscm.dtb \
 	ast2600-fpga.dtb \
 	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
 	ast2600-ncsi.dtb \
 	ast2600-p10bmc.dtb \
 	ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +50 -0
new file mode 100644
index 0000000000..69ed0c5fbc
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "Ampere Mt.Mitchell BMC";
+	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+	};
+
+	aliases {
+		spi0 = &fmc;
+		ethernet0 = &mac0;
+	};
+
+	cpus {
+		cpu@0 {
+			clock-frequency = <800000000>;
+		};
+		cpu@1 {
+			clock-frequency = <800000000>;
+		};
+	};
+};
+
+&uart5 {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&sdrammc {
+	clock-frequency = <400000000>;
+};
+
+&wdt1 {
+	status = "okay";
+};
+
+&wdt2 {
+	status = "okay";

arch/arm/dts/ast2600-mtmitchell.dts line 60

Quoted 10 lines
arch/arm/dts/ast2600-mtmitchell.dts new file +10 -0
+};
+
+&wdt3 {
+	status = "okay";
+};
+
+&mdio {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <	&pinctrl_mdio1_default &pinctrl_mdio2_default

Not sure if there are any particular official style rules that apply here, but the gap between the '<' and the first item looks a bit weird IMO.

Aside from that small nit,

Quoted 57 lines
arch/arm/dts/ast2600-mtmitchell.dts new file +54 -0
+			&pinctrl_mdio3_default &pinctrl_mdio4_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+	flash@0 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+
+	flash@1 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+};
+
+&scu {
+	mac0-clk-delay = <0x10 0x0a
+			  0x10 0x10
+			  0x10 0x10>;
+};
+
+&hace {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&acry {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
Signature · 1 line
2.35.1