Skip to contentSkip to conversation

ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC

PATCH In review Quan Nguyen 1 participant 3 messages Dec 8, 2022 – Jan 30, 2023 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
v2:
- Fix tab issue [Zev Weiss]

---
 arch/arm/dts/Makefile               |   1 +
 arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)
 create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts
arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2600-dcscm.dtb \
 	ast2600-fpga.dtb \
 	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
 	ast2600-ncsi.dtb \
 	ast2600-p10bmc.dtb \
 	ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0

114 lines not on this page · raw message

Signature · 1 line
2.35.1
#1 lore raw

Just a gentle ping on the patch.
Thank you and Happy New Year,
- Quan

Quoted 146 lines · Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
v2:
- Fix tab issue [Zev Weiss]

---
  arch/arm/dts/Makefile               |   1 +
  arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
  2 files changed, 115 insertions(+)

create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
  	ast2600-dcscm.dtb \
  	ast2600-fpga.dtb \
  	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
  	ast2600-ncsi.dtb \
  	ast2600-p10bmc.dtb \
  	ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0
new file mode 100644
index 0000000000..ad95be43da
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "Ampere Mt.Mitchell BMC";
+	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+	};
+
+	aliases {
+		spi0 = &fmc;
+		ethernet0 = &mac0;
+	};
+
+	cpus {
+		cpu@0 {
+			clock-frequency = <800000000>;
+		};
+		cpu@1 {
+			clock-frequency = <800000000>;
+		};
+	};
+};
+
+&uart5 {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&sdrammc {
+	clock-frequency = <400000000>;
+};
+
+&wdt1 {
+	status = "okay";
+};
+
+&wdt2 {
+	status = "okay";
+};
+
+&wdt3 {
+	status = "okay";
+};
+
+&mdio {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_mdio1_default &pinctrl_mdio2_default
+		     &pinctrl_mdio3_default &pinctrl_mdio4_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+	flash@0 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+
+	flash@1 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+};
+
+&scu {
+	mac0-clk-delay = <0x10 0x0a
+			  0x10 0x10
+			  0x10 0x10>;
+};
+
+&hace {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&acry {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
#2 lore raw

Dear reviewers,

Thank you a lot for the reviews and comments so far on the patch.
In fact, I'm still scratching my head and confused if this patch still needs some improvement or I just need to wait for it to get merged?

Thank you,
- Quan

Quoted 151 lines · Quan Nguyen

Just a gentle ping on the patch.
Thank you and Happy New Year,
- Quan

Quoted 146 lines · Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell BMC found on AmpereOne's reference platform.

---
v2:
- Fix tab issue                                        [Zev Weiss]
---
  arch/arm/dts/Makefile               |   1 + arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++

  2 files changed, 115 insertions(+)

  create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

arch/arm/dts/Makefile +1 -0
index 6c34b83336..b6f9df21fc 100755
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
       ast2600-dcscm.dtb \
       ast2600-fpga.dtb \
       ast2600-intel.dtb \
+    ast2600-mtmitchell.dtb \
       ast2600-ncsi.dtb \
       ast2600-p10bmc.dtb \
       ast2600-pfr.dtb \
arch/arm/dts/ast2600-mtmitchell.dts new file +114 -0
new file mode 100644
index 0000000000..ad95be43da
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+    model = "Ampere Mt.Mitchell BMC";
+    compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+    memory {
+        device_type = "memory";
+        reg = <0x80000000 0x40000000>;
+    };
+
+    chosen {
+        stdout-path = &uart5;
+    };
+
+    aliases {
+        spi0 = &fmc;
+        ethernet0 = &mac0;
+    };
+
+    cpus {
+        cpu@0 {
+            clock-frequency = <800000000>;
+        };
+        cpu@1 {
+            clock-frequency = <800000000>;
+        };
+    };
+};
+
+&uart5 {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};
+
+&sdrammc {
+    clock-frequency = <400000000>;
+};
+
+&wdt1 {
+    status = "okay";
+};
+
+&wdt2 {
+    status = "okay";
+};
+
+&wdt3 {
+    status = "okay";
+};
+
+&mdio {
+    status = "okay";
+    pinctrl-names = "default";
+    pinctrl-0 = <&pinctrl_mdio1_default &pinctrl_mdio2_default
+             &pinctrl_mdio3_default &pinctrl_mdio4_default>;
+    #address-cells = <1>;
+    #size-cells = <0>;
+    ethphy0: ethernet-phy@0 {
+        reg = <0>;
+    };
+};
+
+&mac0 {
+    status = "okay";
+    phy-mode = "rgmii-rxid";
+    phy-handle = <&ethphy0>;
+    pinctrl-names = "default";
+    pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+    status = "okay";
+
+    pinctrl-names = "default";
+    pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+    flash@0 {
+        compatible = "spi-flash", "sst,w25q256";
+        status = "okay";
+        spi-max-frequency = <50000000>;
+        spi-tx-bus-width = <4>;
+        spi-rx-bus-width = <4>;
+    };
+
+    flash@1 {
+        compatible = "spi-flash", "sst,w25q256";
+        status = "okay";
+        spi-max-frequency = <50000000>;
+        spi-tx-bus-width = <4>;
+        spi-rx-bus-width = <4>;
+    };
+};
+
+&scu {
+    mac0-clk-delay = <0x10 0x0a
+              0x10 0x10
+              0x10 0x10>;
+};
+
+&hace {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};
+
+&acry {
+    u-boot,dm-pre-reloc;
+    status = "okay";
+};