Skip to contentSkip to conversation

msc_sm2s_imx8mp: Convert to CONFIG_TEXT_BASE

PATCH In review Fabio Estevam 3 participants 3 messages Nov 8, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 msc_sm2s_imx8mp: Convert to CONFIG_TEXT_BASE

From: Fabio Estevam <[email protected]>

The conversion to CONFIG_TEXT_BASE was missed here.

Convert it to fix a build error in CI.

---
Stefano,

This is against u-boot-imx, master-next branch.

If you prefer to squash with the original commit, feel free to do it.

 configs/msc_sm2s_imx8mp_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/msc_sm2s_imx8mp_defconfig +1 -1
index a4f39061ae62..6691eb312fe5 100644
@@ -1,6 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_IMX8M=y
-CONFIG_SYS_TEXT_BASE=0x40200000
+CONFIG_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SPL_GPIO=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
Signature · 1 line
2.25.1
#1 lore raw

Hi Fabio,

Quoted 22 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The conversion to CONFIG_TEXT_BASE was missed here.

Convert it to fix a build error in CI.

---
Stefano,

This is against u-boot-imx, master-next branch.

If you prefer to squash with the original commit, feel free to do it.

  configs/msc_sm2s_imx8mp_defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configs/msc_sm2s_imx8mp_defconfig +0 -0
index a4f39061ae62..6691eb312fe5 100644

configs/msc_sm2s_imx8mp_defconfig line 6

Quoted 7 lines
configs/msc_sm2s_imx8mp_defconfig +1 -1
@@ -1,6 +1,6 @@
  CONFIG_ARM=y
  CONFIG_ARCH_IMX8M=y
-CONFIG_SYS_TEXT_BASE=0x40200000
+CONFIG_TEXT_BASE=0x40200000
  CONFIG_SYS_MALLOC_LEN=0x2000000
  CONFIG_SPL_GPIO=y
  CONFIG_SPL_LIBCOMMON_SUPPORT=y

Thanks. I will first run a pipeline, but it makes sense that I squash this with Martyn's v5-5-5-arm-imx8mp-Initial-MSC-SM2S-iMX8MP-support, by adding Fabio's Signed-off. @Martyn, is it okay for you ?

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#2 lore raw
Quoted 32 lines · Stefano Babic

Hi Fabio,

Quoted 29 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The conversion to CONFIG_TEXT_BASE was missed here.

Convert it to fix a build error in CI.

---
Stefano,

This is against u-boot-imx, master-next branch.

If you prefer to squash with the original commit, feel free to do it.

  configs/msc_sm2s_imx8mp_defconfig | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
configs/msc_sm2s_imx8mp_defconfig +0 -0
index a4f39061ae62..6691eb312fe5 100644
@@ -1,6 +1,6 @@

  CONFIG_ARM=y
  CONFIG_ARCH_IMX8M=y

configs/msc_sm2s_imx8mp_defconfig +1 -1
-CONFIG_SYS_TEXT_BASE=0x40200000
+CONFIG_TEXT_BASE=0x40200000

  CONFIG_SYS_MALLOC_LEN=0x2000000

Quoted 9 lines
Quoted 2 lines

  CONFIG_SPL_GPIO=y
  CONFIG_SPL_LIBCOMMON_SUPPORT=y

Thanks. I will first run a pipeline, but it makes sense that I squash this with Martyn's v5-5-5-arm-imx8mp-Initial-MSC-SM2S-iMX8MP-support, by
adding Fabio's Signed-off. @Martyn, is it okay for you ?

That's fine with me!

Quoted 3 lines

Regards,
Stefano