RISC-V KVM ONE_REG interface for SBI
Subsystems (3)
cover RISC-V KVM ONE_REG interface for SBI
This series does first does few cleanups/fixes (PATCH1 to PATCH5) and adds ONE-REG interface for customizing the SBI interface visible to the Guest/VM.
The testing of this series has been done with KVMTOOL changes in riscv_sbi_imp_v1 branch at:
https://github.com/avpatel/kvmtool.git
These patches can also be found in the riscv_kvm_sbi_imp_v1 branch at:
https://github.com/avpatel/linux.git
Anup Patel (9):
RISC-V: KVM: Fix reg_val check in kvm_riscv_vcpu_set_reg_config()
RISC-V: KVM: Remove redundant includes of asm/kvm_vcpu_timer.h
RISC-V: KVM: Remove redundant includes of asm/csr.h
RISC-V: KVM: Use switch-case in kvm_riscv_vcpu_set/get_reg()
RISC-V: KVM: Move sbi related struct and functions to kvm_vcpu_sbi.h
RISC-V: Export sbi_get_mvendorid() and friends
RISC-V: KVM: Save mvendorid, marchid, and mimpid when creating VCPU
RISC-V: KVM: Add ONE_REG interface for mvendorid, marchid, and mimpid
RISC-V: KVM: Add ONE_REG interface to enable/disable SBI extensions
arch/riscv/include/asm/kvm_host.h | 16 ++- arch/riscv/include/asm/kvm_vcpu_sbi.h | 14 ++- arch/riscv/include/uapi/asm/kvm.h | 22 ++++ arch/riscv/kernel/sbi.c | 3 + arch/riscv/kvm/vcpu.c | 82 +++++++++++---- arch/riscv/kvm/vcpu_sbi.c | 145 +++++++++++++++++++++++--- arch/riscv/kvm/vcpu_sbi_base.c | 15 ++- arch/riscv/kvm/vcpu_sbi_hsm.c | 1 - arch/riscv/kvm/vcpu_sbi_replace.c | 1 - arch/riscv/kvm/vcpu_sbi_v01.c | 1 - 10 files changed, 244 insertions(+), 56 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/9 RISC-V: KVM: Fix reg_val check in kvm_riscv_vcpu_set_reg_config()
The reg_val check in kvm_riscv_vcpu_set_reg_config() should only be done for isa config register.
--- arch/riscv/kvm/vcpu.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
arch/riscv/kvm/vcpu.c +7 -4
@@ -296,12 +296,15 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,if (copy_from_user (®_val, uaddr,KVM_REG_SIZE (reg->id)))return -EFAULT ; -/* This ONE REG interface is only defined for single letter extensions */ -if (fls (reg_val) >=RISCV_ISA_EXT_BASE ) -return -EINVAL ; -switch (reg_num) {case KVM_REG_RISCV_CONFIG_REG (isa): +/* +* This ONE REG interface is only defined for +* single letter extensions. +*/ +if (fls (reg_val) >=RISCV_ISA_EXT_BASE ) +return -EINVAL ; +if (!vcpu->arch.ran_atleast_once) {/* Ignore the enable/disable request for certain extensions */ for (i =0 ; i <RISCV_ISA_EXT_BASE ; i++) {
Signature · 1 line
2.34.1
PATCH 2/9 RISC-V: KVM: Remove redundant includes of asm/kvm_vcpu_timer.h
In reply to Anup PatelThe asm/kvm_vcpu_timer.h is redundantly included in vcpu_sbi_base.c so let us remove it.
--- arch/riscv/kvm/vcpu_sbi_base.c | 1 - 1 file changed, 1 deletion(-)
arch/riscv/kvm/vcpu_sbi_base.c +0 -1
@@ -12,7 +12,6 @@#include <linux/version.h> #include <asm/csr.h> #include <asm/sbi.h> -#include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h> static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run,
Signature · 1 line
2.34.1
PATCH 3/9 RISC-V: KVM: Remove redundant includes of asm/csr.h
In reply to Anup PatelWe should include asm/csr.h only where required so let us remove redundant includes of this header.
--- arch/riscv/include/asm/kvm_host.h | 1 - arch/riscv/kvm/vcpu_sbi_base.c | 1 - arch/riscv/kvm/vcpu_sbi_hsm.c | 1 - arch/riscv/kvm/vcpu_sbi_replace.c | 1 - arch/riscv/kvm/vcpu_sbi_v01.c | 1 - 5 files changed, 5 deletions(-)
arch/riscv/include/asm/kvm_host.h +0 -1
@@ -13,7 +13,6 @@#include <linux/kvm.h> #include <linux/kvm_types.h> #include <linux/spinlock.h> -#include <asm/csr.h> #include <asm/hwcap.h> #include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h>
arch/riscv/kvm/vcpu_sbi_base.c +0 -1
@@ -10,7 +10,6 @@#include <linux/err.h> #include <linux/kvm_host.h> #include <linux/version.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_sbi.h>
arch/riscv/kvm/vcpu_sbi_hsm.c +0 -1
@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_sbi.h>
arch/riscv/kvm/vcpu_sbi_replace.c +0 -1
@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h>
arch/riscv/kvm/vcpu_sbi_v01.c +0 -1
@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h>
Signature · 1 line
2.34.1
PATCH 4/9 RISC-V: KVM: Use switch-case in kvm_riscv_vcpu_set/get_reg()
In reply to Anup PatelWe should use switch-case in kvm_riscv_vcpu_set/get_reg() functions because the else-if ladder is quite big now.
--- arch/riscv/kvm/vcpu.c | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-)
arch/riscv/kvm/vcpu.c +22 -14
@@ -544,22 +544,26 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,static int kvm_riscv_vcpu_set_reg (struct kvm_vcpu *vcpu,const struct kvm_one_reg *reg) { -if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CONFIG ) +switch (reg->id &KVM_REG_RISCV_TYPE_MASK ) { +case KVM_REG_RISCV_CONFIG :return kvm_riscv_vcpu_set_reg_config (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CORE ) +case KVM_REG_RISCV_CORE :return kvm_riscv_vcpu_set_reg_core (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CSR ) +case KVM_REG_RISCV_CSR :return kvm_riscv_vcpu_set_reg_csr (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_TIMER ) +case KVM_REG_RISCV_TIMER :return kvm_riscv_vcpu_set_reg_timer (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_F ) +case KVM_REG_RISCV_FP_F :return kvm_riscv_vcpu_set_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_F ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_D ) +case KVM_REG_RISCV_FP_D :return kvm_riscv_vcpu_set_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_D ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_ISA_EXT ) +case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_set_reg_isa_ext (vcpu, reg); +default : +break ; + }return -EINVAL ; }
@@ -567,22 +571,26 @@ static int kvm_riscv_vcpu_set_reg(struct kvm_vcpu *vcpu,static int kvm_riscv_vcpu_get_reg (struct kvm_vcpu *vcpu,const struct kvm_one_reg *reg) { -if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CONFIG ) +switch (reg->id &KVM_REG_RISCV_TYPE_MASK ) { +case KVM_REG_RISCV_CONFIG :return kvm_riscv_vcpu_get_reg_config (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CORE ) +case KVM_REG_RISCV_CORE :return kvm_riscv_vcpu_get_reg_core (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CSR ) +case KVM_REG_RISCV_CSR :return kvm_riscv_vcpu_get_reg_csr (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_TIMER ) +case KVM_REG_RISCV_TIMER :return kvm_riscv_vcpu_get_reg_timer (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_F ) +case KVM_REG_RISCV_FP_F :return kvm_riscv_vcpu_get_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_F ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_D ) +case KVM_REG_RISCV_FP_D :return kvm_riscv_vcpu_get_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_D ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_ISA_EXT ) +case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_get_reg_isa_ext (vcpu, reg); +default : +break ; + }return -EINVAL ; }
Signature · 1 line
2.34.1
PATCH 5/9 RISC-V: KVM: Move sbi related struct and functions to kvm_vcpu_sbi.h
In reply to Anup PatelJust like asm/kvm_vcpu_timer.h, we should have all sbi related struct and functions in asm/kvm_vcpu_sbi.h.
--- arch/riscv/include/asm/kvm_host.h | 10 ++-------- arch/riscv/include/asm/kvm_vcpu_sbi.h | 6 ++++++ 2 files changed, 8 insertions(+), 8 deletions(-)
arch/riscv/include/asm/kvm_host.h +2 -8
@@ -16,6 +16,7 @@#include <asm/hwcap.h> #include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h> +#include <asm/kvm_vcpu_sbi.h> #include <asm/kvm_vcpu_timer.h> #define KVM_MAX_VCPUS 1024
@@ -94,10 +95,6 @@ struct kvm_arch {struct kvm_guest_timer timer; }; -struct kvm_sbi_context { -int return_handled; -}; -struct kvm_cpu_trap {unsigned long sepc;unsigned long scause;
@@ -216,7 +213,7 @@ struct kvm_vcpu_arch {struct kvm_csr_decode csr_decode;/* SBI context */ -struct kvm_sbi_context sbi_context; +struct kvm_vcpu_sbi_context sbi_context;/* Cache pages needed to program page tables with spinlock held */ struct kvm_mmu_memory_cache mmu_page_cache;
@@ -326,7 +323,4 @@ bool kvm_riscv_vcpu_has_interrupts(struct kvm_vcpu *vcpu, unsigned long mask);void kvm_riscv_vcpu_power_off (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_power_on (struct kvm_vcpu *vcpu); -int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run); -int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run); -#endif /* __RISCV_KVM_HOST_H__ */
arch/riscv/include/asm/kvm_vcpu_sbi.h +6 -0
@@ -14,6 +14,10 @@#define KVM_SBI_VERSION_MAJOR 1#define KVM_SBI_VERSION_MINOR 0 +struct kvm_vcpu_sbi_context { +int return_handled; +}; +struct kvm_vcpu_sbi_extension {unsigned long extid_start;unsigned long extid_end;
@@ -31,7 +35,9 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run);void kvm_riscv_vcpu_sbi_system_reset (struct kvm_vcpu *vcpu,struct kvm_run *run,u32 type,u64 flags); +int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run);const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext (unsigned long extid); +int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);#ifdef CONFIG_RISCV_SBI_V01 extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_v01;
Signature · 1 line
2.34.1
PATCH 6/9 RISC-V: Export sbi_get_mvendorid() and friends
In reply to Anup PatelThe sbi_get_mvendorid(), sbi_get_marchid(), and sbi_get_mimpid() can be used by KVM module so let us export these functions.
--- arch/riscv/kernel/sbi.c | 3 +++ 1 file changed, 3 insertions(+)
arch/riscv/kernel/sbi.c +3 -0
@@ -627,16 +627,19 @@ long sbi_get_mvendorid(void) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MVENDORID ); } +EXPORT_SYMBOL_GPL (sbi_get_mvendorid);long sbi_get_marchid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MARCHID ); } +EXPORT_SYMBOL_GPL (sbi_get_marchid);long sbi_get_mimpid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MIMPID ); } +EXPORT_SYMBOL_GPL (sbi_get_mimpid);static void sbi_send_cpumask_ipi (const struct cpumask *target) {
Signature · 1 line
2.34.1
PATCH 7/9 RISC-V: KVM: Save mvendorid, marchid, and mimpid when creating VCPU
In reply to Anup PatelWe should save VCPU mvendorid, marchid, and mimpid at the time of creating VCPU so that we don't have to do host SBI call every time Guest/VM ask for these details.
--- arch/riscv/include/asm/kvm_host.h | 5 +++++ arch/riscv/kvm/vcpu.c | 6 ++++++ arch/riscv/kvm/vcpu_sbi_base.c | 11 +++++------ 3 files changed, 16 insertions(+), 6 deletions(-)
arch/riscv/include/asm/kvm_host.h +5 -0
@@ -165,6 +165,11 @@ struct kvm_vcpu_arch {/* ISA feature bits (similar to MISA) */ DECLARE_BITMAP (isa,RISCV_ISA_EXT_MAX ); +/* Vendor, Arch, and Implementation details */ +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; +/* SSCRATCH, STVEC, and SCOUNTEREN of Host */ unsigned long host_sscratch;unsigned long host_stvec;
arch/riscv/kvm/vcpu.c +6 -0
@@ -21,6 +21,7 @@#include <asm/csr.h> #include <asm/cacheflush.h> #include <asm/hwcap.h> +#include <asm/sbi.h> const struct _kvm_stats_desc kvm_vcpu_stats_desc[] = {KVM_GENERIC_VCPU_STATS (),
@@ -171,6 +172,11 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)set_bit (host_isa, vcpu->arch.isa); } +/* Setup vendor, arch, and implementation details */ + vcpu->arch.mvendorid =sbi_get_mvendorid (); + vcpu->arch.marchid =sbi_get_marchid (); + vcpu->arch.mimpid =sbi_get_mimpid (); +/* Setup VCPU hfence queue */ spin_lock_init (&vcpu->arch.hfence_lock);
arch/riscv/kvm/vcpu_sbi_base.c +5 -6
@@ -19,7 +19,6 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, {int ret =0 ;struct kvm_cpu_context *cp = &vcpu->arch.guest_context; -struct sbiret ecall_ret;switch (cp->a6) {case SBI_EXT_BASE_GET_SPEC_VERSION :
@@ -48,13 +47,13 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, *out_val =kvm_vcpu_sbi_find_ext (cp->a0) ?1 :0 ;break ;case SBI_EXT_BASE_GET_MVENDORID : + *out_val = vcpu->arch.mvendorid; +break ;case SBI_EXT_BASE_GET_MARCHID : + *out_val = vcpu->arch.marchid; +break ;case SBI_EXT_BASE_GET_MIMPID : - ecall_ret =sbi_ecall (SBI_EXT_BASE , cp->a6,0 ,0 ,0 ,0 ,0 ,0 ); -if (!ecall_ret.error) - *out_val = ecall_ret.value; -/*TODO: We are unnecessarily converting the error twice */ - ret =sbi_err_map_linux_errno (ecall_ret.error); + *out_val = vcpu->arch.mimpid;break ;default : ret = -EOPNOTSUPP ;
Signature · 1 line
2.34.1
PATCH 8/9 RISC-V: KVM: Add ONE_REG interface for mvendorid, marchid, and mimpid
In reply to Anup PatelWe add ONE_REG interface for VCPU mvendorid, marchid, and mimpid so that KVM user-space can change this details to support migration across heterogeneous hosts.
--- arch/riscv/include/uapi/asm/kvm.h | 3 +++ arch/riscv/kvm/vcpu.c | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+)
arch/riscv/include/uapi/asm/kvm.h +3 -0
@@ -49,6 +49,9 @@ struct kvm_sregs {struct kvm_riscv_config {unsigned long isa;unsigned long zicbom_block_size; +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; };/* CORE registers for KVM_GET_ONE_REG and KVM_SET_ONE_REG */
arch/riscv/kvm/vcpu.c +27 -0
@@ -276,6 +276,15 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,return -EINVAL ; reg_val = riscv_cbom_block_size;break ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): + reg_val = vcpu->arch.mvendorid; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): + reg_val = vcpu->arch.marchid; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): + reg_val = vcpu->arch.mimpid; +break ;default :return -EINVAL ; }
@@ -338,6 +347,24 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,break ;case KVM_REG_RISCV_CONFIG_REG (zicbom_block_size):return -EOPNOTSUPP ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mvendorid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.marchid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mimpid = reg_val; +else +return -EBUSY ; +break ;default :return -EINVAL ; }
Signature · 1 line
2.34.1
PATCH 9/9 RISC-V: KVM: Add ONE_REG interface to enable/disable SBI extensions
In reply to Anup PatelWe add ONE_REG interface to enable/disable SBI extensions (just like the ONE_REG interface for ISA extensions). This allows KVM user-space to decide the set of SBI extension enabled for a Guest and by default all SBI extensions are enabled.
--- arch/riscv/include/asm/kvm_vcpu_sbi.h | 8 +- arch/riscv/include/uapi/asm/kvm.h | 19 ++++ arch/riscv/kvm/vcpu.c | 2 + arch/riscv/kvm/vcpu_sbi.c | 145 +++++++++++++++++++++++--- arch/riscv/kvm/vcpu_sbi_base.c | 2 +- 5 files changed, 158 insertions(+), 18 deletions(-)
arch/riscv/include/asm/kvm_vcpu_sbi.h +7 -1
@@ -16,6 +16,7 @@struct kvm_vcpu_sbi_context {int return_handled; +bool extension_disabled[KVM_RISCV_SBI_EXT_MAX ]; };struct kvm_vcpu_sbi_extension {
@@ -36,7 +37,12 @@ void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,struct kvm_run *run, u32 type, u64 flags);int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run); -const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext (unsigned long extid); +int kvm_riscv_vcpu_set_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg); +int kvm_riscv_vcpu_get_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg); +const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext ( +struct kvm_vcpu *vcpu,unsigned long extid);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);#ifdef CONFIG_RISCV_SBI_V01
arch/riscv/include/uapi/asm/kvm.h +19 -0
@@ -108,6 +108,22 @@ enum KVM_RISCV_ISA_EXT_ID { KVM_RISCV_ISA_EXT_MAX, }; +/* +* SBI extension IDs specific to KVM. This is not the same as the SBI +* extension IDs defined by the RISC-V SBI specification. +*/ +enum KVM_RISCV_SBI_EXT_ID { +KVM_RISCV_SBI_EXT_V01 =0 , +KVM_RISCV_SBI_EXT_TIME , +KVM_RISCV_SBI_EXT_IPI , +KVM_RISCV_SBI_EXT_RFENCE , +KVM_RISCV_SBI_EXT_SRST , +KVM_RISCV_SBI_EXT_HSM , +KVM_RISCV_SBI_EXT_EXPERIMENTAL , +KVM_RISCV_SBI_EXT_VENDOR , +KVM_RISCV_SBI_EXT_MAX , +}; +/* Possible states for kvm_riscv_timer */ #define KVM_RISCV_TIMER_STATE_OFF 0#define KVM_RISCV_TIMER_STATE_ON 1
@@ -152,6 +168,9 @@ enum KVM_RISCV_ISA_EXT_ID {/* ISA Extension registers are mapped as type 7 */ #define KVM_REG_RISCV_ISA_EXT (0x07 << KVM_REG_RISCV_TYPE_SHIFT) +/* SBI extension registers are mapped as type 8 */ +#define KVM_REG_RISCV_SBI_EXT (0x08 << KVM_REG_RISCV_TYPE_SHIFT) +#endif #endif /* __LINUX_KVM_RISCV_H */
arch/riscv/kvm/vcpu.c +2 -0
@@ -594,6 +594,8 @@ static int kvm_riscv_vcpu_set_reg(struct kvm_vcpu *vcpu, KVM_REG_RISCV_FP_D);case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_set_reg_isa_ext (vcpu, reg); +case KVM_REG_RISCV_SBI_EXT : +return kvm_riscv_vcpu_set_reg_sbi_ext (vcpu, reg);default :break ; }
arch/riscv/kvm/vcpu_sbi.c +129 -16
166 lines not on this page · raw message
arch/riscv/kvm/vcpu_sbi_base.c +1 -1
@@ -44,7 +44,7 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run,kvm_riscv_vcpu_sbi_forward (vcpu, run); *exit = true; }else - *out_val =kvm_vcpu_sbi_find_ext (cp->a0) ?1 :0 ; + *out_val =kvm_vcpu_sbi_find_ext (vcpu, cp->a0) ?1 :0 ;break ;case SBI_EXT_BASE_GET_MVENDORID : *out_val = vcpu->arch.mvendorid;
Signature · 1 line
2.34.1
Re: [PATCH 1/9] RISC-V: KVM: Fix reg_val check in kvm_riscv_vcpu_set_reg_config()
In reply to Anup PatelQuoted 36 lines · Anup Patel
The
reg_valcheck inkvm_riscv_vcpu_set_reg_config()should only be done for isa config register.Fixes 9bfd900beeec ("RISC-V: KVM: Improve ISA extension by using a bitmap")Signed-off-by Anup Patel <[email protected]>Reviewed-by Andrew Jones <[email protected]>--- arch/riscv/kvm/vcpu.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)arch/riscv/kvm/vcpu.c +7
-5@@ -296,12 +296,15 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,if (copy_from_user (®_val, uaddr,KVM_REG_SIZE (reg->id)))return -EFAULT ; -/* This ONE REG interface is only defined for single letter extensions */ -if (fls (reg_val) >=RISCV_ISA_EXT_BASE ) -return -EINVAL ; -switch (reg_num) {case KVM_REG_RISCV_CONFIG_REG (isa): +/* +* This ONE REG interface is only defined for +* single letter extensions. +*/ +if (fls (reg_val) >=RISCV_ISA_EXT_BASE ) +return -EINVAL ; +if (!vcpu->arch.ran_atleast_once) {/* Ignore the enable/disable request for certain extensions */ for (i =0 ; i <RISCV_ISA_EXT_BASE ; i++) { --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 2/9] RISC-V: KVM: Remove redundant includes of asm/kvm_vcpu_timer.h
In reply to Anup PatelQuoted 22 lines · Anup Patel
The
asm/kvm_vcpu_timer.his redundantly included invcpu_sbi_base.cso let us remove it.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kvm/vcpu_sbi_base.c | 1 - 1 file changed, 1 deletion(-)arch/riscv/kvm/vcpu_sbi_base.c +0
-2@@ -12,7 +12,6 @@#include <linux/version.h> #include <asm/csr.h> #include <asm/sbi.h> -#include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h> static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 3/9] RISC-V: KVM: Remove redundant includes of asm/csr.h
In reply to Anup PatelQuoted 74 lines · Anup Patel
We should include
asm/csr.honly where required so let us remove redundant includes of this header.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 1 - arch/riscv/kvm/vcpu_sbi_base.c | 1 - arch/riscv/kvm/vcpu_sbi_hsm.c | 1 - arch/riscv/kvm/vcpu_sbi_replace.c | 1 - arch/riscv/kvm/vcpu_sbi_v01.c | 1 - 5 files changed, 5 deletions(-)arch/riscv/include/asm/kvm_host.h +0
-1@@ -13,7 +13,6 @@#include <linux/kvm.h> #include <linux/kvm_types.h> #include <linux/spinlock.h> -#include <asm/csr.h> #include <asm/hwcap.h> #include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h> arch/riscv/kvm/vcpu_sbi_base.c +0
-1@@ -10,7 +10,6 @@#include <linux/err.h> #include <linux/kvm_host.h> #include <linux/version.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_sbi.h> arch/riscv/kvm/vcpu_sbi_hsm.c +0
-1@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_sbi.h> arch/riscv/kvm/vcpu_sbi_replace.c +0
-1@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h> arch/riscv/kvm/vcpu_sbi_v01.c +0
-2@@ -9,7 +9,6 @@#include <linux/errno.h> #include <linux/err.h> #include <linux/kvm_host.h> -#include <asm/csr.h> #include <asm/sbi.h> #include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h> --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 4/9] RISC-V: KVM: Use switch-case in kvm_riscv_vcpu_set/get_reg()
In reply to Anup PatelQuoted 83 lines · Anup Patel
We should use switch-case in kvm_riscv_vcpu_set/get_reg() functions because the else-if ladder is quite big now.
Signed-off-by Anup Patel <[email protected]>Reviewed-by Andrew Jones <[email protected]>--- arch/riscv/kvm/vcpu.c | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-)arch/riscv/kvm/vcpu.c +22
-15@@ -544,22 +544,26 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,static int kvm_riscv_vcpu_set_reg (struct kvm_vcpu *vcpu,const struct kvm_one_reg *reg) { -if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CONFIG ) +switch (reg->id &KVM_REG_RISCV_TYPE_MASK ) { +case KVM_REG_RISCV_CONFIG :return kvm_riscv_vcpu_set_reg_config (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CORE ) +case KVM_REG_RISCV_CORE :return kvm_riscv_vcpu_set_reg_core (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CSR ) +case KVM_REG_RISCV_CSR :return kvm_riscv_vcpu_set_reg_csr (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_TIMER ) +case KVM_REG_RISCV_TIMER :return kvm_riscv_vcpu_set_reg_timer (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_F ) +case KVM_REG_RISCV_FP_F :return kvm_riscv_vcpu_set_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_F ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_D ) +case KVM_REG_RISCV_FP_D :return kvm_riscv_vcpu_set_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_D ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_ISA_EXT ) +case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_set_reg_isa_ext (vcpu, reg); +default : +break ; + }return -EINVAL ; }@@ -567,22 +571,26 @@ static int kvm_riscv_vcpu_set_reg(struct kvm_vcpu *vcpu,static int kvm_riscv_vcpu_get_reg (struct kvm_vcpu *vcpu,const struct kvm_one_reg *reg) { -if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CONFIG ) +switch (reg->id &KVM_REG_RISCV_TYPE_MASK ) { +case KVM_REG_RISCV_CONFIG :return kvm_riscv_vcpu_get_reg_config (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CORE ) +case KVM_REG_RISCV_CORE :return kvm_riscv_vcpu_get_reg_core (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_CSR ) +case KVM_REG_RISCV_CSR :return kvm_riscv_vcpu_get_reg_csr (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_TIMER ) +case KVM_REG_RISCV_TIMER :return kvm_riscv_vcpu_get_reg_timer (vcpu, reg); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_F ) +case KVM_REG_RISCV_FP_F :return kvm_riscv_vcpu_get_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_F ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_FP_D ) +case KVM_REG_RISCV_FP_D :return kvm_riscv_vcpu_get_reg_fp (vcpu, reg,KVM_REG_RISCV_FP_D ); -else if ((reg->id &KVM_REG_RISCV_TYPE_MASK ) ==KVM_REG_RISCV_ISA_EXT ) +case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_get_reg_isa_ext (vcpu, reg); +default : +break ; + }return -EINVAL ; } --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 5/9] RISC-V: KVM: Move sbi related struct and functions to kvm_vcpu_sbi.h
In reply to Anup PatelQuoted 76 lines · Anup Patel
Just like
asm/kvm_vcpu_timer.h, we should have all sbi related struct and functions inasm/kvm_vcpu_sbi.h.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 10 ++-------- arch/riscv/include/asm/kvm_vcpu_sbi.h | 6 ++++++ 2 files changed, 8 insertions(+), 8 deletions(-)arch/riscv/include/asm/kvm_host.h +2
-8@@ -16,6 +16,7 @@#include <asm/hwcap.h> #include <asm/kvm_vcpu_fp.h> #include <asm/kvm_vcpu_insn.h> +#include <asm/kvm_vcpu_sbi.h> #include <asm/kvm_vcpu_timer.h> #define KVM_MAX_VCPUS 1024@@ -94,10 +95,6 @@ struct kvm_arch {struct kvm_guest_timer timer; }; -struct kvm_sbi_context { -int return_handled; -}; -struct kvm_cpu_trap {unsigned long sepc;unsigned long scause;@@ -216,7 +213,7 @@ struct kvm_vcpu_arch {struct kvm_csr_decode csr_decode;/* SBI context */ -struct kvm_sbi_context sbi_context; +struct kvm_vcpu_sbi_context sbi_context;/* Cache pages needed to program page tables with spinlock held */ struct kvm_mmu_memory_cache mmu_page_cache;@@ -326,7 +323,4 @@ bool kvm_riscv_vcpu_has_interrupts(struct kvm_vcpu *vcpu, unsigned long mask);void kvm_riscv_vcpu_power_off (struct kvm_vcpu *vcpu);void kvm_riscv_vcpu_power_on (struct kvm_vcpu *vcpu); -int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run); -int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run); -#endif /* __RISCV_KVM_HOST_H__ */ arch/riscv/include/asm/kvm_vcpu_sbi.h +6
-1@@ -14,6 +14,10 @@#define KVM_SBI_VERSION_MAJOR 1#define KVM_SBI_VERSION_MINOR 0 +struct kvm_vcpu_sbi_context { +int return_handled; +}; +struct kvm_vcpu_sbi_extension {unsigned long extid_start;unsigned long extid_end;@@ -31,7 +35,9 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run);void kvm_riscv_vcpu_sbi_system_reset (struct kvm_vcpu *vcpu,struct kvm_run *run,u32 type,u64 flags); +int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run);const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext (unsigned long extid); +int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);#ifdef CONFIG_RISCV_SBI_V01 extern const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_v01; --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 6/9] RISC-V: Export sbi_get_mvendorid() and friends
In reply to Anup PatelQuoted 34 lines · Anup Patel
The
sbi_get_mvendorid(),sbi_get_marchid(), andsbi_get_mimpid()can be used by KVM module so let us export these functions.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kernel/sbi.c | 3 +++ 1 file changed, 3 insertions(+)arch/riscv/kernel/sbi.c +3
-1@@ -627,16 +627,19 @@ long sbi_get_mvendorid(void) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MVENDORID ); } +EXPORT_SYMBOL_GPL (sbi_get_mvendorid);long sbi_get_marchid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MARCHID ); } +EXPORT_SYMBOL_GPL (sbi_get_marchid);long sbi_get_mimpid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MIMPID ); } +EXPORT_SYMBOL_GPL (sbi_get_mimpid);static void sbi_send_cpumask_ipi (const struct cpumask *target) { --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 7/9] RISC-V: KVM: Save mvendorid, marchid, and mimpid when creating VCPU
In reply to Anup PatelQuoted 84 lines · Anup Patel
We should save VCPU mvendorid, marchid, and mimpid at the time of creating VCPU so that we don't have to do host SBI call every time Guest/VM ask for these details.
Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 5 +++++ arch/riscv/kvm/vcpu.c | 6 ++++++ arch/riscv/kvm/vcpu_sbi_base.c | 11 +++++------ 3 files changed, 16 insertions(+), 6 deletions(-)arch/riscv/include/asm/kvm_host.h +5
-0@@ -165,6 +165,11 @@ struct kvm_vcpu_arch {/* ISA feature bits (similar to MISA) */ DECLARE_BITMAP (isa,RISCV_ISA_EXT_MAX ); +/* Vendor, Arch, and Implementation details */ +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; +/* SSCRATCH, STVEC, and SCOUNTEREN of Host */ unsigned long host_sscratch;unsigned long host_stvec;arch/riscv/kvm/vcpu.c +6
-0@@ -21,6 +21,7 @@#include <asm/csr.h> #include <asm/cacheflush.h> #include <asm/hwcap.h> +#include <asm/sbi.h> const struct _kvm_stats_desc kvm_vcpu_stats_desc[] = {KVM_GENERIC_VCPU_STATS (),@@ -171,6 +172,11 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)set_bit (host_isa, vcpu->arch.isa); } +/* Setup vendor, arch, and implementation details */ + vcpu->arch.mvendorid =sbi_get_mvendorid (); + vcpu->arch.marchid =sbi_get_marchid (); + vcpu->arch.mimpid =sbi_get_mimpid (); +/* Setup VCPU hfence queue */ spin_lock_init (&vcpu->arch.hfence_lock);arch/riscv/kvm/vcpu_sbi_base.c +5
-7@@ -19,7 +19,6 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, {int ret =0 ;struct kvm_cpu_context *cp = &vcpu->arch.guest_context; -struct sbiret ecall_ret;switch (cp->a6) {case SBI_EXT_BASE_GET_SPEC_VERSION :@@ -48,13 +47,13 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, *out_val =kvm_vcpu_sbi_find_ext (cp->a0) ?1 :0 ;break ;case SBI_EXT_BASE_GET_MVENDORID : + *out_val = vcpu->arch.mvendorid; +break ;case SBI_EXT_BASE_GET_MARCHID : + *out_val = vcpu->arch.marchid; +break ;case SBI_EXT_BASE_GET_MIMPID : - ecall_ret =sbi_ecall (SBI_EXT_BASE , cp->a6,0 ,0 ,0 ,0 ,0 ,0 ); -if (!ecall_ret.error) - *out_val = ecall_ret.value; -/*TODO: We are unnecessarily converting the error twice */ - ret =sbi_err_map_linux_errno (ecall_ret.error); + *out_val = vcpu->arch.mimpid;break ;default : ret = -EOPNOTSUPP ; --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 8/9] RISC-V: KVM: Add ONE_REG interface for mvendorid, marchid, and mimpid
In reply to Anup PatelQuoted 71 lines · Anup Patel
We add
ONE_REGinterface for VCPU mvendorid, marchid, and mimpid so that KVM user-space can change this details to support migration across heterogeneous hosts.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/uapi/asm/kvm.h | 3 +++ arch/riscv/kvm/vcpu.c | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+)arch/riscv/include/uapi/asm/kvm.h +3
-0@@ -49,6 +49,9 @@ struct kvm_sregs {struct kvm_riscv_config {unsigned long isa;unsigned long zicbom_block_size; +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; };/* CORE registers for KVM_GET_ONE_REG and KVM_SET_ONE_REG */ arch/riscv/kvm/vcpu.c +27
-1@@ -276,6 +276,15 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,return -EINVAL ; reg_val = riscv_cbom_block_size;break ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): + reg_val = vcpu->arch.mvendorid; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): + reg_val = vcpu->arch.marchid; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): + reg_val = vcpu->arch.mimpid; +break ;default :return -EINVAL ; }@@ -338,6 +347,24 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,break ;case KVM_REG_RISCV_CONFIG_REG (zicbom_block_size):return -EOPNOTSUPP ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mvendorid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.marchid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mimpid = reg_val; +else +return -EBUSY ; +break ;default :return -EINVAL ; } --
Quoted 2 lines
2.34.1
Signature · 2 lines
Regards, Atish
Re: [PATCH 2/9] RISC-V: KVM: Remove redundant includes of asm/kvm_vcpu_timer.h
In reply to Anup PatelQuoted 23 lines · Anup Patel
The
asm/kvm_vcpu_timer.his redundantly included invcpu_sbi_base.cso let us remove it.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kvm/vcpu_sbi_base.c | 1 - 1 file changed, 1 deletion(-)arch/riscv/kvm/vcpu_sbi_base.c +0
-1@@ -12,7 +12,6 @@#include <linux/version.h> #include <asm/csr.h> #include <asm/sbi.h> -#include <asm/kvm_vcpu_timer.h> #include <asm/kvm_vcpu_sbi.h> static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run,Signature · 1 line
2.34.1
Re: [PATCH 5/9] RISC-V: KVM: Move sbi related struct and functions to kvm_vcpu_sbi.h
In reply to Anup PatelQuoted 9 lines · Anup Patel
Just like
asm/kvm_vcpu_timer.h, we should have all sbi related struct and functions inasm/kvm_vcpu_sbi.h.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 10 ++-------- arch/riscv/include/asm/kvm_vcpu_sbi.h | 6 ++++++ 2 files changed, 8 insertions(+), 8 deletions(-)
Re: [PATCH 6/9] RISC-V: Export sbi_get_mvendorid() and friends
In reply to Anup PatelQuoted 8 lines · Anup Patel
The
sbi_get_mvendorid(),sbi_get_marchid(), andsbi_get_mimpid()can be used by KVM module so let us export these functions.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kernel/sbi.c | 3 +++ 1 file changed, 3 insertions(+)
Re: [PATCH 7/9] RISC-V: KVM: Save mvendorid, marchid, and mimpid when creating VCPU
In reply to Anup PatelQuoted 11 lines · Anup Patel
We should save VCPU mvendorid, marchid, and mimpid at the time of creating VCPU so that we don't have to do host SBI call every time Guest/VM ask for these details.
Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_host.h | 5 +++++ arch/riscv/kvm/vcpu.c | 6 ++++++ arch/riscv/kvm/vcpu_sbi_base.c | 11 +++++------ 3 files changed, 16 insertions(+), 6 deletions(-)
Re: [PATCH 8/9] RISC-V: KVM: Add ONE_REG interface for mvendorid, marchid, and mimpid
In reply to Anup PatelQuoted 72 lines · Anup Patel
We add
ONE_REGinterface for VCPU mvendorid, marchid, and mimpid so that KVM user-space can change this details to support migration across heterogeneous hosts.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/uapi/asm/kvm.h | 3 +++ arch/riscv/kvm/vcpu.c | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+)arch/riscv/include/uapi/asm/kvm.h +3
-0@@ -49,6 +49,9 @@ struct kvm_sregs {struct kvm_riscv_config {unsigned long isa;unsigned long zicbom_block_size; +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; };/* CORE registers for KVM_GET_ONE_REG and KVM_SET_ONE_REG */ arch/riscv/kvm/vcpu.c +27
-0@@ -276,6 +276,15 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,return -EINVAL ; reg_val = riscv_cbom_block_size;break ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): + reg_val = vcpu->arch.mvendorid; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): + reg_val = vcpu->arch.marchid; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): + reg_val = vcpu->arch.mimpid; +break ;default :return -EINVAL ; }@@ -338,6 +347,24 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,break ;case KVM_REG_RISCV_CONFIG_REG (zicbom_block_size):return -EOPNOTSUPP ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mvendorid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.marchid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mimpid = reg_val; +else +return -EBUSY ; +break ;default :return -EINVAL ; }Signature · 1 line
2.34.1
At some point we should patch Documentation/virt/kvm/api.rst to describe the possible errors we have. It's missing EOPNOTSUPP and EBUSY.
Also, I see a couple places were we use EOPNOTSUPP that would be better as EBUSY. And finally I wonder if we shouldn't use ENOENT when the reg_num is wrong/unknown, which would allow us to differentiate between bad reg_num and bad reg_val in set-one ioctls.
I can send an RFC series to better describe these thoughts.
And for this patch,
Thanks,
drew
Re: [PATCH 9/9] RISC-V: KVM: Add ONE_REG interface to enable/disable SBI extensions
In reply to Anup PatelQuoted 100 lines · Anup Patel
We add
ONE_REGinterface to enable/disable SBI extensions (just like theONE_REGinterface for ISA extensions). This allows KVM user-space to decide the set of SBI extension enabled for a Guest and by default all SBI extensions are enabled.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/kvm_vcpu_sbi.h | 8 +- arch/riscv/include/uapi/asm/kvm.h | 19 ++++ arch/riscv/kvm/vcpu.c | 2 + arch/riscv/kvm/vcpu_sbi.c | 145 +++++++++++++++++++++++--- arch/riscv/kvm/vcpu_sbi_base.c | 2 +- 5 files changed, 158 insertions(+), 18 deletions(-)arch/riscv/include/asm/kvm_vcpu_sbi.h +7
-1@@ -16,6 +16,7 @@struct kvm_vcpu_sbi_context {int return_handled; +bool extension_disabled[KVM_RISCV_SBI_EXT_MAX ]; };struct kvm_vcpu_sbi_extension {@@ -36,7 +37,12 @@ void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,struct kvm_run *run, u32 type, u64 flags);int kvm_riscv_vcpu_sbi_return (struct kvm_vcpu *vcpu,struct kvm_run *run); -const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext (unsigned long extid); +int kvm_riscv_vcpu_set_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg); +int kvm_riscv_vcpu_get_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg); +const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext ( +struct kvm_vcpu *vcpu,unsigned long extid);int kvm_riscv_vcpu_sbi_ecall (struct kvm_vcpu *vcpu,struct kvm_run *run);#ifdef CONFIG_RISCV_SBI_V01 arch/riscv/include/uapi/asm/kvm.h +19
-0@@ -108,6 +108,22 @@ enum KVM_RISCV_ISA_EXT_ID { KVM_RISCV_ISA_EXT_MAX, }; +/* +* SBI extension IDs specific to KVM. This is not the same as the SBI +* extension IDs defined by the RISC-V SBI specification. +*/ +enum KVM_RISCV_SBI_EXT_ID { +KVM_RISCV_SBI_EXT_V01 =0 , +KVM_RISCV_SBI_EXT_TIME , +KVM_RISCV_SBI_EXT_IPI , +KVM_RISCV_SBI_EXT_RFENCE , +KVM_RISCV_SBI_EXT_SRST , +KVM_RISCV_SBI_EXT_HSM , +KVM_RISCV_SBI_EXT_EXPERIMENTAL , +KVM_RISCV_SBI_EXT_VENDOR , +KVM_RISCV_SBI_EXT_MAX , +}; +/* Possible states for kvm_riscv_timer */ #define KVM_RISCV_TIMER_STATE_OFF 0#define KVM_RISCV_TIMER_STATE_ON 1@@ -152,6 +168,9 @@ enum KVM_RISCV_ISA_EXT_ID {/* ISA Extension registers are mapped as type 7 */ #define KVM_REG_RISCV_ISA_EXT (0x07 << KVM_REG_RISCV_TYPE_SHIFT) +/* SBI extension registers are mapped as type 8 */ +#define KVM_REG_RISCV_SBI_EXT (0x08 << KVM_REG_RISCV_TYPE_SHIFT) +#endif #endif /* __LINUX_KVM_RISCV_H */ arch/riscv/kvm/vcpu.c +2
-0@@ -594,6 +594,8 @@ static int kvm_riscv_vcpu_set_reg(struct kvm_vcpu *vcpu, KVM_REG_RISCV_FP_D);case KVM_REG_RISCV_ISA_EXT :return kvm_riscv_vcpu_set_reg_isa_ext (vcpu, reg); +case KVM_REG_RISCV_SBI_EXT : +return kvm_riscv_vcpu_set_reg_sbi_ext (vcpu, reg);default :break ; }arch/riscv/kvm/vcpu_sbi.c +0
-2@@ -40,16 +40,48 @@ static const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_v01 = { };#endif -static const struct kvm_vcpu_sbi_extension *sbi_ext[] = { - &vcpu_sbi_ext_v01,
arch/riscv/kvm/vcpu_sbi.c static const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_v01 = { · line 44
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi.c +2
-8- &vcpu_sbi_ext_base, - &vcpu_sbi_ext_time, - &vcpu_sbi_ext_ipi, - &vcpu_sbi_ext_rfence, - &vcpu_sbi_ext_srst, - &vcpu_sbi_ext_hsm, - &vcpu_sbi_ext_experimental, - &vcpu_sbi_ext_vendor, +struct kvm_riscv_sbi_extension_entry { +enum KVM_RISCV_SBI_EXT_ID dis_idx;
nit: I think I'd prefer this to be spelled out (disable_idx) (although keeping it 7 chars does make the table below line up nicely :-)
Quoted 46 lines
arch/riscv/kvm/vcpu_sbi.c +40
-0+const struct kvm_vcpu_sbi_extension *ext_ptr; +}; + +static const struct kvm_riscv_sbi_extension_entry sbi_ext[] = { + { + .dis_idx =KVM_RISCV_SBI_EXT_V01 , + .ext_ptr = &vcpu_sbi_ext_v01, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_MAX ,/* Can't be disabled */ + .ext_ptr = &vcpu_sbi_ext_base, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_TIME , + .ext_ptr = &vcpu_sbi_ext_time, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_IPI , + .ext_ptr = &vcpu_sbi_ext_ipi, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_RFENCE , + .ext_ptr = &vcpu_sbi_ext_rfence, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_SRST , + .ext_ptr = &vcpu_sbi_ext_srst, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_HSM , + .ext_ptr = &vcpu_sbi_ext_hsm, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_EXPERIMENTAL , + .ext_ptr = &vcpu_sbi_ext_experimental, + }, + { + .dis_idx =KVM_RISCV_SBI_EXT_VENDOR , + .ext_ptr = &vcpu_sbi_ext_vendor, + }, };void kvm_riscv_vcpu_sbi_forward (struct kvm_vcpu *vcpu,struct kvm_run *run)@@ -108,14 +140,95 @@ int kvm_riscv_vcpu_sbi_return(struct kvm_vcpu *vcpu, struct kvm_run *run)return 0 ; }
arch/riscv/kvm/vcpu_sbi.c int kvm_riscv_vcpu_sbi_return(struct kvm_vcpu *vcpu, struct kvm_run *run) · line 150
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi.c +8
-1-const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext (unsigned long extid) +int kvm_riscv_vcpu_set_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg) +{ +unsigned long __user *uaddr = + (unsigned long __user *)(unsigned long )reg->addr; +unsigned long reg_num = reg->id & ~(KVM_REG_ARCH_MASK | +KVM_REG_SIZE_MASK | +KVM_REG_RISCV_SBI_EXT );
I think we should create a macro that extracts reg_num from reg->id for all types, i.e.
#define KVM_REG_NUM(id) ((id) & ~(KVM_REG_ARCH_MASK | KVM_REG_SIZE_MASK | KVM_REG_RISCV_TYPE_MASK))
and then we can use it throughout this file.
arch/riscv/kvm/vcpu_sbi.c int kvm_riscv_vcpu_sbi_return(struct kvm_vcpu *vcpu, struct kvm_run *run) · line 163
Quoted 13 lines
arch/riscv/kvm/vcpu_sbi.c +13
-0+unsigned long i, reg_val; +const struct kvm_riscv_sbi_extension_entry *sext =NULL ; +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; + +if (KVM_REG_SIZE (reg->id) !=sizeof (unsigned long )) +return -EINVAL ; + +if (copy_from_user (®_val, uaddr,KVM_REG_SIZE (reg->id))) +return -EFAULT ; + +if (reg_num >=KVM_RISCV_SBI_EXT_MAX || + (reg_val !=1 && reg_val !=0 )) +return -EINVAL ;
Maybe
if (reg_num >= KVM_RISCV_SBI_EXT_MAX)
return -ENOENT;
if (reg_val != 1 && reg_val != 0)
return -EINVAL;
Quoted 25 lines
arch/riscv/kvm/vcpu_sbi.c +25
-0+ +if (vcpu->arch.ran_atleast_once) +return -EBUSY ; + +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { +if (sbi_ext[i].dis_idx == reg_num) { + sext = &sbi_ext[i]; +break ; + } + } +if (!sext) +return -ENOENT ; + + scontext->extension_disabled[sext->dis_idx] = !reg_val; + +return 0 ; +} + +int kvm_riscv_vcpu_get_reg_sbi_ext (struct kvm_vcpu *vcpu, +const struct kvm_one_reg *reg) +{ +unsigned long __user *uaddr = + (unsigned long __user *)(unsigned long )reg->addr; + unsigned long reg_num = reg->id & ~(KVM_REG_ARCH_MASK | + KVM_REG_SIZE_MASK |
arch/riscv/kvm/vcpu_sbi.c int kvm_riscv_vcpu_sbi_return(struct kvm_vcpu *vcpu, struct kvm_run *run) · line 198
Quoted 10 lines
arch/riscv/kvm/vcpu_sbi.c +10
-0+ KVM_REG_RISCV_SBI_EXT); +unsigned long i, reg_val; +const struct kvm_riscv_sbi_extension_entry *sext =NULL ; +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; + +if (KVM_REG_SIZE (reg->id) !=sizeof (unsigned long )) +return -EINVAL ; + +if (reg_num >=KVM_RISCV_SBI_EXT_MAX ) +return -EINVAL ;
ENOENT?
Quoted 65 lines
arch/riscv/kvm/vcpu_sbi.c +31
-5+ +for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { +if (sbi_ext[i].dis_idx == reg_num) { + sext = &sbi_ext[i]; +break ; + } + } +if (!sext) +return -ENOENT ; + + reg_val = !scontext->extension_disabled[sext->dis_idx]; +if (copy_to_user (uaddr, ®_val,KVM_REG_SIZE (reg->id))) +return -EFAULT ; + +return 0 ; +} + +const struct kvm_vcpu_sbi_extension *kvm_vcpu_sbi_find_ext ( +struct kvm_vcpu *vcpu,unsigned long extid) { -int i =0 ; +int i; +const struct kvm_riscv_sbi_extension_entry *sext; +struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context;for (i =0 ; i <ARRAY_SIZE (sbi_ext); i++) { -if (sbi_ext[i]->extid_start <= extid && - sbi_ext[i]->extid_end >= extid) -return sbi_ext[i]; + sext = &sbi_ext[i]; +if (sext->ext_ptr->extid_start <= extid && + sext->ext_ptr->extid_end >= extid) { +if (sext->dis_idx <KVM_RISCV_SBI_EXT_MAX && + scontext->extension_disabled[sext->dis_idx]) +return NULL ; +return sbi_ext[i].ext_ptr; + } }return NULL ;@@ -132,7 +245,7 @@ int kvm_riscv_vcpu_sbi_ecall(struct kvm_vcpu *vcpu, struct kvm_run *run)unsigned long out_val =0 ;bool ext_is_v01 = false; - sbi_ext =kvm_vcpu_sbi_find_ext (cp->a7); + sbi_ext =kvm_vcpu_sbi_find_ext (vcpu, cp->a7);if (sbi_ext && sbi_ext->handler) {#ifdef CONFIG_RISCV_SBI_V01 if (cp->a7 >= SBI_EXT_0_1_SET_TIMER &&arch/riscv/kvm/vcpu_sbi_base.c +1
-1@@ -44,7 +44,7 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run,kvm_riscv_vcpu_sbi_forward (vcpu, run); *exit = true; }else - *out_val =kvm_vcpu_sbi_find_ext (cp->a0) ?1 :0 ; + *out_val =kvm_vcpu_sbi_find_ext (vcpu, cp->a0) ?1 :0 ;break ;case SBI_EXT_BASE_GET_MVENDORID : *out_val = vcpu->arch.mvendorid;Signature · 1 line
2.34.1
Other than the EINVAL / ENOENT comment and the nits and stuff that can be done later, this looks good to me, so
Thanks,
drew
Re: [PATCH 6/9] RISC-V: Export sbi_get_mvendorid() and friends
In reply to Anup PatelQuoted 22 lines · apatel at ventanamicro.com
The
sbi_get_mvendorid(),sbi_get_marchid(), andsbi_get_mimpid()can be used by KVM module so let us export these functions.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kernel/sbi.c | 3 +++ 1 file changed, 3 insertions(+)arch/riscv/kernel/sbi.c +1
-0@@ -627,16 +627,19 @@ long sbi_get_mvendorid(void) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MVENDORID ); } +EXPORT_SYMBOL_GPL (sbi_get_mvendorid);long sbi_get_marchid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MARCHID ); }
arch/riscv/kernel/sbi.c long sbi_get_mvendorid(void) · line 645
Quoted 10 lines
arch/riscv/kernel/sbi.c +2
-0+EXPORT_SYMBOL_GPL (sbi_get_marchid);long sbi_get_mimpid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MIMPID ); } +EXPORT_SYMBOL_GPL (sbi_get_mimpid);static void sbi_send_cpumask_ipi (const struct cpumask *target) {
Anup Patel
maintainerRe: [PATCH 8/9] RISC-V: KVM: Add ONE_REG interface for mvendorid, marchid, and mimpid
In reply to Andrew JonesQuoted 78 lines · Andrew Jones
Quoted 70 lines · Anup Patel
We add
ONE_REGinterface for VCPU mvendorid, marchid, and mimpid so that KVM user-space can change this details to support migration across heterogeneous hosts.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/uapi/asm/kvm.h | 3 +++ arch/riscv/kvm/vcpu.c | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+)arch/riscv/include/uapi/asm/kvm.h +3
-0@@ -49,6 +49,9 @@ struct kvm_sregs {struct kvm_riscv_config {unsigned long isa;unsigned long zicbom_block_size; +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; };/* CORE registers for KVM_GET_ONE_REG and KVM_SET_ONE_REG */ arch/riscv/kvm/vcpu.c +27
-1@@ -276,6 +276,15 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,return -EINVAL ; reg_val = riscv_cbom_block_size;break ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): + reg_val = vcpu->arch.mvendorid; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): + reg_val = vcpu->arch.marchid; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): + reg_val = vcpu->arch.mimpid; +break ;default :return -EINVAL ; }@@ -338,6 +347,24 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,break ;case KVM_REG_RISCV_CONFIG_REG (zicbom_block_size):return -EOPNOTSUPP ; +case KVM_REG_RISCV_CONFIG_REG (mvendorid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mvendorid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (marchid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.marchid = reg_val; +else +return -EBUSY ; +break ; +case KVM_REG_RISCV_CONFIG_REG (mimpid): +if (!vcpu->arch.ran_atleast_once) + vcpu->arch.mimpid = reg_val; +else +return -EBUSY ; +break ;default :return -EINVAL ; } --Quoted 2 lines
2.34.1
At some point we should patch
Documentation/virt/kvm/api.rstto describe the possible errors we have. It's missing EOPNOTSUPP and EBUSY.
Quoted 6 lines
Also, I see a couple places were we use EOPNOTSUPP that would be better as EBUSY. And finally I wonder if we shouldn't use ENOENT when the
reg_numis wrong/unknown, which would allow us to differentiate between badreg_numand badreg_valin set-one ioctls.I can send an RFC series to better describe these thoughts.
Sure, go ahead.
Quoted 7 lines
And for this patch,
Reviewed-by Andrew Jones <[email protected]>Thanks,
drew
Regards,
Anup
Quoted 12 lines · Anup Patel
This series does first does few cleanups/fixes (PATCH1 to PATCH5) and adds ONE-REG interface for customizing the SBI interface visible to the Guest/VM.
The testing of this series has been done with KVMTOOL changes in
riscv_sbi_imp_v1branch at:
https://github.com/avpatel/kvmtool.gitThese patches can also be found in the
riscv_kvm_sbi_imp_v1branch at:
https://github.com/avpatel/linux.git
Quoted 10 lines
Anup Patel (9):
RISC-V: KVM: Fixreg_valcheck inkvm_riscv_vcpu_set_reg_config()
RISC-V: KVM: Remove redundant includes ofasm/kvm_vcpu_timer.h
RISC-V: KVM: Remove redundant includes ofasm/csr.h
RISC-V: KVM: Use switch-case in kvm_riscv_vcpu_set/get_reg()
RISC-V: KVM: Move sbi related struct and functions tokvm_vcpu_sbi.h
RISC-V: Exportsbi_get_mvendorid()and friends
RISC-V: KVM: Save mvendorid, marchid, and mimpid when creating VCPU
RISC-V: KVM: AddONE_REGinterface for mvendorid, marchid, and mimpid
RISC-V: KVM: AddONE_REGinterface to enable/disable SBI extensions
I have queued PATCH1 to PATCH8 for Linux-6.2.
I have deferred PATCH9 until we have an agreement about how to deal with VM-level attributes. This is also required for the KVM SBI PMU series.
Quoted 13 lines
arch/riscv/include/asm/kvm_host.h | 16 ++- arch/riscv/include/asm/kvm_vcpu_sbi.h | 14 ++- arch/riscv/include/uapi/asm/kvm.h | 22 ++++ arch/riscv/kernel/sbi.c | 3 + arch/riscv/kvm/vcpu.c | 82 +++++++++++---- arch/riscv/kvm/vcpu_sbi.c | 145 +++++++++++++++++++++++--- arch/riscv/kvm/vcpu_sbi_base.c | 15 ++- arch/riscv/kvm/vcpu_sbi_hsm.c | 1 - arch/riscv/kvm/vcpu_sbi_replace.c | 1 - arch/riscv/kvm/vcpu_sbi_v01.c | 1 - 10 files changed, 244 insertions(+), 56 deletions(-)
Quoted 3 lines
--
2.34.1
Thanks,
Anup
Re: [PATCH 6/9] RISC-V: Export sbi_get_mvendorid() and friends
In reply to Atish PatraQuoted 32 lines · atishp at atishpatra.org
Quoted 31 lines · Anup Patel
The
sbi_get_mvendorid(),sbi_get_marchid(), andsbi_get_mimpid()can be used by KVM module so let us export these functions.Signed-off-by Anup Patel <[email protected]>--- arch/riscv/kernel/sbi.c | 3 +++ 1 file changed, 3 insertions(+)arch/riscv/kernel/sbi.c +3
-0@@ -627,16 +627,19 @@ long sbi_get_mvendorid(void) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MVENDORID ); } +EXPORT_SYMBOL_GPL (sbi_get_mvendorid);long sbi_get_marchid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MARCHID ); } +EXPORT_SYMBOL_GPL (sbi_get_marchid);long sbi_get_mimpid (void ) {return __sbi_base_ecall (SBI_EXT_BASE_GET_MIMPID ); } +EXPORT_SYMBOL_GPL (sbi_get_mimpid);
Quoted 7 lines
Quoted 5 lines
arch/riscv/kernel/sbi.c +0
-1static void sbi_send_cpumask_ipi (const struct cpumask *target) { --2.34.1
Reviewed-by Atish Patra <[email protected]>