Skip to contentSkip to conversation

hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro

PATCH Superseded Derek J. Clark 3 participants 7 messages Dec 13, 2022 – Dec 29, 2022

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro

Adds support for the AYANEO AIR and AYANEO AIR Pro models of handheld devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. Tested on Aya Neo AIR. AIR Pro model EC functionality and DMI data were verified using command line tools by another user.

The added devices are:
- AYANEO AIR (AMD 5560U)
- AYANEO AIR Pro (AMD 5560U)
- AYANEO AIR Pro (AMD 5825U)

---
 Documentation/hwmon/oxp-sensors.rst | 17 +++++----
 MAINTAINERS                         |  6 ++++
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 63 insertions(+), 14 deletions(-)
Documentation/hwmon/oxp-sensors.rst +11 -6
index 39c588ec5c50..b93892c892c5 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
 Description:
 ------------
 
-One X Player devices from One Netbook provide fan readings and fan control
-through its Embedded Controller.
+Handheld devices from One Netbook and Aya Neo provide fan readings and fan
+control through their Embedded Controllers.
 
-Currently only supports AMD boards from the One X Player and AOK ZOE lineup.
-Intel boards could be supported if we could figure out the EC registers and
-values to write to since the EC layout and model is different.
+Currently only supports AMD boards from One X Player, AOK ZOE, and some Aya
+Neo devices. One X PLayer Intel boards could be supported if we could figure
+out the EC registers and values to write to since the EC layout and model is
+different. Aya Neo devices preceding the AIR may not be usable as the EC model
+is different and do not appear to have manual control capabiltities.
 
 Supported devices
 -----------------
@@ -22,6 +25,8 @@ Supported devices
 Currently the driver supports the following handhelds:
 
  - AOK ZOE A1
+ - Aya Neo AIR
+ - Aya Neo AIR Pro
  - OneXPlayer AMD
  - OneXPlayer mini AMD
  - OneXPlayer mini AMD PRO
MAINTAINERS +6 -0
index 90220659206c..ba03a2983045 100644
@@ -15345,6 +15345,12 @@ S:	Maintained
 F:	drivers/mtd/nand/onenand/
 F:	include/linux/mtd/onenand*.h
 
+ONEXPLAYER FAN DRIVER
+M:	Derek John Clark <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/hwmon/oxp-sensors.c
+
 ONEXPLAYER FAN DRIVER
 M:	Joaquín Ignacio Aramendía <[email protected]>
 L:	[email protected]
drivers/hwmon/oxp-sensors.c +46 -8

86 lines not on this page · raw message

Signature · 1 line
2.38.1
#1 lore raw
Quoted 1 line · Derek J. Clark

Adds support for the AYANEO AIR and AYANEO AIR Pro models of handheld

s/Adds/Add/

Quoted 4 lines

devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. Tested on Aya Neo AIR. AIR Pro model EC functionality

"The driver is tested on ..., while ..."

Quoted 19 lines

and DMI data were verified using command line tools by another user.

The added devices are:
- AYANEO AIR (AMD 5560U)
- AYANEO AIR Pro (AMD 5560U)
- AYANEO AIR Pro (AMD 5825U)

---
 Documentation/hwmon/oxp-sensors.rst | 17 +++++----
 MAINTAINERS                         |  6 ++++
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 63 insertions(+), 14 deletions(-)
Documentation/hwmon/oxp-sensors.rst +0 -0
index 39c588ec5c50..b93892c892c5 100644

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 10 lines
Documentation/hwmon/oxp-sensors.rst +2 -1
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
 Description:
 ------------

Trim the trailing colon as it is not needed for section title.

Documentation/hwmon/oxp-sensors.rst line 14

Quoted 5 lines
Documentation/hwmon/oxp-sensors.rst +2 -2
-One X Player devices from One Netbook provide fan readings and fan control
-through its Embedded Controller.
+Handheld devices from One Netbook and Aya Neo provide fan readings and fan
+control through their Embedded Controllers.

s/Embedded Controllers/embedded controllers/

Quoted 13 lines
Documentation/hwmon/oxp-sensors.rst +5 -3
-Currently only supports AMD boards from the One X Player and AOK ZOE lineup.
-Intel boards could be supported if we could figure out the EC registers and
-values to write to since the EC layout and model is different.
+Currently only supports AMD boards from One X Player, AOK ZOE, and some Aya
+Neo devices. One X PLayer Intel boards could be supported if we could figure
+out the EC registers and values to write to since the EC layout and model is
+different. Aya Neo devices preceding the AIR may not be usable as the EC model
+is different and do not appear to have manual control capabiltities.
 
 Supported devices
 -----------------

Documentation/hwmon/oxp-sensors.rst Supported devices · line 32

Quoted 8 lines
Documentation/hwmon/oxp-sensors.rst +2 -0
@@ -22,6 +25,8 @@ Supported devices
 Currently the driver supports the following handhelds:
 
  - AOK ZOE A1
+ - Aya Neo AIR
+ - Aya Neo AIR Pro
  - OneXPlayer AMD
  - OneXPlayer mini AMD
  - OneXPlayer mini AMD PRO

Otherwise LGTM, thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#2 lore raw

PATCH v2 1/1 hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro

Add support for the AYANEO AIR and AYANEO AIR Pro models of handheld devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. Tihe driver is tested on Aya Neo AIR while AIR Pro model EC functionality and DMI data were verified using command line tools by another user.

The added devices are:
- AYANEO AIR (AMD 5560U)
- AYANEO AIR Pro (AMD 5560U)
- AYANEO AIR Pro (AMD 5825U)

---
 Documentation/hwmon/oxp-sensors.rst | 19 ++++++----
 MAINTAINERS                         |  1 +
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 59 insertions(+), 15 deletions(-)
Documentation/hwmon/oxp-sensors.rst +12 -7
index 39c588ec5c50..a53c961065b2 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
-Description:
+Description
 ------------
 
-One X Player devices from One Netbook provide fan readings and fan control
-through its Embedded Controller.
+Handheld devices from One Netbook and Aya Neo provide fan readings and fan
+control through their embedded controllers.
 
-Currently only supports AMD boards from the One X Player and AOK ZOE lineup.
-Intel boards could be supported if we could figure out the EC registers and
-values to write to since the EC layout and model is different.
+Currently only supports AMD boards from One X Player, AOK ZOE, and some Aya
+Neo devices. One X PLayer Intel boards could be supported if we could figure
+out the EC registers and values to write to since the EC layout and model is
+different. Aya Neo devices preceding the AIR may not be usable as the EC model
+is different and do not appear to have manual control capabiltities.
 
 Supported devices
 -----------------
@@ -22,6 +25,8 @@ Supported devices
 Currently the driver supports the following handhelds:
 
  - AOK ZOE A1
+ - Aya Neo AIR
+ - Aya Neo AIR Pro
  - OneXPlayer AMD
  - OneXPlayer mini AMD
  - OneXPlayer mini AMD PRO
MAINTAINERS +1 -0
index 90220659206c..8bce95170f12 100644
@@ -15346,6 +15346,7 @@ F:	drivers/mtd/nand/onenand/
 F:	include/linux/mtd/onenand*.h
 
 ONEXPLAYER FAN DRIVER
+M:	Derek John Clark <[email protected]>
 M:	Joaquín Ignacio Aramendía <[email protected]>
 L:	[email protected]
 S:	Maintained
drivers/hwmon/oxp-sensors.c +46 -8

86 lines not on this page · raw message

Signature · 1 line
2.38.1
maintainer
#6 lore raw
In reply to Derek J. Clark
Quoted 1 line · Derek J. Clark

Adds support for the AYANEO AIR and AYANEO AIR Pro models of handheld

s/Adds/Add/

Quoted 64 lines

devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. Tested on Aya Neo AIR. AIR Pro model EC functionality and DMI data were verified using command line tools by another user.

The added devices are:
- AYANEO AIR (AMD 5560U)
- AYANEO AIR Pro (AMD 5560U)
- AYANEO AIR Pro (AMD 5825U)

---
 Documentation/hwmon/oxp-sensors.rst | 17 +++++----
 MAINTAINERS                         |  6 ++++
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 63 insertions(+), 14 deletions(-)
Documentation/hwmon/oxp-sensors.rst +11 -6
index 39c588ec5c50..b93892c892c5 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
 Description:
 ------------
 
-One X Player devices from One Netbook provide fan readings and fan control
-through its Embedded Controller.
+Handheld devices from One Netbook and Aya Neo provide fan readings and fan
+control through their Embedded Controllers.
 
-Currently only supports AMD boards from the One X Player and AOK ZOE lineup.
-Intel boards could be supported if we could figure out the EC registers and
-values to write to since the EC layout and model is different.
+Currently only supports AMD boards from One X Player, AOK ZOE, and some Aya
+Neo devices. One X PLayer Intel boards could be supported if we could figure
+out the EC registers and values to write to since the EC layout and model is
+different. Aya Neo devices preceding the AIR may not be usable as the EC model
+is different and do not appear to have manual control capabiltities.
 
 Supported devices
 -----------------
@@ -22,6 +25,8 @@ Supported devices
 Currently the driver supports the following handhelds:
 
  - AOK ZOE A1
+ - Aya Neo AIR
+ - Aya Neo AIR Pro
  - OneXPlayer AMD
  - OneXPlayer mini AMD
  - OneXPlayer mini AMD PRO
MAINTAINERS +0 -0
index 90220659206c..ba03a2983045 100644

MAINTAINERS S: Maintained · line 15353

Quoted 9 lines
MAINTAINERS +6 -0
@@ -15345,6 +15345,12 @@ S:	Maintained
 F:	drivers/mtd/nand/onenand/
 F:	include/linux/mtd/onenand*.h
 
+ONEXPLAYER FAN DRIVER
+M:	Derek John Clark <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/hwmon/oxp-sensors.c
+

This doesn't make sense. Why add another entry for the same driver ? Add yourself as second maintianer, no problem with that, but don't add a second entry for the same driver.

drivers/hwmon/oxp-sensors.c line 3

Quoted 13 lines
MAINTAINERS +0 -0
 ONEXPLAYER FAN DRIVER
 M:	Joaquín Ignacio Aramendía <[email protected]>
 L:	[email protected]
drivers/hwmon/oxp-sensors.c +1 -2
index f84ec8f8eda9..7adc0199ea66 100644
@@ -1,12 +1,12 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Platform driver for OXP Handhelds that expose fan reading and control
- * via hwmon sysfs.
+ * Platform driver for Handhelds that expose fan reading and control via

That is too generic. It is not a driver which supports _all_ handhelds.

Quoted 50 lines
drivers/hwmon/oxp-sensors.c +23 -5
+ * hwmon sysfs.
  *
- * Old boards have the same DMI strings and they are told appart by the
- * boot cpu vendor (Intel/AMD). Currently only AMD boards are supported
- * but the code is made to be simple to add other handheld boards in the
- * future.
+ * Old OXP boards have the same DMI strings and they are told appart by
+ * the boot cpu vendor (Intel/AMD). Currently only AMD boards are
+ * supported but the code is made to be simple to add other handheld
+ * boards in the future.
  * Fan control is provided via pwm interface in the range [0-255].
  * Old AMD boards use [0-100] as range in the EC, the written value is
  * scaled to accommodate for that. Newer boards like the mini PRO and
@@ -42,6 +42,8 @@ static bool unlock_global_acpi_lock(void)
 
 enum oxp_board {
 	aok_zoe_a1 = 1,
+	aya_neo_air,
+	aya_neo_air_pro,
 	oxp_mini_amd,
 	oxp_mini_amd_pro,
 };
@@ -60,6 +62,20 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *) &(enum oxp_board) {aok_zoe_a1},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AIR"),
+		},
+		.driver_data = (void *) &(enum oxp_board) {aya_neo_air},
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AIR Pro"),
+		},
+		.driver_data = (void *) &(enum oxp_board) {aya_neo_air_pro},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
@@ -161,8 +177,19 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
 			ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
 			if (ret)
 				return ret;
-			if (board == oxp_mini_amd)
+			switch (board) {
+			case aok_zoe_a1:

drivers/hwmon/oxp-sensors.c static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type, · line 191

Quoted 10 lines
drivers/hwmon/oxp-sensors.c +9 -0
+				break;
+			case aya_neo_air:
+			case aya_neo_air_pro:
+			case oxp_mini_amd:
 				*val = (*val * 255) / 100;
+				break;
+			case oxp_mini_amd_pro:
+				break;
+			default:
+				break;

case statements doing nothing can be bundled.

Quoted 11 lines
drivers/hwmon/oxp-sensors.c +3 -1
+			}
 			return 0;
 		case hwmon_pwm_enable:
 			return read_from_ec(OXP_SENSOR_PWM_ENABLE_REG, 1, val);
@@ -191,8 +218,19 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
 		case hwmon_pwm_input:
 			if (val < 0 || val > 255)
 				return -EINVAL;
-			if (board == oxp_mini_amd)
+			switch (board) {
+			case aok_zoe_a1:

drivers/hwmon/oxp-sensors.c static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type, · line 232

Quoted 10 lines
drivers/hwmon/oxp-sensors.c +9 -0
+				break;
+			case aya_neo_air:
+			case aya_neo_air_pro:
+			case oxp_mini_amd:
 				val = (val * 100) / 255;
+				break;
+			case oxp_mini_amd_pro:
+				break;
+			default:
+				break;

Same as above.

Quoted 4 lines
drivers/hwmon/oxp-sensors.c +1 -0
+			}
 			return write_to_ec(dev, OXP_SENSOR_PWM_REG, val);
 		default:
 			break;
maintainer
#3 lore raw
In reply to Derek J. Clark
Quoted 8 lines · Derek J. Clark

Add support for the AYANEO AIR and AYANEO AIR Pro models of handheld devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. Tihe driver is tested on Aya Neo AIR while AIR Pro model EC functionality and DMI data were verified using command line tools by another user.

Quoted 6 lines

The added devices are:
- AYANEO AIR (AMD 5560U)
- AYANEO AIR Pro (AMD 5560U)
- AYANEO AIR Pro (AMD 5825U)

Missed v2, sorry. Comments below.

Quoted 12 lines
---
 Documentation/hwmon/oxp-sensors.rst | 19 ++++++----
 MAINTAINERS                         |  1 +
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 59 insertions(+), 15 deletions(-)
Documentation/hwmon/oxp-sensors.rst +0 -0
index 39c588ec5c50..a53c961065b2 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 10 lines
Documentation/hwmon/oxp-sensors.rst +3 -2
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
-Description:
+Description
 ------------

Why drop ":" here ?

Documentation/hwmon/oxp-sensors.rst line 19

Quoted 13 lines
Documentation/hwmon/oxp-sensors.rst +6 -5
-One X Player devices from One Netbook provide fan readings and fan control
-through its Embedded Controller.
+Handheld devices from One Netbook and Aya Neo provide fan readings and fan
+control through their embedded controllers.
 
-Currently only supports AMD boards from the One X Player and AOK ZOE lineup.
-Intel boards could be supported if we could figure out the EC registers and
-values to write to since the EC layout and model is different.
+Currently only supports AMD boards from One X Player, AOK ZOE, and some Aya
+Neo devices. One X PLayer Intel boards could be supported if we could figure
+out the EC registers and values to write to since the EC layout and model is
+different. Aya Neo devices preceding the AIR may not be usable as the EC model

s/usable/supportable/ ?

Quoted 30 lines
Documentation/hwmon/oxp-sensors.rst +3 -0
+is different and do not appear to have manual control capabiltities.
 
 Supported devices
 -----------------
@@ -22,6 +25,8 @@ Supported devices
 Currently the driver supports the following handhelds:
 
  - AOK ZOE A1
+ - Aya Neo AIR
+ - Aya Neo AIR Pro
  - OneXPlayer AMD
  - OneXPlayer mini AMD
  - OneXPlayer mini AMD PRO
MAINTAINERS +1 -0
index 90220659206c..8bce95170f12 100644
@@ -15346,6 +15346,7 @@ F:	drivers/mtd/nand/onenand/
 F:	include/linux/mtd/onenand*.h
 
 ONEXPLAYER FAN DRIVER
+M:	Derek John Clark <[email protected]>
 M:	Joaquín Ignacio Aramendía <[email protected]>
 L:	[email protected]
 S:	Maintained
drivers/hwmon/oxp-sensors.c +0 -0
index f84ec8f8eda9..7adc0199ea66 100644

drivers/hwmon/oxp-sensors.c line 4

Quoted 6 lines
drivers/hwmon/oxp-sensors.c +2 -2
@@ -1,12 +1,12 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Platform driver for OXP Handhelds that expose fan reading and control
- * via hwmon sysfs.
+ * Platform driver for Handhelds that expose fan reading and control via
+ * hwmon sysfs.

Still too generic. Refer to "One Netbook and Aya Neo" as above.

drivers/hwmon/oxp-sensors.c line 6

Quoted 6 lines
drivers/hwmon/oxp-sensors.c +1 -4
  *
- * Old boards have the same DMI strings and they are told appart by the
- * boot cpu vendor (Intel/AMD). Currently only AMD boards are supported
- * but the code is made to be simple to add other handheld boards in the
- * future.
+ * Old OXP boards have the same DMI strings and they are told appart by

Old problem, but s/appart/apart/

Quoted 43 lines
drivers/hwmon/oxp-sensors.c +21 -1
+ * the boot cpu vendor (Intel/AMD). Currently only AMD boards are
+ * supported but the code is made to be simple to add other handheld
+ * boards in the future.
  * Fan control is provided via pwm interface in the range [0-255].
  * Old AMD boards use [0-100] as range in the EC, the written value is
  * scaled to accommodate for that. Newer boards like the mini PRO and
@@ -42,6 +42,8 @@ static bool unlock_global_acpi_lock(void)
 
 enum oxp_board {
 	aok_zoe_a1 = 1,
+	aya_neo_air,
+	aya_neo_air_pro,
 	oxp_mini_amd,
 	oxp_mini_amd_pro,
 };
@@ -60,6 +62,20 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *) &(enum oxp_board) {aok_zoe_a1},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AIR"),
+		},
+		.driver_data = (void *) &(enum oxp_board) {aya_neo_air},
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AIR Pro"),
+		},
+		.driver_data = (void *) &(enum oxp_board) {aya_neo_air_pro},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
@@ -161,8 +177,19 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
 			ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
 			if (ret)
 				return ret;
-			if (board == oxp_mini_amd)
+			switch (board) {
+			case aok_zoe_a1:

drivers/hwmon/oxp-sensors.c static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type, · line 191

Quoted 10 lines
drivers/hwmon/oxp-sensors.c +9 -0
+				break;
+			case aya_neo_air:
+			case aya_neo_air_pro:
+			case oxp_mini_amd:
 				*val = (*val * 255) / 100;
+				break;
+			case oxp_mini_amd_pro:
+				break;
+			default:
+				break;

bundle case statements

Quoted 12 lines
drivers/hwmon/oxp-sensors.c +4 -1
+			}
 			return 0;
 		case hwmon_pwm_enable:
 			return read_from_ec(OXP_SENSOR_PWM_ENABLE_REG, 1, val);
@@ -191,8 +218,19 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
 		case hwmon_pwm_input:
 			if (val < 0 || val > 255)
 				return -EINVAL;
-			if (board == oxp_mini_amd)
+			switch (board) {
+			case aok_zoe_a1:
+				break;

drivers/hwmon/oxp-sensors.c static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type, · line 233

Quoted 10 lines
drivers/hwmon/oxp-sensors.c +9 -0
+			case aya_neo_air:
+			case aya_neo_air_pro:
+			case oxp_mini_amd:
 				val = (val * 100) / 255;
+				break;
+			case oxp_mini_amd_pro:
+				break;
+			default:
+				break;
+			}

Same as above.

Quoted 3 lines
drivers/hwmon/oxp-sensors.c +0 -0
 			return write_to_ec(dev, OXP_SENSOR_PWM_REG, val);
 		default:
 			break;
#4 lore raw
Quoted 19 lines
Quoted 19 lines
---
 Documentation/hwmon/oxp-sensors.rst | 19 ++++++----
 MAINTAINERS                         |  1 +
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 59 insertions(+), 15 deletions(-)
Documentation/hwmon/oxp-sensors.rst +2 -1
index 39c588ec5c50..a53c961065b2 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
Quoted 5 lines

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 3 lines
Documentation/hwmon/oxp-sensors.rst +1 -1
-Description:
+Description
 ------------

Why drop ":" here ?

To match the style of the rest of the Documentation section titles. Per Bagas Sanjaya previously:

Quoted 9 lines

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 7 lines
Documentation/hwmon/oxp-sensors.rst +2 -1
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
 Description:
 ------------

Trim the trailing colon as it is not needed for section title.

Additional changes forthcoming. Thanks.

maintainer
#5 lore raw
Quoted 19 lines · Derek John Clark
Quoted 19 lines
Quoted 19 lines
---
 Documentation/hwmon/oxp-sensors.rst | 19 ++++++----
 MAINTAINERS                         |  1 +
 drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
 3 files changed, 59 insertions(+), 15 deletions(-)
Documentation/hwmon/oxp-sensors.rst +2 -1
index 39c588ec5c50..a53c961065b2 100644
@@ -3,18 +3,21 @@
 Kernel driver oxp-sensors
 =========================
 
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
Quoted 17 lines
Quoted 5 lines

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 3 lines
Documentation/hwmon/oxp-sensors.rst +1 -1
-Description:
+Description
 ------------

Why drop ":" here ?

To match the style of the rest of the Documentation section titles. Per Bagas Sanjaya previously:

Quoted 9 lines

Documentation/hwmon/oxp-sensors.rst line 11

Quoted 7 lines
Documentation/hwmon/oxp-sensors.rst +2 -1
-Author:
+Authors:
+    - Derek John Clark <[email protected]>
     - Joaquín Ignacio Aramendía <[email protected]>
 
 Description:
 ------------

Trim the trailing colon as it is not needed for section title.

That is POV, unrelated to this patch, and would have to be submitted as separate patch. Please refrain from changes like that and get me involved if someone requests it (actually they should provide such changes themselves since they request it and it is unrelated, and they should explain in the patch description why it is needed).

On a side note, '------------' would have to be changed as well.

Guenter

Quoted 2 lines

Additional changes forthcoming. Thanks.