Skip to contentSkip to conversation

spi: dw_bt1: fix MUX_MMIO dependencies

PATCH Superseded Arnd Bergmann 3 participants 4 messages Dec 15, 2022 – Dec 18, 2022 SPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: dw_bt1: fix MUX_MMIO dependencies

From: Arnd Bergmann <[email protected]>

Selecting a symbol with additional dependencies requires adding the same dependency here:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
- SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])

Alternatively, we could drop this 'select' and require users to manually put it into their .config as we do for other drivers.

Fixes 7218838109fe ("spi: dw-bt1: Fix undefined devm_mux_control_get symbol")
Fixes abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver")
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
index 3b1c0878bb85..1884e4083088 100644
@@ -294,6 +294,7 @@ config SPI_DW_MMIO
 config SPI_DW_BT1
 	tristate "Baikal-T1 SPI driver for DW SPI core"
 	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
+	depends on OF
 	select MULTIPLEXER
 	select MUX_MMIO
 	help
Signature · 1 line
2.35.1
#1 lore raw

Hi Arnd

Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Selecting a symbol with additional dependencies requires adding the same dependency here:

Quoted 7 lines

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
- SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])

Alternatively, we could drop this 'select' and require users to manually put it into their .config as we do for other drivers.

Thanks for the patch. Seeing the driver is only implicitly dependent from the mux-mmio driver (via the device described in the device tree blob) I'd suggest to either drop the MUX_MMIO config reverse dependency or convert it to the weak one - 'imply' (if it will solve the problem).

-Serge(y)

Quoted 23 lines
Fixes 7218838109fe ("spi: dw-bt1: Fix undefined devm_mux_control_get symbol")
Fixes abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver")
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
index 3b1c0878bb85..1884e4083088 100644
@@ -294,6 +294,7 @@ config SPI_DW_MMIO
 config SPI_DW_BT1
 	tristate "Baikal-T1 SPI driver for DW SPI core"
 	depends on MIPS_BAIKAL_T1 || COMPILE_TEST
+	depends on OF
 	select MULTIPLEXER
 	select MUX_MMIO
 	help
Signature · 1 line
2.35.1
#2 lore raw
Quoted 13 lines · Serge Semin

Hi Arnd

Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Selecting a symbol with additional dependencies requires adding the same dependency here:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
- SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])

Quoted 8 lines
Quoted 2 lines

Alternatively, we could drop this 'select' and require users to manually put it into their .config as we do for other drivers.

Thanks for the patch. Seeing the driver is only implicitly dependent from the mux-mmio driver (via the device described in the device tree blob) I'd suggest to either drop the MUX_MMIO config reverse dependency or convert it to the weak one - 'imply' (if it will solve the problem).

Ok, I'll send a new patch. I don't want to use 'imply' though, that tends to cause other problems because almost nobody understands what it actually does.

Arnd

#3 lore raw
Quoted 24 lines · Arnd Bergmann
Quoted 13 lines · Serge Semin

Hi Arnd

Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Selecting a symbol with additional dependencies requires adding the same dependency here:

WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
- SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])

Quoted 8 lines
Quoted 2 lines

Alternatively, we could drop this 'select' and require users to manually put it into their .config as we do for other drivers.

Thanks for the patch. Seeing the driver is only implicitly dependent from the mux-mmio driver (via the device described in the device tree blob) I'd suggest to either drop the MUX_MMIO config reverse dependency or convert it to the weak one - 'imply' (if it will solve the problem).

Quoted 3 lines

Ok, I'll send a new patch. I don't want to use 'imply' though, that tends to cause other problems because almost nobody understands what it actually does.

Ok. Dropping it will be also suitable solution. I'll make sure our defconfigs will be updated afterwards.

-Serge(y)

Quoted 2 lines

Arnd