spi: dw_bt1: fix MUX_MMIO dependencies
PATCH v2 1/1 spi: dw_bt1: fix MUX_MMIO dependencies
From: Arnd Bergmann <[email protected]>
Selecting a symbol with additional dependencies requires adding the same dependency here:
WARNING: unmet direct dependencies detected for MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
- SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])
Drop the 'select' here to avoid the problem. Anyone using the dw-bt1 SPI driver should make sure they include the mux driver as well now.
--- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/spi/Kconfig +0 -1
@@ -295,7 +295,6 @@ config SPI_DW_BT1 tristate "Baikal-T1 SPI driver for DW SPI core" depends on MIPS_BAIKAL_T1 || COMPILE_TEST select MULTIPLEXER - select MUX_MMIO help Baikal-T1 SoC is equipped with three DW APB SSI-based MMIO SPI controllers. Two of them are pretty much normal: with IRQ, DMA,
Signature · 1 line
2.39.0
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Selecting a symbol with additional dependencies requires adding the same dependency here:
WARNING: unmet direct dependencies detected for
MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
-SPI_DW_BT1[=y] && SPI [=y] &&SPI_MASTER[=y] &&SPI_DESIGNWARE[=y] && (MIPS_BAIKAL_T1||COMPILE_TEST[=y])
Quoted 8 lines
Drop the 'select' here to avoid the problem. Anyone using the dw-bt1 SPI driver should make sure they include the mux driver as well now.
Fixes 7218838109fe ("spi: dw-bt1: Fix undefined devm_mux_control_get symbol")Fixes abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver")Signed-off-by Arnd Bergmann <[email protected]>
Thanks!
-Serge(y)
Quoted 19 lines
--- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/spi/Kconfig +0
-1@@ -295,7 +295,6 @@ config SPI_DW_BT1 tristate "Baikal-T1 SPI driver for DW SPI core" depends on MIPS_BAIKAL_T1 || COMPILE_TEST select MULTIPLEXER - select MUX_MMIO help Baikal-T1 SoC is equipped with three DW APB SSI-based MMIO SPI controllers. Two of them are pretty much normal: with IRQ, DMA,Signature · 1 line
2.39.0
Mark Brown
maintainerQuoted 9 lines · Arnd Bergmann
Selecting a symbol with additional dependencies requires adding the same dependency here:
WARNING: unmet direct dependencies detected for
MUX_MMIO
Depends on [n]: MULTIPLEXER [=y] && OF [=n]
Selected by [y]:
-SPI_DW_BT1[=y] && SPI [=y] &&SPI_MASTER[=y] &&SPI_DESIGNWARE[=y] && (MIPS_BAIKAL_T1||COMPILE_TEST[=y])[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: dw_bt1: fix MUX_MMIO dependencies
commit: d4bde04318c0d33705e9a77d4c7df72f262011e0
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark