cpufreq: apple: remove duplicate intializer
Subsystems (2)
PATCH 1/1 cpufreq: apple: remove duplicate intializer
From: Arnd Bergmann <[email protected]>
When -Woverride-init is enabled, gcc notices that the .attr field is initialized twice:
drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
331 | .attr = apple_soc_cpufreq_hw_attr,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Remove the first one, since this is not actually used.
--- drivers/cpufreq/apple-soc-cpufreq.c | 1 - 1 file changed, 1 deletion(-)
drivers/cpufreq/apple-soc-cpufreq.c +0 -1
@@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = { .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, - .attr = cpufreq_generic_attr, .get = apple_soc_cpufreq_get_rate, .init = apple_soc_cpufreq_init, .exit = apple_soc_cpufreq_exit,
Signature · 1 line
2.35.1
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When -Woverride-init is enabled, gcc notices that the .attr field is initialized twice:
Quoted 7 lines
drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
331 | .attr =apple_soc_cpufreq_hw_attr,| ^~~~~~~~~~~~~~~~~~~~~~~~~Remove the first one, since this is not actually used.
Signed-off-by Arnd Bergmann <[email protected]>
Quoted 20 lines
--- drivers/cpufreq/apple-soc-cpufreq.c | 1 - 1 file changed, 1 deletion(-)drivers/cpufreq/apple-soc-cpufreq.c +0
-2@@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = { .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, - .attr = cpufreq_generic_attr, .get = apple_soc_cpufreq_get_rate, .init = apple_soc_cpufreq_init, .exit = apple_soc_cpufreq_exit, --2.35.1
Quoted 11 lines · Eric Curtin
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When -Woverride-init is enabled, gcc notices that the .attr field is initialized twice:
drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
331 | .attr =apple_soc_cpufreq_hw_attr,| ^~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 5 lines
Quoted 3 lines
Remove the first one, since this is not actually used.
Signed-off-by Arnd Bergmann <[email protected]>Reviewed-by Eric Curtin <[email protected]>
Applied. Thanks.
Signature · 1 line
viresh