perf tools: Fix resources leak in perf_data__open_dir
PATCH 1/1 perf tools: Fix resources leak in perf_data__open_dir
In perf_data__open_dir(), opendir() opens the directory stream. Add missing closedir() to release it after use.
Fixes eb6176709b23 ("perf data: Add perf_data__open_dir_data function")
Signed-off-by Miaoqian Lin <[email protected]>
--- tools/perf/util/data.c | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/util/data.c +2 -0
@@ -132,6 +132,7 @@ int perf_data__open_dir(struct perf_data *data) file->size = st.st_size; } +closedir (dir);if (!files)return -EINVAL ;
@@ -140,6 +141,7 @@ int perf_data__open_dir(struct perf_data *data)return 0 ; out_err: +closedir (dir);close_dir (files, nr);return ret; }
Signature · 1 line
2.25.1
Quoted 5 lines · Miaoqian Lin
In
perf_data__open_dir(),opendir()opens the directory stream. Add missingclosedir()to release it after use.Fixes eb6176709b23 ("perf data: Add perf_data__open_dir_data function")Signed-off-by Miaoqian Lin <[email protected]>
Reviewed-by Adrian Hunter <[email protected]>
Quoted 24 lines
--- tools/perf/util/data.c | 2 ++ 1 file changed, 2 insertions(+)tools/perf/util/data.c +2
-0@@ -132,6 +132,7 @@ int perf_data__open_dir(struct perf_data *data) file->size = st.st_size; } +closedir (dir);if (!files)return -EINVAL ;@@ -140,6 +141,7 @@ int perf_data__open_dir(struct perf_data *data)return 0 ; out_err: +closedir (dir);close_dir (files, nr);return ret; }
Em Thu, Dec 29, 2022 at 01:27:39PM +0200, Adrian Hunter escreveu:
Quoted 8 lines · Miaoqian Lin
Quoted 5 lines
In
perf_data__open_dir(),opendir()opens the directory stream. Add missingclosedir()to release it after use.Fixes eb6176709b23 ("perf data: Add perf_data__open_dir_data function")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Adrian Hunter <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 24 lines
Quoted 24 lines
--- tools/perf/util/data.c | 2 ++ 1 file changed, 2 insertions(+)tools/perf/util/data.c +2
-0@@ -132,6 +132,7 @@ int perf_data__open_dir(struct perf_data *data) file->size = st.st_size; } +closedir (dir);if (!files)return -EINVAL ;@@ -140,6 +141,7 @@ int perf_data__open_dir(struct perf_data *data)return 0 ; out_err: +closedir (dir);close_dir (files, nr);return ret; }
Signature · 1 line
- Arnaldo