ata: Fix dependency for CONFIG_SATA_SIL
PATCH 1/1 ata: Fix dependency for CONFIG_SATA_SIL
sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:
LD u-boot
ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
drivers/ata/sata_sil.c:148: undefined reference to dm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in function sil_pci_probe':
drivers/ata/sata_sil.c:687: undefined reference to dm_pci_get_bdf' ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to dm_pci_read_config16' ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to dm_pci_map_bar' ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to dm_pci_map_bar' ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to dm_pci_write_config16' ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to dm_pci_read_config16' ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
drivers/ata/sata_sil.c:256: undefined reference to dm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in function sil_sata_rw_cmd':
drivers/ata/sata_sil.c:330: undefined reference to dm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in function sil_sata_rw_cmd_ext':
drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
make: *** [Makefile:1778: u-boot] Error 1
--- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/ata/Kconfig +1 -0
@@ -135,6 +135,7 @@ config SATA_MV config SATA_SIL bool "Enable Silicon Image SIL3131 / SIL3132 / SIL3124 SATA driver support" + depends on PCI select AHCI select LIBATA help
Signature · 1 line
2.20.1
Quoted 21 lines · Pali Rohár
sata_sil.cis PCI driver and withoutCONFIG_PCIis building of U-Boot failing:LD u-boot
ld.bfd:drivers/ata/sata_sil.o: in function `sil_exec_cmd':
drivers/ata/sata_sil.c:148: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_pci_probe':
drivers/ata/sata_sil.c:687: undefined reference todm_pci_get_bdf' ld.bfd: drivers/ata/sata_sil.c:691: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.c:701: undefined reference todm_pci_map_bar' ld.bfd: drivers/ata/sata_sil.c:704: undefined reference todm_pci_map_bar' ld.bfd:drivers/ata/sata_sil.c:713: undefined reference todm_pci_write_config16' ld.bfd: drivers/ata/sata_sil.c:717: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
drivers/ata/sata_sil.c:256: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd':
drivers/ata/sata_sil.c:330: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd_ext':
drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
make: *** [Makefile:1778: u-boot] Error 1
Quoted 4 lines
Signed-off-by Pali Rohár <[email protected]>--- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 20 lines · Pali Rohár
sata_sil.cis PCI driver and withoutCONFIG_PCIis building of U-Boot failing:LD u-boot
ld.bfd:drivers/ata/sata_sil.o: in function `sil_exec_cmd':
drivers/ata/sata_sil.c:148: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_pci_probe':
drivers/ata/sata_sil.c:687: undefined reference todm_pci_get_bdf' ld.bfd: drivers/ata/sata_sil.c:691: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.c:701: undefined reference todm_pci_map_bar' ld.bfd: drivers/ata/sata_sil.c:704: undefined reference todm_pci_map_bar' ld.bfd:drivers/ata/sata_sil.c:713: undefined reference todm_pci_write_config16' ld.bfd: drivers/ata/sata_sil.c:717: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
drivers/ata/sata_sil.c:256: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd':
drivers/ata/sata_sil.c:330: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd_ext':
drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
make: *** [Makefile:1778: u-boot] Error 1
Quoted 1 line
Signed-off-by Pali Rohár <[email protected]>
Thanks,
Stefan
Quoted 9 lines
--- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/ata/Kconfig +0
-0
drivers/ata/Kconfig config SATA_MV · line 141
Quoted 7 lines
drivers/ata/Kconfig +1
-0@@ -135,6 +135,7 @@ config SATA_MV config SATA_SIL bool "Enable Silicon Image SIL3131 / SIL3132 / SIL3124 SATA driver support" + depends on PCI select AHCI select LIBATA help
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 20 lines · Pali Rohár
sata_sil.cis PCI driver and withoutCONFIG_PCIis building of U-Boot failing:LD u-boot
ld.bfd:drivers/ata/sata_sil.o: in function `sil_exec_cmd':
drivers/ata/sata_sil.c:148: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_pci_probe':
drivers/ata/sata_sil.c:687: undefined reference todm_pci_get_bdf' ld.bfd: drivers/ata/sata_sil.c:691: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.c:701: undefined reference todm_pci_map_bar' ld.bfd: drivers/ata/sata_sil.c:704: undefined reference todm_pci_map_bar' ld.bfd:drivers/ata/sata_sil.c:713: undefined reference todm_pci_write_config16' ld.bfd: drivers/ata/sata_sil.c:717: undefined reference todm_pci_read_config16' ld.bfd:drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
drivers/ata/sata_sil.c:256: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd':
drivers/ata/sata_sil.c:330: undefined reference todm_pci_phys_to_bus' ld.bfd: drivers/ata/sata_sil.o: in functionsil_sata_rw_cmd_ext':
drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
make: *** [Makefile:1778: u-boot] Error 1
Quoted 3 lines
Signed-off-by Pali Rohár <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Stefan Roese <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom