Add Secure TSC support for SNP guests
Subsystems (4)
cover Add Secure TSC support for SNP guests
Secure TSC allows guest to securely use RDTSC/RDTSCP instructions as the parameters being used cannot be changed by hypervisor once the guest is launched. More details in the AMD64 APM Vol 2, Section "Secure TSC".
During the boot-up of the secondary cpus, SecureTSC enabled guests need to query TSC info from Security processor (PSP). This communication channel is encrypted between the security processor and the guest, hypervisor is just the conduit to deliver the guest messages to the security processor. Each message is protected with an AEAD (AES-256 GCM). See "SEV Secure Nested Paging Firmware ABI Specification" document (currently at
https://www.amd.com/system/files/TechDocs/56860.pdf) section "TSC Info"
Use minimal GCM library to encrypt/decrypt SNP Guest messages to communicate with the PSP which is available at earlyboot.
SEV-guest driver has the implementation for guest and security coprocessor communication. As the TSC_INFO needs to be initialized during early boot before smp cpus are started, move most of the sev-guest driver code as part to kernel/sev.c and provide well defined APIs to the sev-guest driver to use the interface to avoid code-duplication.
Patches:
01-05: Preparation and movement of sev-guest driver code
06: Adds generic guest initialization hook
07-11: SecureTSC enablement patches.
Nikunj A Dadhania (11):
virt: sev-guest: Use AES GCM crypto library
virt: sev-guest: Move mutex to SNP guest device structure
virt: sev-guest: Add snp_guest_req structure
virt: sev-guest: Add simplified helper to assign vmpck x86/sev: Move and reorganize sev guest request api x86/mm: Add generic guest initialization hook x86/sev: Change TSC MSR behavior for Secure TSC enabled guests x86/sev: Add Secure TSC support for SNP guests x86/kvmclock: Use Secure TSC as clock if available x86/tsc: Mark Secure TSC as reliable clocksource x86/sev: Enable Secure TSC for SNP guests
arch/x86/Kconfig | 1 +
arch/x86/boot/compressed/sev.c | 2 +-
arch/x86/coco/core.c | 3 +
.../x86/include/asm}/sev-guest.h | 43 ++
arch/x86/include/asm/sev.h | 24 +
arch/x86/include/asm/svm.h | 6 +-
arch/x86/include/asm/x86_init.h | 2 +
arch/x86/kernel/kvmclock.c | 2 +-
arch/x86/kernel/sev-shared.c | 7 +
arch/x86/kernel/sev.c | 500 +++++++++++++++-
arch/x86/kernel/tsc.c | 2 +-
arch/x86/kernel/x86_init.c | 2 +
arch/x86/mm/mem_encrypt.c | 13 +-
arch/x86/mm/mem_encrypt_amd.c | 6 +
drivers/virt/coco/sev-guest/Kconfig | 2 -
drivers/virt/coco/sev-guest/sev-guest.c | 553 ++----------------
include/linux/cc_platform.h | 8 +
17 files changed, 664 insertions(+), 512 deletions(-)
rename {drivers/virt/coco/sev-guest => arch/x86/include/asm}/sev-guest.h (57%)base-commit: 6d796c50f84ca79f1722bb131799e5a5710c4700
Signature · 1 line
2.32.0
RFC PATCH 1/11 virt: sev-guest: Use AES GCM crypto library
SEV-SNP guests with SecureTSC enabled need to send a TSC_INFO SNP Guest message to the AMD security processor before the smpboot phase starts. Details from the TSC_INFO response have to be programmed in the VMSA before the secondary CPUs are brought up.
Start using the AES GCM library implementation as the crypto API is not available yet this early.
--- drivers/virt/coco/sev-guest/Kconfig | 3 +- drivers/virt/coco/sev-guest/sev-guest.c | 172 +++++++----------------- drivers/virt/coco/sev-guest/sev-guest.h | 3 + 3 files changed, 53 insertions(+), 125 deletions(-)
drivers/virt/coco/sev-guest/Kconfig +1 -2
@@ -2,8 +2,7 @@ config SEV_GUEST tristate "AMD SEV Guest driver" default m depends on AMD_MEM_ENCRYPT - select CRYPTO_AEAD2 - select CRYPTO_GCM + select CRYPTO_LIB_AESGCM help SEV-SNP firmware provides the guest a mechanism to communicate with the PSP without risk from a malicious hypervisor who wishes to read,
drivers/virt/coco/sev-guest/sev-guest.c +49 -123
302 lines not on this page · raw message
drivers/virt/coco/sev-guest/sev-guest.h +3 -0
@@ -13,6 +13,9 @@#include <linux/types.h> #define MAX_AUTHTAG_LEN 32 +#define AUTHTAG_LEN 16 +#define AAD_LEN 48 +#define MSG_HDR_VER 1/* See SNP spec SNP_GUEST_REQUEST section for the structure */ enum msg_type {
Signature · 1 line
2.32.0
RFC PATCH 2/11 virt: sev-guest: Move mutex to SNP guest device structure
In reply to Nikunj A DadhaniaIn preparation to provide new API for sending SNP guest message to the sev-guest driver, move the SNP command mutex to the snp_guest_dev structure.
--- drivers/virt/coco/sev-guest/sev-guest.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
drivers/virt/coco/sev-guest/sev-guest.c +11 -10
@@ -32,6 +32,9 @@ struct snp_guest_dev {struct device *dev;struct miscdevice misc; +/* Mutex to serialize the shared buffer access and command handling. */ +struct mutex cmd_mutex; +void *certs_data;struct aesgcm_ctx *ctx;struct snp_guest_msg *request, *response;
@@ -45,9 +48,6 @@ static u32 vmpck_id;module_param (vmpck_id, uint,0444 );MODULE_PARM_DESC (vmpck_id,"The VMPCK ID to use when communicating with the PSP." ); -/* Mutex to serialize the shared buffer access and command handling. */ -static DEFINE_MUTEX (snp_cmd_mutex); -static inline unsigned int get_ctx_authsize (struct snp_guest_dev *snp_dev) {if (snp_dev && snp_dev->ctx)
@@ -96,7 +96,7 @@ static inline u64 __snp_get_msg_seqno(struct snp_guest_dev *snp_dev) {u64 count; -lockdep_assert_held (&snp_cmd_mutex); +lockdep_assert_held (&snp_dev->cmd_mutex);/* Read the current message sequence counter from secrets pages */ count = *snp_dev->os_area_msg_seqno;
@@ -338,7 +338,7 @@ static int get_report(struct snp_guest_dev *snp_dev, struct snp_guest_request_iostruct snp_report_req req;int rc, resp_len; -lockdep_assert_held (&snp_cmd_mutex); +lockdep_assert_held (&snp_dev->cmd_mutex);if (!arg->req_data || !arg->resp_data)return -EINVAL ;
@@ -378,7 +378,7 @@ static int get_derived_key(struct snp_guest_dev *snp_dev, struct snp_guest_reque/* Response data is 64 bytes and max authsize for GCM is 16 bytes. */ u8 buf[64 +16 ]; -lockdep_assert_held (&snp_cmd_mutex); +lockdep_assert_held (&snp_dev->cmd_mutex);if (!arg->req_data || !arg->resp_data)return -EINVAL ;
@@ -417,7 +417,7 @@ static int get_ext_report(struct snp_guest_dev *snp_dev, struct snp_guest_requesstruct snp_report_resp *resp;int ret, npages =0 , resp_len; -lockdep_assert_held (&snp_cmd_mutex); +lockdep_assert_held (&snp_dev->cmd_mutex);if (!arg->req_data || !arg->resp_data)return -EINVAL ;
@@ -502,12 +502,12 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned longif (!input.msg_version)return -EINVAL ; -mutex_lock (&snp_cmd_mutex); +mutex_lock (&snp_dev->cmd_mutex);/* Check if the VMPCK is not empty */ if (is_vmpck_empty (snp_dev)) {dev_err_ratelimited (snp_dev->dev,"VMPCK is disabled\n" ); -mutex_unlock (&snp_cmd_mutex); +mutex_unlock (&snp_dev->cmd_mutex);return -ENOTTY ; }
@@ -525,7 +525,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned longbreak ; } -mutex_unlock (&snp_cmd_mutex); +mutex_unlock (&snp_dev->cmd_mutex);if (input.fw_err &©_to_user (argp, &input,sizeof (input)))return -EFAULT ;
@@ -641,6 +641,7 @@ static int __init sev_guest_probe(struct platform_device *pdev) goto e_unmap; } +mutex_init (&snp_dev->cmd_mutex);platform_set_drvdata (pdev, snp_dev); snp_dev->dev = dev; snp_dev->layout = layout;
Signature · 1 line
2.32.0
RFC PATCH 3/11 virt: sev-guest: Add snp_guest_req structure
In reply to Nikunj A DadhaniaAdd a snp_guest_req structure to simplify the function arguments. The structure will be used to call the SNP Guest message request API instead of passing a long list of parameters.
--- drivers/virt/coco/sev-guest/sev-guest.c | 84 ++++++++++++++----------- drivers/virt/coco/sev-guest/sev-guest.h | 19 ++++++ 2 files changed, 66 insertions(+), 37 deletions(-)
drivers/virt/coco/sev-guest/sev-guest.c +47 -37
@@ -57,16 +57,6 @@ static inline unsigned int get_ctx_authsize(struct snp_guest_dev *snp_dev)return 0 ; } -static bool is_vmpck_empty (struct snp_guest_dev *snp_dev) -{ -char zero_key[VMPCK_KEY_LEN ] = {0 }; - -if (snp_dev->vmpck) -return !memcmp (snp_dev->vmpck, zero_key,VMPCK_KEY_LEN ); - -return true; -} -/* * If an error is received from the host or AMD Secure Processor (ASP) there * are two options. Either retry the exact same encrypted request or discontinue
@@ -195,8 +185,9 @@ static int verify_and_dec_payload(struct snp_guest_dev *snp_dev, void *payload,struct snp_guest_msg_hdr *resp_hdr = &resp->hdr;struct aesgcm_ctx *ctx = snp_dev->ctx; -dev_dbg (snp_dev->dev,"response [seqno %lld type %d version %d sz %d]\n" , - resp_hdr->msg_seqno, resp_hdr->msg_type, resp_hdr->msg_version, resp_hdr->msg_sz); +pr_debug ("response [seqno %lld type %d version %d sz %d]\n" , + resp_hdr->msg_seqno, resp_hdr->msg_type, resp_hdr->msg_version, + resp_hdr->msg_sz);/* Verify that the sequence counter is incremented by 1 */ if (unlikely (resp_hdr->msg_seqno != (req_hdr->msg_seqno +1 )))
@@ -218,41 +209,42 @@ static int verify_and_dec_payload(struct snp_guest_dev *snp_dev, void *payload,return dec_payload (ctx, resp, payload, resp_hdr->msg_sz); } -static int enc_payload (struct snp_guest_dev *snp_dev,u64 seqno,int version,u8 type, -void *payload,size_t sz) +static int enc_payload (struct snp_guest_dev *snp_dev,u64 seqno, +struct snp_guest_req *req,u8 __vmpck_id) { -struct snp_guest_msg *req = snp_dev->request; -struct snp_guest_msg_hdr *hdr = &req->hdr; +struct snp_guest_msg *msg = snp_dev->request; +struct snp_guest_msg_hdr *hdr = &msg->hdr; -memset (req,0 ,sizeof (*req)); +memset (msg,0 ,sizeof (*msg)); hdr->algo =SNP_AEAD_AES_256_GCM ; hdr->hdr_version =MSG_HDR_VER ; hdr->hdr_sz =sizeof (*hdr); - hdr->msg_type = type; - hdr->msg_version = version; + hdr->msg_type = req->msg_type; + hdr->msg_version = req->msg_version; hdr->msg_seqno = seqno; - hdr->msg_vmpck = vmpck_id; - hdr->msg_sz = sz; + hdr->msg_vmpck = __vmpck_id; + hdr->msg_sz = req->req_sz;/* Verify the sequence number is non-zero */ if (!hdr->msg_seqno)return -ENOSR ; -dev_dbg (snp_dev->dev,"request [seqno %lld type %d version %d sz %d]\n" , +pr_debug ("request [seqno %lld type %d version %d sz %d]\n" , hdr->msg_seqno, hdr->msg_type, hdr->msg_version, hdr->msg_sz); -return __enc_payload (snp_dev->ctx, req, payload, sz); +return __enc_payload (snp_dev->ctx, msg, req->req_buf, req->req_sz); } -static int handle_guest_request (struct snp_guest_dev *snp_dev,u64 exit_code,int msg_ver, -u8 type,void *req_buf,size_t req_sz,void *resp_buf, -u32 resp_sz,__u64 *fw_err) +static int snp_send_guest_request (struct snp_guest_dev *snp_dev,struct snp_guest_req *req) {unsigned long err;u64 seqno;int rc; +if (!snp_dev || !req) +return -ENODEV ; +/* Get message sequence and verify that its a non-zero */ seqno =snp_get_msg_seqno (snp_dev);if (!seqno)
@@ -261,7 +253,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, inmemset (snp_dev->response,0 ,sizeof (struct snp_guest_msg ));/* Encrypt the userspace provided payload */ - rc =enc_payload (snp_dev, seqno, msg_ver, type, req_buf, req_sz); + rc =enc_payload (snp_dev, seqno, req, vmpck_id);if (rc)return rc;
@@ -271,7 +263,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);/* * If the extended guest request fails due to having too small of a
@@ -279,11 +271,11 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* extended data request in order to increment the sequence number * and thus avoid IV reuse. */ -if (exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && +if (req->exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && err ==SNP_GUEST_REQ_INVALID_LEN ) {const unsigned int certs_npages = snp_dev->input.data_npages; - exit_code =SVM_VMGEXIT_GUEST_REQUEST ; + req->exit_code =SVM_VMGEXIT_GUEST_REQUEST ;/* * If this call to the firmware succeeds, the sequence number can
@@ -293,7 +285,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* of the VMPCK and the error code being propagated back to the * user as an ioctl() return code. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);/* * Override the error to inform callers the given extended
@@ -304,17 +296,17 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in snp_dev->input.data_npages = certs_npages; } -if (fw_err) - *fw_err = err; +if (req->fw_err) + *req->fw_err = err;if (rc) {dev_alert (snp_dev->dev,"Detected error from ASP request. rc: %d, fw_err: %llu\n" , - rc, *fw_err); + rc, *req->fw_err); goto disable_vmpck; } - rc =verify_and_dec_payload (snp_dev, resp_buf, resp_sz); + rc =verify_and_dec_payload (snp_dev, req->resp_buf, req->resp_sz);if (rc) { dev_alert(snp_dev->dev, "Detected unexpected decode failure from ASP. rc: %d\n",
@@ -332,6 +324,24 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, inreturn rc; } + +static int handle_guest_request (struct snp_guest_dev *snp_dev,u64 exit_code,u8 msg_version, +u8 msg_type,void *req_buf,size_t req_sz,void *resp_buf, +u32 resp_sz,__u64 *fw_err) +{ +struct snp_guest_req guest_req = { + .msg_version = msg_version, + .msg_type = msg_type, + .req_buf = req_buf, + .req_sz = req_sz, + .resp_buf = resp_buf, + .resp_sz = resp_sz, + .fw_err = fw_err, + .exit_code = exit_code, + }; +return snp_send_guest_request (snp_dev, &guest_req); +} +static int get_report (struct snp_guest_dev *snp_dev,struct snp_guest_request_ioctl *arg) {struct snp_report_resp *resp;
@@ -505,7 +515,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned longmutex_lock (&snp_dev->cmd_mutex);/* Check if the VMPCK is not empty */ -if (is_vmpck_empty (snp_dev)) { +if (is_vmpck_empty (snp_dev->vmpck)) {dev_err_ratelimited (snp_dev->dev,"VMPCK is disabled\n" );mutex_unlock (&snp_dev->cmd_mutex);return -ENOTTY ;
@@ -636,7 +646,7 @@ static int __init sev_guest_probe(struct platform_device *pdev) }/* Verify that VMPCK is not zero. */ -if (is_vmpck_empty (snp_dev)) { +if (is_vmpck_empty (snp_dev->vmpck)) {dev_err (dev,"vmpck id %d is null\n" , vmpck_id); goto e_unmap; }
drivers/virt/coco/sev-guest/sev-guest.h +19 -0
@@ -63,4 +63,23 @@ struct snp_guest_msg { u8 payload[4000]; } __packed; +struct snp_guest_req { +void *req_buf, *resp_buf; +size_t req_sz, resp_sz; +u64 exit_code; +u64 *fw_err; +u8 msg_version; +u8 msg_type; +}; + +static inline bool is_vmpck_empty (u8 *vmpck) +{ +char zero_key[VMPCK_KEY_LEN ] = {0 }; + +if (vmpck) +return !memcmp (vmpck, zero_key,VMPCK_KEY_LEN ); + +return true; +} +#endif /* __VIRT_SEVGUEST_H__ */
Signature · 1 line
2.32.0
Re: [RFC PATCH 03/11] virt: sev-guest: Add snp_guest_req structure
Quoted 45 lines
drivers/virt/coco/sev-guest/sev-guest.c +8
-4+static int snp_send_guest_request (struct snp_guest_dev *snp_dev,struct snp_guest_req *req) {unsigned long err;u64 seqno;int rc; +if (!snp_dev || !req) +return -ENODEV ; +/* Get message sequence and verify that its a non-zero */ seqno =snp_get_msg_seqno (snp_dev);if (!seqno)@@ -261,7 +253,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, inmemset (snp_dev->response,0 ,sizeof (struct snp_guest_msg ));/* Encrypt the userspace provided payload */ - rc =enc_payload (snp_dev, seqno, msg_ver, type, req_buf, req_sz); + rc =enc_payload (snp_dev, seqno, req, vmpck_id);if (rc)return rc;@@ -271,7 +263,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);/* * If the extended guest request fails due to having too small of a @@ -279,11 +271,11 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* extended data request in order to increment the sequence number * and thus avoid IV reuse. */ -if (exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && +if (req->exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && err ==SNP_GUEST_REQ_INVALID_LEN ) {const unsigned int certs_npages = snp_dev->input.data_npages; - exit_code =SVM_VMGEXIT_GUEST_REQUEST ; + req->exit_code =SVM_VMGEXIT_GUEST_REQUEST ;/* * If this call to the firmware succeeds, the sequence number can
drivers/virt/coco/sev-guest/sev-guest.c static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in · line 289
Quoted 6 lines
drivers/virt/coco/sev-guest/sev-guest.c +1
-1@@ -293,7 +285,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* of the VMPCK and the error code being propagated back to the * user as an ioctl() return code. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);
This is going to have a merge conflict with "[PATCH v13 1/4] virt/coco/sev-guest: Add throttling awareness", which is an important fix to ensure hosts are allowed to throttle guest requests and guests are able to retry instead of disabling the vmpck. I think that set of patches, or at least the first patch, is going to be going in before this series. Please be aware.
Signature · 1 line
-Dionna Glaze, PhD (she/her)
Re: [RFC PATCH 03/11] virt: sev-guest: Add snp_guest_req structure
Quoted 42 lines · Dionna Amalie Glaze
Quoted 42 lines
drivers/virt/coco/sev-guest/sev-guest.c +8
-4+static int snp_send_guest_request (struct snp_guest_dev *snp_dev,struct snp_guest_req *req) {unsigned long err;u64 seqno;int rc; +if (!snp_dev || !req) +return -ENODEV ; +/* Get message sequence and verify that its a non-zero */ seqno =snp_get_msg_seqno (snp_dev);if (!seqno)@@ -261,7 +253,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, inmemset (snp_dev->response,0 ,sizeof (struct snp_guest_msg ));/* Encrypt the userspace provided payload */ - rc =enc_payload (snp_dev, seqno, msg_ver, type, req_buf, req_sz); + rc =enc_payload (snp_dev, seqno, req, vmpck_id);if (rc)return rc;@@ -271,7 +263,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);/* * If the extended guest request fails due to having too small of a @@ -279,11 +271,11 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* extended data request in order to increment the sequence number * and thus avoid IV reuse. */ -if (exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && +if (req->exit_code ==SVM_VMGEXIT_EXT_GUEST_REQUEST && err ==SNP_GUEST_REQ_INVALID_LEN ) {const unsigned int certs_npages = snp_dev->input.data_npages; - exit_code =SVM_VMGEXIT_GUEST_REQUEST ; + req->exit_code =SVM_VMGEXIT_GUEST_REQUEST ;
Quoted 16 lines
drivers/virt/coco/sev-guest/sev-guest.c static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in · line 289
Quoted 9 lines
drivers/virt/coco/sev-guest/sev-guest.c +1
-1/* * If this call to the firmware succeeds, the sequence number can @@ -293,7 +285,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in* of the VMPCK and the error code being propagated back to the * user as an ioctl() return code. */ - rc =snp_issue_guest_request (exit_code, &snp_dev->input, &err); + rc =snp_issue_guest_request (req->exit_code, &snp_dev->input, &err);This is going to have a merge conflict with "[PATCH v13 1/4]
virt/coco/sev-guest: Add throttling awareness", which is an important fix to ensure hosts are allowed to throttle guest requests and guests are able to retry instead of disabling the vmpck. I think that set of patches, or at least the first patch, is going to be going in before this series. Please be aware.
Yes, I am aware of the series. I can rebase my patches once that goes in.
Regards
Nikunj
RFC PATCH 4/11 virt: sev-guest: Add simplified helper to assign vmpck
In reply to Nikunj A DadhaniaSimplify get_vmpck and prepare it to be used as an API. Update the snp_guest_dev structure in snp_assign_vmpck(). Added vmpck_id to the snp_guest_dev structure which can be used in SNP guest request API and will remove direct use of vmpck_id command line parameter.
--- drivers/virt/coco/sev-guest/sev-guest.c | 41 ++++++++----------------- 1 file changed, 12 insertions(+), 29 deletions(-)
drivers/virt/coco/sev-guest/sev-guest.c +12 -29
@@ -42,6 +42,7 @@ struct snp_guest_dev {struct snp_req_data input;u32 *os_area_msg_seqno;u8 *vmpck; +u8 vmpck_id; };static u32 vmpck_id;
@@ -77,7 +78,7 @@ static inline unsigned int get_ctx_authsize(struct snp_guest_dev *snp_dev)static void snp_disable_vmpck (struct snp_guest_dev *snp_dev) {dev_alert (snp_dev->dev,"Disabling vmpck_id %d to prevent IV reuse.\n" , - vmpck_id); + snp_dev->vmpck_id);memzero_explicit (snp_dev->vmpck,VMPCK_KEY_LEN ); snp_dev->vmpck =NULL ; }
@@ -253,7 +254,7 @@ static int snp_send_guest_request(struct snp_guest_dev *snp_dev, struct snp_guesmemset (snp_dev->response,0 ,sizeof (struct snp_guest_msg ));/* Encrypt the userspace provided payload */ - rc =enc_payload (snp_dev, seqno, req, vmpck_id); + rc =enc_payload (snp_dev, seqno, req, snp_dev->vmpck_id);if (rc)return rc;
@@ -324,7 +325,6 @@ static int snp_send_guest_request(struct snp_guest_dev *snp_dev, struct snp_guesreturn rc; } -static int handle_guest_request (struct snp_guest_dev *snp_dev,u64 exit_code,u8 msg_version,u8 msg_type,void *req_buf,size_t req_sz,void *resp_buf,u32 resp_sz,__u64 *fw_err)
@@ -585,32 +585,16 @@ static const struct file_operations snp_guest_fops = { .unlocked_ioctl = snp_guest_ioctl, }; -static u8 *get_vmpck (int id,struct snp_secrets_page_layout *layout,u32 **seqno) +bool snp_assign_vmpck (struct snp_guest_dev *dev,int vmpck_id) { -u8 *key =NULL ; +if (WARN_ON (vmpck_id >3 )) +return false; -switch (id) { -case 0 : - *seqno = &layout->os_area.msg_seqno_0; - key = layout->vmpck0; -break ; -case 1 : - *seqno = &layout->os_area.msg_seqno_1; - key = layout->vmpck1; -break ; -case 2 : - *seqno = &layout->os_area.msg_seqno_2; - key = layout->vmpck2; -break ; -case 3 : - *seqno = &layout->os_area.msg_seqno_3; - key = layout->vmpck3; -break ; -default : -break ; - } + dev->vmpck_id = vmpck_id; + dev->vmpck = dev->layout->vmpck0 + vmpck_id *VMPCK_KEY_LEN ; + dev->os_area_msg_seqno = &dev->layout->os_area.msg_seqno_0 + vmpck_id; -return key; +return true; }static int __init sev_guest_probe (struct platform_device *pdev)
@@ -639,8 +623,8 @@ static int __init sev_guest_probe(struct platform_device *pdev) goto e_unmap; ret = -EINVAL ; - snp_dev->vmpck =get_vmpck (vmpck_id, layout, &snp_dev->os_area_msg_seqno); -if (!snp_dev->vmpck) { + snp_dev->layout = layout; +if (!snp_assign_vmpck (snp_dev, vmpck_id)) {dev_err (dev,"invalid vmpck id %d\n" , vmpck_id); goto e_unmap; }
@@ -654,7 +638,6 @@ static int __init sev_guest_probe(struct platform_device *pdev)mutex_init (&snp_dev->cmd_mutex);platform_set_drvdata (pdev, snp_dev); snp_dev->dev = dev; - snp_dev->layout = layout;/* Allocate the shared page used for the request and response message. */ snp_dev->request =alloc_shared_pages (dev,sizeof (struct snp_guest_msg ));
Signature · 1 line
2.32.0
RFC PATCH 5/11 x86/sev: Move and reorganize sev guest request api
In reply to Nikunj A DadhaniaFor enabling Secure TSC, SEV-SNP guests need to communicate with the security coprocessor really early during boot. Lot of the required functions are implemented in the sev-guest driver. Move the required functions and provide API to the driver to assign VM communications key and send guest request.
---
arch/x86/Kconfig | 1 +
.../x86/include/asm}/sev-guest.h | 3 +
arch/x86/include/asm/sev.h | 22 +
arch/x86/kernel/sev.c | 396 ++++++++++++++++-
drivers/virt/coco/sev-guest/Kconfig | 1 -
drivers/virt/coco/sev-guest/sev-guest.c | 415 ++----------------
6 files changed, 443 insertions(+), 395 deletions(-)
rename {drivers/virt/coco/sev-guest => arch/x86/include/asm}/sev-guest.h (91%)arch/x86/Kconfig +1 -0
@@ -1545,6 +1545,7 @@ config AMD_MEM_ENCRYPT select INSTRUCTION_DECODER select ARCH_HAS_CC_PLATFORM select X86_MEM_ENCRYPT + select CRYPTO_LIB_AESGCM help Say yes to enable support for the encryption of system memory. This requires an AMD processor that supports Secure Memory
arch/x86/include/asm/sev-guest.h renamed from drivers/virt/coco/sev-guest/sev-guest.h +3 -0
@@ -72,6 +72,9 @@ struct snp_guest_req {u8 msg_type; }; +int snp_send_guest_request (struct snp_guest_dev *dev,struct snp_guest_req *req); +bool snp_assign_vmpck (struct snp_guest_dev *dev,int vmpck_id); +static inline bool is_vmpck_empty (u8 *vmpck) {char zero_key[VMPCK_KEY_LEN ] = {0 };
arch/x86/include/asm/sev.h +22 -0
@@ -9,6 +9,7 @@#define __ASM_ENCRYPTED_STATE_H#include <linux/types.h> +#include <linux/miscdevice.h> #include <asm/insn.h> #include <asm/sev-common.h> #include <asm/bootparam.h>
@@ -96,6 +97,27 @@ struct snp_req_data {struct sev_guest_platform_data {u64 secrets_gpa; + +void *certs_data; +struct aesgcm_ctx *ctx; +struct snp_guest_msg *req, *resp; +struct snp_secrets_page_layout *layout; +struct snp_req_data input; +u8 *vmpck0; +}; + +struct snp_guest_dev { +struct device *dev; +struct miscdevice misc; + +/* Mutex to serialize the shared buffer access and command handling. */ +struct mutex cmd_mutex; + +struct sev_guest_platform_data *pdata; + +u32 *os_area_msg_seqno; +u8 *vmpck; +u8 vmpck_id; };/*
arch/x86/kernel/sev.c +389 -7
423 lines not on this page · raw message
drivers/virt/coco/sev-guest/Kconfig +0 -1
@@ -2,7 +2,6 @@ config SEV_GUEST tristate "AMD SEV Guest driver" default m depends on AMD_MEM_ENCRYPT - select CRYPTO_LIB_AESGCM help SEV-SNP firmware provides the guest a mechanism to communicate with the PSP without risk from a malicious hypervisor who wishes to read,
drivers/virt/coco/sev-guest/sev-guest.c +28 -387
532 lines not on this page · raw message
Signature · 1 line
2.32.0
RFC PATCH 6/11 x86/mm: Add generic guest initialization hook
In reply to Nikunj A DadhaniaAdd generic enc_init guest hook for performing any type of initialization that is vendor specific.
--- arch/x86/include/asm/x86_init.h | 2 ++ arch/x86/kernel/x86_init.c | 2 ++ arch/x86/mm/mem_encrypt.c | 3 +++ 3 files changed, 7 insertions(+)
arch/x86/include/asm/x86_init.h +2 -0
@@ -148,12 +148,14 @@ struct x86_init_acpi {* @enc_status_change_finish Notify HV after the encryption status of a range is changed * @enc_tlb_flush_required Returns true if a TLB flush is needed before changing page encryption status * @enc_cache_flush_required Returns true if a cache flush is needed before changing page encryption status +* @enc_init Prepare and initialize encryption features */ struct x86_guest {void (*enc_status_change_prepare)(unsigned long vaddr,int npages,bool enc);bool (*enc_status_change_finish)(unsigned long vaddr,int npages,bool enc);bool (*enc_tlb_flush_required)(bool enc);bool (*enc_cache_flush_required)(void ); +void (*enc_init)(void ); };/**
arch/x86/kernel/x86_init.c +2 -0
@@ -134,6 +134,7 @@ static void enc_status_change_prepare_noop(unsigned long vaddr, int npages, boolstatic bool enc_status_change_finish_noop (unsigned long vaddr,int npages,bool enc) {return false; }static bool enc_tlb_flush_required_noop (bool enc) {return false; }static bool enc_cache_flush_required_noop (void ) {return false; } +static void enc_init_noop (void ) { }struct x86_platform_ops x86_platform__ro_after_init = { .calibrate_cpu = native_calibrate_cpu_early,
@@ -155,6 +156,7 @@ struct x86_platform_ops x86_platform __ro_after_init = { .enc_status_change_finish = enc_status_change_finish_noop, .enc_tlb_flush_required = enc_tlb_flush_required_noop, .enc_cache_flush_required = enc_cache_flush_required_noop, + .enc_init = enc_init_noop, }, };
arch/x86/mm/mem_encrypt.c +3 -0
@@ -84,5 +84,8 @@ void __init mem_encrypt_init(void)/* Call into SWIOTLB to update the SWIOTLB DMA buffers */ swiotlb_update_mem_attributes (); +if (x86_platform.guest.enc_init) + x86_platform.guest.enc_init (); +print_mem_encrypt_feature_info (); }
Signature · 1 line
2.32.0
RFC PATCH 7/11 x86/sev: Change TSC MSR behavior for Secure TSC enabled guests
In reply to Nikunj A DadhaniaSecure TSC enabled guests should not write MSR_IA32_TSC(10H) register as the subsequent TSC value reads are undefined. MSR_IA32_TSC related accesses should not exit to the hypervisor for such guests.
Accesses to MSR_IA32_TSC needs special handling in the #VC handler for the guests with Secure TSC enabled. Writes to MSR_IA32_TSC should be ignored, and reads of MSR_IA32_TSC should return the result of the RDTSC instruction.
--- arch/x86/kernel/sev.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
arch/x86/kernel/sev.c +24 -0
@@ -1601,6 +1601,30 @@ static enum es_result vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt)/* Is it a WRMSR? */ exit_info_1 = (ctxt->insn.opcode.bytes[1 ] ==0x30 ) ?1 :0 ; +/* +* TSC related accesses should not exit to the hypervisor when a +* guest is executing with SecureTSC enabled, so special handling +* is required for accesses of MSR_IA32_TSC: +* +* Writes: Writing to MSR_IA32_TSC can cause subsequent reads +* of the TSC to return undefined values, so ignore all +* writes. +* Reads: Reads of MSR_IA32_TSC should return the current TSC +* value, use the value returned by RDTSC. +*/ +if (regs->cx ==MSR_IA32_TSC && (sev_status &MSR_AMD64_SNP_SECURE_TSC )) { +u64 tsc; + +if (exit_info_1) +return ES_OK ; + + tsc =rdtsc (); + regs->ax =UINT_MAX & tsc; + regs->dx =UINT_MAX & (tsc >>32 ); + +return ES_OK ; + } +ghcb_set_rcx (ghcb, regs->cx);if (exit_info_1) {ghcb_set_rax (ghcb, regs->ax);
Signature · 1 line
2.32.0
RFC PATCH 8/11 x86/sev: Add Secure TSC support for SNP guests
In reply to Nikunj A DadhaniaAdd support for Secure TSC in SNP enabled guests. Secure TSC allows guest to securely use RDTSC/RDTSCP instructions as the parameters being used cannot be changed by hypervisor once the guest is launched.
During the boot-up of the secondary cpus, SecureTSC enabled guests need to query TSC info from Security processor (PSP). This communication channel is encrypted between the security processor and the guest, hypervisor is just the conduit to deliver the guest messages to the security processor. Each message is protected with an AEAD (AES-256 GCM). Use minimal GCM library to encrypt/decrypt SNP Guest messages to communicate with the PSP.
Moreover, the hypervisor should not be intercepting RDTSC/RDTSCP when Secure TSC is enabled. A #VC exception will be generated if the RDTSC/RDTSCP instructions are being intercepted. If this should occur and Secure TSC is enabled, terminate guest execution.
--- arch/x86/include/asm/sev-guest.h | 18 +++++++ arch/x86/include/asm/sev.h | 2 + arch/x86/include/asm/svm.h | 6 ++- arch/x86/kernel/sev-shared.c | 7 +++ arch/x86/kernel/sev.c | 92 +++++++++++++++++++++++++++++--- arch/x86/mm/mem_encrypt_amd.c | 6 +++ include/linux/cc_platform.h | 8 +++ 7 files changed, 131 insertions(+), 8 deletions(-)
arch/x86/include/asm/sev-guest.h +18 -0
@@ -34,6 +34,8 @@ enum msg_type {SNP_MSG_ABSORB_RSP ,SNP_MSG_VMRK_REQ ,SNP_MSG_VMRK_RSP , +SNP_MSG_TSC_INFO_REQ =17 , +SNP_MSG_TSC_INFO_RSP , SNP_MSG_TYPE_MAX };
@@ -72,6 +74,22 @@ struct snp_guest_req {u8 msg_type; }; +struct snp_tsc_info_req { +#define SNP_TSC_INFO_REQ_SZ 128 +/* Must be zero filled */ +u8 rsvd[SNP_TSC_INFO_REQ_SZ ]; +} __packed; + +struct snp_tsc_info_resp { +/* Status of TSC_INFO message */ +u32 status; +u32 rsvd1; +u64 tsc_scale; +u64 tsc_offset; +u64 tsc_factor; +u8 rsvd2[96 ]; +} __packed; +int snp_send_guest_request (struct snp_guest_dev *dev,struct snp_guest_req *req);bool snp_assign_vmpck (struct snp_guest_dev *dev,int vmpck_id);
arch/x86/include/asm/sev.h +2 -0
@@ -218,6 +218,7 @@ void snp_set_memory_private(unsigned long vaddr, unsigned int npages);void snp_set_wakeup_secondary_cpu (void );bool snp_init (struct boot_params *bp);void __init __noreturn snp_abort (void ); +bool __init snp_secure_tsc_prepare (void );int snp_issue_guest_request (u64 exit_code,struct snp_req_data *input,unsigned long *fw_err);#else static inline void sev_es_ist_enter (struct pt_regs *regs) { }
@@ -238,6 +239,7 @@ static inline void snp_set_memory_private(unsigned long vaddr, unsigned int npagstatic inline void snp_set_wakeup_secondary_cpu (void ) { }static inline bool snp_init (struct boot_params *bp) {return false; }static inline void snp_abort (void ) { } +static inline bool __init snp_secure_tsc_prepare (void ) {return false; }static inline int snp_issue_guest_request (u64 exit_code,struct snp_req_data *input,unsigned long *fw_err) {
arch/x86/include/asm/svm.h +4 -2
@@ -402,7 +402,9 @@ struct sev_es_save_area {u8 reserved_0x298[80 ];u32 pkru;u32 tsc_aux; -u8 reserved_0x2f0[24 ]; +u64 tsc_scale; +u64 tsc_offset; +u8 reserved_0x300[8 ];u64 rcx;u64 rdx;u64 rbx;
@@ -534,7 +536,7 @@ static inline void __unused_size_checks(void)BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x1c0 );BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x248 );BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x298 ); -BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x2f0 ); +BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x300 );BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x320 );BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x380 );BUILD_BUG_RESERVED_OFFSET (sev_es_save_area,0x3f0 );
arch/x86/kernel/sev-shared.c +7 -0
@@ -912,6 +912,13 @@ static enum es_result vc_handle_rdtsc(struct ghcb *ghcb,bool rdtscp = (exit_code ==SVM_EXIT_RDTSCP );enum es_result ret; +/* +* RDTSC and RDTSCP should not be intercepted when Secure TSC is +* enabled. Terminate the SNP guest when the interception is enabled. +*/ +if (sev_status &MSR_AMD64_SNP_SECURE_TSC ) +return ES_VMM_ERROR ; + ret =sev_es_ghcb_hv_call (ghcb, ctxt, exit_code,0 ,0 );if (ret !=ES_OK )return ret;
arch/x86/kernel/sev.c +86 -6
122 lines not on this page · raw message
arch/x86/mm/mem_encrypt_amd.c +6 -0
@@ -215,6 +215,11 @@ void __init sme_map_bootdata(char *real_mode_data)__sme_early_map_unmap_mem (__va (cmdline_paddr),COMMAND_LINE_SIZE , true); } +void __init amd_enc_init (void ) +{ +snp_secure_tsc_prepare (); +} +void __init sev_setup_arch (void ) {phys_addr_t total_mem =memblock_phys_mem_size ();
@@ -501,6 +506,7 @@ void __init sme_early_init(void) x86_platform.guest.enc_status_change_finish = amd_enc_status_change_finish; x86_platform.guest.enc_tlb_flush_required = amd_enc_tlb_flush_required; x86_platform.guest.enc_cache_flush_required = amd_enc_cache_flush_required; + x86_platform.guest.enc_init = amd_enc_init; }void __init mem_encrypt_free_decrypted_mem (void )
include/linux/cc_platform.h +8 -0
@@ -90,6 +90,14 @@ enum cc_attr {* Examples include TDX Guest. */ CC_ATTR_HOTPLUG_DISABLED , + +/** +* @CC_ATTR_GUEST_SECURE_TSC: Secure TSC is active. +* +* The platform/OS is running as a guest/virtual machine and actively +* using AMD SEV-SNP Secure TSC feature. +*/ + CC_ATTR_GUEST_SECURE_TSC, };#ifdef CONFIG_ARCH_HAS_CC_PLATFORM
Signature · 1 line
2.32.0
RFC PATCH 9/11 x86/kvmclock: Use Secure TSC as clock if available
In reply to Nikunj A DadhaniaFor AMD SNP guests having Secure TSC enabled, use Secure TSC based clocksource instead of kvmclock.
--- arch/x86/kernel/kvmclock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/kvmclock.c +1 -1
@@ -288,7 +288,7 @@ void __init kvmclock_init(void) {u8 flags; -if (!kvm_para_available () || !kvmclock) +if (!kvm_para_available () || !kvmclock ||cc_platform_has (CC_ATTR_GUEST_SECURE_TSC ))return ;if (kvm_para_has_feature (KVM_FEATURE_CLOCKSOURCE2 )) {
Signature · 1 line
2.32.0
RFC PATCH 10/11 x86/tsc: Mark Secure TSC as reliable clocksource
In reply to Nikunj A DadhaniaAMD SNP guests may have Secure TSC feature enabled. Secure TSC as clocksource is wrongly marked as unstable, mark Secure TSC as reliable.
--- arch/x86/kernel/tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/tsc.c +1 -1
@@ -1200,7 +1200,7 @@ static void __init check_system_tsc_reliable(void) tsc_clocksource_reliable = 1; }#endif -if (boot_cpu_has (X86_FEATURE_TSC_RELIABLE )) +if (boot_cpu_has (X86_FEATURE_TSC_RELIABLE ) ||cc_platform_has (CC_ATTR_GUEST_SECURE_TSC )) tsc_clocksource_reliable =1 ;/*
Signature · 1 line
2.32.0
RFC PATCH 11/11 x86/sev: Enable Secure TSC for SNP guests
In reply to Nikunj A DadhaniaNow that all the required plumbing is done for enabling SNP Secure TSC feature, add Secure TSC to snp features present list.
The CC_ATTR_GUEST_SECURE_TSC can be used by the guest to query whether the SNP guest has Secure TSC feature active.
--- arch/x86/boot/compressed/sev.c | 2 +- arch/x86/coco/core.c | 3 +++ arch/x86/mm/mem_encrypt.c | 10 ++++++++-- 3 files changed, 12 insertions(+), 3 deletions(-)
arch/x86/boot/compressed/sev.c +1 -1
@@ -315,7 +315,7 @@ static void enforce_vmpl0(void)* by the guest kernel. As and when a new feature is implemented in the * guest kernel, a corresponding bit should be added to the mask. */ -#define SNP_FEATURES_PRESENT (0) +#define SNP_FEATURES_PRESENT (MSR_AMD64_SNP_SECURE_TSC)void snp_check_features (void ) {
arch/x86/coco/core.c +3 -0
@@ -68,6 +68,9 @@ static bool amd_cc_platform_has(enum cc_attr attr)case CC_ATTR_GUEST_SEV_SNP :return sev_status &MSR_AMD64_SEV_SNP_ENABLED ; +case CC_ATTR_GUEST_SECURE_TSC : +return sev_status &MSR_AMD64_SNP_SECURE_TSC ; +default :return false; }
arch/x86/mm/mem_encrypt.c +8 -2
@@ -69,8 +69,14 @@ static void print_mem_encrypt_feature_info(void)pr_cont (" SEV-ES" );/* Secure Nested Paging */ -if (cc_platform_has (CC_ATTR_GUEST_SEV_SNP )) -pr_cont (" SEV-SNP" ); +if (cc_platform_has (CC_ATTR_GUEST_SEV_SNP )) { +pr_cont (" SEV-SNP\n" ); +pr_cont ("SNP Features active: " ); + +/* SNP Secure TSC */ +if (cc_platform_has (CC_ATTR_GUEST_SECURE_TSC )) +pr_cont (" SECURE-TSC" ); + }pr_cont ("\n" ); }
Signature · 1 line
2.32.0