Skip to contentSkip to conversation

asdf

DISCUSSION Christian Brauner 3 participants 4 messages Mar 31, 2023 – Jun 21, 2023

lore
Share & tools
lore
#0 lore raw

Hey Konstantin,

Can't be said enough: thanks for b4!

I have two inquiries about b4 send:

(1) Currently the message id that is generated for each patch sent by b4 has the format:

[date] - [branch name] - [version] - [patch number] - [random] @ kernel.org

where [date] is fixed and is taken from the change-id of the series as you mentioned in a fediverse thread.

It would be nice if we could - potentially opt-in via a config opt - set [date] to the date when the patch series was sent.

(2) I couldn't find an option to tell b4 send to set In-Reply-To: to one or more messages. That comes in handy when e.g., generating a patch in reply to syzbot report.

Maybe that's something worth adding.

Thanks!
Christian

#1 lore raw
Quoted 1 line · Christian Brauner

Can't be said enough: thanks for b4!

Glad to see so many people start to use it.

Quoted 5 lines

I have two inquiries about b4 send:

(1) Currently the message id that is generated for each patch sent by b4 has the format:

Quoted 7 lines

[date] - [branch name] - [version] - [patch number] - [random] @ kernel.org

where [date] is fixed and is taken from the change-id of the series as you mentioned in a fediverse thread.

It would be nice if we could - potentially opt-in via a config opt - set [date] to the date when the patch series was sent.

Sounds reasonable.
bugbot on

Quoted 5 lines

(2) I couldn't find an option to tell b4 send to set In-Reply-To: to one or more messages. That comes in handy when e.g., generating a patch in reply to syzbot report.

Maybe that's something worth adding.

I worry that this can create really weird thread interactions. E.g. if you have a bot report and it results in two different series being proposed:

original bot report
\
-- [PATCH] fixes one issue from the report
\
| -- [PATCH v2] fixes one issue from the report |
-- [PATCH] fixes a different issue from the report \
-- [PATCH v2] fixes a different issue from the report

This will confuse absolutely everyone, not just b4. :) It's best to just use Link:, I think.

-K

#3 lore raw

Re: b4: individual patch series should have the latest timestamp in the message-id

In reply to Christian Brauner

Konstantin Ryabitsev writes in commit 377e02fe2bcd16946b821d3ec2c384192523ee75:

ez: make message-ids use today's date

When creating the message-id of the series to be sent, we're reusing the change-id, which includes the origin date when that change-id was first created. Change this to today's date in order to be more conforming to how git-send-email does it.

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=377e02fe2bcd)

Signature · 2 lines
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)