ACPI: LPSS: Add pwm_lookup_table entry for second PWM on CHT/BSW devices
PATCH v2 1/1 ACPI: LPSS: Add pwm_lookup_table entry for second PWM on CHT/BSW devices
BSW PWM2 is used for backlight control for fixed (etched into the glass) touch controls on some models.
Add an entry for the second PWM controller to bsw_pwm_lookup, so that drivers can use pwm_get() to get a reference to it.
These touch-controls have specialized drivers which bind to different devices on different models, so the consumer-device-name in the lookup table entry is set to NULL, so that only con-id matching is used.
The con-id is set to "pwm_soc_lpss_2" which describes the PWM controller rather than the usual approach of describing its function. The specialized (model specific) drivers which need access to the PWM controller know they need the "pwm_soc_lpss_2" con-id.
---
Changes in v2:
- 2 spelling fixes in commit msg (Andy)
- Add Andy's Reviewed-by + Uwe's Acked-by
--- drivers/acpi/acpi_lpss.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +9 -1
@@ -201,11 +201,19 @@ static void byt_i2c_setup(struct lpss_private_data *pdata)writel (0 , pdata->mmio_base +LPSS_I2C_ENABLE ); } -/* BSW PWM used for backlight control by the i915 driver */ +/* +* BSW PWM1 is used for backlight control by the i915 driver +* BSW PWM2 is used for backlight control for fixed (etched into the glass) +* touch controls on some models. These touch-controls have specialized +* drivers which know they need the "pwm_soc_lpss_2" con-id. +*/ static struct pwm_lookup bsw_pwm_lookup[] = {PWM_LOOKUP_WITH_MODULE ("80862288:00" ,0 ,"0000:00:02.0" ,"pwm_soc_backlight" ,0 ,PWM_POLARITY_NORMAL ,"pwm-lpss-platform" ), +PWM_LOOKUP_WITH_MODULE ("80862289:00" ,0 ,NULL , +"pwm_soc_lpss_2" ,0 ,PWM_POLARITY_NORMAL , +"pwm-lpss-platform" ), };static void bsw_pwm_setup (struct lpss_private_data *pdata)
Signature · 1 line
2.40.1
Quoted 10 lines · Hans de Goede
BSW PWM2 is used for backlight control for fixed (etched into the glass) touch controls on some models.
Add an entry for the second PWM controller to
bsw_pwm_lookup, so that drivers can usepwm_get()to get a reference to it.These touch-controls have specialized drivers which bind to different devices on different models, so the consumer-device-name in the lookup table entry is set to NULL, so that only con-id matching is used.
Quoted 8 lines
The con-id is set to "
pwm_soc_lpss_2" which describes the PWM controller rather than the usual approach of describing its function. The specialized (model specific) drivers which need access to the PWM controller know they need the "pwm_soc_lpss_2" con-id.Reviewed-by Andy Shevchenko <[email protected]>Acked-by Uwe Kleine-König <[email protected]>Signed-off-by Hans de Goede <[email protected]>
Quoted 17 lines · Mika Westerberg
Quoted 15 lines · Hans de Goede
BSW PWM2 is used for backlight control for fixed (etched into the glass) touch controls on some models.
Add an entry for the second PWM controller to
bsw_pwm_lookup, so that drivers can usepwm_get()to get a reference to it.These touch-controls have specialized drivers which bind to different devices on different models, so the consumer-device-name in the lookup table entry is set to NULL, so that only con-id matching is used.
The con-id is set to "
pwm_soc_lpss_2" which describes the PWM controller rather than the usual approach of describing its function. The specialized (model specific) drivers which need access to the PWM controller know they need the "pwm_soc_lpss_2" con-id.
Quoted 5 lines
Quoted 3 lines
Reviewed-by Andy Shevchenko <[email protected]>Acked-by Uwe Kleine-König <[email protected]>Signed-off-by Hans de Goede <[email protected]>Reviewed-by Mika Westerberg <[email protected]>
Applied as 6.5 material, thanks!