Skip to contentSkip to conversation

drm: adv7511: Fix low refresh rate register for ADV7533/5

PATCH Superseded Alexandru Ardelean 3 participants 5 messages May 16, 2023 – Jul 18, 2023

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: adv7511: Fix low refresh rate register for ADV7533/5

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

---
 drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i2c/adv7511.c +7 -2
index 61aa824d45d2..e016105a8fbe 100644
@@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+			0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+			0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Signature · 1 line
2.40.1
#1 lore raw
Quoted 7 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Ping on this patch :)

Quoted 29 lines
---
 drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i2c/adv7511.c +7 -3
index 61aa824d45d2..e016105a8fbe 100644
@@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb,
+                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a,
+                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
--

2.40.1

Reviewed-by Nuno Sa
#3 lore raw

Hey Alex,

Quoted 8 lines · Fabio Estevam
Quoted 7 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Quoted 5 lines
Quoted 2 lines

Should this contain a Fixes tag so that it could be backported to stable kernels?

Yeah, most likely yes... With that:

#4 lore raw
Quoted 2 lines · Nuno Sá

Hey Alex,

Hey Nuno :)

Quoted 10 lines · Fabio Estevam
Quoted 8 lines · Alexandru Ardelean
Quoted 7 lines

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Should this contain a Fixes tag so that it could be backported to stable kernels?

Yeah, most likely yes... With that:

I'll add one.
I seem to forget some upstreaming routines, since I started doing less upstreaming.

Thanks
Alex

Quoted 4 lines