Skip to contentSkip to conversation

Early splash screen on AM62x

PATCH Superseded Devarsh Thakkar 2 participants 8 messages Jun 9, 2023 – Jun 13, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Early splash screen on AM62x

This series is to enable out-of-box early splash screen on AM62x devices with wic images compiled using meta-ti.

With this, u-boot SPL or u-boot proper can load TI logo from boot partition and display it while board is being booted.

Devarsh Thakkar (2):
u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for

    AM62x

conf: machine: am62xx: Add TI logo as image boot file

 meta-ti-bsp/conf/machine/include/am62xx.inc              | 3 +++
 .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
 .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
 1 file changed, 9 insertions(+)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +9 -0
index 4bbb6433..5067e3c8 100644
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
 
 SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4"
 
+do_install:append:am62xx() {
+	install -d ${D}/boot
+	install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot
+}
+
+do_deploy:append:am62xx() {
+	install -d ${DEPLOYDIR}
+	install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
Signature · 1 line
2.34.1
#2 lore raw

Re: [meta-ti] [kirkstone] [PATCH 1/2] u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Quoted 21 lines · Devarsh Thakkar

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
  .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
  1 file changed, 9 insertions(+)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +0 -0
index 4bbb6433..5067e3c8 100644

meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb BRANCH = "ti-u-boot-2023.04" · line 13

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +3 -0
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
 
  SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4"
 
+do_install:append:am62xx() {
+	install -d ${D}/boot
+	install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot

Could you copy this over as ti_logo.gz or similar so we have some idea of the contents.

Andrew

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +6 -0
+}
+
+do_deploy:append:am62xx() {
+	install -d ${DEPLOYDIR}
+	install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
#3 lore raw

Re: [meta-ti] [kirkstone] [PATCH 1/2] u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Hi Andrew,

Thanks for the quick review.

Quoted 19 lines · Andrew Davis
Quoted 18 lines · Devarsh Thakkar

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
  .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++

  1 file changed, 9 insertions(+)
Quoted 14 lines
Quoted 10 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +0 -0
index 4bbb6433..5067e3c8 100644
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"

    SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" +do_install:append:am62xx() {
+    install -d ${D}/boot
+    install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot

Could you copy this over as ti_logo.gz or similar so we have some idea of the contents.

I agree with you regarding naming convention, but unfortunately I think this file is already present in upstream as ti.gz [1] so we thought to stick with it and rather not change it in ti-u-boot.

[1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz

Regards
Devarsh

Quoted 8 lines

Andrew

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +6 -0
+}
+
+do_deploy:append:am62xx() {
+    install -d ${DEPLOYDIR}
+    install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
#4 lore raw

Re: [meta-ti] [kirkstone] [PATCH 1/2] u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Quoted 39 lines · Devarsh Thakkar

Hi Andrew,

Thanks for the quick review.

Quoted 19 lines · Andrew Davis
Quoted 18 lines · Devarsh Thakkar

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
   .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
   1 file changed, 9 insertions(+)
Quoted 14 lines

meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb BRANCH = "ti-u-boot-2023.04" · line 11

Quoted 10 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +2 -0
index 4bbb6433..5067e3c8 100644
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
     SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4"
   +do_install:append:am62xx() {
+    install -d ${D}/boot
+    install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot

Could you copy this over as ti_logo.gz or similar so we have some idea of the contents.

Quoted 4 lines

I agree with you regarding naming convention, but unfortunately I think this file is already present in upstream as ti.gz [1] so we thought to stick with it and rather not change it in ti-u-boot.

In u-boot it is in a folder called "logos", you are moving it into the generic "boot" partition. Could you put it in /boot/logo/ti.gz instead?

Quoted 13 lines

[1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz

Regards
Devarsh

Quoted 8 lines

Andrew

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +6 -0
+}
+
+do_deploy:append:am62xx() {
+    install -d ${DEPLOYDIR}
+    install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
#5 lore raw

Re: [meta-ti] [kirkstone] [PATCH 1/2] u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Hi Andrew,

Thanks for the suggestions.

Quoted 40 lines · Andrew Davis
Quoted 39 lines · Devarsh Thakkar

Hi Andrew,

Thanks for the quick review.

Quoted 33 lines · Andrew Davis
Quoted 24 lines · Devarsh Thakkar

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
   .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++

   1 file changed, 9 insertions(+)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +0 -0
index 4bbb6433..5067e3c8 100644
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
Quoted 4 lines

     SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" +do_install:append:am62xx() {
+    install -d ${D}/boot
+    install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot

Could you copy this over as ti_logo.gz or similar so we have some idea of the contents.

Quoted 8 lines
Quoted 4 lines

I agree with you regarding naming convention, but unfortunately I think this file is already present in upstream as ti.gz [1] so we thought to stick with it and rather not change it in ti-u-boot.

In u-boot it is in a folder called "logos", you are moving it into the generic "boot" partition. Could you put it in /boot/logo/ti.gz instead?

Yeah, that also makes sense to me to have a logos directory if there is a possibility of having multiple logos with different resolutions so that user can choose based upon the connector being used.

But this as well will require a change in u-boot's am62x.env file's splashfile variable, moreover I had to make a change in oe-core to allow installation of directories in boot partition for the same [1].

Meanwhile I discussed with team here (Vignesh and Nikhil) and we agreed to both rename the logo and have it in logos directory but we thought to do the latter as a separate patch when [1] is available in kirkstone, until then we thought it is better to just rename it as ti_logo_414x97.gz in boot partition

[1]
https://lists.openembedded.org/g/openembedded-core/topic/patch_v2_wic_bootimg_add/99501427?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,99501427,previd%3D1686655986349989245,nextid%3D1686587607620747491&previd=1686655986349989245&nextid=1686587607620747491

So is it ok to go ahead with ti_logo_414x97.gz in boot partition for now and take logos directory change as a separate patch in future when [1] is available ?

Regards
Devarsh

Quoted 13 lines
Quoted 13 lines

[1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz

Regards
Devarsh

Quoted 8 lines

Andrew

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +6 -0
+}
+
+do_deploy:append:am62xx() {
+    install -d ${DEPLOYDIR}
+    install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
#6 lore raw

Re: [meta-ti] [kirkstone] [PATCH 1/2] u-boot-ti-staging_2023.04: Copy bitmap file to boot partition for AM62x

Quoted 68 lines · Devarsh Thakkar

Hi Andrew,

Thanks for the suggestions.

Quoted 40 lines · Andrew Davis
Quoted 39 lines · Devarsh Thakkar

Hi Andrew,

Thanks for the quick review.

Quoted 33 lines · Andrew Davis
Quoted 24 lines · Devarsh Thakkar

Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1].

Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp.

[1]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34
[2]
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04

---
    .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
    1 file changed, 9 insertions(+)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +0 -0
index 4bbb6433..5067e3c8 100644

meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb BRANCH = "ti-u-boot-2023.04" · line 11

Quoted 4 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +2 -0
@@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
      SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4"
    +do_install:append:am62xx() {
+    install -d ${D}/boot
+    install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot

Could you copy this over as ti_logo.gz or similar so we have some idea of the contents.

Quoted 8 lines
Quoted 4 lines

I agree with you regarding naming convention, but unfortunately I think this file is already present in upstream as ti.gz [1] so we thought to stick with it and rather not change it in ti-u-boot.

In u-boot it is in a folder called "logos", you are moving it into the generic "boot" partition. Could you put it in /boot/logo/ti.gz instead?

Yeah, that also makes sense to me to have a logos directory if there is a possibility of having multiple logos with different resolutions so that user can choose based upon the connector being used.

But this as well will require a change in u-boot's am62x.env file's splashfile variable, moreover I had to make a change in oe-core to allow installation of directories in boot partition for the same [1].

Meanwhile I discussed with team here (Vignesh and Nikhil) and we agreed to both rename the logo and have it in logos directory but we thought to do the latter as a separate patch when [1] is available in kirkstone, until then we thought it is better to just rename it as ti_logo_414x97.gz in boot partition

Quoted 7 lines

[1]
https://lists.openembedded.org/g/openembedded-core/topic/patch_v2_wic_bootimg_add/99501427?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,99501427,previd%3D1686655986349989245,nextid%3D1686587607620747491&previd=1686655986349989245&nextid=1686587607620747491

So is it ok to go ahead with ti_logo_414x97.gz in boot partition for now and take logos directory change as a separate patch in future when [1] is available ?

Sounds good to me.

Andrew

Quoted 16 lines

Regards
Devarsh

Quoted 13 lines
Quoted 13 lines

[1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz

Regards
Devarsh

Quoted 8 lines

Andrew

Quoted 6 lines
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +6 -0
+}
+
+do_deploy:append:am62xx() {
+    install -d ${DEPLOYDIR}
+    install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR}
+}
#7 lore raw

PATCH 2/2 conf: machine: am62xx: Add TI logo as image boot file

In reply to Devarsh Thakkar

Add TI logo bitmap image as image boot file so that it gets copied to boot partition and A53 SPL or U-boot proper can load it and display during board bootup.

---
 meta-ti-bsp/conf/machine/include/am62xx.inc | 3 +++
 1 file changed, 3 insertions(+)
meta-ti-bsp/conf/machine/include/am62xx.inc +3 -0
index 0bd5279d..8bc4d2fc 100644
@@ -15,6 +15,9 @@ IMAGE_BOOT_FILES += "tiboot3-am62x-gp-evm.bin"
 # Since default tiboot3.bin on AM62x is for HS-FS, add a version for HS-SE
 IMAGE_BOOT_FILES += "tiboot3-am62x-hs-evm.bin"
 
+# Bitmap image tarball for early splashscreen
+IMAGE_BOOT_FILES += "ti.gz"
+
 TFA_BOARD = "lite"
 TFA_K3_SYSTEM_SUSPEND = "1"
 
Signature · 1 line
2.34.1