Skip to contentSkip to conversation

board: stm32mp1: add splash screen on dk2

PATCH In review Dario Binacchi 3 participants 5 messages Jul 4, 2023 – Jul 10, 2023 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 board: stm32mp1: add splash screen on dk2

Display the STMicroelectronics logo.

---

Changes in v2:
- move "splash.h" and "st_logo_data.h" headers before "syscon.h" in order to keep includes sorted alphabetically.
- remove "logo" variable and pass "(ulong)stmicroelectronics_uboot_logo_8bit_rle" directly to the bmp_display() function.

 board/st/stm32mp1/stm32mp1.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
board/st/stm32mp1/stm32mp1.c +11 -0
index 1a1b1844c8c0..ebd3948d519c 100644
@@ -31,8 +31,11 @@
 #include <phy.h>
 #include <remoteproc.h>
 #include <reset.h>
+#include <splash.h>
+#include <st_logo_data.h>
 #include <syscon.h>
 #include <usb.h>
+#include <video.h>
 #include <watchdog.h>
 #include <asm/global_data.h>
 #include <asm/io.h>
@@ -684,6 +687,14 @@ int board_init(void)
 	fw_images[0].fw_name = u"STM32MP-FIP";
 	fw_images[0].image_index = 1;
 #endif
+
+	if (IS_ENABLED(CONFIG_CMD_BMP)) {
+		if (board_is_stm32mp15x_dk2()) {
+			bmp_display((ulong)stmicroelectronics_uboot_logo_8bit_rle,
+				    BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
+		}
+	}
+
 	return 0;
 }
 
Signature · 1 line
2.32.0
#2 lore raw
In reply to Dario Binacchi

Hi Dario,

Quoted 37 lines · Dario Binacchi

Display the STMicroelectronics logo.

---

Changes in v2:
- move "splash.h" and "st_logo_data.h" headers before "syscon.h" in order to keep includes sorted alphabetically.
- remove "logo" variable and pass "(ulong)stmicroelectronics_uboot_logo_8bit_rle" directly to the bmp_display() function.

  board/st/stm32mp1/stm32mp1.c | 11 +++++++++++
  1 file changed, 11 insertions(+)
board/st/stm32mp1/stm32mp1.c +4 -0
index 1a1b1844c8c0..ebd3948d519c 100644
@@ -31,8 +31,11 @@
  #include <phy.h>
  #include <remoteproc.h>
  #include <reset.h>
+#include <splash.h>
+#include <st_logo_data.h>
  #include <syscon.h>
  #include <usb.h>
+#include <video.h>
  #include <watchdog.h>
  #include <asm/global_data.h>
  #include <asm/io.h>
@@ -684,6 +687,14 @@ int board_init(void)
  	fw_images[0].fw_name = u"STM32MP-FIP";
  	fw_images[0].image_index = 1;
  #endif
+

board/st/stm32mp1/stm32mp1.c int board_init(void) · line 700

Quoted 10 lines
board/st/stm32mp1/stm32mp1.c +7 -0
+	if (IS_ENABLED(CONFIG_CMD_BMP)) {
+		if (board_is_stm32mp15x_dk2()) {
+			bmp_display((ulong)stmicroelectronics_uboot_logo_8bit_rle,
+				    BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
+		}
+	}
+
  	return 0;
  }
 

I think "include/st_logo_data.h" should be not directly used for STM32 MPU

it is a obsolete way to have splash screen, used by STM32 MCU as STM32F7.

And direct management for splash it is not really needed in board code,

as it is already managed in VIDEO framework with CONFIG_VIDEO_LOGO

enabled by default since commit 845d71ce999936ab5ae2cef4542b221851cde199 ("video: Show the U-Boot logo by default")

and with CONFIG_SPLASH_SCREEN

see stdio_init_tables()

  => splash_display();

position is managed with:

- CONFIG_SPLASH_SCREEN_ALIGN

- variable: "splashpos=m,m"

But by default the U-Boot logo (yellow submarine) is used for VIDEO LOGO (SPLASH_DECL(u_boot_logo) in video uclass

or denx for SPLASH is used in tools/Makefile

# Generic logo
ifeq ($(LOGO_BMP),)
LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp

# Use board logo and fallback to vendor
ifneq ($(wildcard $(srctree)/$(src)/logos/$(BOARD).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp else
ifneq ($(wildcard $(srctree)/$(src)/logos/$(VENDOR).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp endif
endif

The STMicroelectronics logo image can be integrated in this directory with

         VENDOR="st"

         BOARD="stm32mp1"

We need to add it ./tools/logos/st.bmp

I can propose something, for all ST board STM32MP1x, not only DK2

Patrick

#3 lore raw

Hi Patrick,

Quoted 107 lines · Patrick DELAUNAY

Hi Dario,

Quoted 37 lines · Dario Binacchi

Display the STMicroelectronics logo.

---

Changes in v2:
- move "splash.h" and "st_logo_data.h" headers before "syscon.h" in order to keep includes sorted alphabetically.
- remove "logo" variable and pass "(ulong)stmicroelectronics_uboot_logo_8bit_rle" directly to the bmp_display() function.

  board/st/stm32mp1/stm32mp1.c | 11 +++++++++++
  1 file changed, 11 insertions(+)
board/st/stm32mp1/stm32mp1.c +4 -0
index 1a1b1844c8c0..ebd3948d519c 100644
@@ -31,8 +31,11 @@
  #include <phy.h>
  #include <remoteproc.h>
  #include <reset.h>
+#include <splash.h>
+#include <st_logo_data.h>
  #include <syscon.h>
  #include <usb.h>
+#include <video.h>
  #include <watchdog.h>
  #include <asm/global_data.h>
  #include <asm/io.h>
@@ -684,6 +687,14 @@ int board_init(void)
      fw_images[0].fw_name = u"STM32MP-FIP";
      fw_images[0].image_index = 1;
  #endif
+

board/st/stm32mp1/stm32mp1.c int board_init(void) · line 700

Quoted 10 lines
board/st/stm32mp1/stm32mp1.c +7 -0
+     if (IS_ENABLED(CONFIG_CMD_BMP)) {
+             if (board_is_stm32mp15x_dk2()) {
+                     bmp_display((ulong)stmicroelectronics_uboot_logo_8bit_rle,
+                                 BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
+             }
+     }
+
      return 0;
  }
 

I think "include/st_logo_data.h" should be not directly used for STM32 MPU

it is a obsolete way to have splash screen, used by STM32 MCU as STM32F7.

And direct management for splash it is not really needed in board code,

as it is already managed in VIDEO framework with CONFIG_VIDEO_LOGO

enabled by default since commit 845d71ce999936ab5ae2cef4542b221851cde199 ("video: Show the U-Boot logo by default")

and with CONFIG_SPLASH_SCREEN

see stdio_init_tables()

   => splash_display();

position is managed with:

- CONFIG_SPLASH_SCREEN_ALIGN

- variable: "splashpos=m,m"

But by default the U-Boot logo (yellow submarine) is used for VIDEO LOGO (SPLASH_DECL(u_boot_logo) in video uclass

or denx for SPLASH is used in tools/Makefile

# Generic logo
ifeq ($(LOGO_BMP),)
LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp

# Use board logo and fallback to vendor
ifneq ($(wildcard $(srctree)/$(src)/logos/$(BOARD).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp else
ifneq ($(wildcard $(srctree)/$(src)/logos/$(VENDOR).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp endif
endif

The STMicroelectronics logo image can be integrated in this directory with

          VENDOR="st"

          BOARD="stm32mp1"
Quoted 6 lines

We need to add it ./tools/logos/st.bmp

I can propose something, for all ST board STM32MP1x, not only DK2

Thanks for the explanations.

Regards,
Dario

Quoted 2 lines

Patrick

Signature · 17 lines
Dario Binacchi

Senior Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com
#4 lore raw

Hi,

Quoted 109 lines · Dario Binacchi

Hi Patrick,

Quoted 105 lines · Patrick DELAUNAY

Hi Dario,

Quoted 37 lines · Dario Binacchi

Display the STMicroelectronics logo.

---

Changes in v2:
- move "splash.h" and "st_logo_data.h" headers before "syscon.h" in order to keep includes sorted alphabetically.
- remove "logo" variable and pass "(ulong)stmicroelectronics_uboot_logo_8bit_rle" directly to the bmp_display() function.

   board/st/stm32mp1/stm32mp1.c | 11 +++++++++++
   1 file changed, 11 insertions(+)
board/st/stm32mp1/stm32mp1.c +4 -0
index 1a1b1844c8c0..ebd3948d519c 100644
@@ -31,8 +31,11 @@
   #include <phy.h>
   #include <remoteproc.h>
   #include <reset.h>
+#include <splash.h>
+#include <st_logo_data.h>
   #include <syscon.h>
   #include <usb.h>
+#include <video.h>
   #include <watchdog.h>
   #include <asm/global_data.h>
   #include <asm/io.h>
@@ -684,6 +687,14 @@ int board_init(void)
       fw_images[0].fw_name = u"STM32MP-FIP";
       fw_images[0].image_index = 1;
   #endif
+

board/st/stm32mp1/stm32mp1.c int board_init(void) · line 700

Quoted 10 lines
board/st/stm32mp1/stm32mp1.c +7 -0
+     if (IS_ENABLED(CONFIG_CMD_BMP)) {
+             if (board_is_stm32mp15x_dk2()) {
+                     bmp_display((ulong)stmicroelectronics_uboot_logo_8bit_rle,
+                                 BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
+             }
+     }
+
       return 0;
   }
 

I think "include/st_logo_data.h" should be not directly used for STM32 MPU

it is a obsolete way to have splash screen, used by STM32 MCU as STM32F7.

And direct management for splash it is not really needed in board code,

as it is already managed in VIDEO framework with CONFIG_VIDEO_LOGO

enabled by default since commit 845d71ce999936ab5ae2cef4542b221851cde199 ("video: Show the U-Boot logo by default")

and with CONFIG_SPLASH_SCREEN

see stdio_init_tables()

    => splash_display();

position is managed with:

- CONFIG_SPLASH_SCREEN_ALIGN

- variable: "splashpos=m,m"

But by default the U-Boot logo (yellow submarine) is used for VIDEO LOGO (SPLASH_DECL(u_boot_logo) in video uclass

or denx for SPLASH is used in tools/Makefile

# Generic logo
ifeq ($(LOGO_BMP),)
LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp

# Use board logo and fallback to vendor
ifneq ($(wildcard $(srctree)/$(src)/logos/$(BOARD).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp else
ifneq ($(wildcard $(srctree)/$(src)/logos/$(VENDOR).bmp),) LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp endif
endif

The STMicroelectronics logo image can be integrated in this directory with

           VENDOR="st"

           BOARD="stm32mp1"
Quoted 7 lines
Quoted 6 lines

We need to add it ./tools/logos/st.bmp

I can propose something, for all ST board STM32MP1x, not only DK2

Thanks for the explanations.

You are welcome.

I propose to replace you propsal by the patch I just sent today:

http://patchwork.ozlabs.org/project/uboot/list/?series=363143&state=*

[PATCH] board: stm32mp1: add splash screen with stmicroelectronics logo

I test ir on STM32MP157C-DK2

Tell me if it is OK on your side.

Patrick