drm/msm/adreno: Fix snapshot BINDLESS_DATA size
Subsystems (4)
PATCH 1/1 drm/msm/adreno: Fix snapshot BINDLESS_DATA size
From: Rob Clark <[email protected]>
The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).
Signed-off-by Rob Clark <[email protected]>
--- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1 -1
@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {SHADER (A6XX_SP_LB_3_DATA ,0x800 ),SHADER (A6XX_SP_LB_4_DATA ,0x800 ),SHADER (A6XX_SP_LB_5_DATA ,0x200 ), -SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x2000 ), +SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x800 ),SHADER (A6XX_SP_CB_LEGACY_DATA ,0x280 ),SHADER (A6XX_SP_UAV_DATA ,0x80 ), SHADER(A6XX_SP_INST_TAG, 0x80),
Signature · 1 line
2.41.0
Quoted 28 lines · Rob Clark
From: Rob Clark <[email protected]>
The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1
-1@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {SHADER (A6XX_SP_LB_3_DATA ,0x800 ),SHADER (A6XX_SP_LB_4_DATA ,0x800 ),SHADER (A6XX_SP_LB_5_DATA ,0x200 ), -SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x2000 ), +SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x800 ),SHADER (A6XX_SP_CB_LEGACY_DATA ,0x280 ),SHADER (A6XX_SP_UAV_DATA ,0x80 ), SHADER(A6XX_SP_INST_TAG, 0x80),Signature · 1 line
2.41.0
Reviewed-by Akhil P Oommen <[email protected]>
-Akhil
Quoted 7 lines · Rob Clark
From: Rob Clark <[email protected]>
The incorrect size was causing "CP | AHB bus error" when snapshotting the GPU state on a6xx gen4 (a660 family).
Signed-off-by Rob Clark <[email protected]>
What about:
Fixes 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state")
?
Quoted 17 lines
--- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +1
-1@@ -206,7 +206,7 @@ static const struct a6xx_shader_block {SHADER (A6XX_SP_LB_3_DATA ,0x800 ),SHADER (A6XX_SP_LB_4_DATA ,0x800 ),SHADER (A6XX_SP_LB_5_DATA ,0x200 ), -SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x2000 ), +SHADER (A6XX_SP_CB_BINDLESS_DATA ,0x800 ),SHADER (A6XX_SP_CB_LEGACY_DATA ,0x280 ),SHADER (A6XX_SP_UAV_DATA ,0x80 ), SHADER(A6XX_SP_INST_TAG, 0x80),
Signature · 2 lines
With best wishes Dmitry